EC-CUBE /
ec-cube3
| Conditions | 29 |
| Paths | 9685 |
| Total Lines | 306 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function index(Application $app, Request $request, $id = null) |
||
| 43 | { |
||
| 44 | /* @var $softDeleteFilter \Eccube\Doctrine\Filter\SoftDeleteFilter */ |
||
| 45 | $softDeleteFilter = $app['orm.em']->getFilters()->getFilter('soft_delete'); |
||
| 46 | $softDeleteFilter->setExcludes(array( |
||
| 47 | 'Eccube\Entity\ProductClass', |
||
| 48 | 'Eccube\Entity\Product', |
||
| 49 | )); |
||
| 50 | |||
| 51 | $TargetOrder = null; |
||
|
|
|||
| 52 | $OriginOrder = null; |
||
| 53 | |||
| 54 | if (is_null($id)) { |
||
| 55 | // 空のエンティティを作成. |
||
| 56 | $TargetOrder = $this->newOrder($app); |
||
| 57 | } else { |
||
| 58 | $TargetOrder = $app['eccube.repository.order']->find($id); |
||
| 59 | if (is_null($TargetOrder)) { |
||
| 60 | throw new NotFoundHttpException(); |
||
| 61 | } |
||
| 62 | } |
||
| 63 | |||
| 64 | // 編集前の受注情報を保持 |
||
| 65 | $OriginOrder = clone $TargetOrder; |
||
| 66 | $OriginalOrderDetails = new ArrayCollection(); |
||
| 67 | // 編集前のお届け先情報を保持 |
||
| 68 | $OriginalShippings = new ArrayCollection(); |
||
| 69 | // 編集前のお届け先のアイテム情報を保持 |
||
| 70 | $OriginalShipmentItems = new ArrayCollection(); |
||
| 71 | |||
| 72 | // Save previous value before calculate |
||
| 73 | $arrOldOrder = array(); |
||
| 74 | |||
| 75 | /** @var $OrderDetail OrderDetail*/ |
||
| 76 | foreach ($TargetOrder->getOrderDetails() as $OrderDetail) { |
||
| 77 | $OriginalOrderDetails->add($OrderDetail); |
||
| 78 | $arrOldOrder['OrderDetails'][$OrderDetail->getId()]['quantity'] = $OrderDetail->getQuantity(); |
||
| 79 | } |
||
| 80 | |||
| 81 | // 編集前の情報を保持 |
||
| 82 | /** @var $tmpOriginalShippings Shipping*/ |
||
| 83 | foreach ($TargetOrder->getShippings() as $key => $tmpOriginalShippings) { |
||
| 84 | $arrOldOrder['Shippings'][$key]['shipping_delivery_date'] = $tmpOriginalShippings->getShippingDeliveryDate(); |
||
| 85 | /** @var $tmpOriginalShipmentItem ShipmentItem*/ |
||
| 86 | foreach ($tmpOriginalShippings->getShipmentItems() as $tmpOriginalShipmentItem) { |
||
| 87 | // アイテム情報 |
||
| 88 | $OriginalShipmentItems->add($tmpOriginalShipmentItem); |
||
| 89 | $arrOldOrder['Shippings'][$key]['ShipmentItems'][$tmpOriginalShipmentItem->getId()]['quantity'] = $tmpOriginalShipmentItem->getQuantity(); |
||
| 90 | } |
||
| 91 | // お届け先情報 |
||
| 92 | $OriginalShippings->add($tmpOriginalShippings); |
||
| 93 | } |
||
| 94 | |||
| 95 | $builder = $app['form.factory'] |
||
| 96 | ->createBuilder('order', $TargetOrder); |
||
| 97 | |||
| 98 | $event = new EventArgs( |
||
| 99 | array( |
||
| 100 | 'builder' => $builder, |
||
| 101 | 'OriginOrder' => $OriginOrder, |
||
| 102 | 'TargetOrder' => $TargetOrder, |
||
| 103 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 104 | ), |
||
| 105 | $request |
||
| 106 | ); |
||
| 107 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_INDEX_INITIALIZE, $event); |
||
| 108 | |||
| 109 | $form = $builder->getForm(); |
||
| 110 | |||
| 111 | if ('POST' === $request->getMethod()) { |
||
| 112 | $form->handleRequest($request); |
||
| 113 | |||
| 114 | $event = new EventArgs( |
||
| 115 | array( |
||
| 116 | 'builder' => $builder, |
||
| 117 | 'OriginOrder' => $OriginOrder, |
||
| 118 | 'TargetOrder' => $TargetOrder, |
||
| 119 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 120 | ), |
||
| 121 | $request |
||
| 122 | ); |
||
| 123 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_INDEX_PROGRESS, $event); |
||
| 124 | |||
| 125 | // 入力情報にもとづいて再計算. |
||
| 126 | $this->calculate($app, $TargetOrder); |
||
| 127 | |||
| 128 | // 登録ボタン押下 |
||
| 129 | switch ($request->get('mode')) { |
||
| 130 | case 'register': |
||
| 131 | |||
| 132 | log_info('受注登録開始', array($TargetOrder->getId())); |
||
| 133 | |||
| 134 | if ($TargetOrder->getTotal() > $app['config']['max_total_fee']) { |
||
| 135 | log_info('受注登録入力チェックエラー', array($TargetOrder->getId())); |
||
| 136 | $form['charge']->addError(new FormError('合計金額の上限を超えております。')); |
||
| 137 | } elseif ($form->isValid()) { |
||
| 138 | |||
| 139 | $BaseInfo = $app['eccube.repository.base_info']->get(); |
||
| 140 | |||
| 141 | // お支払い方法の更新 |
||
| 142 | $TargetOrder->setPaymentMethod($TargetOrder->getPayment()->getMethod()); |
||
| 143 | |||
| 144 | // 配送業者・お届け時間の更新 |
||
| 145 | $Shippings = $TargetOrder->getShippings(); |
||
| 146 | foreach ($Shippings as $Shipping) { |
||
| 147 | $Shipping->setShippingDeliveryName($Shipping->getDelivery()->getName()); |
||
| 148 | if (!is_null($Shipping->getDeliveryTime())) { |
||
| 149 | $Shipping->setShippingDeliveryTime($Shipping->getDeliveryTime()->getDeliveryTime()); |
||
| 150 | } else { |
||
| 151 | $Shipping->setShippingDeliveryTime(null); |
||
| 152 | } |
||
| 153 | } |
||
| 154 | |||
| 155 | |||
| 156 | // 受注日/発送日/入金日の更新. |
||
| 157 | $this->updateDate($app, $TargetOrder, $OriginOrder); |
||
| 158 | |||
| 159 | // 受注明細で削除されているものをremove |
||
| 160 | foreach ($OriginalOrderDetails as $OrderDetail) { |
||
| 161 | if (false === $TargetOrder->getOrderDetails()->contains($OrderDetail)) { |
||
| 162 | $app['orm.em']->remove($OrderDetail); |
||
| 163 | } |
||
| 164 | } |
||
| 165 | |||
| 166 | |||
| 167 | if ($BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) { |
||
| 168 | foreach ($TargetOrder->getOrderDetails() as $OrderDetail) { |
||
| 169 | /** @var $OrderDetail \Eccube\Entity\OrderDetail */ |
||
| 170 | $OrderDetail->setOrder($TargetOrder); |
||
| 171 | } |
||
| 172 | |||
| 173 | /** @var \Eccube\Entity\Shipping $Shipping */ |
||
| 174 | foreach ($Shippings as $Shipping) { |
||
| 175 | $shipmentItems = $Shipping->getShipmentItems(); |
||
| 176 | /** @var \Eccube\Entity\ShipmentItem $ShipmentItem */ |
||
| 177 | foreach ($shipmentItems as $ShipmentItem) { |
||
| 178 | // 削除予定から商品アイテムを外す |
||
| 179 | $OriginalShipmentItems->removeElement($ShipmentItem); |
||
| 180 | $ShipmentItem->setOrder($TargetOrder); |
||
| 181 | $ShipmentItem->setShipping($Shipping); |
||
| 182 | $app['orm.em']->persist($ShipmentItem); |
||
| 183 | } |
||
| 184 | // 削除予定からお届け先情報を外す |
||
| 185 | $OriginalShippings->removeElement($Shipping); |
||
| 186 | $Shipping->setOrder($TargetOrder); |
||
| 187 | $app['orm.em']->persist($Shipping); |
||
| 188 | } |
||
| 189 | // 商品アイテムを削除する |
||
| 190 | foreach ($OriginalShipmentItems as $OriginalShipmentItem) { |
||
| 191 | $app['orm.em']->remove($OriginalShipmentItem); |
||
| 192 | } |
||
| 193 | // お届け先情報削除する |
||
| 194 | foreach ($OriginalShippings as $OriginalShipping) { |
||
| 195 | $app['orm.em']->remove($OriginalShipping); |
||
| 196 | } |
||
| 197 | } else { |
||
| 198 | |||
| 199 | $NewShipmentItems = new ArrayCollection(); |
||
| 200 | |||
| 201 | foreach ($TargetOrder->getOrderDetails() as $OrderDetail) { |
||
| 202 | /** @var $OrderDetail \Eccube\Entity\OrderDetail */ |
||
| 203 | $OrderDetail->setOrder($TargetOrder); |
||
| 204 | |||
| 205 | $NewShipmentItem = new ShipmentItem(); |
||
| 206 | $NewShipmentItem |
||
| 207 | ->setProduct($OrderDetail->getProduct()) |
||
| 208 | ->setProductClass($OrderDetail->getProductClass()) |
||
| 209 | ->setProductName($OrderDetail->getProduct()->getName()) |
||
| 210 | ->setProductCode($OrderDetail->getProductClass()->getCode()) |
||
| 211 | ->setClassCategoryName1($OrderDetail->getClassCategoryName1()) |
||
| 212 | ->setClassCategoryName2($OrderDetail->getClassCategoryName2()) |
||
| 213 | ->setClassName1($OrderDetail->getClassName1()) |
||
| 214 | ->setClassName2($OrderDetail->getClassName2()) |
||
| 215 | ->setPrice($OrderDetail->getPrice()) |
||
| 216 | ->setQuantity($OrderDetail->getQuantity()) |
||
| 217 | ->setOrder($TargetOrder); |
||
| 218 | $NewShipmentItems[] = $NewShipmentItem; |
||
| 219 | |||
| 220 | } |
||
| 221 | // 配送商品の更新. delete/insert. |
||
| 222 | $Shippings = $TargetOrder->getShippings(); |
||
| 223 | foreach ($Shippings as $Shipping) { |
||
| 224 | $ShipmentItems = $Shipping->getShipmentItems(); |
||
| 225 | foreach ($ShipmentItems as $ShipmentItem) { |
||
| 226 | $app['orm.em']->remove($ShipmentItem); |
||
| 227 | } |
||
| 228 | $ShipmentItems->clear(); |
||
| 229 | foreach ($NewShipmentItems as $NewShipmentItem) { |
||
| 230 | $NewShipmentItem->setShipping($Shipping); |
||
| 231 | $ShipmentItems->add($NewShipmentItem); |
||
| 232 | } |
||
| 233 | } |
||
| 234 | } |
||
| 235 | |||
| 236 | $Customer = $TargetOrder->getCustomer(); |
||
| 237 | if ($Customer) { |
||
| 238 | // 受注情報の会員情報を更新 |
||
| 239 | $TargetOrder->setSex($Customer->getSex()); |
||
| 240 | $TargetOrder->setJob($Customer->getJob()); |
||
| 241 | $TargetOrder->setBirth($Customer->getBirth()); |
||
| 242 | } |
||
| 243 | |||
| 244 | $app['orm.em']->persist($TargetOrder); |
||
| 245 | $app['orm.em']->flush(); |
||
| 246 | |||
| 247 | if ($Customer) { |
||
| 248 | // 会員の場合、購入回数、購入金額などを更新 |
||
| 249 | $app['eccube.repository.customer']->updateBuyData($app, $Customer, $TargetOrder->getOrderStatus()->getId()); |
||
| 250 | } |
||
| 251 | |||
| 252 | $event = new EventArgs( |
||
| 253 | array( |
||
| 254 | 'form' => $form, |
||
| 255 | 'OriginOrder' => $OriginOrder, |
||
| 256 | 'TargetOrder' => $TargetOrder, |
||
| 257 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 258 | 'Customer' => $Customer, |
||
| 259 | ), |
||
| 260 | $request |
||
| 261 | ); |
||
| 262 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_INDEX_COMPLETE, $event); |
||
| 263 | |||
| 264 | $app->addSuccess('admin.order.save.complete', 'admin'); |
||
| 265 | |||
| 266 | log_info('受注登録完了', array($TargetOrder->getId())); |
||
| 267 | |||
| 268 | return $app->redirect($app->url('admin_order_edit', array('id' => $TargetOrder->getId()))); |
||
| 269 | } |
||
| 270 | |||
| 271 | break; |
||
| 272 | |||
| 273 | case 'add_delivery': |
||
| 274 | // お届け先情報の新規追加 |
||
| 275 | |||
| 276 | $form = $builder->getForm(); |
||
| 277 | |||
| 278 | $Shipping = new \Eccube\Entity\Shipping(); |
||
| 279 | $Shipping->setDelFlg(Constant::DISABLED); |
||
| 280 | |||
| 281 | $TargetOrder->addShipping($Shipping); |
||
| 282 | |||
| 283 | $Shipping->setOrder($TargetOrder); |
||
| 284 | |||
| 285 | $form->setData($TargetOrder); |
||
| 286 | |||
| 287 | break; |
||
| 288 | |||
| 289 | default: |
||
| 290 | break; |
||
| 291 | } |
||
| 292 | } |
||
| 293 | |||
| 294 | // 会員検索フォーム |
||
| 295 | $builder = $app['form.factory'] |
||
| 296 | ->createBuilder('admin_search_customer'); |
||
| 297 | |||
| 298 | $event = new EventArgs( |
||
| 299 | array( |
||
| 300 | 'builder' => $builder, |
||
| 301 | 'OriginOrder' => $OriginOrder, |
||
| 302 | 'TargetOrder' => $TargetOrder, |
||
| 303 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 304 | ), |
||
| 305 | $request |
||
| 306 | ); |
||
| 307 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_SEARCH_CUSTOMER_INITIALIZE, $event); |
||
| 308 | |||
| 309 | $searchCustomerModalForm = $builder->getForm(); |
||
| 310 | |||
| 311 | // 商品検索フォーム |
||
| 312 | $builder = $app['form.factory'] |
||
| 313 | ->createBuilder('admin_search_product'); |
||
| 314 | |||
| 315 | $event = new EventArgs( |
||
| 316 | array( |
||
| 317 | 'builder' => $builder, |
||
| 318 | 'OriginOrder' => $OriginOrder, |
||
| 319 | 'TargetOrder' => $TargetOrder, |
||
| 320 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 321 | ), |
||
| 322 | $request |
||
| 323 | ); |
||
| 324 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_SEARCH_PRODUCT_INITIALIZE, $event); |
||
| 325 | |||
| 326 | $searchProductModalForm = $builder->getForm(); |
||
| 327 | |||
| 328 | // 配送業者のお届け時間 |
||
| 329 | $times = array(); |
||
| 330 | $deliveries = $app['eccube.repository.delivery']->findAll(); |
||
| 331 | foreach ($deliveries as $Delivery) { |
||
| 332 | $deliveryTiems = $Delivery->getDeliveryTimes(); |
||
| 333 | foreach ($deliveryTiems as $DeliveryTime) { |
||
| 334 | $times[$Delivery->getId()][$DeliveryTime->getId()] = $DeliveryTime->getDeliveryTime(); |
||
| 335 | } |
||
| 336 | } |
||
| 337 | |||
| 338 | return $app->render('Order/edit.twig', array( |
||
| 339 | 'form' => $form->createView(), |
||
| 340 | 'searchCustomerModalForm' => $searchCustomerModalForm->createView(), |
||
| 341 | 'searchProductModalForm' => $searchProductModalForm->createView(), |
||
| 342 | 'Order' => $TargetOrder, |
||
| 343 | 'id' => $id, |
||
| 344 | 'shippingDeliveryTimes' => $app['serializer']->serialize($times, 'json'), |
||
| 345 | 'arrOldOrder' => $arrOldOrder, |
||
| 346 | )); |
||
| 347 | } |
||
| 348 | |||
| 771 |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.