Issues (2687)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Eccube/Repository/TaxRuleRepository.php (10 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/*
3
 * This file is part of EC-CUBE
4
 *
5
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6
 *
7
 * http://www.lockon.co.jp/
8
 *
9
 * This program is free software; you can redistribute it and/or
10
 * modify it under the terms of the GNU General Public License
11
 * as published by the Free Software Foundation; either version 2
12
 * of the License, or (at your option) any later version.
13
 *
14
 * This program is distributed in the hope that it will be useful,
15
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
 * GNU General Public License for more details.
18
 *
19
 * You should have received a copy of the GNU General Public License
20
 * along with this program; if not, write to the Free Software
21
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
22
 */
23
24
25
namespace Eccube\Repository;
26
27
use Doctrine\ORM\EntityRepository;
28
use Doctrine\ORM\NoResultException;
29
use Eccube\Common\Constant;
30
31
/**
32
 * TaxRuleRepository
33
 *
34
 * This class was generated by the Doctrine ORM. Add your own custom
35
 * repository methods below.
36
 */
37
class TaxRuleRepository extends EntityRepository
38
{
39
    private $rules = array();
40
41
    protected $app;
42
43 1189
    public function setApplication($app)
44
    {
45 1189
        $this->app = $app;
46
    }
47
48 11
    public function newTaxRule()
49
    {
50 11
        $TaxRule = new \Eccube\Entity\TaxRule();
51 11
        $CalcRule = $this->getEntityManager()
52 11
            ->getRepository('Eccube\Entity\Master\Taxrule')
53 11
            ->find(1);
54 11
        $TaxRule->setCalcRule($CalcRule);
55 11
        $TaxRule->setTaxAdjust(0);
56 11
        $TaxRule->setDelFlg(0);
57
58 11
        return $TaxRule;
59
    }
60
61
    /**
62
     * 現在有効な税率設定情報を返す
63
     *
64
     * @param  int|null|\Eccube\Entity\Product        $Product      商品
65
     * @param  int|null|\Eccube\Entity\ProductClass   $ProductClass 商品規格
66
     * @param  int|null|\Eccube\Entity\Master\Pref    $Pref         都道府県
67
     * @param  int|null|\Eccube\Entity\Master\Country $Country      国
68
     * @return \Eccube\Entity\TaxRule                 税設定情報
69
     *
70
     * @throws NoResultException
71
     */
72 440
    public function getByRule($Product = null, $ProductClass = null, $Pref = null, $Country = null)
73
    {
74 440
        if (!$this->app) {
75
            throw new \LogicException();
76
        }
77
78
        // Pref Country 設定
79 440
        if (!$Pref && !$Country && $this->app['security']->getToken() && $this->app['security']->isGranted('ROLE_USER')) {
80
            /* @var $Customer \Eccube\Entity\Customer */
81 110
            $Customer = $this->app['security']->getToken()->getUser();
82 110
            $Pref = $Customer->getPref();
83 110
            $Country = $Customer->getCountry();
84
        }
85
86
        // 商品単位税率設定がOFFの場合
87
        /** @var $BaseInfo \Eccube\Entity\BaseInfo */
88 440
        $BaseInfo = $this->app['eccube.repository.base_info']->get();
89 440
        if ($BaseInfo->getOptionProductTaxRule() !== Constant::ENABLED) {
90 418
            $Product = null;
91 418
            $ProductClass = null;
92
        }
93
94
        // Cache Key 設定
95 440
        if ($Product instanceof \Eccube\Entity\Product) {
0 ignored issues
show
The class Eccube\Entity\Product does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
96 25
            $productId = $Product->getId();
97 418
        } elseif ($Product) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $Product of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
98
            $productId = $Product;
99
        } else {
100 418
            $productId = '0';
101
        }
102 440
        if ($ProductClass instanceof \Eccube\Entity\ProductClass) {
0 ignored issues
show
The class Eccube\Entity\ProductClass does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
103 24
            $productClassId = $ProductClass->getId();
104 418
        } elseif ($ProductClass) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $ProductClass of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For integer values, zero is a special case, in particular the following results might be unexpected:

0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
Loading history...
105
            $productClassId = $ProductClass;
106
        } else {
107 418
            $productClassId = '0';
108
        }
109 440
        if ($Pref instanceof \Eccube\Entity\Master\Pref) {
0 ignored issues
show
The class Eccube\Entity\Master\Pref does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
110 111
            $prefId = $Pref->getId();
111 331
        } elseif ($Pref) {
112
            $prefId = $Pref;
113
        } else {
114 331
            $prefId = '0';
115
        }
116 440
        if ($Country instanceof \Eccube\Entity\Master\Country) {
0 ignored issues
show
The class Eccube\Entity\Master\Country does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
117 2
            $countryId = $Country->getId();
118 440
        } elseif ($Country) {
119
            $countryId = $Country;
120
        } else {
121 440
            $countryId = '0';
122
        }
123 440
        $cacheKey = $productId.':'.$productClassId.':'.$prefId.':'.$countryId;
124
125
        // すでに取得している場合はキャッシュから
126 440
        if (isset($this->rules[$cacheKey])) {
127 438
            return $this->rules[$cacheKey];
128
        }
129
130 440
        $parameters = array();
131 440
        $qb = $this->createQueryBuilder('t')
132 440
            ->where('t.apply_date < :apply_date');
133 440
        $parameters[':apply_date'] = new \DateTime();
134
135
        // Pref
136 440
        if ($Pref) {
137 111
            $qb->andWhere('t.Pref IS NULL OR t.Pref = :Pref');
138 111
            $parameters['Pref'] = $Pref;
139
        } else {
140 331
            $qb->andWhere('t.Pref IS NULL');
141
        }
142
143
        // Country
144 440
        if ($Country) {
145 2
            $qb->andWhere('t.Country IS NULL OR t.Country = :Country');
146 2
            $parameters['Country'] = $Country;
147
        } else {
148 440
            $qb->andWhere('t.Country IS NULL');
149
        }
150
151
        /*
152
         * Product, ProductClass が persist される前に TaxRuleEventSubscriber によってアクセスされる
153
         * 場合があるため、ID の存在もチェックする.
154
         * https://github.com/EC-CUBE/ec-cube/issues/677
155
         */
156
157
        // Product
158 440
        if ($Product && $productId > 0) {
159 25
            $qb->andWhere('t.Product IS NULL OR t.Product = :Product');
160 25
            $parameters['Product'] = $Product;
161
        } else {
162 421
            $qb->andWhere('t.Product IS NULL');
163
        }
164
165
        // ProductClass
166 440
        if ($ProductClass && $productClassId > 0) {
167 24
            $qb->andWhere('t.ProductClass IS NULL OR t.ProductClass = :ProductClass');
168 24
            $parameters['ProductClass'] = $ProductClass;
169
        } else {
170 436
            $qb->andWhere('t.ProductClass IS NULL');
171
        }
172
173
        $TaxRules = $qb
174 440
            ->setParameters($parameters)
175 440
            ->orderBy('t.apply_date', 'DESC') // 実際は usort() でソートする
176 440
            ->getQuery()
177 440
            ->getResult();
178
179
        // 地域設定を優先するが、システムパラメーターなどに設定を持っていくか
180
        // 後に書いてあるほど優先される
181 440
        $priorityKeys = explode(',', $this->app['config']['tax_rule_priority']);
0 ignored issues
show
$priorityKeys is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
182 440
        $priorityKeys = array();
183 440
        foreach (explode(',', $this->app['config']['tax_rule_priority']) as $key) {
184 440
            $priorityKeys[] = str_replace('_', '', preg_replace('/_id\z/', '', $key));
185
        }
186
187 440
        foreach ($TaxRules as $TaxRule) {
188 440
            $rank = 0;
189 440
            foreach ($priorityKeys as $index => $key) {
190 440
                $arrayProperties = array_change_key_case($TaxRule->toArray());
191 440
                if ($arrayProperties[$key]) {
192
193
                    // 配列の数値添字を重みとして利用する
194 440
                    $rank += 1 << ($index + 1);
195
                }
196
            }
197 440
            $TaxRule->setRank($rank);
198
        }
199
200
        // 適用日降順, rank 降順にソートする
201 440
        usort($TaxRules, function($a, $b) {
0 ignored issues
show
Expected 1 space after FUNCTION keyword; 0 found
Loading history...
202 7
            return $a->compareTo($b);
203 440
        });
204
205 440
        if (!empty($TaxRules)) {
206 440
            $this->rules[$cacheKey] = $TaxRules[0];
207
208 440
            return $TaxRules[0];
209
        } else {
210
            throw new NoResultException();
211
        }
212
    }
213
214
    /**
215
     * getList
216
     *
217
     * @return array|null
218
     */
219 5
    public function getList()
220
    {
221 5
        $qb = $this->createQueryBuilder('t')
222 5
            ->orderBy('t.apply_date', 'DESC')
223 5
            ->where('t.Product IS NULL AND t.ProductClass IS NULL');
224
        $TaxRules = $qb
225 5
            ->getQuery()
226 5
            ->getResult();
227
228 5
        return $TaxRules;
229
    }
230
231
    /**
232
     * getById
233
     *
234
     * @param  int   $id
235
     * @return array
236
     */
237 1
    public function getById($id)
238
    {
239
        $criteria = array(
240 1
            'id' => $id,
241
        );
242
243 1
        return $this->findOneBy($criteria);
244
    }
245
246
    /**
247
     * getByTime
248
     *
249
     * @param  string $applyDate
250
     * @return mixed
251
     */
252
    public function getByTime($applyDate)
253
    {
254
        $criteria = array(
255
            'apply_date' => $applyDate,
256
        );
257
258
        return $this->findOneBy($criteria);
259
    }
260
261
    /**
262
     * 税規約の削除.
263
     *
264
     * @param  int|\Eccube\Entity\TaxRule $TaxRule 税規約
265
     * @return void
266
     * @throws NoResultException
267
     */
268 3
    public function delete($TaxRule)
269
    {
270 3
        if (!$TaxRule instanceof \Eccube\Entity\TaxRule) {
0 ignored issues
show
The class Eccube\Entity\TaxRule does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
271 1
            $TaxRule = $this->find($TaxRule);
272
        }
273 3
        if (!$TaxRule) {
274
            throw new NoResultException;
0 ignored issues
show
Use parentheses when instantiating classes
Loading history...
275
        }
276 3
        $TaxRule->setDelFlg(1);
277 3
        $em = $this->getEntityManager();
278 3
        $em->persist($TaxRule);
279 3
        $em->flush();
280
    }
281
282
    /**
283
     * TaxRule のキャッシュをクリアする.
284
     *
285
     * getByRule() をコールすると、結果をキャッシュし、2回目以降はデータベースへアクセスしない.
286
     * このメソッドをコールすると、キャッシュをクリアし、再度データベースを参照して結果を取得する.
287
     */
288 7
    public function clearCache()
289
    {
290 7
        $this->rules = array();
291
    }
292
}
293