Issues (2687)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Admin/Setting/Shop/TaxRuleController.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/*
3
 * This file is part of EC-CUBE
4
 *
5
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6
 *
7
 * http://www.lockon.co.jp/
8
 *
9
 * This program is free software; you can redistribute it and/or
10
 * modify it under the terms of the GNU General Public License
11
 * as published by the Free Software Foundation; either version 2
12
 * of the License, or (at your option) any later version.
13
 *
14
 * This program is distributed in the hope that it will be useful,
15
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
 * GNU General Public License for more details.
18
 *
19
 * You should have received a copy of the GNU General Public License
20
 * along with this program; if not, write to the Free Software
21
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
22
 */
23
24
25
namespace Eccube\Controller\Admin\Setting\Shop;
26
27
use Doctrine\ORM\EntityManager;
28
use Eccube\Application;
29
use Eccube\Controller\AbstractController;
30
use Eccube\Event\EccubeEvents;
31
use Eccube\Event\EventArgs;
32
use Symfony\Component\Form\Form;
33
use Symfony\Component\Form\FormError;
34
use Symfony\Component\HttpFoundation\Request;
35
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
36
37
class TaxRuleController extends AbstractController
0 ignored issues
show
Missing class doc comment
Loading history...
38
{
39
40
    /**
41
     * 税率設定の初期表示・登録
42
     *
43
     * @param Application $app
44
     * @param Request $request
45
     * @param null $id
46
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
47
     */
48 6
    public function index(Application $app, Request $request, $id = null)
49
    {
50 6
        $TargetTaxRule = null;
51
52 6
        if ($id == null) {
53 2
            $TargetTaxRule = $app['eccube.repository.tax_rule']->newTaxRule();
54
        } else {
55 4
            $TargetTaxRule = $app['eccube.repository.tax_rule']->find($id);
56 4
            if (is_null($TargetTaxRule)) {
57 1
                throw new NotFoundHttpException();
58
            }
59
        }
60
61
        /** @var  $BaseInfo \Eccube\Entity\BaseInfo */
62 5
        $BaseInfo = $app['eccube.repository.base_info']->get();
63
64 5
        $builder = $app['form.factory']
65 5
            ->createBuilder('tax_rule', $TargetTaxRule);
66
67
        $builder
68 5
            ->get('option_product_tax_rule')
69 5
            ->setData($BaseInfo->getOptionProductTaxRule());
70
71 5
        if ($TargetTaxRule->isDefaultTaxRule()) {
72
            // 基本税率設定は適用日時の変更は行わない
73 2
            $builder = $builder->remove('apply_date');
74
        }
75
76 5
        $event = new EventArgs(
77
            array(
78 5
                'builder' => $builder,
79 5
                'BaseInfo' => $BaseInfo,
80 5
                'TargetTaxRule' => $TargetTaxRule,
81
            ),
82
            $request
83
        );
84 5
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_INDEX_INITIALIZE, $event);
85
86
        /* @var $form \Symfony\Component\Form\FormInterface */
87 5
        $form = $builder->getForm();
88
89 5
        if ('POST' === $request->getMethod()) {
90 1
            $form->handleRequest($request);
91 1
            if ($this->isValid($app['orm.em'], $form)) {
92 1
                $app['orm.em']->persist($TargetTaxRule);
93
94 1
                $app['orm.em']->flush();
95
96 1
                $event = new EventArgs(
97
                    array(
98 1
                        'form' => $form,
99 1
                        'BaseInfo' => $BaseInfo,
100 1
                        'TargetTaxRule' => $TargetTaxRule,
101
                    ),
102
                    $request
103
                );
104 1
                $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_INDEX_COMPLETE, $event);
105
106 1
                $app->addSuccess('admin.shop.tax.save.complete', 'admin');
107
108 1
                return $app->redirect($app->url('admin_setting_shop_tax'));
109
            }
110
        }
111
112
        // 共通税率一覧
113 4
        $TaxRules = $app['eccube.repository.tax_rule']->getList();
114
115 4
        return $app->render('Setting/Shop/tax_rule.twig', array(
116 4
            'TargetTaxRule' => $TargetTaxRule,
117 4
            'TaxRules' => $TaxRules,
118 4
            'form' => $form->createView(),
119
        ));
120
    }
121
122
    /**
0 ignored issues
show
Doc comment for parameter "$id" missing
Loading history...
123
     * 税率設定の削除
124
     *
125
     * @param Application $app
126
     * @param Request $request
127
     * @param $id
128
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
129
     */
130 4
    public function delete(Application $app, Request $request, $id)
131
    {
132 4
        $this->isTokenValid($app);
133
134 4
        $TargetTaxRule = $app['eccube.repository.tax_rule']->find($id);
135 4
        if (!$TargetTaxRule) {
136 1
            $app->deleteMessage();
137 1
            return $app->redirect($app->url('admin_setting_shop_tax'));
138
        }
139
140 3
        if (!$TargetTaxRule->isDefaultTaxRule()) {
141 1
            $app['eccube.repository.tax_rule']->delete($TargetTaxRule);
142
143 1
            $event = new EventArgs(
144
                array(
145 1
                    'TargetTaxRule' => $TargetTaxRule,
146
                ),
147
                $request
148
            );
149 1
            $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_DELETE_COMPLETE, $event);
150
151 1
            $app->addSuccess('admin.shop.tax.delete.complete', 'admin');
152
        }
153
154 3
        return $app->redirect($app->url('admin_setting_shop_tax'));
155
    }
156
157
    /**
158
     * 軽減税率の有効/無効設定
159
     *
160
     * @param Application $app
161
     * @param Request $request
162
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
163
     */
164 4
    public function editParameter(Application $app, Request $request)
165
    {
166 4
        $builder = $app['form.factory']
167 4
            ->createBuilder('tax_rule');
168
169 4
        $event = new EventArgs(
170
            array(
171 4
                'builder' => $builder,
172
            ),
173
            $request
174
        );
175 4
        $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_EDIT_PARAMETER_INITIALIZE, $event);
176
177 4
        $form = $builder->getForm();
178
179 4 View Code Duplication
        if ('POST' === $request->getMethod()) {
180 3
            $form->handleRequest($request);
181
182
            // 軽減税率設定の項目のみ処理する
183 3
            $optionForm = $form->get('option_product_tax_rule');
184 3
            if ($optionForm->isValid()) {
185
                /** @var  $BaseInfo \Eccube\Entity\BaseInfo */
186 1
                $BaseInfo = $app['eccube.repository.base_info']->get();
187 1
                $BaseInfo->setOptionProductTaxRule($optionForm->getData());
188
189 1
                $app['orm.em']->flush();
190
191 1
                $event = new EventArgs(
192
                    array(
193 1
                        'form' => $form,
194 1
                        'BaseInfo' => $BaseInfo,
195
                    ),
196
                    $request
197
                );
198 1
                $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_TAX_RULE_EDIT_PARAMETER_COMPLETE, $event);
199
200 1
                $app->addSuccess('admin.shop.tax.save.complete', 'admin');
201
            }
202
        }
203
204 4
        return $app->redirect($app->url('admin_setting_shop_tax'));
205
    }
206
207 1
    protected function isValid(EntityManager $em, Form $form)
208
    {
209 1
        if (!$form->isValid()) {
210
            return false;
211
        }
212
        /**
213
         * 同一日時のエラーチェック.
214
         */
215
        /** @var $TargetTaxRule \Eccube\Entity\TaxRule */
216 1
        $TargetTaxRule = $form->getData();
217 1
        $parameters = array();
218 1
        $parameters['apply_date'] = $TargetTaxRule->getApplyDate();
219
        $qb = $em
220 1
            ->getRepository('Eccube\Entity\TaxRule')
221 1
            ->createQueryBuilder('t')
222 1
            ->select('count(t.id)')
223 1
            ->where('t.apply_date = :apply_date');
224
        // 編集時は, 編集対象をのぞいて検索.
225 1
        if ($TargetTaxRule->getId()) {
226 1
            $qb->andWhere('t.id <> :id');
227 1
            $parameters['id'] = $TargetTaxRule->getId();
228
        }
229 1
        $qb->setParameters($parameters);
230
        $count = $qb
231 1
            ->getQuery()
232 1
            ->getSingleScalarResult();
233
        // 同じ適用日時の登録データがあればエラーとする.
234 1
        if ($count > 0) {
235
            $form['apply_date']->addError(new FormError('既に同じ適用日時で登録されています。'));
236
237
            return false;
238
        }
239
240 1
        return true;
241
    }
242
}
243