Issues in ContentsController.php (master) - Issues in master - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2687)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/Admin/Content/ContentsController.php (1 issue)

Labels

Bug 1

Severity

Major 1

Kentaro Ohkouchi 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Controller\Admin\Content;

use Eccube\Application;
use Symfony\Component\HttpFoundation\Request;

/**
 * @deprecated 3.1 delete. use NewsController
 */
class ContentsController extends NewsController
{
    /**
     * @deprecated 3.1 delete. use NewsController
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * (non-PHPdoc)
     * @see \Eccube\Controller\Admin\Content\NewsController::index()
     * @deprecated 3.1 delete. use NewsController
     * @param Application $app
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function index(Application $app, Request $request = null)
    {
        return parent::index($app, $request);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
    }

    /**
     * (non-PHPdoc)
     * @see \Eccube\Controller\Admin\Content\NewsController::edit()
     * @deprecated 3.1 delete. use NewsController
     * @param Application $app
     * @param Request $request
     * @param integer $id
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response
     */
    public function edit(Application $app, Request $request, $id = null)
    {
        return parent::edit($app, $request, $id);
    }

    /**
     * (non-PHPdoc)
     * @see \Eccube\Controller\Admin\Content\NewsController::up()
     * @param Application $app
     * @param Request $request
     * @param integer $id
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function up(Application $app, Request $request, $id)
    {
        return parent::up($app, $request, $id);
    }

    /**
     * (non-PHPdoc)
     * @see \Eccube\Controller\Admin\Content\NewsController::down()
     * @param Application $app
     * @param Request $request
     * @param integer $id
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function down(Application $app, Request $request, $id)
    {
        return parent::down($app, $request, $id);
    }

    /**
     * (non-PHPdoc)
     * @see \Eccube\Controller\Admin\Content\NewsController::delete()
     * @param Application $app
     * @param Request $request
     * @param integer $id
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function delete(Application $app, Request $request, $id)
    {
        return parent::delete($app, $request, $id);
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24			namespace Eccube\Controller\Admin\Content;
25
26			use Eccube\Application;
27			use Symfony\Component\HttpFoundation\Request;
28
29			/**
30			* @deprecated 3.1 delete. use NewsController
31			*/
32			class ContentsController extends NewsController
33			{
34			/**
35			* @deprecated 3.1 delete. use NewsController
36			*/
37			public function __construct()
38			{
39			parent::__construct();
40			}
41
42			/**
43			* (non-PHPdoc)
44			* @see \Eccube\Controller\Admin\Content\NewsController::index()
45			* @deprecated 3.1 delete. use NewsController
46			* @param Application $app
47			* @return \Symfony\Component\HttpFoundation\Response
48			*/
49			public function index(Application $app, Request $request = null)
50			{
51			return parent::index($app, $request);
			0 ignored issues – show Bug introduced 2016-08-05 14:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$request` defined by parameter `$request` on line `49` can be `null`; however, `Eccube\Controller\Admin\...NewsController::index()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
52			}
53
54			/**
55			* (non-PHPdoc)
56			* @see \Eccube\Controller\Admin\Content\NewsController::edit()
57			* @deprecated 3.1 delete. use NewsController
58			* @param Application $app
59			* @param Request $request
60			* @param integer $id
61			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response
62			*/
63			public function edit(Application $app, Request $request, $id = null)
64			{
65			return parent::edit($app, $request, $id);
66			}
67
68			/**
69			* (non-PHPdoc)
70			* @see \Eccube\Controller\Admin\Content\NewsController::up()
71			* @param Application $app
72			* @param Request $request
73			* @param integer $id
74			* @return \Symfony\Component\HttpFoundation\RedirectResponse
75			*/
76			public function up(Application $app, Request $request, $id)
77			{
78			return parent::up($app, $request, $id);
79			}
80
81			/**
82			* (non-PHPdoc)
83			* @see \Eccube\Controller\Admin\Content\NewsController::down()
84			* @param Application $app
85			* @param Request $request
86			* @param integer $id
87			* @return \Symfony\Component\HttpFoundation\RedirectResponse
88			*/
89			public function down(Application $app, Request $request, $id)
90			{
91			return parent::down($app, $request, $id);
92			}
93
94			/**
95			* (non-PHPdoc)
96			* @see \Eccube\Controller\Admin\Content\NewsController::delete()
97			* @param Application $app
98			* @param Request $request
99			* @param integer $id
100			* @return \Symfony\Component\HttpFoundation\RedirectResponse
101			*/
102			public function delete(Application $app, Request $request, $id)
103			{
104			return parent::delete($app, $request, $id);
105			}
106			}
107

EC-CUBE / ec-cube

Issues (2687)

Security Analysis not enabled

Controller/Admin/Content/ContentsController.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like