Failed Conditions
Pull Request — experimental/3.1 (#2534)
by chihiro
09:59
created
src/Eccube/Controller/Admin/Product/ClassCategoryController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
         $num = $this->productClassRepository->createQueryBuilder('pc')
183 183
             ->select('count(pc.id)')
184 184
             ->where('pc.ClassCategory1 = :id OR pc.ClassCategory2 = :id')
185
-            ->setParameter('id',$id)
185
+            ->setParameter('id', $id)
186 186
             ->getQuery()
187 187
             ->getSingleScalarResult();
188 188
         if ($num > 0) {
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
                 log_error('規格分類削除エラー', array($id, $e));
209 209
 
210 210
                 $message = $app->trans('admin.delete.failed.foreign_key', ['%name%' => '規格分類']);
211
-                $app->addError($message, 'admin');            }
211
+                $app->addError($message, 'admin'); }
212 212
         }
213 213
 
214 214
         return $app->redirect($app->url('admin_product_class_category', array('class_name_id' => $ClassName->getId())));
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ClassNameController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
         try {
149 149
             $this->classNameRepository->delete($ClassName);
150 150
 
151
-            $event = new EventArgs(['ClassName' => $ClassName,], $request);
151
+            $event = new EventArgs(['ClassName' => $ClassName, ], $request);
152 152
             $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_PRODUCT_CLASS_NAME_DELETE_COMPLETE, $event);
153 153
 
154 154
             $app->addSuccess('admin.class_name.delete.complete', 'admin');
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Setting/Shop/PaymentController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -242,7 +242,7 @@
 block discarded – undo
242 242
             $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_PAYMENT_DELETE_COMPLETE, $event);
243 243
 
244 244
             $app->addSuccess('admin.delete.complete', 'admin');
245
-        } catch(ForeignKeyConstraintViolationException $e) {
245
+        } catch (ForeignKeyConstraintViolationException $e) {
246 246
             $this->entityManager->rollback();
247 247
 
248 248
             $message = $app->trans('admin.delete.failed.foreign_key', ['%name%' => '支払方法']);
Please login to merge, or discard this patch.
src/Eccube/Service/Calculator/CalculateContext.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 use Eccube\Entity\Order;
5 5
 use Eccube\Entity\PurchaseInterface;
6 6
 use Eccube\Entity\OrderItem;
7
-use Eccube\Service\Calculator\Strategy\CalculateStrategyInterface;
8 7
 
9 8
 class CalculateContext
10 9
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
         $this->buildCalculator($this->CalculateStrategies);
24 24
 
25 25
         /** @var OrderItem $OrderItem */
26
-        foreach($this->OrderItems as $OrderItem) {
26
+        foreach ($this->OrderItems as $OrderItem) {
27 27
             if ($OrderItem instanceof OrderItem) {
28 28
                 if (!$this->Order->getItems()->contains($OrderItem)) {
29 29
                     $OrderItem->setOrder($this->Order);
Please login to merge, or discard this patch.
src/Eccube/Service/Calculator/Strategy/CalculateChargeStrategy.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,13 +2,9 @@
 block discarded – undo
2 2
 namespace Eccube\Service\Calculator\Strategy;
3 3
 
4 4
 use Eccube\Application;
5
-use Eccube\Entity\Master\OrderItemType;
6
-use Eccube\Entity\Master\TaxType;
7
-use Eccube\Entity\Master\TaxDisplayType;
8 5
 use Eccube\Entity\Order;
9 6
 use Eccube\Entity\PurchaseInterface;
10 7
 use Eccube\Entity\OrderItem;
11
-use Eccube\Entity\Shipping;
12 8
 use Eccube\Repository\Master\OrderItemTypeRepository;
13 9
 use Eccube\Service\Calculator\OrderItemCollection;
14 10
 
Please login to merge, or discard this patch.
src/Eccube/Service/Calculator/Strategy/CalculateTotalStrategy.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,14 +2,10 @@
 block discarded – undo
2 2
 namespace Eccube\Service\Calculator\Strategy;
3 3
 
4 4
 use Eccube\Application;
5
-use Eccube\Entity\Master\OrderItemType;
6
-use Eccube\Entity\Master\TaxType;
7
-use Eccube\Entity\Master\TaxDisplayType;
8 5
 use Eccube\Entity\Cart;
9 6
 use Eccube\Entity\Order;
10 7
 use Eccube\Entity\PurchaseInterface;
11 8
 use Eccube\Entity\OrderItem;
12
-use Eccube\Entity\Shipping;
13 9
 use Eccube\Repository\Master\OrderItemTypeRepository;
14 10
 use Eccube\Service\Calculator\OrderItemCollection;
15 11
 
Please login to merge, or discard this patch.
src/Eccube/Service/Calculator/Strategy/ChargeStrategy.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use Eccube\Entity\Order;
9 9
 use Eccube\Entity\PurchaseInterface;
10 10
 use Eccube\Entity\OrderItem;
11
-use Eccube\Entity\Shipping;
12 11
 use Eccube\Repository\Master\OrderItemTypeRepository;
13 12
 use Eccube\Service\Calculator\OrderItemCollection;
14 13
 
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/Processor/StockReduceProcessor.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Eccube\Service\PurchaseFlow\Processor;
4 4
 
5 5
 use Doctrine\DBAL\LockMode;
6
-use Eccube\Annotation\Inject;
7 6
 use Eccube\Common\Constant;
8 7
 use Eccube\Entity\ItemInterface;
9 8
 use Eccube\Entity\OrderItem;
Please login to merge, or discard this patch.
src/Eccube/Service/TaxRuleService.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      * @param  int|null|\Eccube\Entity\ProductClass   $productClass 商品規格
66 66
      * @param  int|null|\Eccube\Entity\Master\Pref    $pref         都道府県
67 67
      * @param  int|null|\Eccube\Entity\Master\Country $country      国
68
-     * @return int
68
+     * @return double
69 69
      */
70 70
     public function getPriceIncTax($price, $product = null, $productClass = null, $pref = null, $country = null)
71 71
     {
@@ -92,8 +92,8 @@  discard block
 block discarded – undo
92 92
     /**
93 93
      * 課税規則に応じて端数処理を行う
94 94
      *
95
-     * @param  float|integer $value    端数処理を行う数値
96
-     * @param  integer       $calcRule 課税規則
95
+     * @param  integer $value    端数処理を行う数値
96
+     * @param integer $RoundingType
97 97
      * @return double        端数処理後の数値
98 98
      */
99 99
     public function roundByRoundingType($value, $RoundingType)
Please login to merge, or discard this patch.