Queries::customize() - Code Metrics - Inspection of "[WIP] Acmeをconfigで変更できるように対応" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2534)

by chihiro

created 2017-10-03 01:58 UTC

Queries::customize() A

↳ Parent: Queries

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	2
nop	3
dl	0
loc	10
ccs	5
cts	5
cp	1
crap	3
rs	9.4285
c	0
b	0
f	0

<?php


namespace Eccube\Doctrine\Query;


use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\ORM\QueryBuilder;
use Eccube\Annotation\QueryExtension;
use Psr\Log\InvalidArgumentException;

class Queries

{

    private $customizers = [];

    public function addCustomizer(QueryCustomizer $customizer) {

        if (!$customizer) {
            throw new InvalidArgumentException('Customizer should not be null.');
        }
        $reader = new AnnotationReader();
        $rc = new \ReflectionClass($customizer);
        $anno = $reader->getClassAnnotation($rc, QueryExtension::class);
        if (!$anno) {
            throw new InvalidArgumentException(get_class($customizer).' doesn\'t have any '.QueryExtension::class.' annotation.');
        }
        foreach ($anno->value as $queryKey) {
            $this->customizers[$queryKey][] = $customizer;
        }
    }

    public function customize($queryKey, QueryBuilder $builder, $params)

    {
        if (isset($this->customizers[$queryKey])) {
            /* @var QueryCustomizer $customizer */
            foreach ($this->customizers[$queryKey] as $customizer) {
                $customizer->customize($builder, $params, $queryKey);
            }
        }
        return $builder;

    }
}

1		<?php
2
3
4		namespace Eccube\Doctrine\Query;
5
6
7		use Doctrine\Common\Annotations\AnnotationReader;
8		use Doctrine\ORM\QueryBuilder;
9		use Eccube\Annotation\QueryExtension;
10		use Psr\Log\InvalidArgumentException;
11
12		class Queries
		0 ignored issues – show introduced 2017-04-19 07:31 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
13		{
14
15		private $customizers = [];
16
17	1	public function addCustomizer(QueryCustomizer $customizer) {
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
18	1	if (!$customizer) {
19		throw new InvalidArgumentException('Customizer should not be null.');
20		}
21	1	$reader = new AnnotationReader();
22	1	$rc = new \ReflectionClass($customizer);
23	1	$anno = $reader->getClassAnnotation($rc, QueryExtension::class);
24	1	if (!$anno) {
25		throw new InvalidArgumentException(get_class($customizer).' doesn\'t have any '.QueryExtension::class.' annotation.');
26		}
27	1	foreach ($anno->value as $queryKey) {
28	1	$this->customizers[$queryKey][] = $customizer;
29		}
30		}
31
32	1	public function customize($queryKey, QueryBuilder $builder, $params)
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
33		{
34	1	if (isset($this->customizers[$queryKey])) {
35		/* @var QueryCustomizer $customizer */
36	1	foreach ($this->customizers[$queryKey] as $customizer) {
37	1	$customizer->customize($builder, $params, $queryKey);
38		}
39		}
40	1	return $builder;
		0 ignored issues – show introduced 2017-04-19 07:31 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
41		}
42		}

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2534)

Queries::customize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like