Failed Conditions
Pull Request — experimental/3.1 (#2522)
by chihiro
38:22
created
src/Eccube/Di/Scanner/FormExtensionScanner.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 {
32 32
     /**
33 33
      * FormExtensionAutoWiring constructor.
34
-     * @param array|string[] $scanDirs
34
+     * @param string[] $scanDirs
35 35
      */
36 36
     public function __construct($scanDirs)
37 37
     {
Please login to merge, or discard this patch.
src/Eccube/Di/Scanner/RepositoryDefinition.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,8 +30,8 @@
 block discarded – undo
30 30
 {
31 31
     /**
32 32
      * RepositoryDefinition constructor.
33
-     * @param $id
34
-     * @param $refClass
33
+     * @param string $id
34
+     * @param \ReflectionClass $refClass
35 35
      */
36 36
     public function __construct($id, $refClass)
37 37
     {
Please login to merge, or discard this patch.
src/Eccube/Di/Scanner/RepositoryScanner.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
 {
31 31
     /**
32 32
      * RepositoryAutoWiring constructor.
33
-     * @param array|string[] $scanDirs
33
+     * @param string[] $scanDirs
34 34
      */
35 35
     public function __construct($scanDirs)
36 36
     {
Please login to merge, or discard this patch.
src/Eccube/Di/Di.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -161,7 +161,9 @@
 block discarded – undo
161 161
             }
162 162
 
163 163
             if (!empty($components)) {
164
-                if ($snippets) $snippets .= PHP_EOL;
164
+                if ($snippets) {
165
+                    $snippets .= PHP_EOL;
166
+                }
165 167
                 $snippets .= $wiring->generate($twig, $components);
166 168
                 $snippets .= $wiring->generateExtend($twig, $components);
167 169
             }
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/DiServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 {
14 14
     public function register(Container $app)
15 15
     {
16
-        $app['eccube.di'] = function (Container $app) {
16
+        $app['eccube.di'] = function(Container $app) {
17 17
             $di = new Di(
18 18
                 $app['eccube.di.generator.dir'],
19 19
                 $app['eccube.di.generator.class'],
Please login to merge, or discard this patch.
src/Eccube/Controller/Mypage/MypageController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,6 @@
 block discarded – undo
32 32
 use Eccube\Controller\AbstractController;
33 33
 use Eccube\Entity\BaseInfo;
34 34
 use Eccube\Entity\CustomerFavoriteProduct;
35
-use Eccube\Entity\Product;
36 35
 use Eccube\Event\EccubeEvents;
37 36
 use Eccube\Event\EventArgs;
38 37
 use Eccube\Exception\CartException;
Please login to merge, or discard this patch.
src/Eccube/Repository/CustomerRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -392,7 +392,7 @@
 block discarded – undo
392 392
     /**
393 393
      * 会員の初回購入時間、購入時間、購入回数、購入金額を更新する
394 394
      *
395
-     * @param $app
395
+     * @param \Eccube\Application $app
396 396
      * @param  Customer $Customer
397 397
      * @param  $orderStatusId
398 398
      */
Please login to merge, or discard this patch.
src/Eccube/Repository/NewsRepository.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@
 block discarded – undo
114 114
      */
115 115
     public function delete($News)
116 116
     {
117
-       $this->createQueryBuilder('n')
117
+        $this->createQueryBuilder('n')
118 118
             ->update()
119 119
             ->set('n.rank', 'n.rank - 1')
120 120
             ->where('n.rank > :rank')
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/NewsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@
 block discarded – undo
122 122
             $News = new \Eccube\Entity\News();
123 123
         }
124 124
 
125
-        $News->setLinkMethod((bool)$News->getLinkMethod());
125
+        $News->setLinkMethod((bool) $News->getLinkMethod());
126 126
 
127 127
         $builder = $this->formFactory
128 128
             ->createBuilder(NewsType::class, $News);
Please login to merge, or discard this patch.