Completed
Pull Request — 4.0 (#4625)
by Kentaro
04:48
created
src/Eccube/Twig/Extension/EccubeExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -347,7 +347,7 @@
 block discarded – undo
347 347
      *
348 348
      * @param null $currency
349 349
      *
350
-     * @return bool|string
350
+     * @return string|null
351 351
      */
352 352
     public function getCurrencySymbol($currency = null)
353 353
     {
Please login to merge, or discard this patch.
src/Eccube/Command/UpdateSchemaDoctrineCommand.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -112,6 +112,9 @@
 block discarded – undo
112 112
         }
113 113
     }
114 114
 
115
+    /**
116
+     * @param string $outputDir
117
+     */
115 118
     protected function removeOutputDir($outputDir)
116 119
     {
117 120
         if (file_exists($outputDir)) {
Please login to merge, or discard this patch.
src/Eccube/Util/CacheUtil.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,6 @@
 block discarded – undo
111 111
     /**
112 112
      * Doctrineのキャッシュを削除します.
113 113
      *
114
-     * @param null $env
115 114
      *
116 115
      * @return string
117 116
      *
Please login to merge, or discard this patch.
src/Eccube/Repository/PageRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@
 block discarded – undo
132 132
      * @param  string                            $where 追加の検索条件
133 133
      * @param  string[]                          $parameters 追加の検索パラメーター
134 134
      *
135
-     * @return array                             ページ属性の配列
135
+     * @return null|\Symfony\Component\HttpFoundation\Request                             ページ属性の配列
136 136
      */
137 137
     public function getPageList($where = null, $parameters = [])
138 138
     {
Please login to merge, or discard this patch.
codeception/acceptance/EA10PluginCest.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -436,6 +436,9 @@  discard block
 block discarded – undo
436 436
         $fs->remove($dir);
437 437
     }
438 438
 
439
+    /**
440
+     * @param string $fileName
441
+     */
439 442
     private function publishPlugin($fileName)
440 443
     {
441 444
         copy(codecept_data_dir().'/'.'plugins/'.$fileName, codecept_root_dir().'/repos/'.$fileName);
@@ -581,6 +584,9 @@  discard block
 block discarded – undo
581 584
     /** @var Store_Plugin */
582 585
     protected $dependency;
583 586
 
587
+    /**
588
+     * @param string $code
589
+     */
584 590
     public function __construct(AcceptanceTester $I, $code, Store_Plugin $dependency = null)
585 591
     {
586 592
         parent::__construct($I);
@@ -713,6 +719,9 @@  discard block
 block discarded – undo
713 719
         return $this;
714 720
     }
715 721
 
722
+    /**
723
+     * @param string $fileName
724
+     */
716 725
     protected function publishPlugin($fileName)
717 726
     {
718 727
         $published = copy(codecept_data_dir().'/'.'plugins/'.$fileName, codecept_root_dir().'/repos/'.$fileName);
@@ -731,6 +740,9 @@  discard block
 block discarded – undo
731 740
     /** @var string */
732 741
     private $code;
733 742
 
743
+    /**
744
+     * @param string $code
745
+     */
734 746
     public function __construct(AcceptanceTester $I, $code)
735 747
     {
736 748
         parent::__construct($I);
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/ProductType.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -194,7 +194,7 @@
 block discarded – undo
194 194
     /**
195 195
      * 指定された複数ディレクトリのうち、いずれかのディレクトリ以下にファイルが存在するかを確認。
196 196
      *
197
-     * @param $form FormInterface
197
+     * @param FormInterface $form FormInterface
198 198
      * @param $dirs array
199 199
      */
200 200
     private function validateFilePath($form, $dirs)
Please login to merge, or discard this patch.
src/Eccube/Service/SchemaService.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,6 @@
 block discarded – undo
47 47
      * @param callable $callback Metadata を生成した後に実行されるコールバック関数
48 48
      * @param array $generatedFiles Proxy ファイルパスの配列
49 49
      * @param string $proxiesDirectory Proxy ファイルを格納したディレクトリ
50
-     * @param bool $saveMode UpdateSchema を即時実行する場合 true
51 50
      * @param string $outputDir Metadata の出力先ディレクトリ
52 51
      */
53 52
     public function executeCallback(callable $callback, $generatedFiles, $proxiesDirectory, $outputDir = null)
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerApiService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -386,6 +386,9 @@
 block discarded – undo
386 386
         $this->init($BaseInfo);
387 387
     }
388 388
 
389
+    /**
390
+     * @param string $packageNames
391
+     */
389 392
     private function dropTableToExtra($packageNames)
390 393
     {
391 394
         foreach (explode(' ', trim($packageNames)) as $packageName) {
Please login to merge, or discard this patch.