Completed
Pull Request — 4.0 (#4024)
by akira
06:11
created
src/Eccube/Util/CacheUtil.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,6 @@
 block discarded – undo
89 89
      * Doctrineのキャッシュを削除します.
90 90
      * APP_ENV=prodの場合のみ実行されます.
91 91
      *
92
-     * @param null $env
93 92
      * @return string
94 93
      * @throws \Exception
95 94
      */
Please login to merge, or discard this patch.
src/Eccube/Repository/BaseInfoRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
         $BaseInfo = $this->find($id);
45 45
 
46 46
         if (null === $BaseInfo) {
47
-            throw new \Exception('BaseInfo not found. id = '. $id);
47
+            throw new \Exception('BaseInfo not found. id = '.$id);
48 48
         }
49 49
 
50 50
         return $this->find($id);
Please login to merge, or discard this patch.
src/Eccube/EventListener/TransactionListener.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
 
14 14
 namespace Eccube\EventListener;
15 15
 
16
-use Doctrine\Dbal\Connection;
17 16
 use Doctrine\DBAL\TransactionIsolationLevel;
17
+use Doctrine\Dbal\Connection;
18 18
 use Doctrine\ORM\EntityManager;
19 19
 use Doctrine\ORM\EntityManagerInterface;
20 20
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
Please login to merge, or discard this patch.
codeception/acceptance/EA10PluginCest.php 1 patch
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -404,6 +404,9 @@  discard block
 block discarded – undo
404 404
         $Horizon->インストール();
405 405
     }
406 406
 
407
+    /**
408
+     * @param string $fileName
409
+     */
407 410
     private function publishPlugin($fileName)
408 411
     {
409 412
         copy(codecept_data_dir().'/'.'plugins/'.$fileName, codecept_root_dir().'/repos/'.$fileName);
@@ -547,6 +550,9 @@  discard block
 block discarded – undo
547 550
     /** @var Store_Plugin */
548 551
     protected $dependency;
549 552
 
553
+    /**
554
+     * @param string $code
555
+     */
550 556
     public function __construct(AcceptanceTester $I, $code, Store_Plugin $dependency = null)
551 557
     {
552 558
         parent::__construct($I);
@@ -679,6 +685,9 @@  discard block
 block discarded – undo
679 685
         return $this;
680 686
     }
681 687
 
688
+    /**
689
+     * @param string $fileName
690
+     */
682 691
     protected function publishPlugin($fileName)
683 692
     {
684 693
         $published = copy(codecept_data_dir().'/'.'plugins/'.$fileName, codecept_root_dir().'/repos/'.$fileName);
@@ -697,6 +706,9 @@  discard block
 block discarded – undo
697 706
     /** @var string */
698 707
     private $code;
699 708
 
709
+    /**
710
+     * @param string $code
711
+     */
700 712
     public function __construct(AcceptanceTester $I, $code)
701 713
     {
702 714
         parent::__construct($I);
Please login to merge, or discard this patch.
src/Eccube/Twig/Extension/EccubeExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -346,7 +346,7 @@
 block discarded – undo
346 346
      * Get currency symbol
347 347
      *
348 348
      * @param null $currency
349
-     * @return bool|string
349
+     * @return string|null
350 350
      */
351 351
     public function getCurrencySymbol($currency = null)
352 352
     {
Please login to merge, or discard this patch.
src/Eccube/Plugin/AbstractPluginManager.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@
 block discarded – undo
14 14
 namespace Eccube\Plugin;
15 15
 
16 16
 use Doctrine\DBAL\Connection;
17
-use Doctrine\DBAL\Migrations\Migration;
18 17
 use Doctrine\DBAL\Migrations\Configuration\Configuration;
18
+use Doctrine\DBAL\Migrations\Migration;
19 19
 use Symfony\Component\DependencyInjection\ContainerInterface;
20 20
 
21 21
 abstract class AbstractPluginManager
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Store/OwnerStoreController.php 1 patch
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,10 +30,10 @@
 block discarded – undo
30 30
 use Eccube\Util\FormUtil;
31 31
 use Knp\Component\Pager\Paginator;
32 32
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
33
-use Symfony\Component\HttpFoundation\Request;
34
-use Symfony\Component\HttpKernel\KernelEvents;
35 33
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
34
+use Symfony\Component\HttpFoundation\Request;
36 35
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
36
+use Symfony\Component\HttpKernel\KernelEvents;
37 37
 use Symfony\Component\Routing\Annotation\Route;
38 38
 
39 39
 /**
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,11 +22,11 @@
 block discarded – undo
22 22
 use Eccube\Exception\PluginException;
23 23
 use Eccube\Repository\PluginRepository;
24 24
 use Eccube\Service\Composer\ComposerServiceInterface;
25
+use Eccube\Service\SystemService;
25 26
 use Eccube\Util\CacheUtil;
26 27
 use Eccube\Util\StringUtil;
27 28
 use Symfony\Component\DependencyInjection\ContainerInterface;
28 29
 use Symfony\Component\Filesystem\Filesystem;
29
-use Eccube\Service\SystemService;
30 30
 
31 31
 class PluginService
32 32
 {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Store/PluginController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         PluginApiService $pluginApiService,
97 97
         ComposerServiceInterface $composerService,
98 98
         SystemService $systemService
99
-    ){
99
+    ) {
100 100
         $this->pluginRepository = $pluginRepository;
101 101
         $this->pluginService = $pluginService;
102 102
         $this->BaseInfo = $baseInfoRepository->get();
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
             // TERMINATE時のイベントを設定
291 291
             $dispatcher->addListener(KernelEvents::TERMINATE, function () {
292 292
                 // auto_maintenance_updateと設定されたファイルを削除
293
-                $this->systemService->switchMaintenance(false,SystemService::AUTO_MAINTENANCE_UPDATE);
293
+                $this->systemService->switchMaintenance(false, SystemService::AUTO_MAINTENANCE_UPDATE);
294 294
             });
295 295
         }
296 296
 
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
             $this->systemService->switchMaintenance(true); // auto_maintenanceと設定されたファイルを生成
385 385
             // TERMINATE時のイベントを設定
386 386
             $dispatcher->addListener(KernelEvents::TERMINATE, function () {
387
-                $this->systemService->switchMaintenance();// auto_maintenanceと設定されたファイルを削除
387
+                $this->systemService->switchMaintenance(); // auto_maintenanceと設定されたファイルを削除
388 388
             });
389 389
         }
390 390
 
Please login to merge, or discard this patch.