DeliveryController::delete() - Code Metrics - Inspection of "Merge pull request #2522 from chihiro-adachi/repos..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — experimental/3.1 ( 3d2ede...2919b9 )

by Yangsin

created 2017-09-27 01:42 UTC

DeliveryController::delete() B

↳ Parent: DeliveryController

Complexity

Conditions	2
Paths	2

Size

Total Lines	28
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	2.0011

Importance

Changes

Metric	Value
cc	2
eloc	16
nc	2
nop	3
dl	0
loc	28
ccs	14
cts	15
cp	0.9333
crap	2.0011
rs	8.8571
c	0
b	0
f	0

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller\Mypage;

use Doctrine\ORM\EntityManager;
use Eccube\Annotation\Component;
use Eccube\Annotation\Inject;
use Eccube\Application;
use Eccube\Controller\AbstractController;
use Eccube\Entity\BaseInfo;
use Eccube\Entity\CustomerAddress;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Front\CustomerAddressType;
use Eccube\Repository\CustomerAddressRepository;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * @Component
 * @Route(service=DeliveryController::class)
 */
class DeliveryController extends AbstractController
{
    /**
     * @Inject(BaseInfo::class)
     * @var BaseInfo
     */
    protected $BaseInfo;

    /**
     * @Inject("orm.em")
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @Inject("eccube.event.dispatcher")
     * @var EventDispatcher
     */
    protected $eventDispatcher;

    /**
     * @Inject("form.factory")
     * @var FormFactory
     */
    protected $formFactory;

    /**
     * @Inject(CustomerAddressRepository::class)
     * @var CustomerAddressRepository
     */
    protected $customerAddressRepository;

    /**
     * @Inject("config")
     * @var array
     */
    protected $appConfig;

    /**

     * お届け先一覧画面.
     *
     * @Route("/mypage/delivery", name="mypage_delivery")
     * @Template("Mypage/delivery.twig")
     */

    public function index(Application $app, Request $request)

    {
        $Customer = $app['user'];

        return [
            'Customer' => $Customer,
        ];
    }

    /**

     * お届け先編集画面.
     *
     * @Route("/mypage/delivery/new", name="mypage_delivery_new")
     * @Route("/mypage/delivery/{id}/edit", name="mypage_delivery_edit", requirements={"id" = "\d+"})
     * @Template("Mypage/delivery_edit.twig")
     */

    public function edit(Application $app, Request $request, $id = null)
    {
        $Customer = $app['user'];

        // 配送先住所最大値判定
        // $idが存在する際は、追加処理ではなく、編集の処理ため本ロジックスキップ
        if (is_null($id)) {
            $addressCurrNum = count($Customer->getCustomerAddresses());
            $addressMax = $this->appConfig['deliv_addr_max'];
            if ($addressCurrNum >= $addressMax) {
                throw new NotFoundHttpException('お届け先の登録数の上限を超えています');
            }
        }

        $CustomerAddress = $this->customerAddressRepository->findOrCreateByCustomerAndId($Customer, $id);


        $parentPage = $request->get('parent_page', null);

        // 正しい遷移かをチェック
        $allowdParents = array(
            $app->url('mypage_delivery'),
            $app->url('shopping_redirect_to'),
        );

        // 遷移が正しくない場合、デフォルトであるマイページの配送先追加の画面を設定する
        if (!in_array($parentPage, $allowdParents)) {
            // @deprecated 使用されていないコード
            $parentPage = $app->url('mypage_delivery');
        }

        $builder = $this->formFactory
            ->createBuilder(CustomerAddressType::class, $CustomerAddress);

        $event = new EventArgs(
            array(
                'builder' => $builder,
                'Customer' => $Customer,
                'CustomerAddress' => $CustomerAddress,
            ),
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_DELIVERY_EDIT_INITIALIZE, $event);

        $form = $builder->getForm();
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            log_info('お届け先登録開始', array($id));

            $this->entityManager->persist($CustomerAddress);
            $this->entityManager->flush();

            log_info('お届け先登録完了', array($id));

            $event = new EventArgs(
                array(
                    'form' => $form,
                    'Customer' => $Customer,
                    'CustomerAddress' => $CustomerAddress,
                ),
                $request
            );
            $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_DELIVERY_EDIT_COMPLETE, $event);

            $app->addSuccess('mypage.delivery.add.complete');

            return $app->redirect($app->url('mypage_delivery'));
        }

        return [
            'form' => $form->createView(),
            'parentPage' => $parentPage,
            'BaseInfo' => $this->BaseInfo,
        ];
    }

    /**

     * お届け先を削除する.
     *
     * @Method("DELETE")
     * @Route("/mypage/delivery/{id}/delete", name="mypage_delivery_delete")
     */

    public function delete(Application $app, Request $request, CustomerAddress $CustomerAddress)
    {
        $this->isTokenValid($app);

        log_info('お届け先削除開始', array($CustomerAddress->getId()));

        $Customer = $app['user'];

        if ($Customer->getId() != $CustomerAddress->getCustomer()->getId()) {
            throw new BadRequestHttpException();
        }

        $this->customerAddressRepository->delete($CustomerAddress);

        $event = new EventArgs(
            array(

                'Customer' => $Customer,
                'CustomerAddress' => $CustomerAddress
            ), $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_DELIVERY_DELETE_COMPLETE, $event);

        $app->addSuccess('mypage.address.delete.complete');

        log_info('お届け先削除完了', array($CustomerAddress->getId()));

        return $app->redirect($app->url('mypage_delivery'));
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24
25			namespace Eccube\Controller\Mypage;
26
27			use Doctrine\ORM\EntityManager;
28			use Eccube\Annotation\Component;
29			use Eccube\Annotation\Inject;
30			use Eccube\Application;
31			use Eccube\Controller\AbstractController;
32			use Eccube\Entity\BaseInfo;
33			use Eccube\Entity\CustomerAddress;
34			use Eccube\Event\EccubeEvents;
35			use Eccube\Event\EventArgs;
36			use Eccube\Form\Type\Front\CustomerAddressType;
37			use Eccube\Repository\CustomerAddressRepository;
38			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
39			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
40			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
41			use Symfony\Component\EventDispatcher\EventDispatcher;
42			use Symfony\Component\Form\FormFactory;
43			use Symfony\Component\HttpFoundation\Request;
44			use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
45			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
46
47			/**
48			* @Component
49			* @Route(service=DeliveryController::class)
50			*/
51			class DeliveryController extends AbstractController
52			{
53			/**
54			* @Inject(BaseInfo::class)
55			* @var BaseInfo
56			*/
57			protected $BaseInfo;
58
59			/**
60			* @Inject("orm.em")
61			* @var EntityManager
62			*/
63			protected $entityManager;
64
65			/**
66			* @Inject("eccube.event.dispatcher")
67			* @var EventDispatcher
68			*/
69			protected $eventDispatcher;
70
71			/**
72			* @Inject("form.factory")
73			* @var FormFactory
74			*/
75			protected $formFactory;
76
77			/**
78			* @Inject(CustomerAddressRepository::class)
79			* @var CustomerAddressRepository
80			*/
81			protected $customerAddressRepository;
82
83			/**
84			* @Inject("config")
85			* @var array
86			*/
87			protected $appConfig;
88
89			/**
			0 ignored issues – show introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Doc comment for parameter "$app" missing Loading history... introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Doc comment for parameter "$request" missing Loading history...
90			* お届け先一覧画面.
91			*
92			* @Route("/mypage/delivery", name="mypage_delivery")
93			* @Template("Mypage/delivery.twig")
94			*/
			0 ignored issues – show introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
95	1		public function index(Application $app, Request $request)
			0 ignored issues – show Unused Code introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
96			{
97	1		$Customer = $app['user'];
98
99			return [
100	1		'Customer' => $Customer,
101			];
102			}
103
104			/**
			0 ignored issues – show introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Doc comment for parameter "$app" missing Loading history... introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Doc comment for parameter "$request" missing Loading history... introduced 2017-02-13 16:13 UTC by Report Bug Copy Issue Report Doc comment for parameter "$id" missing Loading history...
105			* お届け先編集画面.
106			*
107			* @Route("/mypage/delivery/new", name="mypage_delivery_new")
108			* @Route("/mypage/delivery/{id}/edit", name="mypage_delivery_edit", requirements={"id" = "\d+"})
109			* @Template("Mypage/delivery_edit.twig")
110			*/
			0 ignored issues – show introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
111	4		public function edit(Application $app, Request $request, $id = null)
112			{
113	4		$Customer = $app['user'];
114
115			// 配送先住所最大値判定
116			// $idが存在する際は、追加処理ではなく、編集の処理ため本ロジックスキップ
117	4	View Code Duplication	if (is_null($id)) {
118	2		$addressCurrNum = count($Customer->getCustomerAddresses());
119	2		$addressMax = $this->appConfig['deliv_addr_max'];
120	2		if ($addressCurrNum >= $addressMax) {
121			throw new NotFoundHttpException('お届け先の登録数の上限を超えています');
122			}
123			}
124
125	4		$CustomerAddress = $this->customerAddressRepository->findOrCreateByCustomerAndId($Customer, $id);
			0 ignored issues – show Deprecated Code introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report The method `Eccube\Repository\Custom...CreateByCustomerAndId()` has been deprecated with message: 呼び出し元で制御する This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
126
127	4		$parentPage = $request->get('parent_page', null);
128
129			// 正しい遷移かをチェック
130			$allowdParents = array(
131	4		$app->url('mypage_delivery'),
132	4		$app->url('shopping_redirect_to'),
133			);
134
135			// 遷移が正しくない場合、デフォルトであるマイページの配送先追加の画面を設定する
136	4		if (!in_array($parentPage, $allowdParents)) {
137			// @deprecated 使用されていないコード
138	4		$parentPage = $app->url('mypage_delivery');
139			}
140
141	4		$builder = $this->formFactory
142	4		->createBuilder(CustomerAddressType::class, $CustomerAddress);
143
144	4		$event = new EventArgs(
145			array(
146	4		'builder' => $builder,
147	4		'Customer' => $Customer,
148	4		'CustomerAddress' => $CustomerAddress,
149			),
150	4		$request
151			);
152	4		$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_DELIVERY_EDIT_INITIALIZE, $event);
153
154	4		$form = $builder->getForm();
155	4		$form->handleRequest($request);
156
157	4	View Code Duplication	if ($form->isSubmitted() && $form->isValid()) {
158	2		log_info('お届け先登録開始', array($id));
159
160	2		$this->entityManager->persist($CustomerAddress);
161	2		$this->entityManager->flush();
162
163	2		log_info('お届け先登録完了', array($id));
164
165	2		$event = new EventArgs(
166			array(
167	2		'form' => $form,
168	2		'Customer' => $Customer,
169	2		'CustomerAddress' => $CustomerAddress,
170			),
171	2		$request
172			);
173	2		$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_DELIVERY_EDIT_COMPLETE, $event);
174
175	2		$app->addSuccess('mypage.delivery.add.complete');
176
177	2		return $app->redirect($app->url('mypage_delivery'));
178			}
179
180			return [
181	2		'form' => $form->createView(),
182	2		'parentPage' => $parentPage,
183	2		'BaseInfo' => $this->BaseInfo,
184			];
185			}
186
187			/**
			0 ignored issues – show introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Doc comment for parameter "$app" missing Loading history... introduced 2017-02-13 16:13 UTC by Report Bug Copy Issue Report Doc comment for parameter "$request" missing Loading history... introduced 2017-09-25 09:08 UTC by Report Bug Copy Issue Report Doc comment for parameter "$CustomerAddress" missing Loading history...
188			* お届け先を削除する.
189			*
190			* @Method("DELETE")
191			* @Route("/mypage/delivery/{id}/delete", name="mypage_delivery_delete")
192			*/
			0 ignored issues – show introduced 2017-08-29 02:45 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
193	1		public function delete(Application $app, Request $request, CustomerAddress $CustomerAddress)
194			{
195	1		$this->isTokenValid($app);
196
197	1		log_info('お届け先削除開始', array($CustomerAddress->getId()));
198
199	1		$Customer = $app['user'];
200
201	1		if ($Customer->getId() != $CustomerAddress->getCustomer()->getId()) {
202			throw new BadRequestHttpException();
203			}
204
205	1		$this->customerAddressRepository->delete($CustomerAddress);
206
207	1		$event = new EventArgs(
208			array(
			0 ignored issues – show introduced 2016-02-14 23:45 UTC by Report Bug Copy Issue Report Add a comma after each item in a multi-line array Loading history...
209	1		'Customer' => $Customer,
210	1		'CustomerAddress' => $CustomerAddress
211	1		), $request
212			);
213	1		$this->eventDispatcher->dispatch(EccubeEvents::FRONT_MYPAGE_DELIVERY_DELETE_COMPLETE, $event);
214
215	1		$app->addSuccess('mypage.address.delete.complete');
216
217	1		log_info('お届け先削除完了', array($CustomerAddress->getId()));
218
219	1		return $app->redirect($app->url('mypage_delivery'));
220			}
221			}
222

EC-CUBE / ec-cube

Push — experimental/3.1 ( 3d2ede...2919b9 )

DeliveryController::delete() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like