Eccube\Controller\Admin\Content\NewsController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	214
Duplicated Lines	38.32 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

71%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	22	22	1
B	edit()	0	53	6
A	up()	17	17	2
A	down()	17	17	2
B	delete()	26	26	2

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Eccube\Controller\Admin\Content;

use Eccube\Annotation\Component;
use Eccube\Annotation\Inject;
use Eccube\Application;
use Eccube\Common\Constant;
use Eccube\Controller\AbstractController;
use Eccube\Entity\News;
use Eccube\Event\EccubeEvents;
use Eccube\Event\EventArgs;
use Eccube\Form\Type\Admin\NewsType;
use Eccube\Repository\NewsRepository;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\Form\FormFactory;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * 新着情報のコントローラクラス
 *
 * @Component
 * @Route(service=NewsController::class)
 */
class NewsController extends AbstractController
{
    /**
     * @Inject("form.factory")
     * @var FormFactory
     */
    protected $formFactory;

    /**
     * @Inject("eccube.event.dispatcher")
     * @var EventDispatcher
     */
    protected $eventDispatcher;

    /**
     * @Inject(NewsRepository::class)
     * @var NewsRepository
     */
    protected $newsRepository;

    /**

Doc comment for parameter "$request" missing

     * 新着情報一覧を表示する。
     *
     * @Route("/{_admin}/content/news", name="admin_content_news")
     * @Template("Content/news.twig")
     *
     * @param Application $app
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function index(Application $app, Request $request)

The parameter $app is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $NewsList = $this->newsRepository->findBy(array(), array('rank' => 'DESC'));

        $builder = $this->formFactory->createBuilder();

        $event = new EventArgs(
            array(
                'builder' => $builder,
                'NewsList' => $NewsList,
            ),
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CONTENT_NEWS_INDEX_INITIALIZE, $event);

        $form = $builder->getForm();

        return [
            'form' => $form->createView(),
            'NewsList' => $NewsList,
        ];
    }

    /**
     * 新着情報を登録・編集する。
     *
     * @Route("/{_admin}/content/news/new", name="admin_content_news_new")
     * @Route("/{_admin}/content/news/{id}/edit", requirements={"id" = "\d+"}, name="admin_content_news_edit")
     * @Template("Content/news_edit.twig")
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @param null $id

Expected 8 spaces after parameter type; 1 found

     * @return array|\Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function edit(Application $app, Request $request, $id = null)
    {
        if ($id) {
            $News = $this->newsRepository->find($id);
            if (!$News) {
                throw new NotFoundHttpException();
            }
        } else {
            $News = new \Eccube\Entity\News();
        }

        $News->setLinkMethod((bool)$News->getLinkMethod());

As per coding-style, a cast statement should be followed by a single space.

        $builder = $this->formFactory
            ->createBuilder(NewsType::class, $News);

        $event = new EventArgs(
            array(
                'builder' => $builder,
                'News' => $News,
            ),
            $request
        );
        $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CONTENT_NEWS_EDIT_INITIALIZE, $event);

        $form = $builder->getForm();
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            if (!$News->getUrl()) {
                $News->setLinkMethod(Constant::DISABLED);
            }
            $this->newsRepository->save($News);

            $event = new EventArgs(
                array(
                    'form' => $form,
                    'News' => $News,
                ),
                $request
            );
            $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CONTENT_NEWS_EDIT_COMPLETE, $event);

            $app->addSuccess('admin.news.save.complete', 'admin');

            return $app->redirect($app->url('admin_content_news'));
        }

        return [
            'form' => $form->createView(),
            'News' => $News,
        ];
    }

    /**
     * 指定した新着情報の表示順を1つ上げる。
     *
     * @Method("PUT")
     * @Route("/{_admin}/content/news/{id}/up", requirements={"id" = "\d+"}, name="admin_content_news_up")
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @param News $News

Expected 8 spaces after parameter type; 1 found

     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function up(Application $app, Request $request, News $News)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $this->isTokenValid($app);

        try {
            $this->newsRepository->up($News);

            $app->addSuccess('admin.news.up.complete', 'admin');
        } catch (\Exception $e) {

Blank line found at start of control structure

            log_error('新着情報表示順更新エラー', [$News->getId(), $e]);

            $app->addError('admin.news.up.error', 'admin');
        }

        return $app->redirect($app->url('admin_content_news'));
    }

    /**
     * 指定した新着情報の表示順を1つ下げる。
     *
     * @Method("PUT")
     * @Route("/{_admin}/content/news/{id}/down", requirements={"id" = "\d+"}, name="admin_content_news_down")
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @param News $News

Expected 8 spaces after parameter type; 1 found

     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function down(Application $app, Request $request, News $News)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $this->isTokenValid($app);

        try {
            $this->newsRepository->down($News);

            $app->addSuccess('admin.news.down.complete', 'admin');
        } catch (\Exception $e) {

Blank line found at start of control structure

            log_error('新着情報表示順更新エラー', [$News->getId(), $e]);

            $app->addError('admin.news.down.error', 'admin');
        }

        return $app->redirect($app->url('admin_content_news'));
    }

    /**
     * 指定した新着情報を削除する。
     *
     * @Method("DELETE")
     * @Route("/{_admin}/content/news/{id}/delete", requirements={"id" = "\d+"}, name="admin_content_news_delete")
     *
     * @param Application $app
     * @param Request $request

Expected 5 spaces after parameter type; 1 found

     * @param News $News

Expected 8 spaces after parameter type; 1 found

     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function delete(Application $app, Request $request, News $News)

This method seems to be duplicated in your project.

    {
        $this->isTokenValid($app);

        log_info('新着情報削除開始', [$News->getId()]);

        try {
            $this->newsRepository->delete($News);

            $event = new EventArgs(['News' => $News], $request);
            $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_CONTENT_NEWS_DELETE_COMPLETE, $event);

            $app->addSuccess('admin.news.delete.complete', 'admin');

            log_info('新着情報削除完了', [$News->getId()]);

Blank line found at end of control structure

        } catch (\Exception $e) {

Blank line found at start of control structure

            $message = $app->trans('admin.delete.failed.foreign_key', ['%name%' => '新着情報']);
            $app->addError($message, 'admin');

            log_error('新着情報削除エラー', [$News->getId(), $e]);
        }

        return $app->redirect($app->url('admin_content_news'));
    }
}