Eccube\Service\CartService::setCartItemQuantity()

Complexity

Conditions	13
Paths	112

Size

Total Lines	86
Code Lines	43

Duplication

Lines	25
Ratio	29.07 %

Code Coverage

Tests	43
CRAP Score	13.0468

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function setCartItemQuantity($CartItem, $quantity)
    {
        /** @var ProductClass $ProductClass */
        $ProductClass = $CartItem->getObject();

        if (!$this->isProductDisplay($ProductClass)) {
            throw new CartException('cart.product.not.status');
        }

        $productName = $this->getProductName($ProductClass);

        // 商品種別に紐づく配送業者を取得
        $deliveries = $this->app['eccube.repository.delivery']->getDeliveries($ProductClass->getProductType());

        if (count($deliveries) == 0) {

This code seems to be duplicated across your project.

            // 商品種別が存在しなければエラー
            $this->removeProduct($ProductClass->getId());
            $this->addError('cart.product.not.producttype', $productName);
            throw new CartException('cart.product.not.producttype');
        }

        $this->setCanAddProductType($ProductClass->getProductType());

        if ($this->BaseInfo->getOptionMultipleShipping() != Constant::ENABLED) {

This code seems to be duplicated across your project.

            if (!$this->canAddProduct($ProductClass->getId())) {
                // 複数配送対応でなく、かつ商品種別が異なればエラー
                throw new CartException('cart.product.type.kind');
            }
        } else {
            // 複数配送対応で、かつ同一支払方法がなければエラー
            if (!$this->canAddProductPayment($ProductClass->getProductType())) {
                throw new CartException('cart.product.payment.kind');
            }
        }

        $compareService = $this->generateCartCompareService();
        $ExistsCartItem = $compareService->getExistsCartItem($CartItem);
        $subtotal = 0;
        $productClassQuantity = 0;

        foreach ($this->getCartObj()->getCartItems() as $CurrentCartItem) {

Blank line found at start of control structure

            $CurrentProductClass = $CurrentCartItem->getObject();

            // 同じ商品規格IDの数量を集計
            if ($CurrentProductClass->getId() == $ProductClass->getId()) {
                $productClassQuantity += $CurrentCartItem->getQuantity();
            }

            // 小計を集計
            $subtotal += $CurrentCartItem->getTotalPrice();
        }

        // 既存カートの数量と小計を除外
        if ($ExistsCartItem) {
            $subtotal -= $CurrentCartItem->getTotalPrice();

The variable $CurrentCartItem seems to be defined by a foreach iteration on line 305. Are you sure the iterator is never empty, otherwise this variable is not defined?

            $productClassQuantity -= $CurrentCartItem->getQuantity();
        }

        for ($newQuantity = 0; $newQuantity < $quantity; $newQuantity++) {

This code seems to be duplicated across your project.

            // TODO 単価をProductClassではなくCartItemから取得する
            $subtotal += $ProductClass->getPrice02IncTax();
            if ($subtotal > $this->app['config']['max_total_fee']) {
                $this->setError('cart.over.price_limit');
                break;
            }
        }

        // 数量が0の場合、エラー
        if ($newQuantity == 0) {
            throw new CartException('cart.over.price_limit');
        }

        $totalQuantity = $productClassQuantity + $newQuantity;
        // 制限数チェック(在庫不足の場合は、処理の中でカート内商品を削除している)
        $newTotalQuantity = $this->setProductLimit($ProductClass, $productName, $totalQuantity);
        $quantity = min($quantity, $newTotalQuantity - $productClassQuantity);

        // 新しい数量でカート内商品を登録する
        if (0 < $quantity) {
            $CartItem->setQuantity($quantity);
            $this->cart->setCartItem($CartItem, $compareService);
        }

        return $this;
    }