ItemHolderValidator::__toString() - Code Metrics - Inspection of "PurchaseFlow のツリー表示" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 4.0 (#4223)

by Kentaro

created 2019-07-12 03:33 UTC

ItemHolderValidator::__toString() A

↳ Parent: ItemHolderValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	4
loc	4
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved.
 *
 * http://www.ec-cube.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\PurchaseFlow;

use Eccube\Entity\ItemHolderInterface;

/**
 * カート/受注の妥当性検証を行う.
 */
abstract class ItemHolderValidator

{
    use ValidatorTrait;

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext     $context
     *
     * @return ProcessResult
     */
    final public function execute(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        try {
            $this->validate($itemHolder, $context);

            return ProcessResult::success(null, static::class);
        } catch (InvalidItemException $e) {
            return $e->isWarning()
                ? ProcessResult::warn($e->getMessage(), static::class)
                : ProcessResult::error($e->getMessage(), static::class);
        }
    }

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext $context
     *
     * @throws InvalidItemException
     */
    abstract protected function validate(ItemHolderInterface $itemHolder, PurchaseContext $context);

    protected function handle(ItemHolderInterface $itemHolder)

    {
    }

    public function __toString()
    {
        return get_class($this);
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) EC-CUBE CO.,LTD. All Rights Reserved.
7			*
8			* http://www.ec-cube.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Service\PurchaseFlow;
15
16			use Eccube\Entity\ItemHolderInterface;
17
18			/**
19			* カート/受注の妥当性検証を行う.
20			*/
21		View Code Duplication	abstract class ItemHolderValidator
			0 ignored issues – show Duplication introduced 2018-07-05 10:22 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22			{
23			use ValidatorTrait;
24
25			/**
26			* @param ItemHolderInterface $itemHolder
27			* @param PurchaseContext $context
28			*
29			* @return ProcessResult
30			*/
31	274		final public function execute(ItemHolderInterface $itemHolder, PurchaseContext $context)
32			{
33			try {
34	274		$this->validate($itemHolder, $context);
35
36	260		return ProcessResult::success(null, static::class);
37	21		} catch (InvalidItemException $e) {
38	21		return $e->isWarning()
39			? ProcessResult::warn($e->getMessage(), static::class)
40			: ProcessResult::error($e->getMessage(), static::class);
41			}
42			}
43
44			/**
45			* @param ItemHolderInterface $itemHolder
46			* @param PurchaseContext $context
47			*
48			* @throws InvalidItemException
49			*/
50			abstract protected function validate(ItemHolderInterface $itemHolder, PurchaseContext $context);
51
52			protected function handle(ItemHolderInterface $itemHolder)
			0 ignored issues – show Unused Code introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report The parameter `$itemHolder` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
53			{
54			}
55
56			public function __toString()
57			{
58			return get_class($this);
59			}
60			}
61

EC-CUBE / ec-cube

Pull Request — 4.0 (#4223)

ItemHolderValidator::__toString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like