Eccube\Service\Calculator\OrderItemCollection

Complexity

Total Complexity

11

Size/Duplication

Total Lines	83
Duplicated Lines	20.48 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

21.88%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	reduce()	0	4	1
A	getProductClasses()	0	7	1
A	getDeliveryFees()	0	7	1
A	getCharges()	0	7	1
A	getDiscounts()	0	7	1
A	hasProductByName()	9	9	1
A	hasItemByOrderItemType()	8	8	2
A	getType()	0	4	1

<?php

namespace Eccube\Service\Calculator;

use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\ItemInterface;
use Eccube\Entity\Order;

class OrderItemCollection extends \Doctrine\Common\Collections\ArrayCollection

Missing class doc comment

{
    protected $type;

    public function __construct($OrderItems, $type = null)

Missing function doc comment

    {
        // $OrderItems が Collection だったら toArray(); する
        $this->type = is_null($type) ? Order::class : $type;
        parent::__construct($OrderItems);
    }

    public function reduce(\Closure $func, $initial = null)

Missing function doc comment

    {
        return array_reduce($this->toArray(), $func, $initial);
    }

    // 明細種別ごとに返すメソッド作る
    public function getProductClasses()

You must use "/**" style comments for a function comment

    {
        return $this->filter(
            function(ItemInterface $OrderItem) {

Expected 1 space after FUNCTION keyword; 0 found

                return $OrderItem->isProduct();
            });
    }

    public function getDeliveryFees()

Missing function doc comment

    {
        return $this->filter(
            function(ItemInterface $OrderItem) {

Expected 1 space after FUNCTION keyword; 0 found

                return $OrderItem->isDeliveryFee();
            });
    }

    public function getCharges()

Missing function doc comment

    {
        return $this->filter(
            function(ItemInterface $OrderItem) {

Expected 1 space after FUNCTION keyword; 0 found

                return $OrderItem->isCharge();
            });
    }

    public function getDiscounts()

Missing function doc comment

    {
        return $this->filter(
            function(ItemInterface $OrderItem) {

Expected 1 space after FUNCTION keyword; 0 found

                return $OrderItem->isDiscount();
            });
    }

    /**

Doc comment for parameter "$productName" missing

     * 同名の明細が存在するかどうか.
     *
     * TODO 暫定対応. 本来は明細種別でチェックする.
     */

Missing @return tag in function comment

    public function hasProductByName($productName)

This method seems to be duplicated in your project.

    {
        $OrderItems = $this->filter(
            function (ItemInterface $OrderItem) use ($productName) {
                /* @var OrderItem $OrderItem */
                return $OrderItem->getProductName() == $productName;
            });
        return !$OrderItems->isEmpty();

Missing blank line before return statement

    }

    /**
     * 指定した受注明細区分の明細が存在するかどうか
     * @param OrderItemType $OrderItemType 受注区分
     * @return boolean
     */
    public function hasItemByOrderItemType($OrderItemType)

This method seems to be duplicated in your project.

    {
        $filteredItems = $this->filter(function(ItemInterface $OrderItem) use ($OrderItemType) {

Expected 1 space after FUNCTION keyword; 0 found

            /* @var OrderItem $OrderItem */
            return $OrderItem->getOrderItemType() && $OrderItem->getOrderItemType()->getId() == $OrderItemType->getId();
        });
        return !$filteredItems->isEmpty();

Missing blank line before return statement

    }

    public function getType()

Missing function doc comment

    {
        return $this->type;
    }
}