Failed Conditions
Pull Request — experimental/3.1 (#2199)
by chihiro
82:14 queued 75:34
created
src/Eccube/Command/GeneratorCommand/EntityFromDbGenerator.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@
 block discarded – undo
164 164
             $cmf->setEntityManager($em);
165 165
             $metadatas = $cmf->getAllMetadata();
166 166
 
167
-            $filters = array_map(function ($value) {
167
+            $filters = array_map(function($value) {
168 168
                 return ucfirst(Inflector::camelize(str_replace('plg_', '', $value)));
169 169
             }, $tableList);
170 170
             $metadatas = MetadataFilter::filter($metadatas, $filters);
Please login to merge, or discard this patch.
src/Eccube/Application.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -964,7 +964,7 @@
 block discarded – undo
964 964
      * 失敗 : \Doctrine\DBAL\DBALExceptionエラーが発生( 接続に失敗した場合 )、エラー画面を表示しdie()
965 965
      * 備考 : app['debug']がtrueの際は処理を行わない
966 966
      *
967
-     * @return boolean true
967
+     * @return null|boolean true
968 968
      *
969 969
      */
970 970
     protected function checkDatabaseConnection()
Please login to merge, or discard this patch.
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
         $this->register(new \Silex\Provider\ValidatorServiceProvider());
163 163
         $this->register(new MobileDetectServiceProvider());
164 164
 
165
-        $this->error(function (\Exception $e, Request $request, $code) {
165
+        $this->error(function(\Exception $e, Request $request, $code) {
166 166
             if ($this['debug']) {
167 167
                 return;
168 168
             }
@@ -256,14 +256,14 @@  discard block
 block discarded – undo
256 256
             return $router;
257 257
         });
258 258
 
259
-        $this['eccube.router.origin'] = function ($app) {
259
+        $this['eccube.router.origin'] = function($app) {
260 260
             $resource = __DIR__.'/Controller';
261 261
             $cachePrefix = 'Origin';
262 262
 
263 263
             return $app['eccube.router']($resource, $cachePrefix);
264 264
         };
265 265
 
266
-        $this['eccube.routers.plugin'] = function ($app) {
266
+        $this['eccube.routers.plugin'] = function($app) {
267 267
             // TODO 有効なプラグインを対象とする必要がある.
268 268
             $dirs = Finder::create()
269 269
                 ->in($app['config']['root_dir'].'/app/Plugin')
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
             return $routers;
281 281
         };
282 282
 
283
-        $this['eccube.router.extend'] = function ($app) {
283
+        $this['eccube.router.extend'] = function($app) {
284 284
             // TODO ディレクトリ名は暫定
285 285
             $resource = $app['config']['root_dir'].'/app/Acme/Controller';
286 286
             $cachePrefix = 'Extend';
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
             return $router;
291 291
         };
292 292
 
293
-        $this->extend('request_matcher', function ($matcher, $app) {
293
+        $this->extend('request_matcher', function($matcher, $app) {
294 294
             $matchers = [];
295 295
             $matchers[] = $app['eccube.router.extend'];
296 296
             foreach ($app['eccube.routers.plugin'] as $router) {
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
             return new ChainUrlMatcher($matchers, $app['request_context']);
303 303
         });
304 304
 
305
-        $this->extend('url_generator', function ($generator, $app) {
305
+        $this->extend('url_generator', function($generator, $app) {
306 306
             $generators = [];
307 307
             $generators[] = $app['eccube.router.extend'];
308 308
             foreach ($app['eccube.routers.plugin'] as $router) {
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
             'translator.cache_dir' => $this['debug'] ? null : $this['config']['root_dir'].'/app/cache/translator',
334 334
             'locale_fallbacks' => ['ja', 'en'],
335 335
         ));
336
-        $this->extend('translator', function ($translator, \Silex\Application $app) {
336
+        $this->extend('translator', function($translator, \Silex\Application $app) {
337 337
             $translator->addLoader('yaml', new \Symfony\Component\Translation\Loader\YamlFileLoader());
338 338
 
339 339
             $file = __DIR__.'/Resource/locale/validator.'.$app['locale'].'.yml';
@@ -380,14 +380,14 @@  discard block
 block discarded – undo
380 380
         $this->register(new \Silex\Provider\TwigServiceProvider(), array(
381 381
             'twig.form.templates' => array('Form/form_layout.twig'),
382 382
         ));
383
-        $this->extend('twig', function (\Twig_Environment $twig, \Silex\Application $app) {
383
+        $this->extend('twig', function(\Twig_Environment $twig, \Silex\Application $app) {
384 384
             $twig->addExtension(new \Eccube\Twig\Extension\EccubeExtension($app));
385 385
             $twig->addExtension(new \Twig_Extension_StringLoader());
386 386
 
387 387
             return $twig;
388 388
         });
389 389
 
390
-        $this->before(function (Request $request, \Silex\Application $app) {
390
+        $this->before(function(Request $request, \Silex\Application $app) {
391 391
             $app['admin'] = false;
392 392
             $app['front'] = false;
393 393
             $pathinfo = rawurldecode($request->getPathInfo());
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
             // フロント or 管理画面ごとにtwigの探索パスを切り替える.
420 420
             if (!$app->offsetExists('twig')) {
421 421
 
422
-                $app->extend('twig', function (\Twig_Environment $twig, \Silex\Application $app) {
422
+                $app->extend('twig', function(\Twig_Environment $twig, \Silex\Application $app) {
423 423
                         $paths = array();
424 424
 
425 425
                         // 互換性がないのでprofiler とproduction 時のcacheを分離する
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
         }, self::EARLY_EVENT);
467 467
 
468 468
         // twigのグローバル変数を定義.
469
-        $this->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function (\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) {
469
+        $this->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function(\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) {
470 470
             // 未ログイン時にマイページや管理画面以下にアクセスするとSubRequestで実行されるため,
471 471
             // $event->isMasterRequest()ではなく、グローバル変数が初期化済かどうかの判定を行う
472 472
             if (isset($this['twig_global_initialized']) && $this['twig_global_initialized'] === true) {
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
         // メール送信時の文字エンコード指定(デフォルトはUTF-8)
534 534
         if (isset($this['config']['mail']['charset_iso_2022_jp']) && is_bool($this['config']['mail']['charset_iso_2022_jp'])) {
535 535
             if ($this['config']['mail']['charset_iso_2022_jp'] === true) {
536
-                \Swift::init(function () {
536
+                \Swift::init(function() {
537 537
                     \Swift_DependencyContainer::getInstance()
538 538
                         ->register('mime.qpheaderencoder')
539 539
                         ->asAliasOf('mime.base64headerencoder');
@@ -660,7 +660,7 @@  discard block
 block discarded – undo
660 660
                     'EXTRACT' => 'Eccube\Doctrine\ORM\Query\Extract',
661 661
                 ),
662 662
             ));
663
-            $this->extend('orm.em', function (\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
663
+            $this->extend('orm.em', function(\Doctrine\ORM\EntityManager $em, \Silex\Application $app) {
664 664
                 // tax_rule
665 665
                 $taxRuleRepository = $em->getRepository('Eccube\Entity\TaxRule');
666 666
                 $taxRuleRepository->setApplication($app);
@@ -756,31 +756,31 @@  discard block
 block discarded – undo
756 756
             array('^/mypage', 'ROLE_USER', $channel),
757 757
         );
758 758
 
759
-        $this['eccube.password_encoder'] = function ($app) {
759
+        $this['eccube.password_encoder'] = function($app) {
760 760
             return new \Eccube\Security\Core\Encoder\PasswordEncoder($app['config']);
761 761
         };
762
-        $this['security.encoder_factory'] = function ($app) {
762
+        $this['security.encoder_factory'] = function($app) {
763 763
             return new \Symfony\Component\Security\Core\Encoder\EncoderFactory(array(
764 764
                 'Eccube\Entity\Customer' => $app['eccube.password_encoder'],
765 765
                 'Eccube\Entity\Member' => $app['eccube.password_encoder'],
766 766
             ));
767 767
         };
768
-        $this['eccube.event_listner.security'] = function ($app) {
768
+        $this['eccube.event_listner.security'] = function($app) {
769 769
             return new \Eccube\EventListener\SecurityEventListener($app['orm.em']);
770 770
         };
771 771
 
772 772
         // Voterの設定
773
-        $this['authority_voter'] = function ($app) {
773
+        $this['authority_voter'] = function($app) {
774 774
             return new \Eccube\Security\Voter\AuthorityVoter($app);
775 775
         };
776 776
 
777
-        $this->extend('security.voters', function ($voters, \Silex\Application $app) {
777
+        $this->extend('security.voters', function($voters, \Silex\Application $app) {
778 778
             $voters[] = $app['authority_voter'];
779 779
 
780 780
             return $voters;
781 781
         });
782 782
 
783
-        $this['security.access_manager'] = function ($app) {
783
+        $this['security.access_manager'] = function($app) {
784 784
             return new \Symfony\Component\Security\Core\Authorization\AccessDecisionManager($app['security.voters'], 'unanimous');
785 785
         };
786 786
 
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
     {
795 795
         $config = $this['config'];
796 796
         if (isset($config['trusted_proxies_connection_only']) && !empty($config['trusted_proxies_connection_only'])) {
797
-            $this->on(KernelEvents::REQUEST, function (GetResponseEvent $event) use ($config) {
797
+            $this->on(KernelEvents::REQUEST, function(GetResponseEvent $event) use ($config) {
798 798
                 // サブリクエストのREMOTE_ADDRも動的に設定を行う必要があるため、KernelEvents::REQUESTを使用する
799 799
                 Request::setTrustedProxies(array_merge(array($event->getRequest()->server->get('REMOTE_ADDR')), $config['trusted_proxies']));
800 800
             }, self::EARLY_EVENT);
@@ -954,7 +954,7 @@  discard block
 block discarded – undo
954 954
         $app = $this;
955 955
 
956 956
         // Response Event(http cache対応、event実行は一番遅く設定)
957
-        $this->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function (\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
957
+        $this->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function(\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
958 958
 
959 959
             if (!$event->isMasterRequest()) {
960 960
                 return;
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -27,8 +27,6 @@  discard block
 block discarded – undo
27 27
 use Eccube\Application\ApplicationTrait;
28 28
 use Eccube\Common\Constant;
29 29
 use Eccube\Doctrine\DBAL\Types\UTCDateTimeType;
30
-use Eccube\Doctrine\ORM\Mapping\Driver\YamlDriver;
31
-use Eccube\EventListener\TransactionListener;
32 30
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
33 31
 use Eccube\Routing\EccubeRouter;
34 32
 use Eccube\ServiceProvider\MobileDetectServiceProvider;
@@ -39,13 +37,11 @@  discard block
 block discarded – undo
39 37
 use Sergiors\Silex\Provider\TemplatingServiceProvider;
40 38
 use Sergiors\Silex\Routing\ChainUrlGenerator;
41 39
 use Sergiors\Silex\Routing\ChainUrlMatcher;
42
-use Symfony\Component\EventDispatcher\EventDispatcher;
43 40
 use Symfony\Component\Finder\Finder;
44 41
 use Symfony\Component\HttpFoundation\Request;
45 42
 use Symfony\Component\HttpFoundation\Response;
46 43
 use Symfony\Component\HttpKernel\Event\FilterResponseEvent;
47 44
 use Symfony\Component\HttpKernel\Event\GetResponseEvent;
48
-use Symfony\Component\HttpKernel\Event\PostResponseEvent;
49 45
 use Symfony\Component\HttpKernel\KernelEvents;
50 46
 use Symfony\Component\Yaml\Yaml;
51 47
 
Please login to merge, or discard this patch.
src/Eccube/Controller/Install/InstallController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -329,6 +329,9 @@
 block discarded – undo
329 329
         flush();
330 330
     }
331 331
 
332
+    /**
333
+     * @param InstallApplication $app
334
+     */
332 335
     private function checkModules($app)
333 336
     {
334 337
         foreach ($this->required_modules as $module) {
Please login to merge, or discard this patch.
Spacing   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -61,9 +61,9 @@  discard block
 block discarded – undo
61 61
 
62 62
     public function __construct()
63 63
     {
64
-        $this->config_path = __DIR__ . '/../../../../app/config/eccube';
65
-        $this->dist_path = __DIR__ . '/../../Resource/config';
66
-        $this->cache_path = __DIR__ . '/../../../../app/cache';
64
+        $this->config_path = __DIR__.'/../../../../app/config/eccube';
65
+        $this->dist_path = __DIR__.'/../../Resource/config';
66
+        $this->cache_path = __DIR__.'/../../../../app/cache';
67 67
     }
68 68
 
69 69
     private function isValid(Request $request, Form $form)
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 
114 114
         return $app['twig']->render('step1.twig', array(
115 115
                 'form' => $form->createView(),
116
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
116
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
117 117
         ));
118 118
     }
119 119
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 
137 137
         return $app['twig']->render('step2.twig', array(
138 138
                 'protectedDirs' => $protectedDirs,
139
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
139
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
140 140
         ));
141 141
     }
142 142
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 
151 151
         if (empty($sessionData['shop_name'])) {
152 152
 
153
-            $config_file = $this->config_path . '/config.yml';
153
+            $config_file = $this->config_path.'/config.yml';
154 154
             $fs = new Filesystem();
155 155
 
156 156
             if ($fs->exists($config_file)) {
@@ -164,11 +164,11 @@  discard block
 block discarded – undo
164 164
                 }
165 165
 
166 166
                 // セキュリティの設定
167
-                $config_file = $this->config_path . '/path.yml';
167
+                $config_file = $this->config_path.'/path.yml';
168 168
                 $config = Yaml::parse(file_get_contents($config_file));
169 169
                 $sessionData['admin_dir'] = $config['admin_route'];
170 170
 
171
-                $config_file = $this->config_path . '/config.yml';
171
+                $config_file = $this->config_path.'/config.yml';
172 172
                 $config = Yaml::parse(file_get_contents($config_file));
173 173
 
174 174
                 $allowHost = $config['admin_allow_host'];
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
                 // ロードバランサー、プロキシサーバ設定
181 181
                 if (isset($config['trusted_proxies_connection_only'])) {
182
-                    $sessionData['trusted_proxies_connection_only'] = (bool)$config['trusted_proxies_connection_only'];
182
+                    $sessionData['trusted_proxies_connection_only'] = (bool) $config['trusted_proxies_connection_only'];
183 183
                 }
184 184
                 if (isset($config['trusted_proxies'])) {
185 185
                     $trustedProxies = $config['trusted_proxies'];
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
                     }
189 189
                 }
190 190
                 // メール設定
191
-                $config_file = $this->config_path . '/mail.yml';
191
+                $config_file = $this->config_path.'/mail.yml';
192 192
                 $config = Yaml::parse(file_get_contents($config_file));
193 193
                 $mail = $config['mail'];
194 194
                 $sessionData['mail_backend'] = $mail['transport'];
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
 
212 212
         return $app['twig']->render('step3.twig', array(
213 213
                 'form' => $form->createView(),
214
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
214
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
215 215
         ));
216 216
     }
217 217
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
         if (empty($sessionData['database'])) {
228 228
 
229
-            $config_file = $this->config_path . '/database.yml';
229
+            $config_file = $this->config_path.'/database.yml';
230 230
             $fs = new Filesystem();
231 231
 
232 232
             if ($fs->exists($config_file)) {
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 
255 255
         return $app['twig']->render('step4.twig', array(
256 256
                 'form' => $form->createView(),
257
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
257
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
258 258
         ));
259 259
     }
260 260
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
                 $host = $request->getSchemeAndHttpHost();
302 302
                 $basePath = $request->getBasePath();
303 303
                 $params = array(
304
-                    'http_url' => $host . $basePath,
304
+                    'http_url' => $host.$basePath,
305 305
                     'shop_name' => $sessionData['shop_name'],
306 306
                 );
307 307
 
@@ -316,16 +316,16 @@  discard block
 block discarded – undo
316 316
 
317 317
         return $app['twig']->render('step5.twig', array(
318 318
                 'form' => $form->createView(),
319
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
319
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
320 320
         ));
321 321
     }
322 322
 
323 323
     //    インストール完了
324 324
     public function complete(InstallApplication $app, Request $request)
325 325
     {
326
-        $config_yml = $this->config_path . '/config.yml';
326
+        $config_yml = $this->config_path.'/config.yml';
327 327
         $config = Yaml::parse(file_get_contents($config_yml));
328
-        $config_path = $this->config_path . '/path.yml';
328
+        $config_path = $this->config_path.'/path.yml';
329 329
         $path_yml = Yaml::parse(file_get_contents($config_path));
330 330
 
331 331
         $config = array_replace_recursive($path_yml, $config);
@@ -340,11 +340,11 @@  discard block
 block discarded – undo
340 340
         $host = $request->getSchemeAndHttpHost();
341 341
         $basePath = $request->getBasePath();
342 342
 
343
-        $adminUrl = $host . $basePath . '/' . $config['admin_dir'];
343
+        $adminUrl = $host.$basePath.'/'.$config['admin_dir'];
344 344
 
345 345
         return $app['twig']->render('complete.twig', array(
346 346
                 'admin_url' => $adminUrl,
347
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
347
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
348 348
         ));
349 349
     }
350 350
 
@@ -360,12 +360,12 @@  discard block
 block discarded – undo
360 360
     {
361 361
         foreach ($this->required_modules as $module) {
362 362
             if (!extension_loaded($module)) {
363
-                $app->addDanger('[必須] ' . $module . ' 拡張モジュールが有効になっていません。', 'install');
363
+                $app->addDanger('[必須] '.$module.' 拡張モジュールが有効になっていません。', 'install');
364 364
             }
365 365
         }
366 366
 
367 367
         if (!extension_loaded('pdo_mysql') && !extension_loaded('pdo_pgsql')) {
368
-            $app->addDanger('[必須] ' . 'pdo_pgsql又はpdo_mysql 拡張モジュールを有効にしてください。', 'install');
368
+            $app->addDanger('[必須] '.'pdo_pgsql又はpdo_mysql 拡張モジュールを有効にしてください。', 'install');
369 369
         }
370 370
 
371 371
         foreach ($this->recommended_module as $module) {
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
             if (!function_exists('apache_get_modules')) {
394 394
                 $app->addWarning('mod_rewrite が有効になっているか不明です。', 'install');
395 395
             } elseif (!in_array('mod_rewrite', apache_get_modules())) {
396
-                $app->addDanger('[必須] ' . 'mod_rewriteを有効にしてください。', 'install');
396
+                $app->addDanger('[必須] '.'mod_rewriteを有効にしてください。', 'install');
397 397
             }
398 398
         } elseif (isset($_SERVER['SERVER_SOFTWARE']) && strpos('Microsoft-IIS', $_SERVER['SERVER_SOFTWARE']) !== false) {
399 399
             // iis
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
 
405 405
     private function setPDO()
406 406
     {
407
-        $config_file = $this->config_path . '/database.yml';
407
+        $config_file = $this->config_path.'/database.yml';
408 408
         $config = Yaml::parse(file_get_contents($config_file));
409 409
 
410 410
         try {
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     private function getEntityManager()
440 440
     {
441 441
         if (!isset($this->app['orm.em'])) {
442
-            $config_file = $this->config_path . '/database.yml';
442
+            $config_file = $this->config_path.'/database.yml';
443 443
             $database = Yaml::parse(file_get_contents($config_file));
444 444
 
445 445
             $this->app->register(new \Silex\Provider\DoctrineServiceProvider(), array(
@@ -451,8 +451,8 @@  discard block
 block discarded – undo
451 451
                     'type' => 'yml',
452 452
                     'namespace' => 'Eccube\Entity',
453 453
                     'path' => array(
454
-                        __DIR__ . '/../../Resource/doctrine',
455
-                        __DIR__ . '/../../Resource/doctrine/master',
454
+                        __DIR__.'/../../Resource/doctrine',
455
+                        __DIR__.'/../../Resource/doctrine/master',
456 456
                     ),
457 457
                 ),
458 458
                 array(  // TODO 暫定
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
                 }
485 485
             }
486 486
             $this->app->register(new \Dflydev\Provider\DoctrineOrm\DoctrineOrmServiceProvider(), array(
487
-                'orm.proxies_dir' => __DIR__ . '/../../app/cache/doctrine',
487
+                'orm.proxies_dir' => __DIR__.'/../../app/cache/doctrine',
488 488
                 'orm.em.options' => array(
489 489
                     'mappings' => $ormMappings
490 490
                 )
@@ -524,11 +524,11 @@  discard block
 block discarded – undo
524 524
     {
525 525
         $this->resetNatTimer();
526 526
 
527
-        $config_file = $this->config_path . '/database.yml';
527
+        $config_file = $this->config_path.'/database.yml';
528 528
         $database = Yaml::parse(file_get_contents($config_file));
529 529
         $config['database'] = $database['database'];
530 530
 
531
-        $config_file = $this->config_path . '/config.yml';
531
+        $config_file = $this->config_path.'/config.yml';
532 532
         $baseConfig = Yaml::parse(file_get_contents($config_file));
533 533
         $config['config'] = $baseConfig;
534 534
 
@@ -586,11 +586,11 @@  discard block
 block discarded – undo
586 586
     {
587 587
         $this->resetNatTimer();
588 588
 
589
-        $config_file = $this->config_path . '/database.yml';
589
+        $config_file = $this->config_path.'/database.yml';
590 590
         $database = Yaml::parse(file_get_contents($config_file));
591 591
         $config['database'] = $database['database'];
592 592
 
593
-        $config_file = $this->config_path . '/config.yml';
593
+        $config_file = $this->config_path.'/config.yml';
594 594
         $baseConfig = Yaml::parse(file_get_contents($config_file));
595 595
         $config['config'] = $baseConfig;
596 596
 
@@ -653,7 +653,7 @@  discard block
 block discarded – undo
653 653
         $config = new Configuration($app['db']);
654 654
         $config->setMigrationsNamespace('DoctrineMigrations');
655 655
 
656
-        $migrationDir = __DIR__ . '/../../Resource/doctrine/migration';
656
+        $migrationDir = __DIR__.'/../../Resource/doctrine/migration';
657 657
         $config->setMigrationsDirectory($migrationDir);
658 658
         $config->registerMigrationsFromDirectory($migrationDir);
659 659
 
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
     private function getProtectedDirs()
686 686
     {
687 687
         $protectedDirs = array();
688
-        $base = __DIR__ . '/../../../..';
688
+        $base = __DIR__.'/../../../..';
689 689
         $dirs = array(
690 690
             '/html',
691 691
             '/app',
@@ -698,7 +698,7 @@  discard block
 block discarded – undo
698 698
         );
699 699
 
700 700
         foreach ($dirs as $dir) {
701
-            if (!is_writable($base . $dir)) {
701
+            if (!is_writable($base.$dir)) {
702 702
                 $protectedDirs[] = $dir;
703 703
             }
704 704
         }
@@ -709,7 +709,7 @@  discard block
 block discarded – undo
709 709
     private function createConfigYamlFile($data, $auth = true)
710 710
     {
711 711
         $fs = new Filesystem();
712
-        $config_file = $this->config_path . '/config.yml';
712
+        $config_file = $this->config_path.'/config.yml';
713 713
 
714 714
         if ($fs->exists($config_file)) {
715 715
             $config = Yaml::parse(file_get_contents($config_file));
@@ -750,7 +750,7 @@  discard block
 block discarded – undo
750 750
 
751 751
         $fs = new Filesystem();
752 752
         $content = str_replace(
753
-            $target, $replace, file_get_contents($this->dist_path . '/config.yml.dist')
753
+            $target, $replace, file_get_contents($this->dist_path.'/config.yml.dist')
754 754
         );
755 755
         $fs->dumpFile($config_file, $content);
756 756
 
@@ -766,7 +766,7 @@  discard block
 block discarded – undo
766 766
 
767 767
     private function addInstallStatus()
768 768
     {
769
-        $config_file = $this->config_path . '/config.yml';
769
+        $config_file = $this->config_path.'/config.yml';
770 770
         $config = Yaml::parse(file_get_contents($config_file));
771 771
         $config['eccube_install'] = 1;
772 772
         $yml = Yaml::dump($config);
@@ -778,7 +778,7 @@  discard block
 block discarded – undo
778 778
     private function createDatabaseYamlFile($data)
779 779
     {
780 780
         $fs = new Filesystem();
781
-        $config_file = $this->config_path . '/database.yml';
781
+        $config_file = $this->config_path.'/database.yml';
782 782
         if ($fs->exists($config_file)) {
783 783
             $fs->remove($config_file);
784 784
         }
@@ -811,14 +811,14 @@  discard block
 block discarded – undo
811 811
 
812 812
             $fs = new Filesystem();
813 813
             $content = str_replace(
814
-                $target, $replace, file_get_contents($this->dist_path . '/database.yml.dist')
814
+                $target, $replace, file_get_contents($this->dist_path.'/database.yml.dist')
815 815
             );
816 816
         } else {
817 817
             $content = Yaml::dump(
818 818
                     array(
819 819
                         'database' => array(
820 820
                             'driver' => 'pdo_sqlite',
821
-                            'path' => realpath($this->config_path . '/eccube.db')
821
+                            'path' => realpath($this->config_path.'/eccube.db')
822 822
                         )
823 823
                     )
824 824
             );
@@ -831,7 +831,7 @@  discard block
 block discarded – undo
831 831
     private function createMailYamlFile($data)
832 832
     {
833 833
         $fs = new Filesystem();
834
-        $config_file = $this->config_path . '/mail.yml';
834
+        $config_file = $this->config_path.'/mail.yml';
835 835
         if ($fs->exists($config_file)) {
836 836
             $fs->remove($config_file);
837 837
         }
@@ -846,7 +846,7 @@  discard block
 block discarded – undo
846 846
 
847 847
         $fs = new Filesystem();
848 848
         $content = str_replace(
849
-            $target, $replace, file_get_contents($this->dist_path . '/mail.yml.dist')
849
+            $target, $replace, file_get_contents($this->dist_path.'/mail.yml.dist')
850 850
         );
851 851
         $fs->dumpFile($config_file, $content);
852 852
 
@@ -856,7 +856,7 @@  discard block
 block discarded – undo
856 856
     private function createPathYamlFile($data, Request $request)
857 857
     {
858 858
         $fs = new Filesystem();
859
-        $config_file = $this->config_path . '/path.yml';
859
+        $config_file = $this->config_path.'/path.yml';
860 860
         if ($fs->exists($config_file)) {
861 861
             $fs->remove($config_file);
862 862
         }
@@ -864,16 +864,16 @@  discard block
 block discarded – undo
864 864
         $ADMIN_ROUTE = $data['admin_dir'];
865 865
         $TEMPLATE_CODE = 'default';
866 866
         $USER_DATA_ROUTE = 'user_data';
867
-        $ROOT_DIR = realpath(__DIR__ . '/../../../../');
867
+        $ROOT_DIR = realpath(__DIR__.'/../../../../');
868 868
         $ROOT_URLPATH = $request->getBasePath();
869
-        $ROOT_PUBLIC_URLPATH = $ROOT_URLPATH . RELATIVE_PUBLIC_DIR_PATH;
869
+        $ROOT_PUBLIC_URLPATH = $ROOT_URLPATH.RELATIVE_PUBLIC_DIR_PATH;
870 870
 
871 871
         $target = array('${ADMIN_ROUTE}', '${TEMPLATE_CODE}', '${USER_DATA_ROUTE}', '${ROOT_DIR}', '${ROOT_URLPATH}', '${ROOT_PUBLIC_URLPATH}');
872 872
         $replace = array($ADMIN_ROUTE, $TEMPLATE_CODE, $USER_DATA_ROUTE, $ROOT_DIR, $ROOT_URLPATH, $ROOT_PUBLIC_URLPATH);
873 873
 
874 874
         $fs = new Filesystem();
875 875
         $content = str_replace(
876
-            $target, $replace, file_get_contents($this->dist_path . '/path.yml.dist')
876
+            $target, $replace, file_get_contents($this->dist_path.'/path.yml.dist')
877 877
         );
878 878
         $fs->dumpFile($config_file, $content);
879 879
 
@@ -882,7 +882,7 @@  discard block
 block discarded – undo
882 882
 
883 883
     private function sendAppData($params)
884 884
     {
885
-        $config_file = $this->config_path . '/database.yml';
885
+        $config_file = $this->config_path.'/database.yml';
886 886
         $db_config = Yaml::parse(file_get_contents($config_file));
887 887
 
888 888
         $this->setPDO();
@@ -894,7 +894,7 @@  discard block
 block discarded – undo
894 894
         }
895 895
 
896 896
         if ($db_config['database']['driver'] === 'pdo_mysql') {
897
-            $db_ver = 'MySQL:' . $version;
897
+            $db_ver = 'MySQL:'.$version;
898 898
         } else {
899 899
             $db_ver = $version;
900 900
         }
@@ -912,7 +912,7 @@  discard block
 block discarded – undo
912 912
 
913 913
         $header = array(
914 914
             'Content-Type: application/x-www-form-urlencoded',
915
-            'Content-Length: ' . strlen($data),
915
+            'Content-Length: '.strlen($data),
916 916
         );
917 917
         $context = stream_context_create(
918 918
             array(
@@ -939,7 +939,7 @@  discard block
 block discarded – undo
939 939
     public function migration(InstallApplication $app, Request $request)
940 940
     {
941 941
         return $app['twig']->render('migration.twig', array(
942
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
942
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
943 943
         ));
944 944
     }
945 945
 
@@ -968,7 +968,7 @@  discard block
 block discarded – undo
968 968
             return $app['twig']->render('migration_plugin.twig', array(
969 969
                     'Plugins' => $Plugins,
970 970
                     'version' => Constant::VERSION,
971
-                    'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
971
+                    'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
972 972
             ));
973 973
         }
974 974
     }
@@ -991,7 +991,7 @@  discard block
 block discarded – undo
991 991
         \Eccube\Util\Cache::clear($config_app, true);
992 992
 
993 993
         return $app['twig']->render('migration_end.twig', array(
994
-                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',
994
+                'publicPath' => '..'.RELATIVE_PUBLIC_DIR_PATH.'/',
995 995
         ));
996 996
     }
997 997
 }
Please login to merge, or discard this patch.
html/install.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@
 block discarded – undo
27 27
 }
28 28
 
29 29
 //[INFO]index.php,install.phpをEC-CUBEルート直下に移動させる場合は、コメントアウトしている行に置き換える
30
-require __DIR__ . '/../autoload.php';
30
+require __DIR__.'/../autoload.php';
31 31
 //require __DIR__ . '/autoload.php';
32 32
 
33 33
 $app = new Eccube\InstallApplication();
34 34
 $app['debug'] = true;
35
-$app->before(function (\Symfony\Component\HttpFoundation\Request $request, \Silex\Application $app) {
35
+$app->before(function(\Symfony\Component\HttpFoundation\Request $request, \Silex\Application $app) {
36 36
     if (!$request->getSession()->isStarted()) {
37 37
         $request->getSession()->start();
38 38
     }
Please login to merge, or discard this patch.
html/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
 //require __DIR__.'/autoload.php';
28 28
 
29 29
 ini_set('display_errors', 'Off');
30
-error_reporting(E_ALL & ~E_DEPRECATED & ~E_STRICT);
30
+error_reporting(E_ALL&~E_DEPRECATED&~E_STRICT);
31 31
 
32 32
 // see http://silex.sensiolabs.org/doc/web_servers.html#php-5-4
33 33
 $filename = __DIR__.preg_replace('#(\?.*)$#', '', $_SERVER['REQUEST_URI']);
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/CsvImportType.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,8 +53,8 @@
 block discarded – undo
53 53
                 'constraints' => array(
54 54
                     new Assert\NotBlank(array('message' => 'ファイルを選択してください。')),
55 55
                     new Assert\File(array(
56
-                        'maxSize' => $app['config']['csv_size'] . 'M',
57
-                        'maxSizeMessage' => 'CSVファイルは' . $app['config']['csv_size'] . 'M以下でアップロードしてください。',
56
+                        'maxSize' => $app['config']['csv_size'].'M',
57
+                        'maxSizeMessage' => 'CSVファイルは'.$app['config']['csv_size'].'M以下でアップロードしてください。',
58 58
                     )),
59 59
                 ),
60 60
             ));
Please login to merge, or discard this patch.
src/Eccube/Form/Type/AddCartType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -112,7 +112,7 @@
 block discarded – undo
112 112
                 }
113 113
             }
114 114
 
115
-            $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) use ($Product) {
115
+            $builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) use ($Product) {
116 116
                 $data = $event->getData();
117 117
                 $form = $event->getForm();
118 118
                 if (!is_null($Product->getClassName2())) {
Please login to merge, or discard this patch.
src/Eccube/Command/CacheClearCommand.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
 
53 53
         $this->app = $this->getSilexApplication();
54 54
         
55
-        \Eccube\Util\Cache::clear($this->app,$input->getOption('all'));
55
+        \Eccube\Util\Cache::clear($this->app, $input->getOption('all'));
56 56
         $output->writeln(sprintf("%s <info>success</info>", 'cache:clear'));
57 57
 
58 58
     }
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 
25 25
 namespace Eccube\Command;
26 26
 
27
-use Symfony\Component\Console\Input\InputArgument;
28 27
 use Symfony\Component\Console\Input\InputInterface;
29 28
 use Symfony\Component\Console\Input\InputOption;
30 29
 use Symfony\Component\Console\Output\OutputInterface;
Please login to merge, or discard this patch.
src/Eccube/Log/Monolog/Helper/LogHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@
 block discarded – undo
111 111
         $webProcessor = new WebProcessor();
112 112
         $uidProcessor = new UidProcessor(8);
113 113
 
114
-        $FingerCrossedHandler->pushProcessor(function ($record) use ($app, $uidProcessor, $webProcessor) {
114
+        $FingerCrossedHandler->pushProcessor(function($record) use ($app, $uidProcessor, $webProcessor) {
115 115
             // ログフォーマットに出力する値を独自に設定
116 116
 
117 117
             $record['level_name'] = sprintf("%-5s", $record['level_name']);
Please login to merge, or discard this patch.