Eccube\Doctrine\Common\CsvDataFixtures\Loader

Complexity

Total Complexity

11

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
C	loadFromDirectory()	0	43	7
A	loadFromIterator()	0	11	2
A	getFixtures()	0	4	1
A	addFixture()	0	4	1

<?php

namespace Eccube\Doctrine\Common\CsvDataFixtures;

use Doctrine\Common\DataFixtures\FixtureInterface;
use Symfony\Component\Finder\Finder;
use Symfony\Component\Yaml\Yaml;


/**
 * CSVファイルのローダー.
 *
 * @see https://github.com/doctrine/data-fixtures/blob/master/lib/Doctrine/Common/DataFixtures/Loader.php
 */
class Loader
{
    protected $fixtures;

    /**
     * Load fixtures from directory.
     *
     * 同一階層に, Fixture のロード順を定義した definition.yml が必要.
     *
     * @param string $dir
     * @return array fixtures.
     */
    public function loadFromDirectory($dir)
    {
        if (!dir($dir)) {
            throw new \InvalidArgumentException(sprintf('"%s" does not exist', $dir));
        }

        // import順序の定義ファイルを取得.
        $file = $dir.'/definition.yml';
        if (!file_exists($file)) {
            throw new \InvalidArgumentException(sprintf('"%s" does not exist', $file));
        }
        $definition = Yaml::parse(file_get_contents($file));
        $definition = array_flip($definition);

        $finder = Finder::create()
            ->in($dir)
            ->name('*.csv')
            ->sort(
                // 定義ファイルに記載の順にソート.
                function (\SplFileInfo $a, \SplFileInfo $b) use ($definition) {
                    if (!isset($definition[$a->getFilename()])) {
                        throw new \Exception(sprintf('"%s" is undefined in %s', $a->getFilename()));
                    }
                    if (!isset($definition[$b->getFilename()])) {
                        throw new \Exception(sprintf('"%s" is undefined in %s', $b->getFilename()));
                    }

                    $a_rank = $definition[$a->getFilename()];
                    $b_rank = $definition[$b->getFilename()];

                    if ($a_rank < $b_rank) {
                        return -1;
                    } elseif ($a_rank > $b_rank) {
                        return 1;
                    } else {
                        return 0;
                    }
                }
            )
            ->files();

        return $this->loadFromIterator($finder->getIterator());

It seems like $finder->getIterator() targeting Symfony\Component\Finder\Finder::getIterator() can also be of type array<integer,object<Symfony\Component\Finder\SplFileInfo>>; however, Eccube\Doctrine\Common\CsvDataFixtures\Loader::loadFromIterator() does only seem to accept object<Iterator>, maybe add an additional type check?

    }

    /**
     * Load fixtures from Iterator.
     *
     * @param \Iterator $Iterator Iterator of \SplFileInfo 
     * @return array fixtures.
     */
    public function loadFromIterator(\Iterator $Iterator)
    {
        $fixtures = [];
        foreach ($Iterator as $fixture) {
            // TODO $fixture が \SplFileInfo ではない場合の対応
            $CsvFixture = new CsvFixture($fixture->openFile());
            $this->addFixture($CsvFixture);
            $fixtures[] = $CsvFixture;
        }
        return $fixtures;

Missing blank line before return statement

    }

    public function getFixtures()

Missing function doc comment

    {
        return $this->fixtures;
    }

    public function addFixture(FixtureInterface $fixture)

Missing function doc comment

    {
        $this->fixtures[] = $fixture;
    }
}