Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 6 | class ShippingManagePage extends AbstractAdminPageStyleGuide |
||
|
|
|||
| 7 | { |
||
| 8 | public static $検索条件_受注ステータス = ['id' => 'admin_search_shipping_status']; |
||
| 9 | public static $検索結果_メッセージ = '#search_form > div.c-outsideBlock__contents.mb-3 > span'; |
||
| 10 | public static $検索結果_エラーメッセージ = '//*[@id="page_admin_shipping"]/div[1]/div[3]/div[3]/div/div[1]/div/div/div[1]'; |
||
| 11 | public static $詳細検索ボタン = '//*[@id="search_form"]/div[1]/div/div/div[3]/a/span'; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * ShippingListPage constructor. |
||
| 15 | */ |
||
| 16 | public function __construct(\AcceptanceTester $I) |
||
| 20 | |||
| 21 | public static function go(\AcceptanceTester $I) |
||
| 26 | |||
| 27 | public static function at(\AcceptanceTester $I) |
||
| 32 | |||
| 33 | public function 検索($value = '') |
||
| 39 | |||
| 40 | public function 詳細検索設定() |
||
| 47 | |||
| 48 | public function 入力_ご注文者お名前($value) |
||
| 53 | |||
| 54 | public function 入力_ご注文者お名前フリガナ($value) |
||
| 59 | |||
| 60 | View Code Duplication | public function 詳細検索_電話番号($value = '') |
|
| 68 | |||
| 69 | public function 出荷CSVダウンロード実行() |
||
| 74 | |||
| 75 | public function 出荷CSV出力項目設定() |
||
| 80 | |||
| 81 | public function 一覧_編集($rowNum) |
||
| 85 | |||
| 86 | View Code Duplication | public function 一覧_削除() |
|
| 94 | |||
| 95 | public function 一覧_削除キャンセル() |
||
| 101 | |||
| 102 | View Code Duplication | public function 一括発送済み更新() |
|
| 111 | |||
| 112 | View Code Duplication | public function 一括発送済みメール送信() |
|
| 120 | |||
| 121 | public function 一覧_全選択() |
||
| 126 | |||
| 127 | /** |
||
| 128 | * TODO: Should remove this function due to new design does not have other dropdown menu |
||
| 129 | */ |
||
| 130 | private function その他メニュー() |
||
| 134 | |||
| 135 | public function メール一括通知() |
||
| 139 | |||
| 140 | public function 一覧_チェックボックス($rowNum) |
||
| 144 | |||
| 145 | public function 取得_出荷伝票番号($rowNum) |
||
| 149 | |||
| 150 | public function 取得_出荷日($rowNum) |
||
| 154 | } |
||
| 155 |