Completed
Pull Request — experimental/3.1 (#2644)
by k-yamamura
58:57 queued 33:58
created
app/Acme/Controller/RoutingTestController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
      * @Security("has_role('ROLE_ADMIN')")
17 17
      *
18 18
      * @param Application $app
19
-     * @return \Symfony\Component\HttpFoundation\Response
19
+     * @return string
20 20
      */
21 21
     public function testAdmin(Application $app)
22 22
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Acme\Controller;
4 4
 
5 5
 use Eccube\Application;
6
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
7 6
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
9 8
 
Please login to merge, or discard this patch.
app/Acme/Controller/TestController.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,13 +4,10 @@
 block discarded – undo
4 4
 use Eccube\Application;
5 5
 use Symfony\Component\HttpFoundation\Response;
6 6
 use Symfony\Component\HttpFoundation\Request;
7
-use Symfony\Component\HttpFoundation\ParameterBag;
8
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
9 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
10 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
11 9
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
12 10
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
13
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
14 11
 
15 12
 /**
16 13
  * @Route("/test")
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/MasterdataDataType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@
 block discarded – undo
65 65
             ->add('name', TextType::class, array(
66 66
                 'required' => false,
67 67
             ))
68
-        ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($app) {
68
+        ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($app) {
69 69
             $form = $event->getForm();
70 70
             $data = $form->getData();
71 71
             if (strlen($data['id']) && strlen($data['name']) == 0) {
Please login to merge, or discard this patch.
src/Eccube/Command/GeneratorCommand/generatortemplate/ServiceProvider.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         $app->match('/plugin/[lower_code]/hello', 'Plugin\[code]\Controller\[code]Controller::index')->bind('plugin_[code]_hello');
34 34
 
35 35
         // Form
36
-        $app['form.types'] = $app->extend('form.types', function ($types) use ($app) {
36
+        $app['form.types'] = $app->extend('form.types', function($types) use ($app) {
37 37
             $types[] = new [code]ConfigType();
38 38
 
39 39
             return $types;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
         // }
58 58
 
59 59
         // ログファイル設定
60
-        $app['monolog.logger.[lower_code]'] = function ($app) {
60
+        $app['monolog.logger.[lower_code]'] = function($app) {
61 61
 
62 62
             $logger = new $app['monolog.logger.class']('[lower_code]');
63 63
 
Please login to merge, or discard this patch.
src/Eccube/Doctrine/ORM/Query/Extract.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -121,14 +121,14 @@
 block discarded – undo
121 121
                 $sql = sprintf(
122 122
                     "EXTRACT(%s FROM %s %s $op INTERVAL '$second SECONDS')",
123 123
                     $this->field,
124
-                    (string)$this->type,
124
+                    (string) $this->type,
125 125
                     $this->source->dispatch($sqlWalker));
126 126
                 break;
127 127
             default:
128 128
                 $sql = sprintf(
129 129
                     "EXTRACT(%s FROM %s %s $op INTERVAL $second SECOND)",
130 130
                     $this->field,
131
-                    (string)$this->type,
131
+                    (string) $this->type,
132 132
                     $this->source->dispatch($sqlWalker));
133 133
         }
134 134
 
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Common/CsvDataFixtures/CsvFixture.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Doctrine\Common\DataFixtures\FixtureInterface;
6 6
 use Doctrine\Common\Persistence\ObjectManager;
7 7
 use Doctrine\DBAL\Connection;
8
-use Doctrine\DBAL\Schema\Table;
9 8
 
10 9
 /**
11 10
  * CSVファイルを扱うためのフィクスチャ.
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         }
35 35
 
36 36
         // CSV Reader に設定
37
-        $this->file->setFlags(\SplFileObject::READ_CSV | \SplFileObject::READ_AHEAD | \SplFileObject::SKIP_EMPTY |\SplFileObject::DROP_NEW_LINE);
37
+        $this->file->setFlags(\SplFileObject::READ_CSV|\SplFileObject::READ_AHEAD|\SplFileObject::SKIP_EMPTY|\SplFileObject::DROP_NEW_LINE);
38 38
 
39 39
         // ヘッダ行を取得
40 40
         $headers = $this->file->current();
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Common/CsvDataFixtures/Loader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
             ->name('*.csv')
44 44
             ->sort(
45 45
                 // 定義ファイルに記載の順にソート.
46
-                function (\SplFileInfo $a, \SplFileInfo $b) use ($definition) {
46
+                function(\SplFileInfo $a, \SplFileInfo $b) use ($definition) {
47 47
                     if (!isset($definition[$a->getFilename()])) {
48 48
                         throw new \Exception(sprintf('"%s" is undefined in %s', $a->getFilename()));
49 49
                     }
Please login to merge, or discard this patch.
src/Eccube/Plugin/AbstractPluginManager.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,8 +18,8 @@
 block discarded – undo
18 18
         $config->setMigrationsTableName(self::MIGRATION_TABLE_PREFIX.$pluginCode);
19 19
         $migration = new Migration($config);
20 20
         $migration->setNoMigrationException(true);
21
-                                  // null 又は 'last' を渡すと最新バージョンまでマイグレートする
22
-                                  // 0か'first'を渡すと最初に戻る
21
+                                    // null 又は 'last' を渡すと最新バージョンまでマイグレートする
22
+                                    // 0か'first'を渡すと最初に戻る
23 23
         $migration->migrate($version, false); 
24 24
 
25 25
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,12 +9,12 @@
 block discarded – undo
9 9
 
10 10
     CONST MIGRATION_TABLE_PREFIX = 'migration_';
11 11
 
12
-    public function migrationSchema($app,$migrationFilePath,$pluginCode,$version=null)
12
+    public function migrationSchema($app, $migrationFilePath, $pluginCode, $version = null)
13 13
     {
14 14
         $config = new Configuration($app['db']);
15 15
         $config->setMigrationsNamespace('DoctrineMigrations');
16 16
         $config->setMigrationsDirectory($migrationFilePath);
17
-        $config->registerMigrationsFromDirectory($migrationFilePath );
17
+        $config->registerMigrationsFromDirectory($migrationFilePath);
18 18
         $config->setMigrationsTableName(self::MIGRATION_TABLE_PREFIX.$pluginCode);
19 19
         $migration = new Migration($config);
20 20
         $migration->setNoMigrationException(true);
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/EntityEventServiceProvider.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
      * This method should only be used to configure services and parameters.
17 17
      * It should not get services.
18 18
      *
19
-     * @param Container $pimple A container instance
20 19
      */
21 20
     public function register(Container $container)
22 21
     {
Please login to merge, or discard this patch.