Failed Conditions
Pull Request — experimental/3.1 (#2624)
by Kentaro
18:46
created
src/Eccube/Service/Composer/ComposerApiService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@
 block discarded – undo
234 234
 
235 235
     /**
236 236
      * Get mode
237
-     * @return mixed|string
237
+     * @return string
238 238
      */
239 239
     public function getMode()
240 240
     {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerProcessService.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@
 block discarded – undo
269 269
     public function composerVersion()
270 270
     {
271 271
         $this->init();
272
-        $command = $this->pathPHP . ' ' . $this->composerFile . ' -V';
272
+        $command = $this->pathPHP.' '.$this->composerFile.' -V';
273 273
         return exec($command);
274 274
     }
275 275
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@
 block discarded – undo
234 234
 
235 235
     /**
236 236
      * Get mode
237
-     * @return mixed|string
237
+     * @return string
238 238
      */
239 239
     public function getMode()
240 240
     {
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Store/OwnerStoreController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         $packageNames = '';
252 252
         if (!empty($dependents)) {
253 253
             foreach ($dependents as $item) {
254
-                $packageNames .= self::$vendorName . '/' . $item['product_code'] . ' ';
254
+                $packageNames .= self::$vendorName.'/'.$item['product_code'].' ';
255 255
                 $pluginItem = [
256 256
                     "product_code" => $item['product_code'],
257 257
                     "version" => $item['version']
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
                 array_push($dependentModifier, $pluginItem);
260 260
             }
261 261
         }
262
-        $packageNames .= self::$vendorName . '/' . $pluginCode;
262
+        $packageNames .= self::$vendorName.'/'.$pluginCode;
263 263
         $return = $this->composerService->execRequire($packageNames);
264 264
         $data = array(
265 265
             'code' => $pluginCode,
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
             'core_version' => $eccubeVersion,
268 268
             'php_version' => phpversion(),
269 269
             'db_version' => $this->systemService->getDbversion(),
270
-            'os' => php_uname('s') . ' ' . php_uname('r') . ' ' . php_uname('v'),
270
+            'os' => php_uname('s').' '.php_uname('r').' '.php_uname('v'),
271 271
             'host' => $request->getHost(),
272 272
             'web_server' => $request->server->get("SERVER_SOFTWARE"),
273 273
             'composer_version' => $this->composerService->composerVersion(),
@@ -275,13 +275,13 @@  discard block
 block discarded – undo
275 275
             'dependents' => json_encode($dependentModifier)
276 276
         );
277 277
         if ($return) {
278
-            $url = $this->appConfig['package_repo_url'] . '/report';
278
+            $url = $this->appConfig['package_repo_url'].'/report';
279 279
             $this->postRequestApi($url, $data);
280 280
             $app->addSuccess('admin.plugin.install.complete', 'admin');
281 281
 
282 282
             return $app->redirect($app->url('admin_store_plugin'));
283 283
         }
284
-        $url = $this->appConfig['package_repo_url'] . '/report/fail';
284
+        $url = $this->appConfig['package_repo_url'].'/report/fail';
285 285
         $this->postRequestApi($url, $data);
286 286
         $app->addError('admin.plugin.install.fail', 'admin');
287 287
 
Please login to merge, or discard this patch.