EC-CUBE / ec-cube

src/Eccube/Controller/Admin/Setting/System/MasterdataController.php

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
                 $entity = new $entityName();
                 $sortNo = 0;
                 $ids = array_map(
-                    function ($v) {
+                    function($v) {
                         return $v['id'];
                     },
                     $data['data']

src/Eccube/Command/CacheClearCommand.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
 
         $this->app = $this->getSilexApplication();
         
-        \Eccube\Util\CacheUtil::clear($this->app,$input->getOption('all'));
+        \Eccube\Util\CacheUtil::clear($this->app, $input->getOption('all'));
         $output->writeln(sprintf("%s <info>success</info>", 'cache:clear'));
 
     }

src/Eccube/Doctrine/ORM/Mapping/Driver/ReloadSafeAnnotationDriver.php

Spacing +7 added lines, -7 removed lines

@@ -72,7 +72,7 @@ 
         }
 
         foreach ($this->paths as $path) {
-            if ( ! is_dir($path)) {
+            if (!is_dir($path)) {
                 throw MappingException::fileMappingDriversRequireConfiguredDirectoryPath($path);
             }
 
@@ -81,14 +81,14 @@ 
                     new \RecursiveDirectoryIterator($path, \FilesystemIterator::SKIP_DOTS),
                     \RecursiveIteratorIterator::LEAVES_ONLY
                 ),
-                '/^.+' . preg_quote($this->fileExtension) . '$/i',
+                '/^.+'.preg_quote($this->fileExtension).'$/i',
                 \RecursiveRegexIterator::GET_MATCH
             );
 
             foreach ($iterator as $file) {
                 $sourceFile = $file[0];
 
-                if ( ! preg_match('(^phar:)i', $sourceFile)) {
+                if (!preg_match('(^phar:)i', $sourceFile)) {
                     $sourceFile = realpath($sourceFile);
                 }
 
@@ -133,15 +133,15 @@ 
                     $namespaceEndIndex = $tokens->getNextTokenOfKind($namespaceIndex, [';']);
                     $namespace = $tokens->generatePartialCode($tokens->getNextMeaningfulToken($namespaceIndex), $tokens->getPrevMeaningfulToken($namespaceEndIndex));
                     $className = $tokens[$classNameTokenIndex]->getContent();
-                    $fqcn = $namespace . '\\' . $className;
-                    if (class_exists($fqcn) && ! $this->isTransient($fqcn)) {
+                    $fqcn = $namespace.'\\'.$className;
+                    if (class_exists($fqcn) && !$this->isTransient($fqcn)) {
                         if (in_array($sourceFile, $this->newProxyFiles)) {
-                            $newClassName = $className . StringUtil::random(12);
+                            $newClassName = $className.StringUtil::random(12);
                             $tokens[$classNameTokenIndex] = new Token([T_STRING, $newClassName]);
                             $newFilePath = $this->outputDir."${newClassName}.php";
                             file_put_contents($newFilePath, $tokens->generateCode());
                             require_once $newFilePath;
-                            $results[] = $namespace . "\\${newClassName}";
+                            $results[] = $namespace."\\${newClassName}";
                         } else {
                             $results[] = $fqcn;
                         }

src/Eccube/Controller/Admin/Setting/System/SecurityController.php

Spacing +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
                     } else {
                         // httpから変更されたらfalseのまま
                         $config['force_ssl'] = Constant::DISABLED;
-                        $data['force_ssl'] = (bool)Constant::DISABLED;
+                        $data['force_ssl'] = (bool) Constant::DISABLED;
                     }
                 } else {
                     $config['force_ssl'] = Constant::DISABLED;
@@ -138,7 +138,7 @@ 
             if (count($allowHost) > 0) {
                 $form->get('admin_allow_hosts')->setData(StringUtil::convertLineFeed(implode("\n", $allowHost)));
             }
-            $form->get('force_ssl')->setData((bool)$this->appConfig['force_ssl']);
+            $form->get('force_ssl')->setData((bool) $this->appConfig['force_ssl']);
         }
 
         return [

src/Eccube/Service/SchemaService.php

Spacing +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
 
     public function updateSchema($generatedFiles, $proxiesDirectory)
     {
-        $outputDir = sys_get_temp_dir() . '/proxy_' . StringUtil::random(12);
+        $outputDir = sys_get_temp_dir().'/proxy_'.StringUtil::random(12);
         mkdir($outputDir);
 
         try {

src/Eccube/Service/PluginService.php

Spacing +3 added lines, -3 removed lines

@@ -181,7 +181,7 @@ 
     {
         // Proxyのクラスをロードせずにスキーマを更新するために、
         // インストール時には一時的なディレクトリにProxyを生成する
-        $tmpProxyOutputDir = sys_get_temp_dir() . '/proxy_' . StringUtil::random(12);
+        $tmpProxyOutputDir = sys_get_temp_dir().'/proxy_'.StringUtil::random(12);
         @mkdir($tmpProxyOutputDir);
 
         try {
@@ -247,7 +247,7 @@ 
             if (!empty($config_cache)) {
                 $meta = $config_cache;
             } else {
-                $meta = $this->readYml($dir . '/config.yml');
+                $meta = $this->readYml($dir.'/config.yml');
             }
         } catch (\Symfony\Component\Yaml\Exception\ParseException $e) {
             throw new PluginException($e->getMessage(), $e->getCode(), $e);
@@ -856,7 +856,7 @@ 
     {
         $result = array_keys($packages);
         if ($getVersion) {
-            $result = array_map(function ($package, $version) {
+            $result = array_map(function($package, $version) {
                 return $package.':'.$version;
             }, array_keys($packages), array_values($packages));
         }

Doc Comments +23 added lines, -3 removed lines

@@ -115,7 +115,7 @@ 
      *
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
-     * @return mixed
+     * @return boolean
      * @throws PluginException
      * @throws \Exception
      */
@@ -180,6 +180,10 @@ 
     }
 
     // インストール事後処理
+
+    /**
+     * @param integer $source
+     */
     public function postInstall($config, $event, $source)
     {
         // Proxyのクラスをロードせずにスキーマを更新するために、
@@ -226,6 +230,10 @@ 
         }
     }
 
+    /**
+     * @param string $archive
+     * @param string $dir
+     */
     public function unpackPluginArchive($archive, $dir)
     {
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -285,6 +293,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -302,6 +313,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -321,6 +335,9 @@ 
         return $this->appConfig['plugin_realdir'].'/'.$name;
     }
 
+    /**
+     * @param string $d
+     */
     public function createPluginDir($d)
     {
         $b = @mkdir($d);
@@ -378,6 +395,9 @@ 
         return $p;
     }
 
+    /**
+     * @param string $method
+     */
     public function callPluginManagerMethod($meta, $method)
     {
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
@@ -888,7 +908,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -923,7 +943,7 @@ 
      *
      * @param string $pluginVersion
      * @param string $remoteVersion
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use Eccube\Entity\Plugin;
 use Eccube\Entity\PluginEventHandler;
 use Eccube\Exception\PluginException;
-use Eccube\Plugin\ConfigManager;
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
 use Eccube\Repository\PluginEventHandlerRepository;
 use Eccube\Repository\PluginRepository;

src/Eccube/Util/StringUtil.php

Spacing +5 added lines, -5 removed lines

@@ -159,7 +159,7 @@ 
             return $value;
         }
 
-        return rtrim(mb_substr($value, 0, $length, 'UTF-8')) . $end;
+        return rtrim(mb_substr($value, 0, $length, 'UTF-8')).$end;
     }
 
 
@@ -186,18 +186,18 @@ 
         }
         if ($diff->m == 1 || $diff->days > 0) {
             if ($diff->days <= 31) {
-                return $diff->days . '日前';
+                return $diff->days.'日前';
             }
             // return $date->format("Y/m/d H:i");
             return $date->format("Y/m/d");
         }
         if ($diff->h > 0) {
-            return $diff->h . "時間前";
+            return $diff->h."時間前";
         }
         if ($diff->i > 0) {
-            return $diff->i . "分前";
+            return $diff->i."分前";
         }
-        return $diff->s . "秒前";
+        return $diff->s."秒前";
     }
 
     /**

src/Eccube/Form/Type/Shopping/OrderType.php

Spacing +2 added lines, -2 removed lines

@@ -110,7 +110,7 @@ 
         // 支払い方法のプルダウンを生成
         $builder->addEventListener(
             FormEvents::PRE_SET_DATA,
-            function (FormEvent $event) {
+            function(FormEvent $event) {
                 /** @var Order $Order */
                 $Order = $event->getData();
                 if (is_null($Order) || !$Order->getId()) {
@@ -158,7 +158,7 @@ 
         // TODO Calculatorで行うのが適切.
         $builder->addEventListener(
             FormEvents::POST_SUBMIT,
-            function (FormEvent $event) {
+            function(FormEvent $event) {
                 /** @var Order $Order */
                 $Order = $event->getData();
                 // XXX 非会員購入の際, use_point が null で submit される？

src/Eccube/DI/DIServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
 {
     public function register(Container $app)
     {
-        $app['eccube.di'] = function (Container $app) {
+        $app['eccube.di'] = function(Container $app) {
             $di = new DependencyBuilder(
                 $app['eccube.di.generator.dir'],
                 $app['eccube.di.generator.class'],
@@ -37,7 +37,7 @@ 
 
         // XXX これを入れないと EntityEventDispatcher が有効になった時テストがコケる
         if (!$app->offsetExists('eccube.event.dispatcher')) {
-            $app['eccube.event.dispatcher'] = function () use ($app) {
+            $app['eccube.event.dispatcher'] = function() use ($app) {
                 return $app['dispatcher'];
             };
         }