Failed Conditions
Pull Request — experimental/3.1 (#2285)
by Kiyotaka
41:31
created
src/Eccube/Application/ApplicationTrait.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,7 @@  discard block
 block discarded – undo
16 16
 {
17 17
     /**
18 18
      * Application Shortcut Methods
19
+     * @param string $message
19 20
      */
20 21
     public function addSuccess($message, $namespace = 'front')
21 22
     {
@@ -32,6 +33,9 @@  discard block
 block discarded – undo
32 33
         $this['session']->getFlashBag()->add('eccube.' . $namespace . '.danger', $message);
33 34
     }
34 35
 
36
+    /**
37
+     * @param string $message
38
+     */
35 39
     public function addWarning($message, $namespace = 'front')
36 40
     {
37 41
         $this['session']->getFlashBag()->add('eccube.' . $namespace . '.warning', $message);
@@ -42,6 +46,9 @@  discard block
 block discarded – undo
42 46
         $this['session']->getFlashBag()->add('eccube.' . $namespace . '.info', $message);
43 47
     }
44 48
 
49
+    /**
50
+     * @param string $message
51
+     */
45 52
     public function addRequestError($message, $namespace = 'front')
46 53
     {
47 54
         $this['session']->getFlashBag()->set('eccube.' . $namespace . '.request.error', $message);
@@ -58,6 +65,9 @@  discard block
 block discarded – undo
58 65
         $this->addWarning('admin.delete.warning', 'admin');
59 66
     }
60 67
 
68
+    /**
69
+     * @param string $targetPath
70
+     */
61 71
     public function setLoginTargetPath($targetPath, $namespace = null)
62 72
     {
63 73
         if (is_null($namespace)) {
@@ -109,7 +119,7 @@  discard block
 block discarded – undo
109 119
      * @param string $path フォワード先のパス
110 120
      * @param array $requestParameters
111 121
      * @param Response $response
112
-     * @return Application
122
+     * @return ApplicationTrait
113 123
      */
114 124
     public function forwardChain($path, array $requestParameters = [], Response &$response = null)
115 125
     {
Please login to merge, or discard this patch.
app/Acme/Controller/RoutingTestController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
      * @Security("has_role('ROLE_ADMIN')")
17 17
      *
18 18
      * @param Application $app
19
-     * @return \Symfony\Component\HttpFoundation\Response
19
+     * @return string
20 20
      */
21 21
     public function testAdmin(Application $app)
22 22
     {
Please login to merge, or discard this patch.
src/Eccube/Service/CartService.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
     }
232 232
 
233 233
     /**
234
-     * @param  \Eccube\Entity\ProductClass|integer $ProductClass
234
+     * @param  string $ProductClass
235 235
      * @param  integer $quantity
236 236
      * @return \Eccube\Service\CartService
237 237
      * @throws CartException
@@ -645,7 +645,7 @@  discard block
 block discarded – undo
645 645
      * 在庫数と販売制限数ともに個数が超えていれば、少ない方を適用させてメッセージを表示する
646 646
      *
647 647
      * @param ProductClass $ProductClass
648
-     * @param $productName
648
+     * @param string $productName
649 649
      * @param $quantity
650 650
      * @return int チェック後に更新した個数
651 651
      */
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/EntityEventServiceProvider.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
      * This method should only be used to configure services and parameters.
17 17
      * It should not get services.
18 18
      *
19
-     * @param Container $pimple A container instance
20 19
      */
21 20
     public function register(Container $container)
22 21
     {
Please login to merge, or discard this patch.
src/Eccube/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@
 block discarded – undo
32 32
 {
33 33
     protected $trait_proxies_directory;
34 34
 
35
+    /**
36
+     * @param string $dir
37
+     */
35 38
     public function setTraitProxiesDirectory($dir)
36 39
     {
37 40
         $this->trait_proxies_directory = $dir;
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/JoinClause.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * JoinClause constructor.
59
-     * @param $leftJoin
59
+     * @param boolean $leftJoin
60 60
      * @param $join
61 61
      * @param $alias
62 62
      * @param $conditionType
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/OrderByClause.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 
38 38
     /**
39 39
      * OrderByClause constructor.
40
-     * @param $sort
40
+     * @param string $sort
41 41
      * @param string $order
42 42
      */
43 43
     function __construct($sort, $order = 'asc')
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/WhereClause.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@
 block discarded – undo
53 53
         $this->params = $params;
54 54
     }
55 55
 
56
+    /**
57
+     * @param Expr\Comparison $expr
58
+     */
56 59
     private static function newWhereClause($expr, $x, $y)
57 60
     {
58 61
         if ($y) {
Please login to merge, or discard this patch.