Failed Conditions
Pull Request — experimental/3.1 (#2285)
by Kiyotaka
41:31
created

OrderByClause   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 33
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 0
Metric Value
dl 0
loc 33
rs 10
c 0
b 0
f 0
wmc 3
lcom 0
cbo 0

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 5 1
A getSort() 0 4 1
A getOrder() 0 4 1
1
<?php
2
/*
3
 * This file is part of EC-CUBE
4
 *
5
 * Copyright(c) 2000-2017 LOCKON CO.,LTD. All Rights Reserved.
6
 *
7
 * http://www.lockon.co.jp/
8
 *
9
 * This program is free software; you can redistribute it and/or
10
 * modify it under the terms of the GNU General Public License
11
 * as published by the Free Software Foundation; either version 2
12
 * of the License, or (at your option) any later version.
13
 *
14
 * This program is distributed in the hope that it will be useful,
15
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17
 * GNU General Public License for more details.
18
 *
19
 * You should have received a copy of the GNU General Public License
20
 * along with this program; if not, write to the Free Software
21
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
22
 */
23
24
namespace Eccube\Doctrine\Query;
25
26
27
/**
28
 * ORDER BY句を組み立てるクラス。
29
 *
30
 * @package Eccube\Doctrine\Query
31
 */
32
class OrderByClause
33
{
34
35
    private $sort;
36
    private $order;
37
38
    /**
0 ignored issues
show
introduced by
Doc comment for parameter "$sort" missing
Loading history...
39
     * OrderByClause constructor.
40
     * @param $sort
0 ignored issues
show
introduced by
Missing parameter name
Loading history...
41
     * @param string $order
42
     */
43
    function __construct($sort, $order = 'asc')
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
introduced by
No scope modifier specified for function "__construct"
Loading history...
Comprehensibility Best Practice introduced by
It is recommend to declare an explicit visibility for __construct.

Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed.

If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with private, and only raise it to protected if a sub-class needs to have access, or public if an external class needs access.

Loading history...
44
    {
45
        $this->sort = $sort;
46
        $this->order = $order;
47
    }
48
49
    /**
50
     * @return string
51
     */
52
    public function getSort()
53
    {
54
        return $this->sort;
55
    }
56
57
    /**
58
     * @return string
59
     */
60
    public function getOrder()
61
    {
62
        return $this->order;
63
    }
64
}