EccubeBlockExtension::getFunctions() - Code Metrics - Inspection of ".scrutinizser.yml の修正" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/sf (#3236)

by Kentaro

created 2018-08-01 02:06 UTC

EccubeBlockExtension::getFunctions() A

↳ Parent: EccubeBlockExtension

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
nc	1
nop	0
dl	0
loc	17
ccs	9
cts	9
cp	1
crap	3
rs	9.7
c	0
b	0
f	0

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Twig\Extension;

use Twig\Environment;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;

class EccubeBlockExtension extends AbstractExtension
{
    protected $twig;

    protected $blockTemplates;

    public function __construct(Environment $twig, array $blockTemplates)
    {
        $this->twig = $twig;
        $this->blockTemplates = $blockTemplates;
    }

    public function getFunctions()
    {
        return [
            new TwigFunction('eccube_block_*', function ($name, array $parameters = []) {
                $sources = $this->blockTemplates;
                foreach ($sources as $source) {
                    $template = $this->twig->loadTemplate($source);
                    if ($template->hasBlock($name, $parameters)) {
                        echo $template->renderBlock($name, $parameters);

                        return;
                    }
                }
                @trigger_error($name.' block is not found', E_USER_WARNING);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }, ['pre_escape' => 'html', 'is_safe' => ['html']]),
        ];
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\Twig\Extension;
15
16		use Twig\Environment;
17		use Twig\Extension\AbstractExtension;
18		use Twig\TwigFunction;
19
20		class EccubeBlockExtension extends AbstractExtension
21		{
22		protected $twig;
23
24		protected $blockTemplates;
25
26	470	public function __construct(Environment $twig, array $blockTemplates)
27		{
28	470	$this->twig = $twig;
29	470	$this->blockTemplates = $blockTemplates;
30		}
31
32		public function getFunctions()
33		{
34		return [
35	243	new TwigFunction('eccube_block_*', function ($name, array $parameters = []) {
36	47	$sources = $this->blockTemplates;
37	47	foreach ($sources as $source) {
38	2	$template = $this->twig->loadTemplate($source);
39	2	if ($template->hasBlock($name, $parameters)) {
40	2	echo $template->renderBlock($name, $parameters);
41
42	2	return;
43		}
44		}
45	45	@trigger_error($name.' block is not found', E_USER_WARNING);
		0 ignored issues – show Security Best Practice introduced 2018-06-26 06:07 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
46	243	}, ['pre_escape' => 'html', 'is_safe' => ['html']]),
47		];
48		}
49		}
50

EC-CUBE / ec-cube

Pull Request — experimental/sf (#3236)

EccubeBlockExtension::getFunctions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like