OrderHelper - Code Metrics - Inspection of ".scrutinizser.yml の修正" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/sf (#3236)

by Kentaro

created 2018-08-01 02:06 UTC

OrderHelper A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	329
Duplicated Lines	7.29 %

Coupling/Cohesion

Components	1
Dependencies	19

Test Coverage

Coverage

99.22%

Importance

Changes

Metric	Value
dl	24
loc	329
rs	10
c	0
b	0
f	0
ccs	127
cts	128
cp	0.9922
wmc	23
lcom	1
cbo	19

10 Methods

Rating	Name	Duplication	Size	Complexity
A	setDefaultDelivery()	5	20	2
A	__construct()	0	25	1
A	createProcessingOrder()	0	42	4
A	convertToCart()	0	17	2
A	createPreOrderId()	10	16	2
A	setCustomer()	0	16	2
A	createOrderItemsFromCartItems()	0	35	3
A	createShippingFromCustomer()	0	17	1
A	setDefaultPayment()	9	30	4
A	addOrderItems()	0	9	2

How to fix Duplicated Code

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Eccube\Common\EccubeConfig;
use Eccube\Entity\Cart;
use Eccube\Entity\CartItem;
use Eccube\Entity\Customer;
use Eccube\Entity\Master\DeviceType;
use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\Master\OrderStatus;
use Eccube\Entity\Order;
use Eccube\Entity\OrderItem;
use Eccube\Entity\Shipping;
use Eccube\Repository\DeliveryFeeRepository;
use Eccube\Repository\DeliveryRepository;
use Eccube\Repository\Master\DeviceTypeRepository;
use Eccube\Repository\Master\OrderItemTypeRepository;
use Eccube\Repository\Master\OrderStatusRepository;
use Eccube\Repository\OrderRepository;
use Eccube\Repository\PaymentRepository;
use Eccube\Repository\TaxRuleRepository;
use Eccube\Util\StringUtil;

/**
 * OrderやOrderに関連するエンティティを構築するクラス
 * namespaceやクラス名は要検討
 */
class OrderHelper
{
    /**
     * @var OrderItemTypeRepository
     */
    protected $orderItemTypeRepository;

    /**
     * @var OrderStatusRepository
     */
    protected $orderStatusRepository;

    /**
     * @var TaxRuleRepository
     */
    protected $taxRuleRepository;

    /**
     * @var DeliveryFeeRepository
     */
    protected $deliveryFeeRepository;

    /**
     * @var DeliveryRepository
     */
    protected $deliveryRepository;

    /**
     * @var PaymentRepository
     */
    protected $paymentRepository;

    /**
     * @var OrderRepository
     */
    protected $orderRepository;

    /**
     * @var EntityManager
     */
    protected $entityManager;

    /**
     * @var EccubeConfig
     */
    protected $eccubeConfig;

    /**
     * @var \Mobile_Detect
     */
    protected $mobileDetect;

    /**
     * @var DeviceTypeRepository
     */
    protected $deviceTypeRepository;

    /**
     * OrderHelper constructor.
     *
     * @param OrderItemTypeRepository $orderItemTypeRepository
     * @param OrderStatusRepository $orderStatusRepository
     * @param TaxRuleRepository $taxRuleRepository
     * @param DeliveryFeeRepository $deliveryFeeRepository
     * @param DeliveryRepository $deliveryRepository
     * @param PaymentRepository $paymentRepository
     * @param OrderRepository $orderRepository
     * @param EntityManager $entityManager
     * @param EccubeConfig $eccubeConfig
     * @param \Mobile_Detect $mobileDetect
     * @param DeviceTypeRepository $deviceTypeRepository
     */
    public function __construct(
        OrderItemTypeRepository $orderItemTypeRepository,
        OrderStatusRepository $orderStatusRepository,
        TaxRuleRepository $taxRuleRepository,
        DeliveryFeeRepository $deliveryFeeRepository,
        DeliveryRepository $deliveryRepository,
        PaymentRepository $paymentRepository,
        OrderRepository $orderRepository,
        EntityManagerInterface $entityManager,
        EccubeConfig $eccubeConfig,
        \Mobile_Detect $mobileDetect,
        DeviceTypeRepository $deviceTypeRepository
    ) {
        $this->orderItemTypeRepository = $orderItemTypeRepository;
        $this->orderStatusRepository = $orderStatusRepository;
        $this->taxRuleRepository = $taxRuleRepository;
        $this->deliveryFeeRepository = $deliveryFeeRepository;
        $this->deliveryRepository = $deliveryRepository;
        $this->paymentRepository = $paymentRepository;
        $this->orderRepository = $orderRepository;
        $this->entityManager = $entityManager;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->eccubeConfig = $eccubeConfig;
        $this->mobileDetect = $mobileDetect;
        $this->deviceTypeRepository = $deviceTypeRepository;
    }

    /**
     * 購入処理中の受注データを生成する.
     *
     * @param Customer $Customer
     * @param array $CartItems
     *
     * @return Order
     */
    public function createProcessingOrder(Customer $Customer, $CartItems, $preOrderId = null)
    {
        $OrderStatus = $this->orderStatusRepository->find(OrderStatus::PROCESSING);
        $Order = new Order($OrderStatus);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (!$preOrderId) {
            // pre_order_idを生成
            $Order->setPreOrderId($this->createPreOrderId());
        }

        // 顧客情報の設定
        $this->setCustomer($Order, $Customer);

        $DeviceType = $this->deviceTypeRepository->find($this->mobileDetect->isMobile() ? DeviceType::DEVICE_TYPE_SP : DeviceType::DEVICE_TYPE_PC);
        $Order->setDeviceType($DeviceType);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        // 明細情報の設定
        $OrderItems = $this->createOrderItemsFromCartItems($CartItems);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $OrderItemsGroupBySaleType = array_reduce($OrderItems, function ($result, $item) {
            /* @var OrderItem $item */
            $saleTypeId = $item->getProductClass()->getSaleType()->getId();
            $result[$saleTypeId][] = $item;

            return $result;
        }, []);

        foreach ($OrderItemsGroupBySaleType as $OrderItems) {
            $Shipping = $this->createShippingFromCustomer($Customer);
            $Shipping->setOrder($Order);
            $this->addOrderItems($Order, $Shipping, $OrderItems);
            $this->setDefaultDelivery($Shipping);
            $this->entityManager->persist($Shipping);
            $Order->addShipping($Shipping);
        }

        $this->setDefaultPayment($Order);

        $this->entityManager->persist($Order);
        //$this->entityManager->flush();

        return $Order;
    }

    /**
     * OrderをCartに変換します.
     *
     * @param Order $Order
     *
     * @return Cart
     */
    public function convertToCart(Order $Order)
    {
        $Cart = new Cart();
        $Cart->setPreOrderId($Order->getPreOrderId());
        /** @var OrderItem $OrderItem */
        foreach ($Order->getProductOrderItems() as $OrderItem) {
            $CartItem = new CartItem();
            $ProductClass = $OrderItem->getProductClass();
            $this->entityManager->refresh($ProductClass);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $CartItem->setProductClass($ProductClass);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $CartItem->setPrice($OrderItem->getPriceIncTax());
            $CartItem->setQuantity($OrderItem->getQuantity());
            $Cart->addCartItem($CartItem);
        }

        return $Cart;
    }

    private function createPreOrderId()
    {
        // ランダムなpre_order_idを作成
        do {
            $preOrderId = sha1(StringUtil::random(32));

            $Order = $this->orderRepository->findOneBy(
                [
                    'pre_order_id' => $preOrderId,
                    'OrderStatus' => OrderStatus::PROCESSING,
                ]
            );
        } while ($Order);

        return $preOrderId;
    }

    private function setCustomer(Order $Order, Customer $Customer)
    {
        if ($Customer->getId()) {
            $Order->setCustomer($Customer);
        }

        $Order->copyProperties(
            $Customer,
            [
                'id',
                'create_date',
                'update_date',
                'del_flg',
            ]
        );
    }

    /**
     * @param ArrayCollection $CartItems
     *
     * @return OrderItem[]
     */
    private function createOrderItemsFromCartItems($CartItems)
    {
        $ProductItemType = $this->orderItemTypeRepository->find(OrderItemType::PRODUCT);

        return array_map(function ($item) use ($ProductItemType) {
            /* @var $item CartItem */
            /* @var $ProductClass \Eccube\Entity\ProductClass */
            $ProductClass = $item->getProductClass();
            /* @var $Product \Eccube\Entity\Product */
            $Product = $ProductClass->getProduct();

            $OrderItem = new OrderItem();
            $OrderItem
                ->setProduct($Product)
                ->setProductClass($ProductClass)
                ->setProductName($Product->getName())
                ->setProductCode($ProductClass->getCode())
                ->setPrice($ProductClass->getPrice02())
                ->setQuantity($item->getQuantity())
                ->setOrderItemType($ProductItemType);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            $ClassCategory1 = $ProductClass->getClassCategory1();
            if (!is_null($ClassCategory1)) {
                $OrderItem->setClasscategoryName1($ClassCategory1->getName());
                $OrderItem->setClassName1($ClassCategory1->getClassName()->getName());
            }
            $ClassCategory2 = $ProductClass->getClassCategory2();
            if (!is_null($ClassCategory2)) {
                $OrderItem->setClasscategoryName2($ClassCategory2->getName());
                $OrderItem->setClassName2($ClassCategory2->getClassName()->getName());
            }

            return $OrderItem;
        }, $CartItems->toArray());
    }

    private function createShippingFromCustomer(Customer $Customer)
    {
        $Shipping = new Shipping();
        $Shipping
            ->setName01($Customer->getName01())
            ->setName02($Customer->getName02())
            ->setKana01($Customer->getKana01())
            ->setKana02($Customer->getKana02())
            ->setCompanyName($Customer->getCompanyName())
            ->setPhoneNumber($Customer->getPhoneNumber())
            ->setPostalCode($Customer->getPostalCode())
            ->setPref($Customer->getPref())
            ->setAddr01($Customer->getAddr01())
            ->setAddr02($Customer->getAddr02());

        return $Shipping;
    }

    private function setDefaultDelivery(Shipping $Shipping)
    {
        // 配送商品に含まれる販売種別を抽出.
        $OrderItems = $Shipping->getOrderItems();
        $SaleTypes = [];
        /** @var OrderItem $OrderItem */
        foreach ($OrderItems as $OrderItem) {
            $ProductClass = $OrderItem->getProductClass();
            $SaleType = $ProductClass->getSaleType();
            $SaleTypes[$SaleType->getId()] = $SaleType;
        }

        // 販売種別に紐づく配送業者を取得.
        $Deliveries = $this->deliveryRepository->getDeliveries($SaleTypes);

        // 初期の配送業者を設定
        $Delivery = current($Deliveries);
        $Shipping->setDelivery($Delivery);
        $Shipping->setShippingDeliveryName($Delivery->getName());
    }

    private function setDefaultPayment(Order $Order)
    {
        $OrderItems = $Order->getOrderItems();

        // 受注明細に含まれる販売種別を抽出.
        $SaleTypes = [];
        /** @var OrderItem $OrderItem */
        foreach ($OrderItems as $OrderItem) {
            $ProductClass = $OrderItem->getProductClass();
            if (is_null($ProductClass)) {
                // 商品明細のみ対象とする. 送料明細等はスキップする.
                continue;
            }
            $SaleType = $ProductClass->getSaleType();
            $SaleTypes[$SaleType->getId()] = $SaleType;
        }

        // 販売種別に紐づく配送業者を抽出
        $Deliveries = $this->deliveryRepository->getDeliveries($SaleTypes);

        // 利用可能な支払い方法を抽出.
        $Payments = $this->paymentRepository->findAllowedPayments($Deliveries, true);

        // 初期の支払い方法を設定.
        $Payment = current($Payments);
        if ($Payment) {
            $Order->setPayment($Payment);
            $Order->setPaymentMethod($Payment->getMethod());
        }
    }

    private function addOrderItems(Order $Order, Shipping $Shipping, array $OrderItems)
    {
        foreach ($OrderItems as $OrderItem) {
            $Shipping->addOrderItem($OrderItem);
            $Order->addOrderItem($OrderItem);
            $OrderItem->setOrder($Order);
            $OrderItem->setShipping($Shipping);
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of EC-CUBE
5			*
6			* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7			*
8			* http://www.lockon.co.jp/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Eccube\Service;
15
16			use Doctrine\Common\Collections\ArrayCollection;
17			use Doctrine\ORM\EntityManager;
18			use Doctrine\ORM\EntityManagerInterface;
19			use Eccube\Common\EccubeConfig;
20			use Eccube\Entity\Cart;
21			use Eccube\Entity\CartItem;
22			use Eccube\Entity\Customer;
23			use Eccube\Entity\Master\DeviceType;
24			use Eccube\Entity\Master\OrderItemType;
25			use Eccube\Entity\Master\OrderStatus;
26			use Eccube\Entity\Order;
27			use Eccube\Entity\OrderItem;
28			use Eccube\Entity\Shipping;
29			use Eccube\Repository\DeliveryFeeRepository;
30			use Eccube\Repository\DeliveryRepository;
31			use Eccube\Repository\Master\DeviceTypeRepository;
32			use Eccube\Repository\Master\OrderItemTypeRepository;
33			use Eccube\Repository\Master\OrderStatusRepository;
34			use Eccube\Repository\OrderRepository;
35			use Eccube\Repository\PaymentRepository;
36			use Eccube\Repository\TaxRuleRepository;
37			use Eccube\Util\StringUtil;
38
39			/**
40			* OrderやOrderに関連するエンティティを構築するクラス
41			* namespaceやクラス名は要検討
42			*/
43			class OrderHelper
44			{
45			/**
46			* @var OrderItemTypeRepository
47			*/
48			protected $orderItemTypeRepository;
49
50			/**
51			* @var OrderStatusRepository
52			*/
53			protected $orderStatusRepository;
54
55			/**
56			* @var TaxRuleRepository
57			*/
58			protected $taxRuleRepository;
59
60			/**
61			* @var DeliveryFeeRepository
62			*/
63			protected $deliveryFeeRepository;
64
65			/**
66			* @var DeliveryRepository
67			*/
68			protected $deliveryRepository;
69
70			/**
71			* @var PaymentRepository
72			*/
73			protected $paymentRepository;
74
75			/**
76			* @var OrderRepository
77			*/
78			protected $orderRepository;
79
80			/**
81			* @var EntityManager
82			*/
83			protected $entityManager;
84
85			/**
86			* @var EccubeConfig
87			*/
88			protected $eccubeConfig;
89
90			/**
91			* @var \Mobile_Detect
92			*/
93			protected $mobileDetect;
94
95			/**
96			* @var DeviceTypeRepository
97			*/
98			protected $deviceTypeRepository;
99
100			/**
101			* OrderHelper constructor.
102			*
103			* @param OrderItemTypeRepository $orderItemTypeRepository
104			* @param OrderStatusRepository $orderStatusRepository
105			* @param TaxRuleRepository $taxRuleRepository
106			* @param DeliveryFeeRepository $deliveryFeeRepository
107			* @param DeliveryRepository $deliveryRepository
108			* @param PaymentRepository $paymentRepository
109			* @param OrderRepository $orderRepository
110			* @param EntityManager $entityManager
111			* @param EccubeConfig $eccubeConfig
112			* @param \Mobile_Detect $mobileDetect
113			* @param DeviceTypeRepository $deviceTypeRepository
114			*/
115	175		public function __construct(
116			OrderItemTypeRepository $orderItemTypeRepository,
117			OrderStatusRepository $orderStatusRepository,
118			TaxRuleRepository $taxRuleRepository,
119			DeliveryFeeRepository $deliveryFeeRepository,
120			DeliveryRepository $deliveryRepository,
121			PaymentRepository $paymentRepository,
122			OrderRepository $orderRepository,
123			EntityManagerInterface $entityManager,
124			EccubeConfig $eccubeConfig,
125			\Mobile_Detect $mobileDetect,
126			DeviceTypeRepository $deviceTypeRepository
127			) {
128	175		$this->orderItemTypeRepository = $orderItemTypeRepository;
129	175		$this->orderStatusRepository = $orderStatusRepository;
130	175		$this->taxRuleRepository = $taxRuleRepository;
131	175		$this->deliveryFeeRepository = $deliveryFeeRepository;
132	175		$this->deliveryRepository = $deliveryRepository;
133	175		$this->paymentRepository = $paymentRepository;
134	175		$this->orderRepository = $orderRepository;
135	175		$this->entityManager = $entityManager;
			0 ignored issues – show Documentation Bug introduced 2018-06-08 04:37 UTC by Report Bug Copy Issue Report `$entityManager` is of type `object<Doctrine\ORM\EntityManagerInterface>`, but the property `$entityManager` was declared to be of type `object<Doctrine\ORM\EntityManager>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
136	175		$this->eccubeConfig = $eccubeConfig;
137	175		$this->mobileDetect = $mobileDetect;
138	175		$this->deviceTypeRepository = $deviceTypeRepository;
139			}
140
141			/**
142			* 購入処理中の受注データを生成する.
143			*
144			* @param Customer $Customer
145			* @param array $CartItems
146			*
147			* @return Order
148			*/
149	51		public function createProcessingOrder(Customer $Customer, $CartItems, $preOrderId = null)
150			{
151	51		$OrderStatus = $this->orderStatusRepository->find(OrderStatus::PROCESSING);
152	51		$Order = new Order($OrderStatus);
			0 ignored issues – show Bug introduced 2018-06-26 09:41 UTC by Report Bug Copy Issue Report It seems like `$OrderStatus` defined by `$this->orderStatusReposi...rderStatus::PROCESSING)` on line `151` can also be of type `object`; however, `Eccube\Entity\Order::__construct()` does only seem to accept `null\|object<Eccube\Entity\Master\OrderStatus>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
153
154	51		if (!$preOrderId) {
155			// pre_order_idを生成
156	51		$Order->setPreOrderId($this->createPreOrderId());
157			}
158
159			// 顧客情報の設定
160	51		$this->setCustomer($Order, $Customer);
161
162	51		$DeviceType = $this->deviceTypeRepository->find($this->mobileDetect->isMobile() ? DeviceType::DEVICE_TYPE_SP : DeviceType::DEVICE_TYPE_PC);
163	51		$Order->setDeviceType($DeviceType);
			0 ignored issues – show Bug introduced 2018-07-20 11:09 UTC by Report Bug Copy Issue Report It seems like `$DeviceType` defined by `$this->deviceTypeReposit...ceType::DEVICE_TYPE_PC)` on line `162` can also be of type `object`; however, `Eccube\Entity\Order::setDeviceType()` does only seem to accept `null\|object<Eccube\Entity\Master\DeviceType>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
164
165			// 明細情報の設定
166	51		$OrderItems = $this->createOrderItemsFromCartItems($CartItems);
			0 ignored issues – show Documentation introduced 2017-09-26 09:59 UTC by Report Bug Copy Issue Report `$CartItems` is of type `array`, but the function expects a `object<Doctrine\Common\C...ctions\ArrayCollection>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
167	51		$OrderItemsGroupBySaleType = array_reduce($OrderItems, function ($result, $item) {
168			/* @var OrderItem $item */
169	51		$saleTypeId = $item->getProductClass()->getSaleType()->getId();
170	51		$result[$saleTypeId][] = $item;
171
172	51		return $result;
173	51		}, []);
174
175	51		foreach ($OrderItemsGroupBySaleType as $OrderItems) {
176	51		$Shipping = $this->createShippingFromCustomer($Customer);
177	51		$Shipping->setOrder($Order);
178	51		$this->addOrderItems($Order, $Shipping, $OrderItems);
179	51		$this->setDefaultDelivery($Shipping);
180	51		$this->entityManager->persist($Shipping);
181	51		$Order->addShipping($Shipping);
182			}
183
184	51		$this->setDefaultPayment($Order);
185
186	51		$this->entityManager->persist($Order);
187			//$this->entityManager->flush();
188
189	51		return $Order;
190			}
191
192			/**
193			* OrderをCartに変換します.
194			*
195			* @param Order $Order
196			*
197			* @return Cart
198			*/
199	2		public function convertToCart(Order $Order)
200			{
201	2		$Cart = new Cart();
202	2		$Cart->setPreOrderId($Order->getPreOrderId());
203			/** @var OrderItem $OrderItem */
204	2		foreach ($Order->getProductOrderItems() as $OrderItem) {
205	1		$CartItem = new CartItem();
206	1		$ProductClass = $OrderItem->getProductClass();
207	1		$this->entityManager->refresh($ProductClass);
			0 ignored issues – show Bug introduced 2018-06-26 09:41 UTC by Report Bug Copy Issue Report It seems like `$ProductClass` defined by `$OrderItem->getProductClass()` on line `206` can be `null`; however, `Doctrine\ORM\EntityManager::refresh()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
208	1		$CartItem->setProductClass($ProductClass);
			0 ignored issues – show Bug introduced 2018-06-26 09:41 UTC by Report Bug Copy Issue Report It seems like `$ProductClass` defined by `$OrderItem->getProductClass()` on line `206` can be `null`; however, `Eccube\Entity\CartItem::setProductClass()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
209	1		$CartItem->setPrice($OrderItem->getPriceIncTax());
210	1		$CartItem->setQuantity($OrderItem->getQuantity());
211	1		$Cart->addCartItem($CartItem);
212			}
213
214	2		return $Cart;
215			}
216
217	51		private function createPreOrderId()
218			{
219			// ランダムなpre_order_idを作成
220		View Code Duplication	do {
221	51		$preOrderId = sha1(StringUtil::random(32));
222
223	51		$Order = $this->orderRepository->findOneBy(
224			[
225	51		'pre_order_id' => $preOrderId,
226			'OrderStatus' => OrderStatus::PROCESSING,
227			]
228			);
229	51		} while ($Order);
230
231	51		return $preOrderId;
232			}
233
234	51		private function setCustomer(Order $Order, Customer $Customer)
235			{
236	51		if ($Customer->getId()) {
237	34		$Order->setCustomer($Customer);
238			}
239
240	51		$Order->copyProperties(
241	51		$Customer,
242			[
243	51		'id',
244			'create_date',
245			'update_date',
246			'del_flg',
247			]
248			);
249			}
250
251			/**
252			* @param ArrayCollection $CartItems
253			*
254			* @return OrderItem[]
255			*/
256	51		private function createOrderItemsFromCartItems($CartItems)
257			{
258	51		$ProductItemType = $this->orderItemTypeRepository->find(OrderItemType::PRODUCT);
259
260	51		return array_map(function ($item) use ($ProductItemType) {
261			/* @var $item CartItem */
262			/* @var $ProductClass \Eccube\Entity\ProductClass */
263	51		$ProductClass = $item->getProductClass();
264			/* @var $Product \Eccube\Entity\Product */
265	51		$Product = $ProductClass->getProduct();
266
267	51		$OrderItem = new OrderItem();
268			$OrderItem
269	51		->setProduct($Product)
270	51		->setProductClass($ProductClass)
271	51		->setProductName($Product->getName())
272	51		->setProductCode($ProductClass->getCode())
273	51		->setPrice($ProductClass->getPrice02())
274	51		->setQuantity($item->getQuantity())
275	51		->setOrderItemType($ProductItemType);
			0 ignored issues – show Bug introduced 2018-06-26 09:41 UTC by Report Bug Copy Issue Report It seems like `$ProductItemType` defined by `$this->orderItemTypeRepo...OrderItemType::PRODUCT)` on line `258` can also be of type `object`; however, `Eccube\Entity\OrderItem::setOrderItemType()` does only seem to accept `null\|object<Eccube\Entity\Master\OrderItemType>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
276
277	51		$ClassCategory1 = $ProductClass->getClassCategory1();
278	51		if (!is_null($ClassCategory1)) {
279	51		$OrderItem->setClasscategoryName1($ClassCategory1->getName());
280	51		$OrderItem->setClassName1($ClassCategory1->getClassName()->getName());
281			}
282	51		$ClassCategory2 = $ProductClass->getClassCategory2();
283	51		if (!is_null($ClassCategory2)) {
284	42		$OrderItem->setClasscategoryName2($ClassCategory2->getName());
285	42		$OrderItem->setClassName2($ClassCategory2->getClassName()->getName());
286			}
287
288	51		return $OrderItem;
289	51		}, $CartItems->toArray());
290			}
291
292	51		private function createShippingFromCustomer(Customer $Customer)
293			{
294	51		$Shipping = new Shipping();
295			$Shipping
296	51		->setName01($Customer->getName01())
297	51		->setName02($Customer->getName02())
298	51		->setKana01($Customer->getKana01())
299	51		->setKana02($Customer->getKana02())
300	51		->setCompanyName($Customer->getCompanyName())
301	51		->setPhoneNumber($Customer->getPhoneNumber())
302	51		->setPostalCode($Customer->getPostalCode())
303	51		->setPref($Customer->getPref())
304	51		->setAddr01($Customer->getAddr01())
305	51		->setAddr02($Customer->getAddr02());
306
307	51		return $Shipping;
308			}
309
310	51		private function setDefaultDelivery(Shipping $Shipping)
311			{
312			// 配送商品に含まれる販売種別を抽出.
313	51		$OrderItems = $Shipping->getOrderItems();
314	51		$SaleTypes = [];
315			/** @var OrderItem $OrderItem */
316	51	View Code Duplication	foreach ($OrderItems as $OrderItem) {
317	51		$ProductClass = $OrderItem->getProductClass();
318	51		$SaleType = $ProductClass->getSaleType();
319	51		$SaleTypes[$SaleType->getId()] = $SaleType;
320			}
321
322			// 販売種別に紐づく配送業者を取得.
323	51		$Deliveries = $this->deliveryRepository->getDeliveries($SaleTypes);
324
325			// 初期の配送業者を設定
326	51		$Delivery = current($Deliveries);
327	51		$Shipping->setDelivery($Delivery);
328	51		$Shipping->setShippingDeliveryName($Delivery->getName());
329			}
330
331	51		private function setDefaultPayment(Order $Order)
332			{
333	51		$OrderItems = $Order->getOrderItems();
334
335			// 受注明細に含まれる販売種別を抽出.
336	51		$SaleTypes = [];
337			/** @var OrderItem $OrderItem */
338	51	View Code Duplication	foreach ($OrderItems as $OrderItem) {
339	51		$ProductClass = $OrderItem->getProductClass();
340	51		if (is_null($ProductClass)) {
341			// 商品明細のみ対象とする. 送料明細等はスキップする.
342			continue;
343			}
344	51		$SaleType = $ProductClass->getSaleType();
345	51		$SaleTypes[$SaleType->getId()] = $SaleType;
346			}
347
348			// 販売種別に紐づく配送業者を抽出
349	51		$Deliveries = $this->deliveryRepository->getDeliveries($SaleTypes);
350
351			// 利用可能な支払い方法を抽出.
352	51		$Payments = $this->paymentRepository->findAllowedPayments($Deliveries, true);
353
354			// 初期の支払い方法を設定.
355	51		$Payment = current($Payments);
356	51		if ($Payment) {
357	51		$Order->setPayment($Payment);
358	51		$Order->setPaymentMethod($Payment->getMethod());
359			}
360			}
361
362	51		private function addOrderItems(Order $Order, Shipping $Shipping, array $OrderItems)
363			{
364	51		foreach ($OrderItems as $OrderItem) {
365	51		$Shipping->addOrderItem($OrderItem);
366	51		$Order->addOrderItem($OrderItem);
367	51		$OrderItem->setOrder($Order);
368	51		$OrderItem->setShipping($Shipping);
369			}
370			}
371			}
372

EC-CUBE / ec-cube

Pull Request — experimental/sf (#3236)

OrderHelper A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like