EC-CUBE / ec-cube

src/Eccube/Service/Calculator/Strategy/ChargeStrategy.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Eccube\Entity\Order;
 use Eccube\Entity\PurchaseInterface;
 use Eccube\Entity\ShipmentItem;
-use Eccube\Entity\Shipping;
 use Eccube\Repository\Master\OrderItemTypeRepository;
 use Eccube\Service\Calculator\ShipmentItemCollection;
 

src/Eccube/Service/Calculator/ShipmentItemCollection.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
     public function hasProductByName($productName)
     {
         $ShipmentItems = $this->filter(
-            function (ItemInterface $ShipmentItem) use ($productName) {
+            function(ItemInterface $ShipmentItem) use ($productName) {
                 /* @var ShipmentItem $ShipmentItem */
                 return $ShipmentItem->getProductName() == $productName;
             });

src/Eccube/Service/Calculator/Strategy/CalculateDeliveryFeeStrategy.php

Unused Use Statements -4 removed lines

@@ -2,13 +2,9 @@
 namespace Eccube\Service\Calculator\Strategy;
 
 use Eccube\Application;
-use Eccube\Entity\Master\OrderItemType;
-use Eccube\Entity\Master\TaxType;
-use Eccube\Entity\Master\TaxDisplayType;
 use Eccube\Entity\Order;
 use Eccube\Entity\PurchaseInterface;
 use Eccube\Entity\ShipmentItem;
-use Eccube\Entity\Shipping;
 use Eccube\Repository\Master\OrderItemTypeRepository;
 use Eccube\Service\Calculator\ShipmentItemCollection;
 

app/Plugin/PurchaseProcessors/ServiceProvider/PurchaseProcessorsServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
     {
         $app->extend(
             'eccube.purchase.flow.cart.item_processors',
-            function (ArrayCollection $processors, Container $app) {
+            function(ArrayCollection $processors, Container $app) {
                 $processors[] = new EmptyProcessor();
                 $processors[] = new ValidatableEmptyProcessor();
                 return $processors;

app/Plugin/FormExtension/ServiceProvider/FormExtensionServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     {
         $app->extend(
             'form.type.extensions',
-            function ($extensions) {
+            function($extensions) {
                 $extensions[] = new EntryTypeExtension();
 
                 return $extensions;

src/Eccube/Service/PurchaseFlow/PurchaseFlow.php

Spacing +6 added lines, -6 removed lines

@@ -104,7 +104,7 @@ 
      */
     protected function calculateTotal(ItemHolderInterface $itemHolder)
     {
-        $total = $itemHolder->getItems()->reduce(function ($sum, ItemInterface $item) {
+        $total = $itemHolder->getItems()->reduce(function($sum, ItemInterface $item) {
             $sum += $item->getPriceIncTax() * $item->getQuantity();
 
             return $sum;
@@ -121,7 +121,7 @@ 
     {
         $total = $itemHolder->getItems()
             ->getProductClasses()
-            ->reduce(function ($sum, ItemInterface $item) {
+            ->reduce(function($sum, ItemInterface $item) {
                 $sum += $item->getPriceIncTax() * $item->getQuantity();
 
                 return $sum;
@@ -140,7 +140,7 @@ 
     {
         $total = $itemHolder->getItems()
             ->getDeliveryFees()
-            ->reduce(function ($sum, ItemInterface $item) {
+            ->reduce(function($sum, ItemInterface $item) {
                 $sum += $item->getPriceIncTax() * $item->getQuantity();
 
                 return $sum;
@@ -155,7 +155,7 @@ 
     {
         $total = $itemHolder->getItems()
             ->getDiscounts()
-            ->reduce(function ($sum, ItemInterface $item) {
+            ->reduce(function($sum, ItemInterface $item) {
                 $sum += $item->getPriceIncTax() * $item->getQuantity();
 
                 return $sum;
@@ -171,7 +171,7 @@ 
     {
         $total = $itemHolder->getItems()
             ->getCharges()
-            ->reduce(function ($sum, ItemInterface $item) {
+            ->reduce(function($sum, ItemInterface $item) {
                 $sum += $item->getPriceIncTax() * $item->getQuantity();
 
                 return $sum;
@@ -185,7 +185,7 @@ 
     protected function calculateTax(ItemHolderInterface $itemHolder)
     {
         $total = $itemHolder->getItems()
-            ->reduce(function ($sum, ItemInterface $item) {
+            ->reduce(function($sum, ItemInterface $item) {
                 $sum += ($item->getPriceIncTax() - $item->getPrice()) * $item->getQuantity();
 
                 return $sum;

src/Eccube/Service/PurchaseFlow/ItemCollection.php

Spacing +7 added lines, -7 removed lines

@@ -31,7 +31,7 @@ 
     public function getProductClasses()
     {
         return $this->filter(
-            function (ItemInterface $ShipmentItem) {
+            function(ItemInterface $ShipmentItem) {
                 return $ShipmentItem->isProduct();
             });
     }
@@ -39,7 +39,7 @@ 
     public function getDeliveryFees()
     {
         return $this->filter(
-            function (ItemInterface $ShipmentItem) {
+            function(ItemInterface $ShipmentItem) {
                 return $ShipmentItem->isDeliveryFee();
             });
     }
@@ -47,7 +47,7 @@ 
     public function getCharges()
     {
         return $this->filter(
-            function (ItemInterface $ShipmentItem) {
+            function(ItemInterface $ShipmentItem) {
                 return $ShipmentItem->isCharge();
             });
     }
@@ -55,7 +55,7 @@ 
     public function getDiscounts()
     {
         return $this->filter(
-            function (ItemInterface $ShipmentItem) {
+            function(ItemInterface $ShipmentItem) {
                 return $ShipmentItem->isDiscount();
             });
     }
@@ -68,7 +68,7 @@ 
     public function hasProductByName($productName)
     {
         $ShipmentItems = $this->filter(
-            function (ItemInterface $ShipmentItem) use ($productName) {
+            function(ItemInterface $ShipmentItem) use ($productName) {
                 /* @var ShipmentItem $ShipmentItem */
                 return $ShipmentItem->getProductName() == $productName;
             });
@@ -85,7 +85,7 @@ 
      */
     public function hasItemByOrderItemType($OrderItemType)
     {
-        $filteredItems = $this->filter(function (ItemInterface $ShipmentItem) use ($OrderItemType) {
+        $filteredItems = $this->filter(function(ItemInterface $ShipmentItem) use ($OrderItemType) {
             /* @var ShipmentItem $ShipmentItem */
             return $ShipmentItem->getOrderItemType() && $ShipmentItem->getOrderItemType()->getId() == $OrderItemType->getId();
         });
@@ -101,7 +101,7 @@ 
     public function sort()
     {
         $Items = $this->toArray();
-        usort($Items, function (ItemInterface $a, ItemInterface $b) {
+        usort($Items, function(ItemInterface $a, ItemInterface $b) {
             if ($a->getOrderItemType() === $b->getOrderItemType()) {
                 return ($a->getId() < $b->getId()) ? -1 : 1;
             } elseif ($a->isProduct()) {

src/Eccube/Service/PurchaseFlow/PurchaseFlowResult.php

Spacing +2 added lines, -2 removed lines

@@ -53,7 +53,7 @@ 
      */
     public function getErrors()
     {
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
             return $processResult->isError();
         });
     }
@@ -63,7 +63,7 @@ 
      */
     public function getWarning()
     {
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
             return $processResult->isWarning();
         });
     }

src/Eccube/Controller/AbstractController.php

Doc Comments +6 added lines

@@ -59,11 +59,17 @@
      */
     protected $formFactory;
 
+    /**
+     * @param \Eccube\Application $app
+     */
     protected function getSecurity($app)
     {
         return $this->tokenStorage;
     }
 
+    /**
+     * @param \Eccube\Application $app
+     */
     protected function isTokenValid($app)
     {
         $csrf = $this->csrfTokenManager;