Completed
Push — experimental/3.1 ( 10e424...a981bd )
by Kiyotaka
55:16
created
src/Eccube/Service/PurchaseFlow/PurchaseFlowResult.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public function getErrors()
55 55
     {
56
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
56
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
57 57
             return $processResult->isError();
58 58
         });
59 59
     }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public function getWarning()
65 65
     {
66
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
66
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
67 67
             return $processResult->isWarning();
68 68
         });
69 69
     }
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -59,11 +59,17 @@
 block discarded – undo
59 59
      */
60 60
     protected $formFactory;
61 61
 
62
+    /**
63
+     * @param \Eccube\Application $app
64
+     */
62 65
     protected function getSecurity($app)
63 66
     {
64 67
         return $this->tokenStorage;
65 68
     }
66 69
 
70
+    /**
71
+     * @param \Eccube\Application $app
72
+     */
67 73
     protected function isTokenValid($app)
68 74
     {
69 75
         $csrf = $this->csrfTokenManager;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/FileController.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -270,6 +270,10 @@  discard block
 block discarded – undo
270 270
         return $str;
271 271
     }
272 272
 
273
+    /**
274
+     * @param string $topDir
275
+     * @param Request $request
276
+     */
273 277
     private function getTree($topDir, $request)
274 278
     {
275 279
         $finder = Finder::create()->in($topDir)
@@ -307,6 +311,10 @@  discard block
 block discarded – undo
307 311
         return $tree;
308 312
     }
309 313
 
314
+    /**
315
+     * @param Application $app
316
+     * @param string $nowDir
317
+     */
310 318
     private function getFileList($app, $nowDir)
311 319
     {
312 320
         $topDir = $this->appConfig['user_data_realdir'];
@@ -366,6 +374,9 @@  discard block
 block discarded – undo
366 374
         return (strpos($targetDir, $topDir) === 0);
367 375
     }
368 376
 
377
+    /**
378
+     * @return string
379
+     */
369 380
     private function convertStrFromServer($target)
370 381
     {
371 382
         if ($this->encode == self::SJIS) {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     private $error = null;
63 63
     private $encode = '';
64 64
 
65
-    public function __construct(){
65
+    public function __construct() {
66 66
         $this->encode = self::UTF;
67 67
         if ('\\' === DIRECTORY_SEPARATOR) {
68 68
             $this->encode = self::SJIS;
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         $arrFileList = $this->getFileList($app, $nowDir);
112 112
 
113 113
         $javascript = $this->getJsArrayList($tree);
114
-        $onload = "eccube.fileManager.viewFileTree('tree', arrTree, '" . $nowDir . "', 'tree_select_file', 'tree_status', 'move');";
114
+        $onload = "eccube.fileManager.viewFileTree('tree', arrTree, '".$nowDir."', 'tree_select_file', 'tree_status', 'move');";
115 115
 
116 116
         return [
117 117
             'form' => $form->createView(),
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
                 $nowDir = $this->checkDir($request->get('now_dir'), $topDir)
173 173
                     ? $this->normalizePath($request->get('now_dir'))
174 174
                     : $topDir;
175
-                $fs->mkdir($nowDir . '/' . $filename);
175
+                $fs->mkdir($nowDir.'/'.$filename);
176 176
             }
177 177
         }
178 178
     }
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
     {
258 258
         $str = "arrTree = new Array();\n";
259 259
         foreach ($tree as $key => $val) {
260
-            $str .= 'arrTree[' . $key . "] = new Array(" . $key . ", '" . $val['type'] . "', '" . $val['path'] . "', " . $val['sort_no'] . ',';
260
+            $str .= 'arrTree['.$key."] = new Array(".$key.", '".$val['type']."', '".$val['path']."', ".$val['sort_no'].',';
261 261
             if ($val['open']) {
262 262
                 $str .= "true);\n";
263 263
             } else {
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     private function getFileList($app, $nowDir)
309 309
     {
310 310
         $topDir = $this->appConfig['user_data_realdir'];
311
-        $filter = function (\SplFileInfo $file) use ($topDir) {
311
+        $filter = function(\SplFileInfo $file) use ($topDir) {
312 312
             $acceptPath = realpath($topDir);
313 313
             $targetPath = $file->getRealPath();
314 314
             return (strpos($targetPath, $acceptPath) === 0);
Please login to merge, or discard this patch.
src/Eccube/Controller/NonMemberShoppingController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -474,7 +474,7 @@
 block discarded – undo
474 474
      *
475 475
      * @param Application $app
476 476
      * @param array $data リクエストパラメータ
477
-     * @return array
477
+     * @return \Symfony\Component\Validator\ConstraintViolationListInterface[]
478 478
      */
479 479
     protected function customerValidation(Application $app, array $data)
480 480
     {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Front/CustomerAddressType.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,6 @@
 block discarded – undo
59 59
     protected $app;
60 60
 
61 61
     /**
62
-     * @param array $config
63 62
      */
64 63
     public function __construct()
65 64
     {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/SearchProductBlockType.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,6 @@
 block discarded – undo
48 48
     /**
49 49
      * SearchProductType constructor.
50 50
      *
51
-     * @param Application $app
52 51
      */
53 52
     public function __construct()
54 53
     {
Please login to merge, or discard this patch.
src/Eccube/Repository/BlockRepository.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
      * @deprecated 呼び出し元で制御する
50 50
      * @param $block_id
51 51
      * @param $DeviceType
52
-     * @return array|\Eccube\Entity\Block
52
+     * @return Block|null
53 53
      */
54 54
     public function findOrCreate($block_id, $DeviceType)
55 55
     {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
      * ブロック一覧の取得.
112 112
      *
113 113
      * @param  \Eccube\Entity\Master\DeviceType $DeviceType
114
-     * @return array
114
+     * @return null|\Symfony\Component\HttpFoundation\Request
115 115
      */
116 116
     public function getList($DeviceType)
117 117
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@
 block discarded – undo
197 197
             $this->appConfig['block_default_realdir'],
198 198
         );
199 199
         foreach ($readPaths as $readPath) {
200
-            $filePath = $readPath . '/' . $fileName . '.twig';
200
+            $filePath = $readPath.'/'.$fileName.'.twig';
201 201
             $fs = new Filesystem();
202 202
             if ($fs->exists($filePath)) {
203 203
                 return array(
Please login to merge, or discard this patch.
src/Eccube/Service/ShoppingService.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
     /**
221 221
      * 非会員情報を取得
222 222
      *
223
-     * @param $sesisonKey
223
+     * @param string $sesisonKey
224 224
      * @return $Customer|null
225 225
      */
226 226
     public function getNonMember($sesisonKey)
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     /**
253 253
      * 受注情報を作成
254 254
      *
255
-     * @param $Customer
255
+     * @param null|Customer $Customer
256 256
      * @return \Eccube\Entity\Order
257 257
      */
258 258
     public function createOrder($Customer)
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
      * 仮受注情報作成
282 282
      *
283 283
      * @param $Customer
284
-     * @param $preOrderId
284
+     * @param string $preOrderId
285 285
      * @return mixed
286 286
      * @throws \Doctrine\ORM\NoResultException
287 287
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -1403,7 +1403,7 @@  discard block
 block discarded – undo
1403 1403
      * 受注メール送信を行う
1404 1404
      *
1405 1405
      * @param Order $Order
1406
-     * @return MailHistory
1406
+     * @return null|\Symfony\Component\HttpFoundation\Request
1407 1407
      */
1408 1408
     public function sendOrderMail(Order $Order)
1409 1409
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -952,7 +952,7 @@
 block discarded – undo
952 952
 
953 953
         // 配送日数が設定されている
954 954
         if ($deliveryDurationFlag) {
955
-            $period = new \DatePeriod (
955
+            $period = new \DatePeriod(
956 956
                 new \DateTime($minDate.' day'),
957 957
                 new \DateInterval('P1D'),
958 958
                 new \DateTime($minDate + $this->appConfig['deliv_date_end_max'].' day')
Please login to merge, or discard this patch.
src/Eccube/Controller/ShoppingController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -817,7 +817,7 @@
 block discarded – undo
817 817
                 if ($dispatcher instanceof Response
818 818
                     && ($dispatcher->isRedirection() || $dispatcher->getContent())
819 819
                 ) { // $paymentMethod->apply() が Response を返した場合は画面遷移
820
-                    return $dispatcher;                // 画面遷移したいパターンが複数ある場合はどうする? 引数で制御?
820
+                    return $dispatcher; // 画面遷移したいパターンが複数ある場合はどうする? 引数で制御?
821 821
                 }
822 822
                 $PaymentResult = $paymentService->doCheckout($paymentMethod); // 決済実行
823 823
                 if (!$PaymentResult->isSuccess()) {
Please login to merge, or discard this patch.