ComposerApiService::__construct() - Code Metrics - Inspection of "Merge pull request #2652 from eccubevn/292_install..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — experimental/3.1 ( 5ad1b6...37d029 )

by Ryo

created 2017-11-24 07:49 UTC

ComposerApiService::__construct() A

↳ Parent: ComposerApiService

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */
namespace Eccube\Service\Composer;

use Composer\Console\Application;
use Eccube\Annotation\Service;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Output\BufferedOutput;

/**
 * Class ComposerApiService
 * @package Eccube\Service\Composer
 * @Service
 */
class ComposerApiService implements ComposerServiceInterface
{
    /**
     * @var array
     */
    protected $appConfig;

    /**
     * @var Application $consoleApplication
     */
    private $consoleApplication;

    private $workingDir;

    public function __construct($appConfig)

    {
        $this->appConfig = $appConfig;
    }

    /**
     * Run get info command
     *
     * @param string $pluginName format foo/bar or foo/bar:1.0.0 or "foo/bar 1.0.0"
     * @return array
     */
    public function execInfo($pluginName)
    {
        $output = $this->runCommand(array(
            'command' => 'info',
            'package' => $pluginName,
        ));

        return OutputParser::parseInfo($output);
    }

    /**
     * Run execute command
     *
     * @param string $packageName format "foo/bar foo/bar:1.0.0"
     * @return array
     */
    public function execRequire($packageName)

    {
        $packageName = explode(" ", trim($packageName));
        $output = $this->runCommand(array(
            'command' => 'require',
            'packages' => $packageName,
            '--no-interaction' => true,
            '--profile' => true,
            '--prefer-dist' => true,
            '--ignore-platform-reqs' => true,
        ));

        return OutputParser::parseRequire($output);
    }

    /**
     * Run remove command
     *
     * @param string $packageName format "foo/bar foo/bar:1.0.0"
     * @return bool
     */
    public function execRemove($packageName)

    {
        $packageName = explode(' ', trim($packageName));
        $this->runCommand(array(
            'command' => 'remove',
            'packages' => $packageName,
            '--ignore-platform-reqs' => true,
            '--no-interaction' => true,
            '--profile' => true,
        ));

        return true;
    }

    /**
     * Get require
     *
     * @param string $packageName
     * @param string $callback
     * @param null   $typeFilter
     */
    public function foreachRequires($packageName, $callback, $typeFilter = null)
    {
        $info = $this->execInfo($packageName);
        if (isset($info['requires'])) {
            foreach ($info['requires'] as $name => $version) {
                $package = $this->execInfo($name);
                if (is_null($typeFilter) || @$package['type'] === $typeFilter) {
                    $callback($package);
                }
            }
        }
    }

    /**
     * Run get config information
     *
     * @param string $key
     * @param null   $value
     * @return array|mixed
     */
    public function execConfig($key, $value = null)
    {
        $commands = array(
            'command' => 'config',
            'setting-key' => $key,
            'setting-value' => $value,
        );
        if ($value) {
            $commands['setting-value'] = $value;
        }
        $output = $this->runCommand($commands);

        return OutputParser::parseConfig($output);
    }

    /**
     * Get config list
     *
     * @return array
     */
    public function getConfig()
    {
        $output = $this->runCommand(array(
            'command' => 'config',
            '--list' => true,
        ));

        return OutputParser::parseList($output);
    }

    /**
     * Set work dir
     *
     * @param string $workingDir
     */
    public function setWorkingDir($workingDir)
    {
        $this->workingDir = $workingDir;
    }

    /**
     * Run composer command
     *
     * @param array $commands
     * @return string
     */
    public function runCommand($commands)
    {
        $this->init();
        $commands['--working-dir'] = $this->workingDir;
        $commands['--no-ansi'] = 1;
        $input = new ArrayInput($commands);
        $output = new BufferedOutput();

        $exitCode = $this->consoleApplication->run($input, $output);

        $log = $output->fetch();
        if ($exitCode) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            log_error($log);
            throw new \RuntimeException($log);
        }
        log_info($log, $commands);

        return $log;
    }

    /**
     * Init composer console application
     */
    private function init()
    {
        set_time_limit(0);
        @ini_set('memory_limit', '1536M');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        // Config for some environment
        putenv('COMPOSER_HOME='.$this->appConfig['plugin_realdir'].'/.composer');
        $consoleApplication = new Application();
        $consoleApplication->resetComposer();
        $consoleApplication->setAutoExit(false);
        $this->consoleApplication = $consoleApplication;
        $this->workingDir = $this->workingDir ? $this->workingDir : $this->appConfig['root_dir'];
    }
}


1		<?php
2		/*
3		* This file is part of EC-CUBE
4		*
5		* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6		*
7		* http://www.lockon.co.jp/
8		*
9		* This program is free software; you can redistribute it and/or
10		* modify it under the terms of the GNU General Public License
11		* as published by the Free Software Foundation; either version 2
12		* of the License, or (at your option) any later version.
13		*
14		* This program is distributed in the hope that it will be useful,
15		* but WITHOUT ANY WARRANTY; without even the implied warranty of
16		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17		* GNU General Public License for more details.
18		*
19		* You should have received a copy of the GNU General Public License
20		* along with this program; if not, write to the Free Software
21		* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22		*/
23		namespace Eccube\Service\Composer;
24
25		use Composer\Console\Application;
26		use Eccube\Annotation\Service;
27		use Symfony\Component\Console\Input\ArrayInput;
28		use Symfony\Component\Console\Output\BufferedOutput;
29
30		/**
31		* Class ComposerApiService
32		* @package Eccube\Service\Composer
33		* @Service
34		*/
35		class ComposerApiService implements ComposerServiceInterface
36		{
37		/**
38		* @var array
39		*/
40		protected $appConfig;
41
42		/**
43		* @var Application $consoleApplication
44		*/
45		private $consoleApplication;
46
47		private $workingDir;
48
49		public function __construct($appConfig)
		0 ignored issues – show introduced 2017-11-22 12:42 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
50		{
51		$this->appConfig = $appConfig;
52		}
53
54		/**
55		* Run get info command
56		*
57		* @param string $pluginName format foo/bar or foo/bar:1.0.0 or "foo/bar 1.0.0"
58		* @return array
59		*/
60		public function execInfo($pluginName)
61		{
62		$output = $this->runCommand(array(
63		'command' => 'info',
64		'package' => $pluginName,
65		));
66
67		return OutputParser::parseInfo($output);
68		}
69
70		/**
71		* Run execute command
72		*
73		* @param string $packageName format "foo/bar foo/bar:1.0.0"
74		* @return array
75		*/
76	View Code Duplication	public function execRequire($packageName)
		0 ignored issues – show Duplication introduced 2017-11-17 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		$packageName = explode(" ", trim($packageName));
79		$output = $this->runCommand(array(
80		'command' => 'require',
81		'packages' => $packageName,
82		'--no-interaction' => true,
83		'--profile' => true,
84		'--prefer-dist' => true,
85		'--ignore-platform-reqs' => true,
86		));
87
88		return OutputParser::parseRequire($output);
89		}
90
91		/**
92		* Run remove command
93		*
94		* @param string $packageName format "foo/bar foo/bar:1.0.0"
95		* @return bool
96		*/
97	View Code Duplication	public function execRemove($packageName)
		0 ignored issues – show Duplication introduced 2017-11-17 10:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
98		{
99		$packageName = explode(' ', trim($packageName));
100		$this->runCommand(array(
101		'command' => 'remove',
102		'packages' => $packageName,
103		'--ignore-platform-reqs' => true,
104		'--no-interaction' => true,
105		'--profile' => true,
106		));
107
108		return true;
109		}
110
111		/**
112		* Get require
113		*
114		* @param string $packageName
115		* @param string $callback
116		* @param null $typeFilter
117		*/
118		public function foreachRequires($packageName, $callback, $typeFilter = null)
119		{
120		$info = $this->execInfo($packageName);
121		if (isset($info['requires'])) {
122		foreach ($info['requires'] as $name => $version) {
123		$package = $this->execInfo($name);
124		if (is_null($typeFilter) \|\| @$package['type'] === $typeFilter) {
125		$callback($package);
126		}
127		}
128		}
129		}
130
131		/**
132		* Run get config information
133		*
134		* @param string $key
135		* @param null $value
136		* @return array\|mixed
137		*/
138		public function execConfig($key, $value = null)
139		{
140		$commands = array(
141		'command' => 'config',
142		'setting-key' => $key,
143		'setting-value' => $value,
144		);
145		if ($value) {
146		$commands['setting-value'] = $value;
147		}
148		$output = $this->runCommand($commands);
149
150		return OutputParser::parseConfig($output);
151		}
152
153		/**
154		* Get config list
155		*
156		* @return array
157		*/
158		public function getConfig()
159		{
160		$output = $this->runCommand(array(
161		'command' => 'config',
162		'--list' => true,
163		));
164
165		return OutputParser::parseList($output);
166		}
167
168		/**
169		* Set work dir
170		*
171		* @param string $workingDir
172		*/
173		public function setWorkingDir($workingDir)
174		{
175		$this->workingDir = $workingDir;
176		}
177
178		/**
179		* Run composer command
180		*
181		* @param array $commands
182		* @return string
183		*/
184		public function runCommand($commands)
185		{
186		$this->init();
187		$commands['--working-dir'] = $this->workingDir;
188		$commands['--no-ansi'] = 1;
189		$input = new ArrayInput($commands);
190		$output = new BufferedOutput();
191
192		$exitCode = $this->consoleApplication->run($input, $output);
193
194		$log = $output->fetch();
195		if ($exitCode) {
		0 ignored issues – show Bug Best Practice introduced 2017-11-09 10:42 UTC by Report Bug Copy Issue Report The expression `$exitCode` of type `null\|integer` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
196		log_error($log);
197		throw new \RuntimeException($log);
198		}
199		log_info($log, $commands);
200
201		return $log;
202		}
203
204		/**
205		* Init composer console application
206		*/
207		private function init()
208		{
209		set_time_limit(0);
210		@ini_set('memory_limit', '1536M');
		0 ignored issues – show Security Best Practice introduced 2017-10-20 14:07 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
211		// Config for some environment
212		putenv('COMPOSER_HOME='.$this->appConfig['plugin_realdir'].'/.composer');
213		$consoleApplication = new Application();
214		$consoleApplication->resetComposer();
215		$consoleApplication->setAutoExit(false);
216		$this->consoleApplication = $consoleApplication;
217		$this->workingDir = $this->workingDir ? $this->workingDir : $this->appConfig['root_dir'];
218		}
219		}
220

EC-CUBE / ec-cube

Push — experimental/3.1 ( 5ad1b6...37d029 )

ComposerApiService::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like