EC-CUBE / ec-cube

src/Eccube/ServiceProvider/DebugServiceProvider.php

Unused Use Statements -3 removed lines

@@ -24,18 +24,15 @@
 
 namespace Eccube\ServiceProvider;
 
-use Eccube\Common\Constant;
 use Eccube\DataCollector\EccubeDataCollector;
 use Pimple\Container;
 use Pimple\ServiceProviderInterface;
 use Silex\Api\BootableProviderInterface;
 use Silex\Application;
 use Symfony\Bridge\Twig\Extension\DumpExtension;
-use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpKernel\DataCollector\DumpDataCollector;
 use Symfony\Component\HttpKernel\EventListener\DumpListener;
 use Symfony\Component\VarDumper\Cloner\VarCloner;
-use Symfony\Component\VarDumper\Dumper\CliDumper;
 use Symfony\Component\VarDumper\Dumper\HtmlDumper;
 use Symfony\Component\VarDumper\VarDumper;
 

Spacing +13 added lines, -13 removed lines

@@ -72,7 +72,7 @@ 
 {
     public function register(Container $app)
     {
-        $app['var_dumper.cloner'] = function ($app) {
+        $app['var_dumper.cloner'] = function($app) {
             $cloner = new VarCloner();
 
             if (isset($app['debug.max_items'])) {
@@ -86,37 +86,37 @@ 
             return $cloner;
         };
 
-        $app->extend('data_collector.templates', function ($templates) {
+        $app->extend('data_collector.templates', function($templates) {
             return array_merge($templates, array(array('dump', '@Debug/Profiler/dump.html.twig')));
         });
 
-        $app['data_collector.dump'] = function ($app) {
+        $app['data_collector.dump'] = function($app) {
             return new DumpDataCollector($app['stopwatch'], $app['code.file_link_format'], null, null, new HtmlDumper());
         };
 
-        $app->extend('data_collectors', function ($collectors, $app) {
-            $collectors['dump'] = function ($app) {
+        $app->extend('data_collectors', function($collectors, $app) {
+            $collectors['dump'] = function($app) {
                 return $app['data_collector.dump'];
             };
 
-            $collectors['eccube'] = function ($app) {
+            $collectors['eccube'] = function($app) {
                 return new EccubeDataCollector($app);
             };
             return $collectors;
         });
 
-        $app->extend('data_collector.templates', function ($templates, $app) {
+        $app->extend('data_collector.templates', function($templates, $app) {
                 array_unshift($templates, ['eccube', '@EccubeProfiler/eccube.html.twig']);
                 return $templates;
             }
         );
 
-        $app->extend('twig.loader.filesystem', function ($filesystem, $app) {
+        $app->extend('twig.loader.filesystem', function($filesystem, $app) {
                 return $filesystem;
             }
         );
 
-        $app->extend('twig', function ($twig, $app) {
+        $app->extend('twig', function($twig, $app) {
             if (class_exists('\Symfony\Bridge\Twig\Extension\DumpExtension')) {
                 $twig->addExtension(new DumpExtension($app['var_dumper.cloner']));
             }
@@ -124,14 +124,14 @@ 
             return $twig;
         });
 
-        $app->extend('twig.loader.filesystem', function ($loader, $app) {
+        $app->extend('twig.loader.filesystem', function($loader, $app) {
             $loader->addPath($app['debug.templates_path'], 'Debug');
             $loader->addPath(__DIR__.'/../Resource/template/toolbar', 'EccubeProfiler');
 
             return $loader;
         });
 
-        $app['debug.templates_path'] = function () {
+        $app['debug.templates_path'] = function() {
             $r = new \ReflectionClass('Symfony\Bundle\DebugBundle\DependencyInjection\Configuration');
 
             return dirname(dirname($r->getFileName())).'/Resources/views';
@@ -143,11 +143,11 @@ 
         // This code is here to lazy load the dump stack. This default
         // configuration for CLI mode is overridden in HTTP mode on
         // 'kernel.request' event
-        VarDumper::setHandler(function ($var) use ($app) {
+        VarDumper::setHandler(function($var) use ($app) {
             $dumper = $app['data_collector.dump'];
             $cloner = $app['var_dumper.cloner'];
 
-            $handler = function ($var) use ($dumper, $cloner) {
+            $handler = function($var) use ($dumper, $cloner) {
                 $dumper->dump($cloner->cloneVar($var));
             };
 

app/Acme/Controller/AController.php

Unused Use Statements -5 removed lines

@@ -2,14 +2,9 @@
 namespace Acme\Controller;
 
 use Eccube\Application;
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\ParameterBag;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 
 /**
  * @Route("/test")

app/Acme/Controller/RoutingTestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
      * @Security("has_role('ROLE_ADMIN')")
      *
      * @param Application $app
-     * @return \Symfony\Component\HttpFoundation\Response
+     * @return string
      */
     public function testAdmin(Application $app)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Acme\Controller;
 
 use Eccube\Application;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
 

app/Acme/Controller/TestController.php

Unused Use Statements -3 removed lines

@@ -4,13 +4,10 @@
 use Eccube\Application;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\ParameterBag;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 
 /**
  * @Route("/test")

src/Eccube/Controller/Admin/Store/PluginController.php

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 use Eccube\Form\Type\Admin\PluginLocalInstallType;
 use Eccube\Form\Type\Admin\PluginManagementType;
 use Eccube\Util\Str;
-use Monolog\Logger;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Form\Extension\Core\Type\TextType;

src/Eccube/Service/Calculator/OrderDetailCollection.php

Indentation +3 added lines, -3 removed lines

@@ -35,9 +35,9 @@
     public function hasProductByName($productName)
     {
         $OrderDetails = array_filter($this->getArrayCopy(),
-                                     function ($OrderDetail) use ($productName) {
-                                         return $OrderDetail->getProductName() == $productName;
-                                     });
+                                        function ($OrderDetail) use ($productName) {
+                                            return $OrderDetail->getProductName() == $productName;
+                                        });
         return !empty($OrderDetails);
     }
     // map, filter, reduce も実装したい

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     {
         return new self(array_filter(
             $this->getArrayCopy(),
-            function ($OrderDetail) {
+            function($OrderDetail) {
                 if ($OrderDetail->getProductClass()) {
                     return true;
                 }
@@ -35,7 +35,7 @@ 
     public function hasProductByName($productName)
     {
         $OrderDetails = array_filter($this->getArrayCopy(),
-                                     function ($OrderDetail) use ($productName) {
+                                     function($OrderDetail) use ($productName) {
                                          return $OrderDetail->getProductName() == $productName;
                                      });
         return !empty($OrderDetails);

src/Eccube/Service/CartService.php

Doc Comments +2 added lines, -2 removed lines

@@ -231,7 +231,7 @@ 
     }
 
     /**
-     * @param  \Eccube\Entity\ProductClass|integer $ProductClass
+     * @param  string $ProductClass
      * @param  integer $quantity
      * @return \Eccube\Service\CartService
      * @throws CartException
@@ -645,7 +645,7 @@ 
      * 在庫数と販売制限数ともに個数が超えていれば、少ない方を適用させてメッセージを表示する
      *
      * @param ProductClass $ProductClass
-     * @param $productName
+     * @param string $productName
      * @param $quantity
      * @return int チェック後に更新した個数
      */

Indentation +1 added lines, -1 removed lines

@@ -302,7 +302,7 @@
         // 制限数チェック(在庫不足の場合は、処理の中でカート内商品を削除している)
         $quantity = $this->setProductLimit($ProductClass, $productName, $tmp_quantity);
 
-		// 新しい数量でカート内商品を登録する
+        // 新しい数量でカート内商品を登録する
         if (0 < $quantity) {
             $CartItem = new CartItem();
             $CartItem

Spacing +3 added lines, -3 removed lines

@@ -222,7 +222,7 @@ 
      */
     public function getProductQuantity($productClassId)
     {
-        $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string)$productClassId);
+        $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
         if ($CartItem) {
             return $CartItem->getQuantity();
         } else {
@@ -307,7 +307,7 @@ 
             $CartItem = new CartItem();
             $CartItem
                 ->setClassName('Eccube\Entity\ProductClass')
-                ->setClassId((string)$ProductClass->getId())
+                ->setClassId((string) $ProductClass->getId())
                 ->setPrice($ProductClass->getPrice02IncTax())
                 ->setQuantity($quantity);
 
@@ -465,7 +465,7 @@ 
      */
     public function removeProduct($productClassId)
     {
-        $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string)$productClassId);
+        $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId);
 
         // 支払方法の再設定
         if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) {

src/Eccube/Form/Type/Admin/MasterdataDataType.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
             ->add('name', TextType::class, array(
                 'required' => false,
             ))
-        ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) use ($app) {
+        ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) use ($app) {
             $form = $event->getForm();
             $data = $form->getData();
             if (strlen($data['id']) && strlen($data['name']) == 0) {

src/Eccube/Command/GeneratorCommand/generatortemplate/ServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
         $app->match('/plugin/[lower_code]/hello', 'Plugin\[code]\Controller\[code]Controller::index')->bind('plugin_[code]_hello');
 
         // Form
-        $app['form.types'] = $app->extend('form.types', function ($types) use ($app) {
+        $app['form.types'] = $app->extend('form.types', function($types) use ($app) {
             $types[] = new [code]ConfigType();
 
             return $types;
@@ -57,7 +57,7 @@ 
         // }
 
         // ログファイル設定
-        $app['monolog.logger.[lower_code]'] = function ($app) {
+        $app['monolog.logger.[lower_code]'] = function($app) {
 
             $logger = new $app['monolog.logger.class']('[lower_code]');