ItemCollection::sort() - Code Metrics - Inspection of "CoCをプラグインにも適用するように変更" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2521)

by Kiyotaka

created 2017-09-27 06:27 UTC

ItemCollection::sort() C

↳ Parent: ItemCollection

Complexity

Conditions	12
Paths	1

Size

Total Lines	35
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	12.667

Importance

Changes

Metric	Value
cc	12
eloc	23
nc	1
nop	0
dl	0
loc	35
ccs	20
cts	24
cp	0.8333
crap	12.667
rs	5.1612
c	0
b	0
f	0

How to fix Complexity

<?php

namespace Eccube\Service\PurchaseFlow;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Eccube\Entity\ItemInterface;
use Eccube\Entity\Master\OrderItemType;
use Eccube\Entity\Order;

class ItemCollection extends ArrayCollection

{
    protected $type;

    public function __construct($Items, $type = null)

    {
        $this->type = is_null($type) ? Order::class : $type;

        if ($Items instanceof Collection) {
            $Items = $Items->toArray();
        }
        parent::__construct($Items);
    }

    public function reduce(\Closure $func, $initial = null)

    {
        return array_reduce($this->toArray(), $func, $initial);
    }

    // 明細種別ごとに返すメソッド作る
    public function getProductClasses()

    {
        return $this->filter(
            function (ItemInterface $ShipmentItem) {
                return $ShipmentItem->isProduct();
            });
    }

    public function getDeliveryFees()

    {
        return $this->filter(
            function (ItemInterface $ShipmentItem) {
                return $ShipmentItem->isDeliveryFee();
            });
    }

    public function getCharges()

    {
        return $this->filter(
            function (ItemInterface $ShipmentItem) {
                return $ShipmentItem->isCharge();
            });
    }

    public function getDiscounts()

    {
        return $this->filter(
            function (ItemInterface $ShipmentItem) {
                return $ShipmentItem->isDiscount();
            });
    }

    /**

     * 同名の明細が存在するかどうか.
     *
     * TODO 暫定対応. 本来は明細種別でチェックする.
     */

    public function hasProductByName($productName)

    {
        $ShipmentItems = $this->filter(
            function (ItemInterface $ShipmentItem) use ($productName) {
                /* @var ShipmentItem $ShipmentItem */
                return $ShipmentItem->getProductName() == $productName;
            });

        return !$ShipmentItems->isEmpty();
    }

    /**
     * 指定した受注明細区分の明細が存在するかどうか.
     *
     * @param OrderItemType $OrderItemType 受注区分
     *
     * @return bool
     */
    public function hasItemByOrderItemType($OrderItemType)

    {
        $filteredItems = $this->filter(function (ItemInterface $ShipmentItem) use ($OrderItemType) {
            /* @var ShipmentItem $ShipmentItem */
            return $ShipmentItem->getOrderItemType() && $ShipmentItem->getOrderItemType()->getId() == $OrderItemType->getId();
        });

        return !$filteredItems->isEmpty();
    }

    public function getType()

    {
        return $this->type;
    }

    public function sort()

    {
        $Items = $this->toArray();
        usort($Items, function (ItemInterface $a, ItemInterface $b) {
            if ($a->getOrderItemType() === $b->getOrderItemType()) {
                return ($a->getId() < $b->getId()) ? -1 : 1;
            } elseif ($a->isProduct()) {
                return -1;
            } elseif ($a->isDeliveryFee()) {
                if ($b->isProduct()) {
                    return 1;
                }

                return -1;
            } elseif ($a->isCharge()) {
                if ($b->isDeliveryFee() || $b->isProduct()) {
                    return 1;
                }

                return -1;
            } elseif ($a->isDiscount()) {
                if (!$b->isTax()) {
                    return 1;
                }

                return -1;
            } elseif ($a->isTax()) {
                return 1;
            }

            return 0;
        });

        return new self($Items);
    }
}


1			<?php
2
3			namespace Eccube\Service\PurchaseFlow;
4
5			use Doctrine\Common\Collections\ArrayCollection;
6			use Doctrine\Common\Collections\Collection;
7			use Eccube\Entity\ItemInterface;
8			use Eccube\Entity\Master\OrderItemType;
9			use Eccube\Entity\Order;
10
11			class ItemCollection extends ArrayCollection
			0 ignored issues – show introduced 2017-07-20 09:47 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
12			{
13			protected $type;
14
15	116		public function __construct($Items, $type = null)
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
16			{
17	116		$this->type = is_null($type) ? Order::class : $type;
18
19	116		if ($Items instanceof Collection) {
20	116		$Items = $Items->toArray();
21			}
22	116		parent::__construct($Items);
23			}
24
25	27		public function reduce(\Closure $func, $initial = null)
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
26			{
27	27		return array_reduce($this->toArray(), $func, $initial);
28			}
29
30			// 明細種別ごとに返すメソッド作る
31	25		public function getProductClasses()
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report You must use "/**" style comments for a function comment Loading history...
32			{
33	25		return $this->filter(
34			function (ItemInterface $ShipmentItem) {
35	19		return $ShipmentItem->isProduct();
36	25		});
37			}
38
39	24		public function getDeliveryFees()
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
40			{
41	24		return $this->filter(
42			function (ItemInterface $ShipmentItem) {
43	18		return $ShipmentItem->isDeliveryFee();
44	24		});
45			}
46
47	25		public function getCharges()
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
48			{
49	25		return $this->filter(
50			function (ItemInterface $ShipmentItem) {
51	19		return $ShipmentItem->isCharge();
52	25		});
53			}
54
55	23		public function getDiscounts()
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
56			{
57	23		return $this->filter(
58			function (ItemInterface $ShipmentItem) {
59	17		return $ShipmentItem->isDiscount();
60	23		});
61			}
62
63			/**
			0 ignored issues – show introduced 2017-07-20 09:47 UTC by Report Bug Copy Issue Report Doc comment for parameter "$productName" missing Loading history...
64			* 同名の明細が存在するかどうか.
65			*
66			* TODO 暫定対応. 本来は明細種別でチェックする.
67			*/
			0 ignored issues – show introduced 2017-07-20 09:47 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
68		View Code Duplication	public function hasProductByName($productName)
			0 ignored issues – show Duplication introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69			{
70			$ShipmentItems = $this->filter(
71			function (ItemInterface $ShipmentItem) use ($productName) {
72			/* @var ShipmentItem $ShipmentItem */
73			return $ShipmentItem->getProductName() == $productName;
74			});
75
76			return !$ShipmentItems->isEmpty();
77			}
78
79			/**
80			* 指定した受注明細区分の明細が存在するかどうか.
81			*
82			* @param OrderItemType $OrderItemType 受注区分
83			*
84			* @return bool
85			*/
86	1	View Code Duplication	public function hasItemByOrderItemType($OrderItemType)
			0 ignored issues – show Duplication introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87			{
88			$filteredItems = $this->filter(function (ItemInterface $ShipmentItem) use ($OrderItemType) {
89			/* @var ShipmentItem $ShipmentItem */
90	1		return $ShipmentItem->getOrderItemType() && $ShipmentItem->getOrderItemType()->getId() == $OrderItemType->getId();
91	1		});
92
93	1		return !$filteredItems->isEmpty();
94			}
95
96			public function getType()
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
97			{
98			return $this->type;
99			}
100
101	116		public function sort()
			0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
102			{
103	116		$Items = $this->toArray();
104	116		usort($Items, function (ItemInterface $a, ItemInterface $b) {
105	29		if ($a->getOrderItemType() === $b->getOrderItemType()) {
106	11		return ($a->getId() < $b->getId()) ? -1 : 1;
107	28		} elseif ($a->isProduct()) {
108	28		return -1;
109	15		} elseif ($a->isDeliveryFee()) {
110	13		if ($b->isProduct()) {
111	2		return 1;
112			}
113
114	13		return -1;
115	15		} elseif ($a->isCharge()) {
116	15		if ($b->isDeliveryFee() \|\| $b->isProduct()) {
117	2		return 1;
118			}
119
120	15		return -1;
121	2		} elseif ($a->isDiscount()) {
122	2		if (!$b->isTax()) {
123	2		return 1;
124			}
125
126			return -1;
127			} elseif ($a->isTax()) {
128			return 1;
129			}
130
131			return 0;
132	116		});
133
134	116		return new self($Items);
135			}
136			}
137

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2521)

ItemCollection::sort() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like