TaxStrategy::execute() - Code Metrics - Inspection of "消し忘れのコマンドを削除" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/3.1 (#2449)

by Kiyotaka

created 2017-08-02 03:29 UTC

TaxStrategy::execute() A

↳ Parent: TaxStrategy

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	5
Ratio	50 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	5
loc	10
ccs	0
cts	5
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace Eccube\Service\Calculator\Strategy;

use Eccube\Application;
use Eccube\Entity\Order;
use Eccube\Entity\PurchaseInterface;
use Eccube\Entity\ShipmentItem;
use Eccube\Service\Calculator\ShipmentItemCollection;

class TaxStrategy implements CalculateStrategyInterface

{
    protected $app;
    protected $Order;

    public function __construct(Application $app = null)

    {
        $this->app = $app;
    }

    public function execute(ShipmentItemCollection $ShipmentItems)

    {
        // map でやりたい
        /* @var ShipmentItem $ShipmentItem */
        foreach ($ShipmentItems as $ShipmentItem) {
            $tax = $this->app['eccube.service.tax_rule']
                ->calcTax($ShipmentItem->getPrice(), $ShipmentItem->getTaxRate(), $ShipmentItem->getTaxRule());
            $ShipmentItem->setPriceIncTax($ShipmentItem->getPrice() + $tax);
        }
    }

    public function setApplication(Application $app)

    {
        $this->app = $app;
        return $this;

    }

    public function setOrder(PurchaseInterface $Order)

    {
        $this->Order = $Order;
        return $this;

    }

    public function getTargetTypes()

    {
        return [Order::class];
    }
}


1		<?php
2
3		namespace Eccube\Service\Calculator\Strategy;
4
5		use Eccube\Application;
6		use Eccube\Entity\Order;
7		use Eccube\Entity\PurchaseInterface;
8		use Eccube\Entity\ShipmentItem;
9		use Eccube\Service\Calculator\ShipmentItemCollection;
10
11		class TaxStrategy implements CalculateStrategyInterface
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
12		{
13		protected $app;
14		protected $Order;
15
16		public function __construct(Application $app = null)
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
17		{
18		$this->app = $app;
19		}
20
21		public function execute(ShipmentItemCollection $ShipmentItems)
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
22		{
23		// map でやりたい
24		/* @var ShipmentItem $ShipmentItem */
25	View Code Duplication	foreach ($ShipmentItems as $ShipmentItem) {
26		$tax = $this->app['eccube.service.tax_rule']
27		->calcTax($ShipmentItem->getPrice(), $ShipmentItem->getTaxRate(), $ShipmentItem->getTaxRule());
28		$ShipmentItem->setPriceIncTax($ShipmentItem->getPrice() + $tax);
29		}
30		}
31
32		public function setApplication(Application $app)
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
33		{
34		$this->app = $app;
35		return $this;
		0 ignored issues – show introduced 2016-12-15 10:20 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
36		}
37
38		public function setOrder(PurchaseInterface $Order)
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
39		{
40		$this->Order = $Order;
41		return $this;
		0 ignored issues – show introduced 2017-06-12 01:08 UTC by Report Bug Copy Issue Report Missing blank line before return statement Loading history...
42		}
43
44		public function getTargetTypes()
		0 ignored issues – show introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
45		{
46		return [Order::class];
47		}
48		}
49

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2449)

TaxStrategy::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like