Eccube\Controller\Install\InstallController::step3()

Complexity

Conditions	9
Paths	28

Size

Total Lines	73
Code Lines	46

Duplication

Lines	6
Ratio	8.22 %

Code Coverage

Tests	37
CRAP Score	9.4552

Importance

Changes

0

<?php
    public function step3(InstallApplication $app, Request $request)

You must use "/**" style comments for a function comment

    {
        $form = $app['form.factory']
            ->createBuilder(Step3Type::class)
            ->getForm();
        $sessionData = $this->getSessionData($request);

        if (empty($sessionData['shop_name'])) {

Blank line found at start of control structure

            $config_file = $this->config_path . '/config.yml';

Concat operator must not be surrounded by spaces

            $fs = new Filesystem();

            if ($fs->exists($config_file)) {
                // すでに登録されていた場合、登録データを表示
                $this->setPDO();
                $stmt = $this->PDO->query("SELECT shop_name, email01 FROM dtb_base_info WHERE id = 1;");

                foreach ($stmt as $row) {
                    $sessionData['shop_name'] = $row['shop_name'];
                    $sessionData['email'] = $row['email01'];
                }

                // セキュリティの設定
                $config_file = $this->config_path . '/path.yml';

Concat operator must not be surrounded by spaces

                $config = Yaml::parse(file_get_contents($config_file));
                $sessionData['admin_dir'] = $config['admin_route'];

                $config_file = $this->config_path . '/config.yml';

Concat operator must not be surrounded by spaces

                $config = Yaml::parse(file_get_contents($config_file));

                $allowHost = $config['admin_allow_host'];
                if (count($allowHost) > 0) {
                    $sessionData['admin_allow_hosts'] = Str::convertLineFeed(implode("\n", $allowHost));
                }
                $sessionData['admin_force_ssl'] = (bool) $config['force_ssl'];

                // ロードバランサー、プロキシサーバ設定
                if (isset($config['trusted_proxies_connection_only'])) {
                    $sessionData['trusted_proxies_connection_only'] = (bool)$config['trusted_proxies_connection_only'];

As per coding-style, a cast statement should be followed by a single space.

                }
                if (isset($config['trusted_proxies'])) {
                    $trustedProxies = $config['trusted_proxies'];
                    if (count($trustedProxies) > 0) {
                        $sessionData['trusted_proxies'] = Str::convertLineFeed(implode("\n", $trustedProxies));
                    }
                }
                // メール設定
                $config_file = $this->config_path . '/mail.yml';

Concat operator must not be surrounded by spaces

                $config = Yaml::parse(file_get_contents($config_file));
                $mail = $config['mail'];
                $sessionData['mail_backend'] = $mail['transport'];
                $sessionData['smtp_host'] = $mail['host'];
                $sessionData['smtp_port'] = $mail['port'];
                $sessionData['smtp_username'] = $mail['username'];
                $sessionData['smtp_password'] = $mail['password'];
            } else {
                // 初期値にmailを設定
                $sessionData['mail_backend'] = 'mail';
            }
        }

        $form->setData($sessionData);
        if ($this->isValid($request, $form)) {
            $data = $form->getData();

$data is not used, you could remove the assignment.

            return $app->redirect($app->path('install_step4'));
        }

        return $app['twig']->render('step3.twig', array(
                'form' => $form->createView(),
                'publicPath' => '..' . RELATIVE_PUBLIC_DIR_PATH . '/',

Concat operator must not be surrounded by spaces

        ));
    }