ItemHolderValidator::execute() - Code Metrics - Inspection of "支払い方法ごとに購入処理の仮確定/確定/仮確定取消を行えるようにPurcheseFlowを修正" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/sf (#3247)

by Kiyotaka

created 2018-07-03 08:00 UTC

ItemHolderValidator::execute() A

↳ Parent: ItemHolderValidator

Complexity

Conditions	2
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
nc	3
nop	2
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
ccs	5
cts	5
cp	1
crap	2

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Service\PurchaseFlow;

use Eccube\Entity\ItemHolderInterface;

/**
 * カート/受注の妥当性検証を行う.
 */
abstract class ItemHolderValidator

{
    use ValidatorTrait;

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext     $context
     *
     * @return ProcessResult
     */
    final public function execute(ItemHolderInterface $itemHolder, PurchaseContext $context)
    {
        try {
            $this->validate($itemHolder, $context);

            return ProcessResult::success();
        } catch (InvalidItemException $e) {
            return ProcessResult::error($e->getMessage());
        }
    }

    /**
     * @param ItemHolderInterface $itemHolder
     * @param PurchaseContext $context
     *
     * @throws InvalidItemException
     */
    abstract protected function validate(ItemHolderInterface $itemHolder, PurchaseContext $context);

    protected function handle(ItemHolderInterface $itemHolder)

    {
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\Service\PurchaseFlow;
15
16		use Eccube\Entity\ItemHolderInterface;
17
18		/**
19		* カート/受注の妥当性検証を行う.
20		*/
21		abstract class ItemHolderValidator
		0 ignored issues – show introduced 2018-07-03 09:54 UTC by Report Bug Copy Issue Report Abstract class name is not prefixed with "Abstract" Loading history...
22		{
23		use ValidatorTrait;
24
25		/**
26		* @param ItemHolderInterface $itemHolder
27		* @param PurchaseContext $context
28		*
29		* @return ProcessResult
30		*/
31	230	final public function execute(ItemHolderInterface $itemHolder, PurchaseContext $context)
32		{
33		try {
34	230	$this->validate($itemHolder, $context);
35
36	223	return ProcessResult::success();
37	14	} catch (InvalidItemException $e) {
38	14	return ProcessResult::error($e->getMessage());
39		}
40		}
41
42		/**
43		* @param ItemHolderInterface $itemHolder
44		* @param PurchaseContext $context
45		*
46		* @throws InvalidItemException
47		*/
48		abstract protected function validate(ItemHolderInterface $itemHolder, PurchaseContext $context);
49
50		protected function handle(ItemHolderInterface $itemHolder)
		0 ignored issues – show Unused Code introduced 2017-08-02 04:20 UTC by Report Bug Copy Issue Report The parameter `$itemHolder` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
51		{
52		}
53		}
54

EC-CUBE / ec-cube

Pull Request — experimental/sf (#3247)

ItemHolderValidator::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like