EccubeRouter::setRequireHttps() - Code Metrics - Inspection of "Merge pull request #2348 from chihiro-adachi/fix-r..." - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — experimental/3.1 ( cb54a4...028283 )

by Kiyotaka

created 2017-05-31 01:13 UTC

EccubeRouter::setRequireHttps() A

↳ Parent: EccubeRouter

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0
ccs	2
cts	2
cp	1
crap	1

<?php

namespace Eccube\Routing;

use Symfony\Component\Routing\Router;

class EccubeRouter extends Router

{
    protected $requireHttps = false;

    protected $adminPrefix = 'admin';

    protected $userDataPrefix = 'user_data';

    public function setRequireHttps($requireHttps)

    {
        $this->requireHttps = (bool)$requireHttps;

    }

    public function setAdminPrefix($adminPrefix)

    {
        $this->adminPrefix = $adminPrefix;
    }

    public function setUserDataPrefix($userDataPrefix)

    {
        $this->userDataPrefix = $userDataPrefix;
    }

    public function getRouteCollection()

    {
        $collection = parent::getRouteCollection();

        if ($this->requireHttps) {
            $collection->setSchemes('https');
        }

        $collection->addRequirements(
            [
                '_admin' => $this->adminPrefix,
                '_user_data' => $this->userDataPrefix,
            ]
        );

        $collection->addDefaults(
            [
                '_admin' => $this->adminPrefix,
                '_user_data' => $this->userDataPrefix,
            ]
        );

        return $collection;
    }
}


1		<?php
2
3		namespace Eccube\Routing;
4
5		use Symfony\Component\Routing\Router;
6
7		class EccubeRouter extends Router
		0 ignored issues – show introduced 2017-02-24 10:42 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
8		{
9		protected $requireHttps = false;
10
11		protected $adminPrefix = 'admin';
12
13		protected $userDataPrefix = 'user_data';
14
15	1178	public function setRequireHttps($requireHttps)
		0 ignored issues – show introduced 2017-02-24 10:42 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
16		{
17	1178	$this->requireHttps = (bool)$requireHttps;
		0 ignored issues – show Coding Style introduced 2017-02-24 10:42 UTC by Report Bug Copy Issue Report As per coding-style, a cast statement should be followed by a single space. Loading history...
18		}
19
20	1178	public function setAdminPrefix($adminPrefix)
		0 ignored issues – show introduced 2017-02-24 10:42 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
21		{
22	1178	$this->adminPrefix = $adminPrefix;
23		}
24
25	1178	public function setUserDataPrefix($userDataPrefix)
		0 ignored issues – show introduced 2017-02-24 10:42 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
26		{
27	1178	$this->userDataPrefix = $userDataPrefix;
28		}
29
30	478	public function getRouteCollection()
		0 ignored issues – show introduced 2017-02-24 10:42 UTC by Report Bug Copy Issue Report Missing function doc comment Loading history...
31		{
32	478	$collection = parent::getRouteCollection();
33
34	478	if ($this->requireHttps) {
35		$collection->setSchemes('https');
36		}
37
38	478	$collection->addRequirements(
39		[
40	478	'_admin' => $this->adminPrefix,
41	478	'_user_data' => $this->userDataPrefix,
42		]
43		);
44
45	478	$collection->addDefaults(
46		[
47		'_admin' => $this->adminPrefix,
48		'_user_data' => $this->userDataPrefix,
49		]
50		);
51
52		return $collection;
53		}
54		}
55

EC-CUBE / ec-cube

Push — experimental/3.1 ( cb54a4...028283 )

EccubeRouter::setRequireHttps() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like