Completed
Pull Request — experimental/3.1 (#2483)
by Kentaro
44:50
created
src/Eccube/ServiceProvider/EntityEventServiceProvider.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
      * This method should only be used to configure services and parameters.
17 17
      * It should not get services.
18 18
      *
19
-     * @param Container $pimple A container instance
20 19
      */
21 20
     public function register(Container $container)
22 21
     {
Please login to merge, or discard this patch.
src/Eccube/Doctrine/ORM/Mapping/Driver/AnnotationDriver.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@
 block discarded – undo
32 32
 {
33 33
     protected $trait_proxies_directory;
34 34
 
35
+    /**
36
+     * @param string $dir
37
+     */
35 38
     public function setTraitProxiesDirectory($dir)
36 39
     {
37 40
         $this->trait_proxies_directory = $dir;
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/JoinClause.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * JoinClause constructor.
59
-     * @param $leftJoin
59
+     * @param boolean $leftJoin
60 60
      * @param $join
61 61
      * @param $alias
62 62
      * @param $conditionType
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/OrderByClause.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
 
38 38
     /**
39 39
      * OrderByClause constructor.
40
-     * @param $sort
40
+     * @param string $sort
41 41
      * @param string $order
42 42
      */
43 43
     function __construct($sort, $order = 'asc')
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Query/WhereClause.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -53,6 +53,9 @@
 block discarded – undo
53 53
         $this->params = $params;
54 54
     }
55 55
 
56
+    /**
57
+     * @param Expr\Comparison $expr
58
+     */
56 59
     private static function newWhereClause($expr, $x, $y)
57 60
     {
58 61
         if ($y) {
Please login to merge, or discard this patch.
src/Eccube/Repository/ShippingRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
      *
39 39
      * @param  array        $searchData
40
-     * @return QueryBuilder
40
+     * @return \Doctrine\ORM\QueryBuilder
41 41
      */
42 42
     public function getQueryBuilderBySearchDataForAdmin($searchData)
43 43
     {
Please login to merge, or discard this patch.
src/Eccube/Application/ApplicationTrait.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,6 +16,7 @@  discard block
 block discarded – undo
16 16
 {
17 17
     /**
18 18
      * Application Shortcut Methods
19
+     * @param string $message
19 20
      */
20 21
     public function addSuccess($message, $namespace = 'front')
21 22
     {
@@ -58,6 +59,9 @@  discard block
 block discarded – undo
58 59
         $this->addWarning('admin.delete.warning', 'admin');
59 60
     }
60 61
 
62
+    /**
63
+     * @param string $targetPath
64
+     */
61 65
     public function setLoginTargetPath($targetPath, $namespace = null)
62 66
     {
63 67
         if (is_null($namespace)) {
@@ -109,7 +113,7 @@  discard block
 block discarded – undo
109 113
      * @param string $path フォワード先のパス
110 114
      * @param array $requestParameters
111 115
      * @param Response $response
112
-     * @return Application
116
+     * @return ApplicationTrait
113 117
      */
114 118
     public function forwardChain($path, array $requestParameters = [], Response &$response = null)
115 119
     {
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -59,11 +59,17 @@
 block discarded – undo
59 59
      */
60 60
     protected $formFactory;
61 61
 
62
+    /**
63
+     * @param \Eccube\Application $app
64
+     */
62 65
     protected function getSecurity($app)
63 66
     {
64 67
         return $this->tokenStorage;
65 68
     }
66 69
 
70
+    /**
71
+     * @param \Eccube\Application $app
72
+     */
67 73
     protected function isTokenValid($app)
68 74
     {
69 75
         $csrf = $this->csrfTokenManager;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/FileController.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -270,6 +270,10 @@  discard block
 block discarded – undo
270 270
         return $str;
271 271
     }
272 272
 
273
+    /**
274
+     * @param string $topDir
275
+     * @param Request $request
276
+     */
273 277
     private function getTree($topDir, $request)
274 278
     {
275 279
         $finder = Finder::create()->in($topDir)
@@ -307,6 +311,10 @@  discard block
 block discarded – undo
307 311
         return $tree;
308 312
     }
309 313
 
314
+    /**
315
+     * @param Application $app
316
+     * @param string $nowDir
317
+     */
310 318
     private function getFileList($app, $nowDir)
311 319
     {
312 320
         $topDir = $this->appConfig['user_data_realdir'];
@@ -366,6 +374,9 @@  discard block
 block discarded – undo
366 374
         return (strpos($targetDir, $topDir) === 0);
367 375
     }
368 376
 
377
+    /**
378
+     * @return string
379
+     */
369 380
     private function convertStrFromServer($target)
370 381
     {
371 382
         if ($this->encode == self::SJIS) {
Please login to merge, or discard this patch.