Failed Conditions
Pull Request — experimental/3.1 (#2672)
by
unknown
16:13
created
src/Eccube/Form/Type/Admin/PageType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
                 'label' => false,
47 47
                 'class' => 'Eccube\Entity\Page',
48 48
                 'choice_label' => 'name',
49
-                'query_builder' => function (EntityRepository $er) {
49
+                'query_builder' => function(EntityRepository $er) {
50 50
                     return $er
51 51
                         ->createQueryBuilder('l')
52 52
                         ->where('l.id <> 0')
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 3 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 use Eccube\Common\Constant;
32 32
 use Eccube\Entity\Plugin;
33 33
 use Eccube\Exception\PluginException;
34
-use Eccube\Plugin\ConfigManager;
35 34
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
36 35
 use Eccube\Repository\PluginEventHandlerRepository;
37 36
 use Eccube\Repository\PluginRepository;
Please login to merge, or discard this patch.
Doc Comments   +22 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      *
115 115
      * @param string $path   path to tar.gz/zip plugin file
116 116
      * @param int    $source
117
-     * @return mixed
117
+     * @return boolean
118 118
      * @throws PluginException
119 119
      * @throws \Exception
120 120
      */
@@ -179,6 +179,10 @@  discard block
 block discarded – undo
179 179
     }
180 180
 
181 181
     // インストール事後処理
182
+
183
+    /**
184
+     * @param integer $source
185
+     */
182 186
     public function postInstall($config, $event, $source)
183 187
     {
184 188
         // Proxyのクラスをロードせずにスキーマを更新するために、
@@ -225,6 +229,10 @@  discard block
 block discarded – undo
225 229
         }
226 230
     }
227 231
 
232
+    /**
233
+     * @param string $archive
234
+     * @param string $dir
235
+     */
228 236
     public function unpackPluginArchive($archive, $dir)
229 237
     {
230 238
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -284,6 +292,9 @@  discard block
 block discarded – undo
284 292
         }
285 293
     }
286 294
 
295
+    /**
296
+     * @param string $yml
297
+     */
287 298
     public function readYml($yml)
288 299
     {
289 300
         if (file_exists($yml)) {
@@ -301,6 +312,9 @@  discard block
 block discarded – undo
301 312
         // ディレクトリ名などに使われれるので厳しめ
302 313
     }
303 314
 
315
+    /**
316
+     * @param string $path
317
+     */
304 318
     public function deleteFile($path)
305 319
     {
306 320
         $f = new Filesystem();
@@ -320,6 +334,9 @@  discard block
 block discarded – undo
320 334
         return $this->appConfig['plugin_realdir'].'/'.$name;
321 335
     }
322 336
 
337
+    /**
338
+     * @param string $d
339
+     */
323 340
     public function createPluginDir($d)
324 341
     {
325 342
         $b = @mkdir($d);
@@ -377,6 +394,9 @@  discard block
 block discarded – undo
377 394
         return $p;
378 395
     }
379 396
 
397
+    /**
398
+     * @param string $method
399
+     */
380 400
     public function callPluginManagerMethod($meta, $method)
381 401
     {
382 402
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
@@ -873,7 +893,7 @@  discard block
 block discarded – undo
873 893
      * [プラグインコード]/Resource/assets
874 894
      * 配下に置かれているファイルが所定の位置へコピーされる
875 895
      *
876
-     * @param $pluginBaseDir
896
+     * @param string $pluginBaseDir
877 897
      * @param $pluginCode
878 898
      */
879 899
     public function copyAssets($pluginBaseDir, $pluginCode)
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
     {
182 182
         // Proxyのクラスをロードせずにスキーマを更新するために、
183 183
         // インストール時には一時的なディレクトリにProxyを生成する
184
-        $tmpProxyOutputDir = sys_get_temp_dir() . '/proxy_' . StringUtil::random(12);
184
+        $tmpProxyOutputDir = sys_get_temp_dir().'/proxy_'.StringUtil::random(12);
185 185
         @mkdir($tmpProxyOutputDir);
186 186
 
187 187
         try {
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             if (!empty($config_cache)) {
248 248
                 $meta = $config_cache;
249 249
             } else {
250
-                $meta = $this->readYml($dir . '/config.yml');
250
+                $meta = $this->readYml($dir.'/config.yml');
251 251
             }
252 252
         } catch (\Symfony\Component\Yaml\Exception\ParseException $e) {
253 253
             throw new PluginException($e->getMessage(), $e->getCode(), $e);
@@ -856,7 +856,7 @@  discard block
 block discarded – undo
856 856
     {
857 857
         $result = array_keys($packages);
858 858
         if ($getVersion) {
859
-            $result = array_map(function ($package, $version) {
859
+            $result = array_map(function($package, $version) {
860 860
                 return $package.':'.$version;
861 861
             }, array_keys($packages), array_values($packages));
862 862
         }
Please login to merge, or discard this patch.
src/Eccube/Controller/Install/InstallController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -420,6 +420,9 @@
 block discarded – undo
420 420
         $session->set('eccube.session.install', $data);
421 421
     }
422 422
 
423
+    /**
424
+     * @param InstallApplication $app
425
+     */
423 426
     private function checkModules($app)
424 427
     {
425 428
         foreach ($this->requiredModules as $module) {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@
 block discarded – undo
212 212
 
213 213
                 // ロードバランサ, プロキシサーバ
214 214
                 if (!empty($config['trusted_proxies_connection_only'])) {
215
-                    $sessionData['trusted_proxies_connection_only'] = (bool)$config['trusted_proxies_connection_only'];
215
+                    $sessionData['trusted_proxies_connection_only'] = (bool) $config['trusted_proxies_connection_only'];
216 216
                 }
217 217
                 if (!empty($config['trusted_proxies'])) {
218 218
                     $sessionData['trusted_proxies'] = StringUtil::convertLineFeed(implode("\n",
Please login to merge, or discard this patch.
eccube_install.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -400,15 +400,15 @@
 block discarded – undo
400 400
     foreach ($finder as $content) {
401 401
         $permission = $content->getPerms();
402 402
         // see also http://www.php.net/fileperms
403
-        if (!($permission & 0x0010) || !($permission & 0x0002)) {
403
+        if (!($permission&0x0010) || !($permission&0x0002)) {
404 404
             $realPath = $content->getRealPath();
405 405
             if ($verbose) {
406 406
                 out(sprintf('%s %s to ', $realPath, substr(sprintf('%o', $permission), -4)), 'info', false);
407 407
             }
408
-            $permission = !($permission & 0x0020) ? $permission += 040 : $permission; // g+r
409
-            $permission = !($permission & 0x0010) ? $permission += 020 : $permission; // g+w
410
-            $permission = !($permission & 0x0004) ? $permission += 04 : $permission;  // o+r
411
-            $permission = !($permission & 0x0002) ? $permission += 02 : $permission;  // o+w
408
+            $permission = !($permission&0x0020) ? $permission += 040 : $permission; // g+r
409
+            $permission = !($permission&0x0010) ? $permission += 020 : $permission; // g+w
410
+            $permission = !($permission&0x0004) ? $permission += 04 : $permission; // o+r
411
+            $permission = !($permission&0x0002) ? $permission += 02 : $permission; // o+w
412 412
             $result = chmod($realPath, $permission);
413 413
             if ($verbose) {
414 414
                 if ($result) {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/SecurityType.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -77,8 +77,8 @@
 block discarded – undo
77 77
                     new Assert\NotBlank(),
78 78
                     new Assert\Length(array('max' => $this->appConfig['stext_len'])),
79 79
                     new Assert\Regex(array(
80
-                       'pattern' => "/^[0-9a-zA-Z]+$/",
81
-                   )),
80
+                        'pattern' => "/^[0-9a-zA-Z]+$/",
81
+                    )),
82 82
                 ),
83 83
             ))
84 84
             ->add('admin_allow_hosts', TextareaType::class, array(
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -92,19 +92,19 @@
 block discarded – undo
92 92
                 'label' => 'SSLを強制',
93 93
                 'required' => false,
94 94
             ))
95
-            ->addEventListener(FormEvents::POST_SUBMIT, function ($event) use($app) {
95
+            ->addEventListener(FormEvents::POST_SUBMIT, function($event) use($app) {
96 96
                 $form = $event->getForm();
97 97
                 $data = $form->getData();
98 98
 
99 99
                 $ips = preg_split("/\R/", $data['admin_allow_hosts'], null, PREG_SPLIT_NO_EMPTY);
100 100
 
101
-                foreach($ips as $ip) {
101
+                foreach ($ips as $ip) {
102 102
                     $errors = $this->recursiveValidator->validate($ip, array(
103 103
                             new Assert\Ip(),
104 104
                         )
105 105
                     );
106 106
                     if ($errors->count() != 0) {
107
-                        $form['admin_allow_hosts']->addError(new FormError($ip . 'はIPv4アドレスではありません。'));
107
+                        $form['admin_allow_hosts']->addError(new FormError($ip.'はIPv4アドレスではありません。'));
108 108
                     }
109 109
                 }
110 110
             })
Please login to merge, or discard this patch.
src/Eccube/Resource/config/log.php 1 patch
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php return [
2
-  'log' => 
3
-  [
2
+    'log' => 
3
+    [
4 4
     'suffix' => null,
5 5
     'filename' => 'site',
6 6
     'delimiter' => '_',
@@ -13,8 +13,8 @@  discard block
 block discarded – undo
13 13
     'log_format' => '[%datetime%] %channel%.%level_name% [%session_id%] [%uid%] [%user_id%] [%class%:%function%:%line%] - %message% %context% %extra% [%method%, %url%, %ip%, %referrer%, %user_agent%]',
14 14
     'channel' => 
15 15
     [
16
-      'monolog' => 
17
-      [
16
+        'monolog' => 
17
+        [
18 18
         'name' => 'eccube',
19 19
         'filename' => 'site',
20 20
         'delimiter' => '_',
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
         'max_files' => 90,
26 26
         'log_dateformat' => 'Y-m-d H:i:s,u',
27 27
         'log_format' => '[%datetime%] %channel%.%level_name% [%session_id%] [%uid%] [%user_id%] [%class%:%function%:%line%] - %message% %context% %extra% [%method%, %url%, %ip%, %referrer%, %user_agent%]',
28
-      ],
29
-      'front' => 
30
-      [
28
+        ],
29
+        'front' => 
30
+        [
31 31
         'name' => 'front',
32 32
         'filename' => 'front_site',
33 33
         'delimiter' => '_',
@@ -38,9 +38,9 @@  discard block
 block discarded – undo
38 38
         'max_files' => 90,
39 39
         'log_dateformat' => 'Y-m-d H:i:s,u',
40 40
         'log_format' => '[%datetime%] %channel%.%level_name% [%session_id%] [%uid%] [%user_id%] [%class%:%function%:%line%] - %message% %context% %extra% [%method%, %url%, %ip%, %referrer%, %user_agent%]',
41
-      ],
42
-      'admin' => 
43
-      [
41
+        ],
42
+        'admin' => 
43
+        [
44 44
         'name' => 'admin',
45 45
         'filename' => 'admin_site',
46 46
         'delimiter' => '_',
@@ -51,12 +51,12 @@  discard block
 block discarded – undo
51 51
         'max_files' => 90,
52 52
         'log_dateformat' => 'Y-m-d H:i:s,u',
53 53
         'log_format' => '[%datetime%] %channel%.%level_name% [%session_id%] [%uid%] [%user_id%] [%class%:%function%:%line%] - %message% %context% %extra% [%method%, %url%, %ip%, %referrer%, %user_agent%]',
54
-      ],
54
+        ],
55 55
     ],
56 56
     'exclude_keys' => 
57 57
     [
58
-      'password',
59
-      'app',
58
+        'password',
59
+        'app',
60
+    ],
60 61
     ],
61
-  ],
62 62
 ];
Please login to merge, or discard this patch.
src/Eccube/Resource/config/doctrine_cache.php 1 patch
Indentation   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -1,39 +1,39 @@
 block discarded – undo
1 1
 <?php return [
2
-  'doctrine_cache' => 
3
-  [
2
+    'doctrine_cache' => 
3
+    [
4 4
     'metadata_cache' => 
5 5
     [
6
-      'driver' => 'array',
7
-      'path' => null,
8
-      'host' => null,
9
-      'port' => null,
10
-      'password' => null,
6
+        'driver' => 'array',
7
+        'path' => null,
8
+        'host' => null,
9
+        'port' => null,
10
+        'password' => null,
11 11
     ],
12 12
     'query_cache' => 
13 13
     [
14
-      'driver' => 'array',
15
-      'path' => null,
16
-      'host' => null,
17
-      'port' => null,
18
-      'password' => null,
14
+        'driver' => 'array',
15
+        'path' => null,
16
+        'host' => null,
17
+        'port' => null,
18
+        'password' => null,
19 19
     ],
20 20
     'result_cache' => 
21 21
     [
22
-      'driver' => 'array',
23
-      'path' => null,
24
-      'host' => null,
25
-      'port' => null,
26
-      'password' => null,
27
-      'lifetime' => 3600,
28
-      'clear_cache' => true,
22
+        'driver' => 'array',
23
+        'path' => null,
24
+        'host' => null,
25
+        'port' => null,
26
+        'password' => null,
27
+        'lifetime' => 3600,
28
+        'clear_cache' => true,
29 29
     ],
30 30
     'hydration_cache' => 
31 31
     [
32
-      'driver' => 'array',
33
-      'path' => null,
34
-      'host' => null,
35
-      'port' => null,
36
-      'password' => null,
32
+        'driver' => 'array',
33
+        'path' => null,
34
+        'host' => null,
35
+        'port' => null,
36
+        'password' => null,
37
+    ],
37 38
     ],
38
-  ],
39 39
 ];
Please login to merge, or discard this patch.
install.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     apc_clear_cache();
27 27
 }
28 28
 
29
-require __DIR__ . '/autoload.php';
29
+require __DIR__.'/autoload.php';
30 30
 
31 31
 set_time_limit(0);
32 32
 ini_set('memory_limit', -1);
Please login to merge, or discard this patch.
index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 $loader = require __DIR__.'/autoload.php';
26 26
 
27 27
 ini_set('display_errors', 'Off');
28
-error_reporting(E_ALL & ~E_DEPRECATED & ~E_STRICT);
28
+error_reporting(E_ALL&~E_DEPRECATED&~E_STRICT);
29 29
 
30 30
 // see http://silex.sensiolabs.org/doc/web_servers.html#php-5-4
31 31
 $filename = __DIR__.preg_replace('#(\?.*)$#', '', $_SERVER['REQUEST_URI']);
Please login to merge, or discard this patch.