Complex classes like CartService often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CartService, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
35 | class CartService |
||
|
|||
36 | { |
||
37 | /** @var \Eccube\Application */ |
||
38 | public $app; |
||
39 | |||
40 | /** |
||
41 | * @var Session |
||
42 | */ |
||
43 | private $session; |
||
44 | |||
45 | /** |
||
46 | * @var EntityManager |
||
47 | */ |
||
48 | private $entityManager; |
||
49 | |||
50 | /** |
||
51 | * @var \Eccube\Entity\Cart |
||
52 | */ |
||
53 | private $cart; |
||
54 | |||
55 | /** |
||
56 | * @var \Eccube\Entity\BaseInfo |
||
57 | */ |
||
58 | private $BaseInfo; |
||
59 | |||
60 | /** |
||
61 | * @var array |
||
62 | */ |
||
63 | private $errors = array(); |
||
64 | |||
65 | private $ProductType = null; |
||
66 | |||
67 | /** |
||
68 | * @var array |
||
69 | */ |
||
70 | private $messages = array(); |
||
71 | |||
72 | /** |
||
73 | * @var array |
||
74 | */ |
||
75 | private $error; |
||
76 | |||
77 | 97 | public function __construct(\Eccube\Application $app) |
|
78 | { |
||
79 | 97 | $this->app = $app; |
|
80 | $this->session = $app['session']; |
||
81 | $this->entityManager = $app['orm.em']; |
||
82 | |||
83 | if ($this->session->has('cart')) { |
||
84 | $this->cart = $this->session->get('cart'); |
||
85 | } else { |
||
86 | $this->cart = new \Eccube\Entity\Cart(); |
||
87 | } |
||
88 | |||
89 | $this->loadProductClassFromCart(); |
||
90 | |||
91 | $this->BaseInfo = $app['eccube.repository.base_info']->get(); |
||
92 | } |
||
93 | |||
94 | /** |
||
95 | * カートに保存されている商品の ProductClass エンティティを読み込み、カートへ設定します。 |
||
96 | */ |
||
97 | 97 | protected function loadProductClassFromCart() |
|
112 | |||
113 | /** |
||
114 | * CartItem に対応する ProductClass を設定します。 |
||
115 | * |
||
116 | * @param CartItem $CartItem |
||
117 | */ |
||
118 | 21 | protected function loadProductClassFromCartItem(CartItem $CartItem) |
|
119 | { |
||
120 | $ProductClass = $this |
||
121 | 21 | ->entityManager |
|
122 | ->getRepository($CartItem->getClassName()) |
||
123 | ->find($CartItem->getClassId()); |
||
124 | |||
125 | $CartItem->setObject($ProductClass); |
||
126 | |||
127 | if (is_null($this->ProductType) && $ProductClass->getDelFlg() == Constant::DISABLED) { |
||
128 | $this->setCanAddProductType($ProductClass->getProductType()); |
||
129 | } |
||
130 | } |
||
131 | |||
132 | 58 | public function setCanAddProductType(\Eccube\Entity\Master\ProductType $ProductType) |
|
133 | { |
||
134 | if (is_null($this->ProductType)) { |
||
135 | 58 | $this->ProductType = $ProductType; |
|
136 | } |
||
137 | |||
138 | 50 | return $this; |
|
139 | 50 | } |
|
140 | |||
141 | public function save() |
||
145 | |||
146 | 2 | public function unlock() |
|
147 | { |
||
148 | 2 | $this->cart |
|
149 | 2 | ->setLock(false) |
|
150 | ->setPreOrderId(null); |
||
151 | 2 | } |
|
152 | |||
153 | 11 | public function lock() |
|
154 | { |
||
155 | 11 | $this->cart |
|
156 | 11 | ->setLock(true) |
|
157 | ->setPreOrderId(null); |
||
158 | 11 | } |
|
159 | |||
160 | /** |
||
161 | * @return bool |
||
162 | */ |
||
163 | public function isLocked() |
||
164 | { |
||
165 | return $this->cart->getLock(); |
||
166 | } |
||
167 | |||
168 | /** |
||
169 | * @param string $pre_order_id |
||
170 | * @return \Eccube\Service\CartService |
||
171 | */ |
||
172 | 16 | public function setPreOrderId($pre_order_id) |
|
173 | { |
||
174 | $this->cart->setPreOrderId($pre_order_id); |
||
175 | |||
176 | 16 | return $this; |
|
177 | } |
||
178 | |||
179 | /** |
||
180 | * @return string |
||
181 | */ |
||
182 | public function getPreOrderId() |
||
186 | |||
187 | /** |
||
188 | * @return \Eccube\Service\CartService |
||
189 | */ |
||
190 | 6 | public function clear() |
|
191 | { |
||
192 | 6 | $this->cart |
|
193 | 6 | ->setPreOrderId(null) |
|
194 | 6 | ->setLock(false) |
|
195 | ->clearCartItems(); |
||
196 | |||
197 | 6 | return $this; |
|
198 | } |
||
199 | |||
200 | 1 | public function getCanAddProductType() |
|
201 | { |
||
202 | 1 | return $this->ProductType; |
|
203 | } |
||
204 | |||
205 | /** |
||
206 | * |
||
207 | * @param string $productClassId |
||
208 | * @param integer $quantity |
||
209 | * @return \Eccube\Service\CartService |
||
210 | */ |
||
211 | 16 | public function addProduct($productClassId, $quantity = 1) |
|
212 | { |
||
213 | $quantity += $this->getProductQuantity($productClassId); |
||
214 | 1 | $this->setProductQuantity($productClassId, $quantity); |
|
215 | |||
216 | 16 | return $this; |
|
217 | 3 | } |
|
218 | |||
219 | /** |
||
220 | * @param string $productClassId |
||
221 | * @return integer |
||
222 | */ |
||
223 | 21 | public function getProductQuantity($productClassId) |
|
224 | { |
||
225 | $CartItem = $this->cart->getCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId); |
||
226 | 20 | if ($CartItem) { |
|
227 | return $CartItem->getQuantity(); |
||
228 | } else { |
||
229 | 21 | return 0; |
|
230 | } |
||
231 | } |
||
232 | |||
233 | /** |
||
234 | * @param \Eccube\Entity\ProductClass|integer $ProductClass |
||
235 | * @param integer $quantity |
||
236 | * @return \Eccube\Service\CartService |
||
237 | * @throws CartException |
||
238 | */ |
||
239 | 53 | public function setProductQuantity($ProductClass, $quantity) |
|
240 | { |
||
241 | 53 | if (!$ProductClass instanceof ProductClass) { |
|
242 | 48 | $ProductClass = $this->entityManager |
|
243 | 48 | ->getRepository('Eccube\Entity\ProductClass') |
|
244 | ->find($ProductClass); |
||
245 | 48 | if (!$ProductClass) { |
|
246 | throw new CartException('cart.product.delete'); |
||
247 | } |
||
248 | } |
||
249 | if ($ProductClass->getProduct()->getStatus()->getId() !== Disp::DISPLAY_SHOW) { |
||
250 | $this->removeProduct($ProductClass->getId()); |
||
251 | throw new CartException('cart.product.not.status'); |
||
252 | } |
||
253 | |||
254 | $productName = $ProductClass->getProduct()->getName(); |
||
255 | if ($ProductClass->hasClassCategory1()) { |
||
256 | $productName .= " - ".$ProductClass->getClassCategory1()->getName(); |
||
257 | } |
||
258 | if ($ProductClass->hasClassCategory2()) { |
||
259 | $productName .= " - ".$ProductClass->getClassCategory2()->getName(); |
||
260 | } |
||
261 | |||
262 | // 商品種別に紐づく配送業者を取得 |
||
263 | $deliveries = $this->app['eccube.repository.delivery']->getDeliveries($ProductClass->getProductType()); |
||
264 | |||
265 | if (count($deliveries) == 0) { |
||
266 | // 商品種別が存在しなければエラー |
||
267 | $this->removeProduct($ProductClass->getId()); |
||
268 | $this->addError('cart.product.not.producttype', $productName); |
||
269 | throw new CartException('cart.product.not.producttype'); |
||
270 | } |
||
271 | |||
272 | $this->setCanAddProductType($ProductClass->getProductType()); |
||
273 | |||
274 | if ($this->BaseInfo->getOptionMultipleShipping() != Constant::ENABLED) { |
||
275 | if (!$this->canAddProduct($ProductClass->getId())) { |
||
276 | // 複数配送対応でなければ商品種別が異なればエラー |
||
277 | throw new CartException('cart.product.type.kind'); |
||
278 | } |
||
279 | } else { |
||
280 | // 複数配送の場合、同一支払方法がなければエラー |
||
281 | if (!$this->canAddProductPayment($ProductClass->getProductType())) { |
||
282 | throw new CartException('cart.product.payment.kind'); |
||
283 | } |
||
284 | |||
285 | 50 | } |
|
286 | |||
287 | 51 | $tmp_subtotal = 0; |
|
288 | 51 | $tmp_quantity = 0; |
|
289 | foreach ($this->getCart()->getCartItems() as $cartitem) { |
||
290 | $pc = $cartitem->getObject(); |
||
291 | if ($pc->getId() != $ProductClass->getId()) { |
||
292 | // まず、追加された商品以外のtotal priceをセット |
||
293 | $tmp_subtotal += $cartitem->getTotalPrice(); |
||
294 | } |
||
295 | 51 | } |
|
296 | for ($i = 0; $i < $quantity; $i++) { |
||
297 | $tmp_subtotal += $ProductClass->getPrice02IncTax(); |
||
298 | if ($tmp_subtotal > $this->app['config']['max_total_fee']) { |
||
299 | $this->setError('cart.over.price_limit'); |
||
300 | 1 | break; |
|
301 | } |
||
302 | 46 | $tmp_quantity++; |
|
303 | 1 | } |
|
304 | 51 | $quantity = $tmp_quantity; |
|
305 | |||
306 | 51 | $tmp_quantity = 0; |
|
307 | |||
308 | /* |
||
309 | * 実際の在庫は ProductClass::ProductStock だが、購入時にロックがかかるため、 |
||
310 | * ここでは ProductClass::stock で在庫のチェックをする |
||
311 | */ |
||
312 | if (!$ProductClass->getStockUnlimited() && $quantity > $ProductClass->getStock()) { |
||
313 | if ($ProductClass->getSaleLimit() && $ProductClass->getStock() > $ProductClass->getSaleLimit()) { |
||
314 | $tmp_quantity = $ProductClass->getSaleLimit(); |
||
315 | $this->addError('cart.over.sale_limit', $productName); |
||
316 | } else { |
||
317 | $tmp_quantity = $ProductClass->getStock(); |
||
318 | $this->addError('cart.over.stock', $productName); |
||
319 | 1 | } |
|
320 | } |
||
321 | if ($ProductClass->getSaleLimit() && $quantity > $ProductClass->getSaleLimit()) { |
||
322 | $tmp_quantity = $ProductClass->getSaleLimit(); |
||
323 | $this->addError('cart.over.sale_limit', $productName); |
||
324 | } |
||
325 | 51 | if ($tmp_quantity) { |
|
326 | 2 | $quantity = $tmp_quantity; |
|
327 | } |
||
328 | |||
329 | $CartItem = new CartItem(); |
||
330 | $CartItem |
||
331 | 51 | ->setClassName('Eccube\Entity\ProductClass') |
|
332 | ->setClassId((string) $ProductClass->getId()) |
||
333 | ->setPrice($ProductClass->getPrice02IncTax()) |
||
334 | ->setQuantity($quantity); |
||
335 | |||
336 | $this->cart->setCartItem($CartItem); |
||
337 | |||
338 | 51 | return $this; |
|
339 | } |
||
340 | |||
341 | /** |
||
342 | * @param string $productClassId |
||
343 | * @return boolean |
||
344 | */ |
||
345 | 49 | public function canAddProduct($productClassId) |
|
346 | { |
||
347 | $ProductClass = $this |
||
348 | 49 | ->entityManager |
|
349 | 49 | ->getRepository('\Eccube\Entity\ProductClass') |
|
350 | ->find($productClassId); |
||
351 | |||
352 | 49 | if (!$ProductClass) { |
|
353 | return false; |
||
354 | } |
||
355 | |||
356 | $ProductType = $ProductClass->getProductType(); |
||
357 | |||
358 | 49 | return $this->ProductType == $ProductType; |
|
359 | } |
||
360 | |||
361 | /** |
||
362 | * @param \Eccube\Entity\Master\ProductType $ProductType |
||
363 | * @return bool |
||
364 | */ |
||
365 | 5 | public function canAddProductPayment(\Eccube\Entity\Master\ProductType $ProductType) |
|
366 | { |
||
367 | $deliveries = $this |
||
368 | 1 | ->entityManager |
|
369 | 1 | ->getRepository('\Eccube\Entity\Delivery') |
|
370 | ->findBy(array('ProductType' => $ProductType)); |
||
371 | |||
372 | // 支払方法を取得 |
||
373 | $payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries); |
||
374 | |||
375 | if ($this->getCart()->getTotalPrice() < 1) { |
||
376 | // カートになければ支払方法を全て設定 |
||
377 | $this->getCart()->setPayments($payments); |
||
378 | 5 | return true; |
|
379 | } |
||
380 | |||
381 | // カートに存在している支払方法と追加された商品の支払方法チェック |
||
382 | 2 | $arr = array(); |
|
383 | foreach ($payments as $payment) { |
||
384 | foreach ($this->getCart()->getPayments() as $p) { |
||
385 | if ($payment['id'] == $p['id']) { |
||
386 | 1 | $arr[] = $payment; |
|
387 | 1 | break; |
|
388 | } |
||
389 | } |
||
390 | } |
||
391 | |||
392 | if (count($arr) > 0) { |
||
393 | $this->getCart()->setPayments($arr); |
||
394 | 1 | return true; |
|
395 | } |
||
396 | |||
397 | // 支払条件に一致しない |
||
398 | 1 | return false; |
|
399 | |||
400 | 1 | } |
|
401 | |||
402 | /** |
||
403 | * カートを取得します。 |
||
404 | * |
||
405 | * @return \Eccube\Entity\Cart |
||
406 | */ |
||
407 | 51 | public function getCart() |
|
408 | { |
||
409 | 51 | foreach ($this->cart->getCartItems() as $CartItem) { |
|
410 | $ProductClass = $CartItem->getObject(); |
||
411 | 3 | if (!$ProductClass) { |
|
412 | $this->loadProductClassFromCartItem($CartItem); |
||
413 | |||
414 | $ProductClass = $CartItem->getObject(); |
||
415 | } |
||
416 | |||
417 | if ($ProductClass->getDelFlg() == Constant::DISABLED) { |
||
418 | // 商品情報が有効 |
||
419 | $stockUnlimited = $ProductClass->getStockUnlimited(); |
||
420 | 3 | if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < 1) { |
|
421 | // 在庫がなければカートから削除 |
||
422 | $this->setError('cart.zero.stock'); |
||
423 | $this->removeProduct($ProductClass->getId()); |
||
424 | } else { |
||
425 | $quantity = $CartItem->getQuantity(); |
||
426 | $saleLimit = $ProductClass->getSaleLimit(); |
||
427 | 3 | if ($stockUnlimited == Constant::DISABLED && $ProductClass->getStock() < $quantity) { |
|
428 | // 購入数が在庫数を超えている場合、メッセージを表示 |
||
429 | $this->setError('cart.over.stock'); |
||
430 | } elseif (!is_null($saleLimit) && $saleLimit < $quantity) { |
||
431 | // 購入数が販売制限数を超えている場合、メッセージを表示 |
||
432 | $this->setError('cart.over.sale_limit'); |
||
433 | } |
||
434 | } |
||
435 | } else { |
||
436 | // 商品情報が削除されていたらエラー |
||
437 | $this->setError('cart.product.delete'); |
||
438 | // カートから削除 |
||
439 | $this->removeProduct($ProductClass->getId()); |
||
440 | 3 | } |
|
441 | 51 | } |
|
442 | |||
443 | 51 | return $this->cart; |
|
444 | } |
||
445 | |||
446 | /** |
||
447 | * @param string $productClassId |
||
448 | * @return \Eccube\Service\CartService |
||
449 | */ |
||
450 | 7 | public function removeProduct($productClassId) |
|
451 | { |
||
452 | $this->cart->removeCartItemByIdentifier('Eccube\Entity\ProductClass', (string) $productClassId); |
||
453 | |||
454 | // 支払方法の再設定 |
||
455 | if ($this->BaseInfo->getOptionMultipleShipping() == Constant::ENABLED) { |
||
456 | |||
457 | // 複数配送対応 |
||
458 | 1 | $productTypes = array(); |
|
459 | foreach ($this->getCart()->getCartItems() as $item) { |
||
460 | /* @var $ProductClass \Eccube\Entity\ProductClass */ |
||
461 | $ProductClass = $item->getObject(); |
||
462 | $productTypes[] = $ProductClass->getProductType(); |
||
463 | } |
||
464 | |||
465 | // 配送業者を取得 |
||
466 | $deliveries = $this->entityManager->getRepository('Eccube\Entity\Delivery')->getDeliveries($productTypes); |
||
467 | |||
468 | // 支払方法を取得 |
||
469 | $payments = $this->entityManager->getRepository('Eccube\Entity\Payment')->findAllowedPayments($deliveries); |
||
470 | |||
471 | $this->getCart()->setPayments($payments); |
||
472 | } |
||
473 | |||
474 | 7 | return $this; |
|
475 | } |
||
476 | |||
477 | /** |
||
478 | * @param string $error |
||
479 | * @param string $productName |
||
480 | * @return \Eccube\Service\CartService |
||
481 | */ |
||
482 | 6 | public function addError($error = null, $productName = null) |
|
483 | { |
||
484 | 6 | $this->errors[] = $error; |
|
485 | $this->session->getFlashBag()->add('eccube.front.request.error', $error); |
||
486 | if (!is_null($productName)) { |
||
487 | $this->session->getFlashBag()->add('eccube.front.request.product', $productName); |
||
488 | } |
||
489 | 6 | return $this; |
|
490 | } |
||
491 | |||
492 | /** |
||
493 | * @param string $productClassId |
||
494 | * @return \Eccube\Service\CartService |
||
495 | */ |
||
496 | 2 | public function upProductQuantity($productClassId) |
|
497 | { |
||
498 | $quantity = $this->getProductQuantity($productClassId) + 1; |
||
499 | 1 | $this->setProductQuantity($productClassId, $quantity); |
|
500 | |||
501 | 2 | return $this; |
|
502 | } |
||
503 | |||
504 | /** |
||
505 | * @param string $productClassId |
||
506 | * @return \Eccube\Service\CartService |
||
507 | */ |
||
508 | 4 | public function downProductQuantity($productClassId) |
|
509 | { |
||
510 | $quantity = $this->getProductQuantity($productClassId) - 1; |
||
511 | |||
512 | 4 | if ($quantity > 0) { |
|
513 | $this->setProductQuantity($productClassId, $quantity); |
||
514 | } else { |
||
515 | $this->removeProduct($productClassId); |
||
516 | 1 | } |
|
517 | |||
518 | 4 | return $this; |
|
519 | } |
||
520 | |||
521 | /** |
||
522 | * @return array |
||
523 | */ |
||
524 | 16 | public function getProductTypes() |
|
525 | { |
||
526 | |||
527 | 16 | $productTypes = array(); |
|
528 | foreach ($this->getCart()->getCartItems() as $item) { |
||
529 | /* @var $ProductClass \Eccube\Entity\ProductClass */ |
||
530 | $ProductClass = $item->getObject(); |
||
531 | $productTypes[] = $ProductClass->getProductType(); |
||
532 | } |
||
533 | return array_unique($productTypes); |
||
534 | |||
535 | } |
||
536 | |||
537 | /** |
||
538 | * @return string[] |
||
539 | */ |
||
540 | 2 | public function getErrors() |
|
541 | { |
||
542 | 2 | return $this->errors; |
|
543 | } |
||
544 | |||
545 | /** |
||
546 | * @return string[] |
||
547 | */ |
||
548 | public function getMessages() |
||
552 | |||
553 | /** |
||
554 | * @param string $message |
||
555 | * @return \Eccube\Service\CartService |
||
556 | */ |
||
557 | public function setMessage($message) |
||
563 | |||
564 | /** |
||
565 | * @return string |
||
566 | */ |
||
567 | 1 | public function getError() |
|
568 | { |
||
569 | 1 | return $this->error; |
|
570 | } |
||
571 | |||
572 | /** |
||
573 | * @param string $error |
||
574 | * @return \Eccube\Service\CartService |
||
575 | */ |
||
576 | 1 | public function setError($error = null) |
|
577 | { |
||
578 | 1 | $this->error = $error; |
|
579 | $this->session->getFlashBag()->set('eccube.front.request.error', $error); |
||
580 | 1 | return $this; |
|
581 | } |
||
582 | |||
583 | } |
||
584 |