Failed Conditions
Pull Request — experimental/3.1 (#2561)
by k-yamamura
44:34 queued 05:21
created
src/Eccube/Service/PurchaseFlow/PurchaseFlowResult.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public function getErrors()
55 55
     {
56
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
56
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
57 57
             return $processResult->isError();
58 58
         });
59 59
     }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      */
64 64
     public function getWarning()
65 65
     {
66
-        return array_filter($this->processResults, function (ProcessResult $processResult) {
66
+        return array_filter($this->processResults, function(ProcessResult $processResult) {
67 67
             return $processResult->isWarning();
68 68
         });
69 69
     }
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -59,11 +59,17 @@
 block discarded – undo
59 59
      */
60 60
     protected $formFactory;
61 61
 
62
+    /**
63
+     * @param \Eccube\Application $app
64
+     */
62 65
     protected function getSecurity($app)
63 66
     {
64 67
         return $this->tokenStorage;
65 68
     }
66 69
 
70
+    /**
71
+     * @param \Eccube\Application $app
72
+     */
67 73
     protected function isTokenValid($app)
68 74
     {
69 75
         $csrf = $this->csrfTokenManager;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/FileController.php 2 patches
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -270,6 +270,10 @@  discard block
 block discarded – undo
270 270
         return $str;
271 271
     }
272 272
 
273
+    /**
274
+     * @param string $topDir
275
+     * @param Request $request
276
+     */
273 277
     private function getTree($topDir, $request)
274 278
     {
275 279
         $finder = Finder::create()->in($topDir)
@@ -307,6 +311,10 @@  discard block
 block discarded – undo
307 311
         return $tree;
308 312
     }
309 313
 
314
+    /**
315
+     * @param Application $app
316
+     * @param string $nowDir
317
+     */
310 318
     private function getFileList($app, $nowDir)
311 319
     {
312 320
         $topDir = $this->appConfig['user_data_realdir'];
@@ -366,6 +374,9 @@  discard block
 block discarded – undo
366 374
         return (strpos($targetDir, $topDir) === 0);
367 375
     }
368 376
 
377
+    /**
378
+     * @return string
379
+     */
369 380
     private function convertStrFromServer($target)
370 381
     {
371 382
         if ($this->encode == self::SJIS) {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     private $error = null;
65 65
     private $encode = '';
66 66
 
67
-    public function __construct(){
67
+    public function __construct() {
68 68
         $this->encode = self::UTF;
69 69
         if ('\\' === DIRECTORY_SEPARATOR) {
70 70
             $this->encode = self::SJIS;
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $arrFileList = $this->getFileList($app, $nowDir);
114 114
 
115 115
         $javascript = $this->getJsArrayList($tree);
116
-        $onload = "eccube.fileManager.viewFileTree('tree', arrTree, '" . $nowDir . "', 'tree_select_file', 'tree_status', 'move');";
116
+        $onload = "eccube.fileManager.viewFileTree('tree', arrTree, '".$nowDir."', 'tree_select_file', 'tree_status', 'move');";
117 117
 
118 118
         return [
119 119
             'form' => $form->createView(),
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
                 $nowDir = $this->checkDir($request->get('now_dir'), $topDir)
175 175
                     ? $this->normalizePath($request->get('now_dir'))
176 176
                     : $topDir;
177
-                $fs->mkdir($nowDir . '/' . $filename);
177
+                $fs->mkdir($nowDir.'/'.$filename);
178 178
             }
179 179
         }
180 180
     }
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
     {
260 260
         $str = "arrTree = new Array();\n";
261 261
         foreach ($tree as $key => $val) {
262
-            $str .= 'arrTree[' . $key . "] = new Array(" . $key . ", '" . $val['type'] . "', '" . $val['path'] . "', " . $val['rank'] . ',';
262
+            $str .= 'arrTree['.$key."] = new Array(".$key.", '".$val['type']."', '".$val['path']."', ".$val['rank'].',';
263 263
             if ($val['open']) {
264 264
                 $str .= "true);\n";
265 265
             } else {
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     private function getFileList($app, $nowDir)
311 311
     {
312 312
         $topDir = $this->appConfig['user_data_realdir'];
313
-        $filter = function (\SplFileInfo $file) use ($topDir) {
313
+        $filter = function(\SplFileInfo $file) use ($topDir) {
314 314
             $acceptPath = realpath($topDir);
315 315
             $targetPath = $file->getRealPath();
316 316
             return (strpos($targetPath, $acceptPath) === 0);
Please login to merge, or discard this patch.
src/Eccube/Controller/NonMemberShoppingController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -474,7 +474,7 @@
 block discarded – undo
474 474
      *
475 475
      * @param Application $app
476 476
      * @param array $data リクエストパラメータ
477
-     * @return array
477
+     * @return \Symfony\Component\Validator\ConstraintViolationListInterface[]
478 478
      */
479 479
     protected function customerValidation(Application $app, array $data)
480 480
     {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Front/CustomerAddressType.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,6 @@
 block discarded – undo
59 59
     protected $app;
60 60
 
61 61
     /**
62
-     * @param array $config
63 62
      */
64 63
     public function __construct()
65 64
     {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/SearchProductBlockType.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,6 @@
 block discarded – undo
48 48
     /**
49 49
      * SearchProductType constructor.
50 50
      *
51
-     * @param Application $app
52 51
      */
53 52
     public function __construct()
54 53
     {
Please login to merge, or discard this patch.
src/Eccube/Repository/BlockRepository.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
      * @deprecated 呼び出し元で制御する
50 50
      * @param $block_id
51 51
      * @param $DeviceType
52
-     * @return array|\Eccube\Entity\Block
52
+     * @return Block|null
53 53
      */
54 54
     public function findOrCreate($block_id, $DeviceType)
55 55
     {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
      * ブロック一覧の取得.
112 112
      *
113 113
      * @param  \Eccube\Entity\Master\DeviceType $DeviceType
114
-     * @return array
114
+     * @return null|\Symfony\Component\HttpFoundation\Request
115 115
      */
116 116
     public function getList($DeviceType)
117 117
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@
 block discarded – undo
197 197
             $this->appConfig['block_default_realdir'],
198 198
         );
199 199
         foreach ($readPaths as $readPath) {
200
-            $filePath = $readPath . '/' . $fileName . '.twig';
200
+            $filePath = $readPath.'/'.$fileName.'.twig';
201 201
             $fs = new Filesystem();
202 202
             if ($fs->exists($filePath)) {
203 203
                 return array(
Please login to merge, or discard this patch.
src/Eccube/Repository/DeliveryRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 
41 41
     /**
42 42
      * @deprecated 呼び出し元で制御する
43
-     * @param $id
43
+     * @param integer $id
44 44
      * @return \Eccube\Entity\Delivery|null|object
45 45
      */
46 46
     public function findOrCreate($id)
Please login to merge, or discard this patch.
src/Eccube/Service/ShoppingService.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
     /**
221 221
      * 非会員情報を取得
222 222
      *
223
-     * @param $sesisonKey
223
+     * @param string $sesisonKey
224 224
      * @return $Customer|null
225 225
      */
226 226
     public function getNonMember($sesisonKey)
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     /**
253 253
      * 受注情報を作成
254 254
      *
255
-     * @param $Customer
255
+     * @param null|Customer $Customer
256 256
      * @return \Eccube\Entity\Order
257 257
      */
258 258
     public function createOrder($Customer)
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
      * 仮受注情報作成
282 282
      *
283 283
      * @param $Customer
284
-     * @param $preOrderId
284
+     * @param string $preOrderId
285 285
      * @return mixed
286 286
      * @throws \Doctrine\ORM\NoResultException
287 287
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -1403,7 +1403,7 @@  discard block
 block discarded – undo
1403 1403
      * 受注メール送信を行う
1404 1404
      *
1405 1405
      * @param Order $Order
1406
-     * @return MailHistory
1406
+     * @return null|\Symfony\Component\HttpFoundation\Request
1407 1407
      */
1408 1408
     public function sendOrderMail(Order $Order)
1409 1409
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1117,7 +1117,7 @@
 block discarded – undo
1117 1117
 
1118 1118
         // 配送日数が設定されている
1119 1119
         if ($deliveryDateFlag) {
1120
-            $period = new \DatePeriod (
1120
+            $period = new \DatePeriod(
1121 1121
                 new \DateTime($minDate.' day'),
1122 1122
                 new \DateInterval('P1D'),
1123 1123
                 new \DateTime($minDate + $this->appConfig['deliv_date_end_max'].' day')
Please login to merge, or discard this patch.