Eccube\Controller\Admin\Setting\System\MasterdataController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	index()	0	36	5
C	edit()	0	41	7

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller\Admin\Setting\System;

use Eccube\Application;
use Eccube\Controller\AbstractController;
use Eccube\Form\Type\Admin\MasterdataDataType;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;

class MasterdataController extends AbstractController

Missing class doc comment

{
    public function index(Application $app, Request $request)

Missing function doc comment

    {
        $data = array();

        $builder = $app['form.factory']->createBuilder('admin_system_masterdata');
        $form = $builder->getForm();

        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);
            if ($form->isValid()) {
                $data = $form->getData();

                if ($data['masterdata']) {
                    $masterdata = $app['orm.em']->getRepository($data['masterdata'])->findBy(array(), array('rank' => 'ASC'));

                    foreach ($masterdata as $key => $value) {
                        $data['data'][$value['rank']]['id'] = $value['id'];
                        $data['data'][$value['rank']]['name'] = $value['name'];
                    }

                    $data['data'][$value['rank']+1]['id'] = '';

The variable $value seems to be defined by a foreach iteration on line 51. Are you sure the iterator is never empty, otherwise this variable is not defined?

                    $data['data'][$value['rank']+1]['name'] = '';

                    $data['masterdata_name'] = $data['masterdata'];
                }
            }
        }

        $builder2 = $app['form.factory']->createBuilder('admin_system_masterdata_edit', $data);
        $form2 = $builder2->getForm();

        return $app->render('Setting/System/masterdata.twig', array(
            'form' => $form->createView(),
            'form2' => $form2->createView(),
        ));
    }

    public function edit(Application $app, Request $request)

Missing function doc comment

    {
        $builder2 = $app['form.factory']->createBuilder('admin_system_masterdata_edit');
        $form2 = $builder2->getForm();

        if ('POST' === $request->getMethod()) {
            $form2->handleRequest($request);

            if ($form2->isValid()) {
                $data = $form2->getData();

                $entity = new $data['masterdata_name']();

Use parentheses when instantiating classes

                foreach ($data['data'] as $key => $value) {
                    if ($value['id'] !== null && $value['name'] !== null) {
                        $entity->setId($value['id']);
                        $entity->setName($value['name']);
                        $entity->setRank($key);
                        $app['orm.em']->merge($entity);
                    } else {
                        // remove
                        $rank = $app['orm.em']->getRepository($data['masterdata_name'])->findOneBy(array('rank' => $key));
                        if ($rank) {
                            $app['orm.em']->remove($rank);
                        }
                    }
                }
                $app['orm.em']->flush();
                $app->addSuccess('admin.register.complete', 'admin');

                return $app->redirect($app->url('admin_setting_system_masterdata'));
            }
        }

        $builder = $app['form.factory']->createBuilder('admin_system_masterdata');
        $form = $builder->getForm();

        return $app->render('Setting/System/masterdata.twig', array(
            'form' => $form->createView(),
            'form2' => $form2->createView(),
        ));
    }
}