Failed Conditions
Pull Request — master (#1399)
by Shinichi
28:03
created
src/Eccube/Controller/Admin/Store/TemplateController.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use Eccube\Entity\Master\DeviceType;
29 29
 use Eccube\Util\Str;
30 30
 use Symfony\Component\Filesystem\Filesystem;
31
-use Symfony\Component\Finder\Finder;
32 31
 use Symfony\Component\Form\FormError;
33 32
 use Symfony\Component\HttpFoundation\Request;
34 33
 use Symfony\Component\HttpFoundation\Response;
Please login to merge, or discard this patch.
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -65,15 +65,15 @@  discard block
 block discarded – undo
65 65
                     ->find($form['selected']->getData());
66 66
 
67 67
                 // path.ymlの再構築
68
-                $file = $app['config']['root_dir'] . '/app/config/eccube/path.yml';
68
+                $file = $app['config']['root_dir'].'/app/config/eccube/path.yml';
69 69
                 $config = Yaml::parse($file);
70 70
 
71 71
                 $templateCode = $Template->getCode();
72 72
                 $config['template_code'] = $templateCode;
73
-                $config['template_realdir'] = $config['root_dir'] . '/app/template/' . $templateCode;
74
-                $config['template_html_realdir'] = $config['root_dir'] . '/html/template/' . $templateCode;
75
-                $config['front_urlpath'] = $config['root_urlpath'] . '/template/' . $templateCode;
76
-                $config['block_realdir'] =$config['template_realdir'] . '/Block';
73
+                $config['template_realdir'] = $config['root_dir'].'/app/template/'.$templateCode;
74
+                $config['template_html_realdir'] = $config['root_dir'].'/html/template/'.$templateCode;
75
+                $config['front_urlpath'] = $config['root_urlpath'].'/template/'.$templateCode;
76
+                $config['block_realdir'] = $config['template_realdir'].'/Block';
77 77
 
78 78
                 file_put_contents($file, Yaml::dump($config));
79 79
 
@@ -108,19 +108,19 @@  discard block
 block discarded – undo
108 108
         // 該当テンプレートのディレクトリ
109 109
         $config = $app['config'];
110 110
         $templateCode = $Template->getCode();
111
-        $targetRealDir = $config['root_dir'] . '/app/template/' . $templateCode;
112
-        $targetHtmlRealDir = $config['root_dir'] . '/html/template/' . $templateCode;
111
+        $targetRealDir = $config['root_dir'].'/app/template/'.$templateCode;
112
+        $targetHtmlRealDir = $config['root_dir'].'/html/template/'.$templateCode;
113 113
 
114 114
         // 一時ディレクトリ
115 115
         $uniqId = sha1(Str::random(32));
116
-        $tmpDir = $config['template_temp_realdir'] . '/' . $uniqId;
117
-        $appDir = $tmpDir . '/app';
118
-        $htmlDir = $tmpDir . '/html';
116
+        $tmpDir = $config['template_temp_realdir'].'/'.$uniqId;
117
+        $appDir = $tmpDir.'/app';
118
+        $htmlDir = $tmpDir.'/html';
119 119
 
120 120
         // ファイル名
121
-        $tarFile = $config['template_temp_realdir'] . '/' . $uniqId . '.tar';
122
-        $tarGzFile = $tarFile . '.gz';
123
-        $downloadFileName = $Template->getCode() . '.tar.gz';
121
+        $tarFile = $config['template_temp_realdir'].'/'.$uniqId.'.tar';
122
+        $tarGzFile = $tarFile.'.gz';
123
+        $downloadFileName = $Template->getCode().'.tar.gz';
124 124
 
125 125
         // 該当テンプレートを一時ディレクトリへコピーする.
126 126
         $fs = new Filesystem();
@@ -140,14 +140,14 @@  discard block
 block discarded – undo
140 140
 
141 141
         // ダウンロード完了後にファイルを削除する.
142 142
         // http://stackoverflow.com/questions/15238897/removing-file-after-delivering-response-with-silex-symfony
143
-        $app->finish(function (Request $request, Response $response, \Silex\Application $app) use (
143
+        $app->finish(function(Request $request, Response $response, \Silex\Application $app) use (
144 144
             $tmpDir,
145 145
             $tarFile,
146 146
             $tarGzFile
147 147
         ) {
148
-            $app['monolog']->addDebug('remove temp file: ' . $tmpDir);
149
-            $app['monolog']->addDebug('remove temp file: ' . $tarFile);
150
-            $app['monolog']->addDebug('remove temp file: ' . $tarGzFile);
148
+            $app['monolog']->addDebug('remove temp file: '.$tmpDir);
149
+            $app['monolog']->addDebug('remove temp file: '.$tarFile);
150
+            $app['monolog']->addDebug('remove temp file: '.$tarGzFile);
151 151
             $fs = new Filesystem();
152 152
             $fs->remove($tmpDir);
153 153
             $fs->remove($tarFile);
@@ -188,8 +188,8 @@  discard block
 block discarded – undo
188 188
         // テンプレートディレクトリの削除
189 189
         $config = $app['config'];
190 190
         $templateCode = $Template->getCode();
191
-        $targetRealDir = $config['root_dir'] . '/app/template/' . $templateCode;
192
-        $targetHtmlRealDir = $config['root_dir'] . '/html/template/' . $templateCode;
191
+        $targetRealDir = $config['root_dir'].'/app/template/'.$templateCode;
192
+        $targetHtmlRealDir = $config['root_dir'].'/html/template/'.$templateCode;
193 193
 
194 194
         $fs = new Filesystem();
195 195
         $fs->remove($targetRealDir);
@@ -232,18 +232,18 @@  discard block
 block discarded – undo
232 232
                 // 該当テンプレートのディレクトリ
233 233
                 $config = $app['config'];
234 234
                 $templateCode = $Template->getCode();
235
-                $targetRealDir = $config['root_dir'] . '/app/template/' . $templateCode;
236
-                $targetHtmlRealDir = $config['root_dir'] . '/html/template/' . $templateCode;
235
+                $targetRealDir = $config['root_dir'].'/app/template/'.$templateCode;
236
+                $targetHtmlRealDir = $config['root_dir'].'/html/template/'.$templateCode;
237 237
 
238 238
                 // 一時ディレクトリ
239 239
                 $uniqId = sha1(Str::random(32));
240
-                $tmpDir = $config['template_temp_realdir'] . '/' . $uniqId;
241
-                $appDir = $tmpDir . '/app';
242
-                $htmlDir = $tmpDir . '/html';
240
+                $tmpDir = $config['template_temp_realdir'].'/'.$uniqId;
241
+                $appDir = $tmpDir.'/app';
242
+                $htmlDir = $tmpDir.'/html';
243 243
 
244 244
                 $formFile = $form['file']->getData();
245 245
                 // ファイル名
246
-                $archive = $templateCode . '.' . $formFile->getClientOriginalExtension();
246
+                $archive = $templateCode.'.'.$formFile->getClientOriginalExtension();
247 247
 
248 248
                 // ファイルを一時ディレクトリへ移動.
249 249
                 $formFile->move($tmpDir, $archive);
@@ -252,11 +252,11 @@  discard block
 block discarded – undo
252 252
                 try {
253 253
                     if ($formFile->getClientOriginalExtension() == 'zip') {
254 254
                         $zip = new \ZipArchive();
255
-                        $zip->open($tmpDir . '/' . $archive);
255
+                        $zip->open($tmpDir.'/'.$archive);
256 256
                         $zip->extractTo($tmpDir);
257 257
                         $zip->close();
258 258
                     } else {
259
-                        $phar = new \PharData($tmpDir . '/' . $archive);
259
+                        $phar = new \PharData($tmpDir.'/'.$archive);
260 260
                         $phar->extractTo($tmpDir, null, true);
261 261
                     }
262 262
                 } catch (\Exception $e) {
Please login to merge, or discard this patch.
src/Eccube/Controller/Install/InstallController.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -250,6 +250,9 @@
 block discarded – undo
250 250
     }
251 251
 
252 252
 
253
+    /**
254
+     * @param InstallApplication $app
255
+     */
253 256
     private function checkModules($app)
254 257
     {
255 258
         foreach ($this->required_modules as $module) {
Please login to merge, or discard this patch.
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -60,9 +60,9 @@  discard block
 block discarded – undo
60 60
 
61 61
     public function __construct()
62 62
     {
63
-        $this->config_path = __DIR__ . '/../../../../app/config/eccube';
64
-        $this->dist_path = __DIR__ . '/../../Resource/config';
65
-        $this->cache_path = __DIR__ . '/../../../../app/cache';
63
+        $this->config_path = __DIR__.'/../../../../app/config/eccube';
64
+        $this->dist_path = __DIR__.'/../../Resource/config';
65
+        $this->cache_path = __DIR__.'/../../../../app/cache';
66 66
     }
67 67
 
68 68
     private function isValid(Request $request, Form $form)
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 
148 148
         if (empty($sessionData['shop_name'])) {
149 149
 
150
-            $config_file = $this->config_path . '/config.yml';
150
+            $config_file = $this->config_path.'/config.yml';
151 151
             $fs = new Filesystem();
152 152
 
153 153
             if ($fs->exists($config_file)) {
@@ -161,21 +161,21 @@  discard block
 block discarded – undo
161 161
                 }
162 162
 
163 163
                 // セキュリティの設定
164
-                $config_file = $this->config_path . '/path.yml';
164
+                $config_file = $this->config_path.'/path.yml';
165 165
                 $config = Yaml::parse(file_get_contents($config_file));
166 166
                 $sessionData['admin_dir'] = $config['admin_route'];
167 167
 
168
-                $config_file = $this->config_path . '/config.yml';
168
+                $config_file = $this->config_path.'/config.yml';
169 169
                 $config = Yaml::parse(file_get_contents($config_file));
170 170
 
171 171
                 $allowHost = $config['admin_allow_host'];
172 172
                 if (count($allowHost) > 0) {
173 173
                     $sessionData['admin_allow_hosts'] = Str::convertLineFeed(implode("\n", $allowHost));
174 174
                 }
175
-                $sessionData['admin_force_ssl'] = (bool)$config['force_ssl'];
175
+                $sessionData['admin_force_ssl'] = (bool) $config['force_ssl'];
176 176
 
177 177
                 // メール設定
178
-                $config_file = $this->config_path . '/mail.yml';
178
+                $config_file = $this->config_path.'/mail.yml';
179 179
                 $config = Yaml::parse(file_get_contents($config_file));
180 180
                 $mail = $config['mail'];
181 181
                 $sessionData['mail_backend'] = $mail['transport'];
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 
213 213
         if (empty($sessionData['database'])) {
214 214
 
215
-            $config_file = $this->config_path . '/database.yml';
215
+            $config_file = $this->config_path.'/database.yml';
216 216
             $fs = new Filesystem();
217 217
 
218 218
             if ($fs->exists($config_file)) {
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
                 $host = $request->getSchemeAndHttpHost();
286 286
                 $basePath = $request->getBasePath();
287 287
                 $params = array(
288
-                    'http_url' => $host . $basePath,
288
+                    'http_url' => $host.$basePath,
289 289
                     'shop_name' => $sessionData['shop_name'],
290 290
                 );
291 291
 
@@ -306,13 +306,13 @@  discard block
 block discarded – undo
306 306
     //    インストール完了
307 307
     public function complete(InstallApplication $app, Request $request)
308 308
     {
309
-        $config_file = $this->config_path . '/path.yml';
309
+        $config_file = $this->config_path.'/path.yml';
310 310
         $config = Yaml::parse(file_get_contents($config_file));
311 311
 
312 312
         $host = $request->getSchemeAndHttpHost();
313 313
         $basePath = $request->getBasePath();
314 314
 
315
-        $adminUrl = $host . $basePath . '/' . $config['admin_dir'];
315
+        $adminUrl = $host.$basePath.'/'.$config['admin_dir'];
316 316
 
317 317
         return $app['twig']->render('complete.twig', array(
318 318
             'admin_url' => $adminUrl,
@@ -332,17 +332,17 @@  discard block
 block discarded – undo
332 332
     {
333 333
         foreach ($this->required_modules as $module) {
334 334
             if (!extension_loaded($module)) {
335
-                $app->addDanger('[必須] ' . $module . ' 拡張モジュールが有効になっていません。', 'install');
335
+                $app->addDanger('[必須] '.$module.' 拡張モジュールが有効になっていません。', 'install');
336 336
             }
337 337
         }
338 338
 
339 339
         if (!extension_loaded('pdo_mysql') && !extension_loaded('pdo_pgsql')) {
340
-            $app->addDanger('[必須] ' . 'pdo_pgsql又はpdo_mysql 拡張モジュールを有効にしてください。', 'install');
340
+            $app->addDanger('[必須] '.'pdo_pgsql又はpdo_mysql 拡張モジュールを有効にしてください。', 'install');
341 341
         }
342 342
 
343 343
         foreach ($this->recommended_module as $module) {
344 344
             if (!extension_loaded($module)) {
345
-                $app->addWarning('[推奨] ' . $module . ' 拡張モジュールが有効になっていません。', 'install');
345
+                $app->addWarning('[推奨] '.$module.' 拡張モジュールが有効になっていません。', 'install');
346 346
             }
347 347
         }
348 348
 
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
             if (!function_exists('apache_get_modules')) {
361 361
                 $app->addWarning('mod_rewrite が有効になっているか不明です。', 'install');
362 362
             } elseif (!in_array('mod_rewrite', apache_get_modules())) {
363
-                $app->addDanger('[必須] ' . 'mod_rewriteを有効にしてください。', 'install');
363
+                $app->addDanger('[必須] '.'mod_rewriteを有効にしてください。', 'install');
364 364
             }
365 365
         } elseif (isset($_SERVER['SERVER_SOFTWARE']) && strpos('Microsoft-IIS', $_SERVER['SERVER_SOFTWARE']) !== false) {
366 366
             // iis
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
 
372 372
     private function setPDO()
373 373
     {
374
-        $config_file = $this->config_path . '/database.yml';
374
+        $config_file = $this->config_path.'/database.yml';
375 375
         $config = Yaml::parse(file_get_contents($config_file));
376 376
 
377 377
         try {
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
      */
407 407
     private function getEntityManager()
408 408
     {
409
-        $config_file = $this->config_path . '/database.yml';
409
+        $config_file = $this->config_path.'/database.yml';
410 410
         $database = Yaml::parse(file_get_contents($config_file));
411 411
 
412 412
         $this->app->register(new \Silex\Provider\DoctrineServiceProvider(), array(
@@ -414,15 +414,15 @@  discard block
 block discarded – undo
414 414
         ));
415 415
 
416 416
         $this->app->register(new \Dflydev\Silex\Provider\DoctrineOrm\DoctrineOrmServiceProvider(), array(
417
-            'orm.proxies_dir' => __DIR__ . '/../../app/cache/doctrine',
417
+            'orm.proxies_dir' => __DIR__.'/../../app/cache/doctrine',
418 418
             'orm.em.options' => array(
419 419
                 'mappings' => array(
420 420
                     array(
421 421
                         'type' => 'yml',
422 422
                         'namespace' => 'Eccube\Entity',
423 423
                         'path' => array(
424
-                            __DIR__ . '/../../Resource/doctrine',
425
-                            __DIR__ . '/../../Resource/doctrine/master',
424
+                            __DIR__.'/../../Resource/doctrine',
425
+                            __DIR__.'/../../Resource/doctrine/master',
426 426
                         ),
427 427
                     ),
428 428
 
@@ -450,11 +450,11 @@  discard block
 block discarded – undo
450 450
     {
451 451
         $this->resetNatTimer();
452 452
 
453
-        $config_file = $this->config_path . '/database.yml';
453
+        $config_file = $this->config_path.'/database.yml';
454 454
         $database = Yaml::parse(file_get_contents($config_file));
455 455
         $config['database'] = $database['database'];
456 456
 
457
-        $config_file = $this->config_path . '/config.yml';
457
+        $config_file = $this->config_path.'/config.yml';
458 458
         $baseConfig = Yaml::parse(file_get_contents($config_file));
459 459
         $config['config'] = $baseConfig;
460 460
 
@@ -510,11 +510,11 @@  discard block
 block discarded – undo
510 510
     {
511 511
         $this->resetNatTimer();
512 512
 
513
-        $config_file = $this->config_path . '/database.yml';
513
+        $config_file = $this->config_path.'/database.yml';
514 514
         $database = Yaml::parse(file_get_contents($config_file));
515 515
         $config['database'] = $database['database'];
516 516
 
517
-        $config_file = $this->config_path . '/config.yml';
517
+        $config_file = $this->config_path.'/config.yml';
518 518
         $baseConfig = Yaml::parse(file_get_contents($config_file));
519 519
         $config['config'] = $baseConfig;
520 520
 
@@ -579,7 +579,7 @@  discard block
 block discarded – undo
579 579
         $config = new Configuration($app['db']);
580 580
         $config->setMigrationsNamespace('DoctrineMigrations');
581 581
 
582
-        $migrationDir = __DIR__ . '/../../Resource/doctrine/migration';
582
+        $migrationDir = __DIR__.'/../../Resource/doctrine/migration';
583 583
         $config->setMigrationsDirectory($migrationDir);
584 584
         $config->registerMigrationsFromDirectory($migrationDir);
585 585
 
@@ -610,7 +610,7 @@  discard block
 block discarded – undo
610 610
     private function getProtectedDirs()
611 611
     {
612 612
         $protectedDirs = array();
613
-        $base = __DIR__ . '/../../../..';
613
+        $base = __DIR__.'/../../../..';
614 614
         $dirs = array(
615 615
             '/html',
616 616
             '/app',
@@ -623,7 +623,7 @@  discard block
 block discarded – undo
623 623
         );
624 624
 
625 625
         foreach ($dirs as $dir) {
626
-            if (!is_writable($base . $dir)) {
626
+            if (!is_writable($base.$dir)) {
627 627
                 $protectedDirs[] = $dir;
628 628
             }
629 629
         }
@@ -634,7 +634,7 @@  discard block
 block discarded – undo
634 634
     private function createConfigYamlFile($data, $auth = true)
635 635
     {
636 636
         $fs = new Filesystem();
637
-        $config_file = $this->config_path . '/config.yml';
637
+        $config_file = $this->config_path.'/config.yml';
638 638
 
639 639
         if ($fs->exists($config_file)) {
640 640
             $config = Yaml::parse(file_get_contents($config_file));
@@ -665,7 +665,7 @@  discard block
 block discarded – undo
665 665
         $content = str_replace(
666 666
             $target,
667 667
             $replace,
668
-            file_get_contents($this->dist_path . '/config.yml.dist')
668
+            file_get_contents($this->dist_path.'/config.yml.dist')
669 669
         );
670 670
         $fs->dumpFile($config_file, $content);
671 671
 
@@ -679,7 +679,7 @@  discard block
 block discarded – undo
679 679
 
680 680
     private function addInstallStatus()
681 681
     {
682
-        $config_file = $this->config_path . '/config.yml';
682
+        $config_file = $this->config_path.'/config.yml';
683 683
         $config = Yaml::parse(file_get_contents($config_file));
684 684
         $config['eccube_install'] = 1;
685 685
         $yml = Yaml::dump($config);
@@ -691,7 +691,7 @@  discard block
 block discarded – undo
691 691
     private function createDatabaseYamlFile($data)
692 692
     {
693 693
         $fs = new Filesystem();
694
-        $config_file = $this->config_path . '/database.yml';
694
+        $config_file = $this->config_path.'/database.yml';
695 695
         if ($fs->exists($config_file)) {
696 696
             $fs->remove($config_file);
697 697
         }
@@ -725,7 +725,7 @@  discard block
 block discarded – undo
725 725
             $content = str_replace(
726 726
                 $target,
727 727
                 $replace,
728
-                file_get_contents($this->dist_path . '/database.yml.dist')
728
+                file_get_contents($this->dist_path.'/database.yml.dist')
729 729
             );
730 730
 
731 731
         } else {
@@ -733,7 +733,7 @@  discard block
 block discarded – undo
733 733
                 array(
734 734
                     'database' => array(
735 735
                         'driver' => 'pdo_sqlite',
736
-                        'path' => realpath($this->config_path . '/eccube.db')
736
+                        'path' => realpath($this->config_path.'/eccube.db')
737 737
                     )
738 738
                 )
739 739
             );
@@ -746,7 +746,7 @@  discard block
 block discarded – undo
746 746
     private function createMailYamlFile($data)
747 747
     {
748 748
         $fs = new Filesystem();
749
-        $config_file = $this->config_path . '/mail.yml';
749
+        $config_file = $this->config_path.'/mail.yml';
750 750
         if ($fs->exists($config_file)) {
751 751
             $fs->remove($config_file);
752 752
         }
@@ -763,7 +763,7 @@  discard block
 block discarded – undo
763 763
         $content = str_replace(
764 764
             $target,
765 765
             $replace,
766
-            file_get_contents($this->dist_path . '/mail.yml.dist')
766
+            file_get_contents($this->dist_path.'/mail.yml.dist')
767 767
         );
768 768
         $fs->dumpFile($config_file, $content);
769 769
 
@@ -773,7 +773,7 @@  discard block
 block discarded – undo
773 773
     private function createPathYamlFile($data, Request $request)
774 774
     {
775 775
         $fs = new Filesystem();
776
-        $config_file = $this->config_path . '/path.yml';
776
+        $config_file = $this->config_path.'/path.yml';
777 777
         if ($fs->exists($config_file)) {
778 778
             $fs->remove($config_file);
779 779
         }
@@ -781,7 +781,7 @@  discard block
 block discarded – undo
781 781
         $ADMIN_ROUTE = $data['admin_dir'];
782 782
         $TEMPLATE_CODE = 'default';
783 783
         $USER_DATA_ROUTE = 'user_data';
784
-        $ROOT_DIR = realpath(__DIR__ . '/../../../../');
784
+        $ROOT_DIR = realpath(__DIR__.'/../../../../');
785 785
         $ROOT_URLPATH = $request->getBasePath();
786 786
 
787 787
         $target = array('${ADMIN_ROUTE}', '${TEMPLATE_CODE}', '${USER_DATA_ROUTE}', '${ROOT_DIR}', '${ROOT_URLPATH}');
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
         $content = str_replace(
792 792
             $target,
793 793
             $replace,
794
-            file_get_contents($this->dist_path . '/path.yml.dist')
794
+            file_get_contents($this->dist_path.'/path.yml.dist')
795 795
         );
796 796
         $fs->dumpFile($config_file, $content);
797 797
 
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
 
801 801
     private function sendAppData($params)
802 802
     {
803
-        $config_file = $this->config_path . '/database.yml';
803
+        $config_file = $this->config_path.'/database.yml';
804 804
         $db_config = Yaml::parse(file_get_contents($config_file));
805 805
 
806 806
         $this->setPDO();
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
         }
813 813
 
814 814
         if ($db_config['database']['driver'] === 'pdo_mysql') {
815
-            $db_ver = 'MySQL:' . $version;
815
+            $db_ver = 'MySQL:'.$version;
816 816
         } else {
817 817
             $db_ver = $version;
818 818
         }
@@ -830,7 +830,7 @@  discard block
 block discarded – undo
830 830
 
831 831
         $header = array(
832 832
             'Content-Type: application/x-www-form-urlencoded',
833
-            'Content-Length: ' . strlen($data),
833
+            'Content-Length: '.strlen($data),
834 834
         );
835 835
         $context = stream_context_create(
836 836
             array(
Please login to merge, or discard this patch.
src/Eccube/Controller/Mypage/DeliveryController.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
      * Index
36 36
      *
37 37
      * @param  Application $app
38
-     * @return string
38
+     * @return \Symfony\Component\HttpFoundation\Response
39 39
      */
40 40
     public function index(Application $app, Request $request)
41 41
     {
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      *
52 52
      * @param  Application $app
53 53
      * @request  Symfony\Component\HttpFoundation\Request $app
54
-     * @return mixed
54
+     * @return \Symfony\Component\HttpFoundation\Response
55 55
      */
56 56
     public function edit(Application $app, Request $request, $id = null)
57 57
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
 
80 80
         // 遷移が正しくない場合、デフォルトであるマイページの配送先追加の画面を設定する
81 81
         if (!in_array($parentPage, $allowdParents)) {
82
-            $parentPage  = $app->url('mypage_delivery');
82
+            $parentPage = $app->url('mypage_delivery');
83 83
         }
84 84
 
85 85
         /* @var $form \Symfony\Component\Form\FormInterface */
Please login to merge, or discard this patch.
src/Eccube/Controller/Mypage/MypageController.php 1 patch
Doc Comments   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      * @param Application $app
63 63
      * @param Request     $request
64 64
      *
65
-     * @return string
65
+     * @return \Symfony\Component\HttpFoundation\Response
66 66
      */
67 67
     public function index(Application $app, Request $request)
68 68
     {
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
      * @param Application $app
90 90
      * @param Request     $request
91 91
      *
92
-     * @return string
92
+     * @return \Symfony\Component\HttpFoundation\Response
93 93
      */
94 94
     public function history(Application $app, Request $request, $id)
95 95
     {
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
      * @param Request     $request
119 119
      * @param id     $id
120 120
      *
121
-     * @return string
121
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
122 122
      */
123 123
     public function order(Application $app, Request $request, $id)
124 124
     {
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
      * @param Application $app
156 156
      * @param Request     $request
157 157
      *
158
-     * @return string
158
+     * @return \Symfony\Component\HttpFoundation\Response
159 159
      */
160 160
     public function favorite(Application $app, Request $request)
161 161
     {
@@ -182,9 +182,8 @@  discard block
 block discarded – undo
182 182
 
183 183
     /**
184 184
      * @param Application $app
185
-     * @param Request     $request
186 185
      *
187
-     * @return string
186
+     * @return \Symfony\Component\HttpFoundation\RedirectResponse
188 187
      */
189 188
     public function delete(Application $app, $id)
190 189
     {
Please login to merge, or discard this patch.
src/Eccube/Controller/Mypage/WithdrawController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
      * Complete
88 88
      *
89 89
      * @param  Application $app
90
-     * @return mixed
90
+     * @return \Symfony\Component\HttpFoundation\Response
91 91
      */
92 92
     public function complete(Application $app, Request $request)
93 93
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
                         // 会員削除
63 63
                         $email = $Customer->getEmail();
64 64
                         // メールアドレスにダミーをセット
65
-                        $Customer->setEmail(Str::random(60) . '@dummy.dummy');
65
+                        $Customer->setEmail(Str::random(60).'@dummy.dummy');
66 66
                         $Customer->setDelFlg(Constant::ENABLED);
67 67
 
68 68
                         $app['orm.em']->flush();
Please login to merge, or discard this patch.
src/Eccube/Controller/ShoppingController.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -1188,6 +1188,7 @@
 block discarded – undo
1188 1188
 
1189 1189
     /**
1190 1190
      * 非会員でのお客様情報変更時の入力チェック
1191
+     * @param Application $app
1191 1192
      */
1192 1193
     private function customerValidation($app, $data) {
1193 1194
 
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
 
222 222
                 $MailHistory = new MailHistory();
223 223
                 $MailHistory
224
-                    ->setSubject('[' . $app['eccube.repository.base_info']->get()->getShopName() . '] ' . $MailTemplate->getSubject())
224
+                    ->setSubject('['.$app['eccube.repository.base_info']->get()->getShopName().'] '.$MailTemplate->getSubject())
225 225
                     ->setMailBody($body)
226 226
                     ->setMailTemplate($MailTemplate)
227 227
                     ->setSendDate(new \DateTime())
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
                 ->setFax03($CustomerAddress->getFax03())
494 494
                 ->setZip01($CustomerAddress->getZip01())
495 495
                 ->setZip02($CustomerAddress->getZip02())
496
-                ->setZipCode($CustomerAddress->getZip01() . $CustomerAddress->getZip02())
496
+                ->setZipCode($CustomerAddress->getZip01().$CustomerAddress->getZip02())
497 497
                 ->setPref($CustomerAddress->getPref())
498 498
                 ->setAddr01($CustomerAddress->getAddr01())
499 499
                 ->setAddr02($CustomerAddress->getAddr02());
@@ -619,7 +619,7 @@  discard block
 block discarded – undo
619 619
                         ->setTel03($data['tel03'])
620 620
                         ->setZip01($data['zip01'])
621 621
                         ->setZip02($data['zip02'])
622
-                        ->setZipCode($data['zip01'] . $data['zip02'])
622
+                        ->setZipCode($data['zip01'].$data['zip02'])
623 623
                         ->setPref($data['pref'])
624 624
                         ->setAddr01($data['addr01'])
625 625
                         ->setAddr02($data['addr02'])
@@ -640,7 +640,7 @@  discard block
 block discarded – undo
640 640
                     ->setTel03($data['tel03'])
641 641
                     ->setZip01($data['zip01'])
642 642
                     ->setZip02($data['zip02'])
643
-                    ->setZipCode($data['zip01'] . $data['zip02'])
643
+                    ->setZipCode($data['zip01'].$data['zip02'])
644 644
                     ->setPref($data['pref'])
645 645
                     ->setAddr01($data['addr01'])
646 646
                     ->setAddr02($data['addr02']);
@@ -706,7 +706,7 @@  discard block
 block discarded – undo
706 706
                     ->setTel03($data['customer_tel03'])
707 707
                     ->setZip01($data['customer_zip01'])
708 708
                     ->setZip02($data['customer_zip02'])
709
-                    ->setZipCode($data['customer_zip01'] . $data['customer_zip02'])
709
+                    ->setZipCode($data['customer_zip01'].$data['customer_zip02'])
710 710
                     ->setPref($pref)
711 711
                     ->setAddr01($data['customer_addr01'])
712 712
                     ->setAddr02($data['customer_addr02'])
@@ -812,7 +812,7 @@  discard block
 block discarded – undo
812 812
                     ->setTel03($data['tel03'])
813 813
                     ->setZip01($data['zip01'])
814 814
                     ->setZip02($data['zip02'])
815
-                    ->setZipCode($data['zip01'] . $data['zip02'])
815
+                    ->setZipCode($data['zip01'].$data['zip02'])
816 816
                     ->setPref($data['pref'])
817 817
                     ->setAddr01($data['addr01'])
818 818
                     ->setAddr02($data['addr02']);
@@ -831,7 +831,7 @@  discard block
 block discarded – undo
831 831
                     ->setTel03($data['tel03'])
832 832
                     ->setZip01($data['zip01'])
833 833
                     ->setZip02($data['zip02'])
834
-                    ->setZipCode($data['zip01'] . $data['zip02'])
834
+                    ->setZipCode($data['zip01'].$data['zip02'])
835 835
                     ->setPref($data['pref'])
836 836
                     ->setAddr01($data['addr01'])
837 837
                     ->setAddr02($data['addr02'])
@@ -1055,7 +1055,7 @@  discard block
 block discarded – undo
1055 1055
                                 ->setFax03($CustomerAddress->getFax03())
1056 1056
                                 ->setZip01($CustomerAddress->getZip01())
1057 1057
                                 ->setZip02($CustomerAddress->getZip02())
1058
-                                ->setZipCode($CustomerAddress->getZip01() . $CustomerAddress->getZip02())
1058
+                                ->setZipCode($CustomerAddress->getZip01().$CustomerAddress->getZip02())
1059 1059
                                 ->setPref($CustomerAddress->getPref())
1060 1060
                                 ->setAddr01($CustomerAddress->getAddr01())
1061 1061
                                 ->setAddr02($CustomerAddress->getAddr02())
@@ -1153,7 +1153,7 @@  discard block
 block discarded – undo
1153 1153
                     ->setTel03($data['tel03'])
1154 1154
                     ->setZip01($data['zip01'])
1155 1155
                     ->setZip02($data['zip02'])
1156
-                    ->setZipCode($data['zip01'] . $data['zip02'])
1156
+                    ->setZipCode($data['zip01'].$data['zip02'])
1157 1157
                     ->setPref($data['pref'])
1158 1158
                     ->setAddr01($data['addr01'])
1159 1159
                     ->setAddr02($data['addr02'])
@@ -1202,7 +1202,7 @@  discard block
 block discarded – undo
1202 1202
 
1203 1203
         $errors[] = $app['validator']->validateValue($data['customer_name02'], array(
1204 1204
             new Assert\NotBlank(),
1205
-            new Assert\Length(array('max' => $app['config']['name_len'], )),
1205
+            new Assert\Length(array('max' => $app['config']['name_len'],)),
1206 1206
             new Assert\Regex(array('pattern' => '/^[^\s ]+$/u', 'message' => 'form.type.name.firstname.nothasspace'))
1207 1207
         ));
1208 1208
 
Please login to merge, or discard this patch.
src/Eccube/Form/DataTransformer/EntityToIdTransformer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 
43 43
     /**
44 44
      * @param ObjectManager $om
45
-     * @param stging $className
45
+     * @param string $className
46 46
      */
47 47
     public function __construct(ObjectManager $om, $className)
48 48
     {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/ShipmentItemType.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -36,6 +36,9 @@
 block discarded – undo
36 36
 {
37 37
     protected $app;
38 38
 
39
+    /**
40
+     * @param \Silex\Application $app
41
+     */
39 42
     public function __construct($app)
40 43
     {
41 44
         $this->app = $app;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
                 )));
92 92
 
93 93
         $app = $this->app;
94
-        $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) use ($app) {
94
+        $builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) use ($app) {
95 95
             // モーダルからのPOST時に、金額等をセットする.
96 96
             if ('modal' === $app['request']->get('modal')) {
97 97
                 $data = $event->getData();
Please login to merge, or discard this patch.
src/Eccube/Form/Type/KanaType.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -25,9 +25,7 @@
 block discarded – undo
25 25
 
26 26
 use Symfony\Component\Form\AbstractType;
27 27
 use Symfony\Component\Form\FormBuilderInterface;
28
-use Symfony\Component\Form\FormEvents;
29 28
 use Symfony\Component\Validator\Constraints as Assert;
30
-use Symfony\Component\OptionsResolver\Options;
31 29
 use Symfony\Component\OptionsResolver\OptionsResolver;
32 30
 
33 31
 /**
Please login to merge, or discard this patch.