EntryController::index() - Code Metrics - Inspection of "Webインストーラでdatabase.ymlが正常にdumpされない不具合の修正" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#1399)

by Shinichi

created 2016-01-16 06:11 UTC

EntryController::index() B

↳ Parent: EntryController

Complexity

Conditions	6
Paths	6

Size

Total Lines	90
Code Lines	56

Duplication

Lines	9
Ratio	10 %

Code Coverage

Tests	11
CRAP Score	7.0986

Metric	Value
dl	9
loc	90
ccs	11
cts	16
cp	0.6875
rs	8.2713
cc	6
eloc	56
nc	6
nop	2
crap	7.0986

How to fix Long Method

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Controller;

use Eccube\Application;
use Eccube\Common\Constant;
use Eccube\Entity\Master\CustomerStatus;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Validator\Constraints as Assert;
use Symfony\Component\HttpKernel\Exception as HttpException;
use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;

class EntryController extends AbstractController

{

    /**

     * Index
     *
     * @param  Application $app
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function index(Application $app, Request $request)
    {
        /** @var $Customer \Eccube\Entity\Customer */
        $Customer = $app['eccube.repository.customer']->newCustomer();

        /* @var $builder \Symfony\Component\Form\FormBuilderInterface */
        $builder = $app['form.factory']->createBuilder('entry', $Customer);

        /* @var $form \Symfony\Component\Form\FormInterface */
        $form = $builder->getForm();
        if ('POST' === $request->getMethod()) {
            $form->handleRequest($request);

            if ($form->isValid()) {
                switch ($request->get('mode')) {
                    case 'confirm':

                        $builder->setAttribute('freeze', true);
                        $form = $builder->getForm();
                        $form->handleRequest($request);

                        return $app['twig']->render('Entry/confirm.twig', array(
                            'form' => $form->createView(),
                        ));
                        break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

                    case 'complete':
                        $Customer->setSalt(
                            $app['eccube.repository.customer']
                                ->createSalt(5)
                        );

                        $Customer->setPassword(
                            $app['eccube.repository.customer']->encryptPassword($app, $Customer)
                        );

                        $Customer->setSecretKey(
                            $app['eccube.repository.customer']->getUniqueSecretKey($app)
                        );

                        $CustomerAddress = new \Eccube\Entity\CustomerAddress();
                        $CustomerAddress->setName01($Customer->getName01())
                            ->setName02($Customer->getName02())
                            ->setKana01($Customer->getKana01())
                            ->setKana02($Customer->getKana02())
                            ->setCompanyName($Customer->getCompanyName())
                            ->setZip01($Customer->getZip01())
                            ->setZip02($Customer->getZip02())
                            ->setZipcode($Customer->getZip01() . $Customer->getZip02())

                            ->setPref($Customer->getPref())
                            ->setAddr01($Customer->getAddr01())
                            ->setAddr02($Customer->getAddr02())
                            ->setTel01($Customer->getTel01())
                            ->setTel02($Customer->getTel02())
                            ->setTel03($Customer->getTel03())
                            ->setFax01($Customer->getFax01())
                            ->setFax02($Customer->getFax02())
                            ->setFax03($Customer->getFax03())
                            ->setDelFlg(Constant::DISABLED)
                            ->setCustomer($Customer);

                        $app['orm.em']->persist($Customer);
                        $app['orm.em']->persist($CustomerAddress);
                        $app['orm.em']->flush();

                        $activateUrl = $app->url('entry_activate', array('secret_key' => $Customer->getSecretKey()));

                        /** @var $BaseInfo \Eccube\Entity\BaseInfo */
                        $BaseInfo = $app['eccube.repository.base_info']->get();
                        $activateFlg = $BaseInfo->getOptionCustomerActivate();

                        // 仮会員設定が有効な場合は、確認メールを送信し完了画面表示.
                        if ($activateFlg) {

                            // メール送信
                            $app['eccube.service.mail']->sendCustomerConfirmMail($Customer, $activateUrl);

                            return $app->redirect($app->url('entry_complete'));

                        // 仮会員設定が無効な場合は認証URLへ遷移させ、会員登録を完了させる.
                        } else {
                            return $app->redirect($activateUrl);
                        }
                }
            }
        }

        return $app['view']->render('Entry/index.twig', array(
            'form' => $form->createView(),
        ));
    }

    /**
     * Complete
     *
     * @param  Application $app
     * @return mixed
     */
    public function complete(Application $app)
    {
        return $app['view']->render('Entry/complete.twig', array(

        ));
    }

    /**

     * 会員のアクティベート（本会員化）を行う
     *
     * @param  Application $app
     * @return mixed
     */
    public function activate(Application $app, Request $request, $secret_key)
    {
        $errors = $app['validator']->validateValue($secret_key, array(

                new Assert\NotBlank(),
                new Assert\Regex(array(
                    'pattern' => '/^[a-zA-Z0-9]+$/',
                ))
            )
            );


        if ($request->getMethod() === 'GET' && count($errors) === 0) {
            try {
                $Customer = $app['eccube.repository.customer']
                    ->getNonActiveCustomerBySecretKey($secret_key);
            } catch (\Exception $e) {
                throw new HttpException\NotFoundHttpException('※ 既に会員登録が完了しているか、無効なURLです。');
            }

            $CustomerStatus = $app['eccube.repository.customer_status']->find(CustomerStatus::ACTIVE);
            $Customer->setStatus($CustomerStatus);
            $Customer->setBuyTimes(0);
            $Customer->setBuyTotal(0);

            $app['orm.em']->persist($Customer);
            $app['orm.em']->flush();

            // メール送信
            $app['eccube.service.mail']->sendCustomerCompleteMail($Customer);

            // 本会員登録してログイン状態にする
            $token = new UsernamePasswordToken($Customer, null, 'customer', array('ROLE_USER'));
            $this->getSecurity($app)->setToken($token);

            return $app['view']->render('Entry/activate.twig');
        } else {
            throw new HttpException\AccessDeniedHttpException('不正なアクセスです。');
        }
    }
}


1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24
25			namespace Eccube\Controller;
26
27			use Eccube\Application;
28			use Eccube\Common\Constant;
29			use Eccube\Entity\Master\CustomerStatus;
30			use Symfony\Component\HttpFoundation\Request;
31			use Symfony\Component\Validator\Constraints as Assert;
32			use Symfony\Component\HttpKernel\Exception as HttpException;
33			use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken;
34
35			class EntryController extends AbstractController
			0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Missing class doc comment Loading history...
36			{
37
38			/**
			0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Doc comment for parameter "$request" missing Loading history...
39			* Index
40			*
41			* @param Application $app
42			* @return \Symfony\Component\HttpFoundation\RedirectResponse
43			*/
44	5		public function index(Application $app, Request $request)
45			{
46			/** @var $Customer \Eccube\Entity\Customer */
47			$Customer = $app['eccube.repository.customer']->newCustomer();
48
49			/* @var $builder \Symfony\Component\Form\FormBuilderInterface */
50			$builder = $app['form.factory']->createBuilder('entry', $Customer);
51
52			/* @var $form \Symfony\Component\Form\FormInterface */
53			$form = $builder->getForm();
54			if ('POST' === $request->getMethod()) {
55			$form->handleRequest($request);
56
57			if ($form->isValid()) {
58	3		switch ($request->get('mode')) {
59	3	View Code Duplication	case 'confirm':
			0 ignored issues – show Duplication introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60			$builder->setAttribute('freeze', true);
61			$form = $builder->getForm();
62			$form->handleRequest($request);
63
64	1		return $app['twig']->render('Entry/confirm.twig', array(
65	1		'form' => $form->createView(),
66			));
67			break;
			0 ignored issues – show Unused Code introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
68
69	2		case 'complete':
70			$Customer->setSalt(
71			$app['eccube.repository.customer']
72			->createSalt(5)
73			);
74
75			$Customer->setPassword(
76			$app['eccube.repository.customer']->encryptPassword($app, $Customer)
77			);
78
79			$Customer->setSecretKey(
80			$app['eccube.repository.customer']->getUniqueSecretKey($app)
81			);
82
83			$CustomerAddress = new \Eccube\Entity\CustomerAddress();
84			$CustomerAddress->setName01($Customer->getName01())
85			->setName02($Customer->getName02())
86			->setKana01($Customer->getKana01())
87			->setKana02($Customer->getKana02())
88			->setCompanyName($Customer->getCompanyName())
89			->setZip01($Customer->getZip01())
90			->setZip02($Customer->getZip02())
91			->setZipcode($Customer->getZip01() . $Customer->getZip02())
			0 ignored issues – show Coding Style introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Concat operator must not be surrounded by spaces Loading history...
92			->setPref($Customer->getPref())
93			->setAddr01($Customer->getAddr01())
94			->setAddr02($Customer->getAddr02())
95			->setTel01($Customer->getTel01())
96			->setTel02($Customer->getTel02())
97			->setTel03($Customer->getTel03())
98			->setFax01($Customer->getFax01())
99			->setFax02($Customer->getFax02())
100			->setFax03($Customer->getFax03())
101	1		->setDelFlg(Constant::DISABLED)
102			->setCustomer($Customer);
103
104			$app['orm.em']->persist($Customer);
105			$app['orm.em']->persist($CustomerAddress);
106			$app['orm.em']->flush();
107
108			$activateUrl = $app->url('entry_activate', array('secret_key' => $Customer->getSecretKey()));
109
110			/** @var $BaseInfo \Eccube\Entity\BaseInfo */
111			$BaseInfo = $app['eccube.repository.base_info']->get();
112			$activateFlg = $BaseInfo->getOptionCustomerActivate();
113
114			// 仮会員設定が有効な場合は、確認メールを送信し完了画面表示.
115	1		if ($activateFlg) {
116
117			// メール送信
118			$app['eccube.service.mail']->sendCustomerConfirmMail($Customer, $activateUrl);
119
120			return $app->redirect($app->url('entry_complete'));
121
122			// 仮会員設定が無効な場合は認証URLへ遷移させ、会員登録を完了させる.
123			} else {
124			return $app->redirect($activateUrl);
125			}
126			}
127			}
128			}
129
130	3		return $app['view']->render('Entry/index.twig', array(
131	3		'form' => $form->createView(),
132			));
133	5		}
134
135			/**
136			* Complete
137			*
138			* @param Application $app
139			* @return mixed
140			*/
141	1		public function complete(Application $app)
142			{
143	1		return $app['view']->render('Entry/complete.twig', array(
			0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Add a comma after each item in a multi-line array Loading history...
144			));
145	1		}
146
147			/**
			0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Doc comment for parameter "$request" missing Loading history... introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Doc comment for parameter "$secret_key" missing Loading history...
148			* 会員のアクティベート（本会員化）を行う
149			*
150			* @param Application $app
151			* @return mixed
152			*/
153	3		public function activate(Application $app, Request $request, $secret_key)
154			{
155			$errors = $app['validator']->validateValue($secret_key, array(
			0 ignored issues – show introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report Add a comma after each item in a multi-line array Loading history...
156			new Assert\NotBlank(),
157			new Assert\Regex(array(
158			'pattern' => '/^[a-zA-Z0-9]+$/',
159			))
160	3		)
161			);
			0 ignored issues – show Coding Style introduced 2015-11-21 02:41 UTC by Report Bug Copy Issue Report This line of the multi-line function call does not seem to be indented correctly. Expected `8` spaces, but found `12`. Loading history...
162
163			if ($request->getMethod() === 'GET' && count($errors) === 0) {
164			try {
165			$Customer = $app['eccube.repository.customer']
166			->getNonActiveCustomerBySecretKey($secret_key);
167			} catch (\Exception $e) {
168			throw new HttpException\NotFoundHttpException('※ 既に会員登録が完了しているか、無効なURLです。');
169	2		}
170
171			$CustomerStatus = $app['eccube.repository.customer_status']->find(CustomerStatus::ACTIVE);
172			$Customer->setStatus($CustomerStatus);
173			$Customer->setBuyTimes(0);
174			$Customer->setBuyTotal(0);
175
176			$app['orm.em']->persist($Customer);
177			$app['orm.em']->flush();
178
179			// メール送信
180			$app['eccube.service.mail']->sendCustomerCompleteMail($Customer);
181
182			// 本会員登録してログイン状態にする
183			$token = new UsernamePasswordToken($Customer, null, 'customer', array('ROLE_USER'));
184			$this->getSecurity($app)->setToken($token);
185
186			return $app['view']->render('Entry/activate.twig');
187			} else {
188			throw new HttpException\AccessDeniedHttpException('不正なアクセスです。');
189			}
190	3		}
191			}
192

EC-CUBE / ec-cube

Pull Request — master (#1399)

EntryController::index() B

Complexity

Size

Duplication

Code Coverage

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like