AnnotatedRoutingController::form() - Code Metrics - Inspection of "3.1拡張機能のプラグインサンプルを追加" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — experimental/3.1 (#2357)

by Kiyotaka

created 2017-06-02 06:19 UTC

AnnotatedRoutingController::form() A

↳ Parent: AnnotatedRoutingController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	4
rs	10

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2017 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */

namespace Plugin\AnnotatedRouting\Controller;
use Eccube\Application;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;

/**
 * @Route("/arc")
 */
class AnnotatedRoutingController
{
    /**

     * @Route("/")
     * @Template("AnnotatedRouting/Resource/template/index.twig")
     */

    public function index(Application $app)

    {
        return [];
    }

    /**

     * @Route("/form")
     * @Method("GET")
     * @Template("AnnotatedRouting/Resource/template/form.twig")
     */

    public function form(Application $app)

    {
        return [];
    }

    /**

     * @Route("/form")
     * @Method("POST")
     */

    public function submit(Application $app)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return 'Hello, '.$_REQUEST['value'];
    }
}

1			<?php
2			/*
3			* This file is part of EC-CUBE
4			*
5			* Copyright(c) 2000-2017 LOCKON CO.,LTD. All Rights Reserved.
6			*
7			* http://www.lockon.co.jp/
8			*
9			* This program is free software; you can redistribute it and/or
10			* modify it under the terms of the GNU General Public License
11			* as published by the Free Software Foundation; either version 2
12			* of the License, or (at your option) any later version.
13			*
14			* This program is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with this program; if not, write to the Free Software
21			* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
22			*/
23
24			namespace Plugin\AnnotatedRouting\Controller;
25			use Eccube\Application;
26			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
27			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
28			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
29
30			/**
31			* @Route("/arc")
32			*/
33			class AnnotatedRoutingController
34			{
35			/**
			0 ignored issues – show introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report Doc comment for parameter "$app" missing Loading history...
36			* @Route("/")
37			* @Template("AnnotatedRouting/Resource/template/index.twig")
38			*/
			0 ignored issues – show introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
39			public function index(Application $app)
			0 ignored issues – show Unused Code introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
40			{
41			return [];
42			}
43
44			/**
			0 ignored issues – show introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report Doc comment for parameter "$app" missing Loading history...
45			* @Route("/form")
46			* @Method("GET")
47			* @Template("AnnotatedRouting/Resource/template/form.twig")
48			*/
			0 ignored issues – show introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
49			public function form(Application $app)
			0 ignored issues – show Unused Code introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
50			{
51			return [];
52			}
53
54			/**
			0 ignored issues – show introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report Doc comment for parameter "$app" missing Loading history...
55			* @Route("/form")
56			* @Method("POST")
57			*/
			0 ignored issues – show introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report Missing @return tag in function comment Loading history...
58			public function submit(Application $app)
			0 ignored issues – show Unused Code introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report The parameter `$app` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Coding Style introduced 2017-06-02 07:37 UTC by Report Bug Copy Issue Report `submit` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
59			{
60			return 'Hello, '.$_REQUEST['value'];
61			}
62			}

EC-CUBE / ec-cube

Pull Request — experimental/3.1 (#2357)

AnnotatedRoutingController::form() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like