Eccube\Repository\BlockRepository

Complexity

Total Complexity

13

Size/Duplication

Total Lines	166
Duplicated Lines	18.67 %

Coupling/Cohesion

Components	3
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getNewBlockId()	0	12	1
A	findOrCreate()	0	10	2
A	newBlock()	0	10	1
A	getBlock()	0	9	1
A	getList()	0	13	1
A	getPageList()	21	21	3
A	getWriteTemplatePath()	0	4	1
A	getReadTemplateFile()	10	17	3

<?php
/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) 2000-2015 LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of the GNU General Public License
 * as published by the Free Software Foundation; either version 2
 * of the License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
 */


namespace Eccube\Repository;

use Eccube\Entity\Block;
use Symfony\Component\Filesystem\Filesystem;

/**
 * BlocRepository
 *
 * This class was generated by the Doctrine ORM. Add your own custom
 * repository methods below.
 */
class BlockRepository extends AbstractRepository
{

    /**

Doc comment for parameter "$block_id" missing

Doc comment for parameter "$DeviceType" missing

     * @deprecated 呼び出し元で制御する
     * @param $block_id

Missing parameter name

     * @param $DeviceType

Missing parameter name

     * @return array|\Eccube\Entity\Block
     */
    public function findOrCreate($block_id, $DeviceType)
    {

        if ($block_id == null) {
            return $this->newBlock($DeviceType);
        } else {
            return $this->getBlock($block_id, $DeviceType);

The method Eccube\Repository\BlockRepository::getBlock() has been deprecated with message: Use magic finder methods. BlockRepository::findOneByIdAndDeviceType()

        }

    }

    public function newBlock($DeviceType)

Missing function doc comment

    {
        $Block = new \Eccube\Entity\Block();
        $Block
            ->setDeviceType($DeviceType)
            ->setLogicFlg(0)
            ->setDeletableFlg(1);

        return $Block;
    }

    /**
     * @deprecated since 3.0.0, to be removed in 3.1
     */
    private function getNewBlockId($DeviceType)
    {

        $qb = $this->createQueryBuilder('b')
            ->select('max(b.id) +1 as block_id')
            ->where('b.DeviceType = :DeviceType')
            ->setParameter('DeviceType', $DeviceType);
        $result = $qb->getQuery()->getSingleResult();

        return $result['block_id'];

    }

    /**
     * ブロックの情報を取得.
     *
     * @deprecated Use magic finder methods. BlockRepository::findOneByIdAndDeviceType()
     * @param  integer $block_id ブロックID

Expected 26 spaces after parameter type; 1 found

Expected 3 spaces after parameter name; 1 found

     * @param  \Eccube\Entity\Master\DeviceType $DeviceType
     * @return Block
     */
    public function getBlock($block_id, $DeviceType)

Declare public methods first, then protected ones and finally private ones

    {
        $Block = $this->findOneBy(array(
            'id' => $block_id,
            'DeviceType' => $DeviceType,
        ));

        return $Block;
    }

    /**
     * ブロック一覧の取得.
     *
     * @param  \Eccube\Entity\Master\DeviceType $DeviceType
     * @return array
     */
    public function getList($DeviceType)
    {
        $qb = $this->createQueryBuilder('b')
            ->orderBy('b.id', 'DESC')
            ->where('b.DeviceType = :DeviceType')
            ->setParameter('DeviceType', $DeviceType);

        $Blocks = $qb
            ->getQuery()
            ->getResult();

        return $Blocks;
    }

    /**
     * ページの属性を取得する.
     *
     * この関数は, dtb_pagelayout の情報を検索する.
     * $deviceTypeId は必須. デフォルト値は DEVICE_TYPE_PC.
     *
     * @access public
     * @param  DeviceType $DeviceType 端末種別ID
     * @param  string $where 追加の検索条件

Expected 5 spaces after parameter type; 1 found

Expected 6 spaces after parameter name; 1 found

     * @param  string[] $parameters 追加の検索パラメーター

Expected 3 spaces after parameter type; 1 found

     * @return array                             ページ属性の配列
     * @deprecated since 3.0.0, to be removed in 3.1
     */
    public function getPageList(DeviceType $DeviceType, $where = null, $parameters = array())

This method seems to be duplicated in your project.

    {
        $qb = $this->createQueryBuilder('l')
            ->orderBy('l.id', 'DESC')
            ->where('l.DeviceType = :DeviceType')
            ->setParameter('DeviceType', $DeviceType)
            ->andWhere('l.id <> 0')
            ->orderBy('l.id', 'ASC');
        if (!is_null($where)) {
            $qb->andWhere($where);
            foreach ($parameters as $key => $val) {
                $qb->setParameter($key, $val);
            }
        }

        $PageLayouts = $qb
            ->getQuery()
            ->getResult();

        return $PageLayouts;
    }

    /**
     * 書き込みパスの取得
     * User定義の場合： /html/user_data
     * そうでない場合： /app/template/{template_code}
     *
     * @param  boolean $isUser
     * @return string
     *
     * @deprecated since 3.0.0, to be removed in 3.1
     */
    public function getWriteTemplatePath($isUser = false)

The parameter $isUser is not used and could be removed.

    {
        return $this->app['config']['block_realdir'];
    }

    /**
     * 読み込みファイルの取得
     *
     * 1. block_realdir
     *      app/template/{template_code}/block
     * 2. block_default_readldir
     *      src/Eccube/Resource/template/default/block
     *
     * @param string $fileName

Expected 2 spaces after parameter type; 1 found

     * @param  boolean $isUser
     *
     * @return array
     */
    public function getReadTemplateFile($fileName, $isUser = false)

The parameter $isUser is not used and could be removed.

    {
        $readPaths = array(
            $this->app['config']['block_realdir'],
            $this->app['config']['block_default_realdir'],
        );
        foreach ($readPaths as $readPath) {
            $filePath = $readPath . '/' . $fileName . '.twig';

Concat operator must not be surrounded by spaces

            $fs = new Filesystem();
            if ($fs->exists($filePath)) {
                return array(
                    'file_name' => $fileName,
                    'tpl_data' => file_get_contents($filePath),
                );
            }
        }
    }
}