OwnerStoreController::__construct() - Code Metrics - Inspection of "メンテナンス管理から.maintenanceファイルが作成/削除できる" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 4.0 (#4000)

unknown

created 2018-11-22 02:01 UTC

OwnerStoreController::__construct() A

↳ Parent: OwnerStoreController

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
nc	2
nop	8
dl	0
loc	25
ccs	0
cts	12
cp	0
crap	12
rs	9.52
c	0
b	0
f	0

How to fix Many Parameters

<?php

/*
 * This file is part of EC-CUBE
 *
 * Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
 *
 * http://www.lockon.co.jp/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Eccube\Controller\Admin\Store;

use Eccube\Controller\AbstractController;
use Eccube\Entity\BaseInfo;
use Eccube\Entity\Master\PageMax;
use Eccube\Entity\Plugin;
use Eccube\Exception\PluginApiException;
use Eccube\Form\Type\Admin\SearchPluginApiType;
use Eccube\Repository\BaseInfoRepository;
use Eccube\Repository\PluginRepository;
use Eccube\Service\Composer\ComposerProcessService;
use Eccube\Service\Composer\ComposerServiceInterface;
use Eccube\Service\PluginApiService;
use Eccube\Service\PluginService;
use Eccube\Service\SystemService;
use Eccube\Util\CacheUtil;
use Eccube\Util\FormUtil;
use Knp\Component\Pager\Paginator;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;

/**
 * @Route("/%eccube_admin_route%/store/plugin/api")
 */
class OwnerStoreController extends AbstractController
{
    /**
     * @var PluginRepository
     */
    protected $pluginRepository;

    /**
     * @var PluginService
     */
    protected $pluginService;

    /**
     * @var ComposerServiceInterface
     */
    protected $composerService;

    /**
     * @var SystemService
     */
    protected $systemService;

    /**
     * @var PluginApiService
     */
    protected $pluginApiService;

    private static $vendorName = 'ec-cube';

    /** @var BaseInfo */
    private $BaseInfo;

    /** @var CacheUtil */
    private $cacheUtil;

    /**
     * OwnerStoreController constructor.
     *
     * @param PluginRepository $pluginRepository
     * @param PluginService $pluginService
     * @param ComposerProcessService $composerProcessService
     * @param ComposerServiceInterface $composerService
     * @param SystemService $systemService
     * @param PluginApiService $pluginApiService
     * @param BaseInfoRepository $baseInfoRepository
     * @param CacheUtil $cacheUtil
     *
     * @throws \Doctrine\ORM\NoResultException
     * @throws \Doctrine\ORM\NonUniqueResultException
     */
    public function __construct(
        PluginRepository $pluginRepository,
        PluginService $pluginService,
        ComposerProcessService $composerProcessService,
        ComposerServiceInterface $composerService,
        SystemService $systemService,
        PluginApiService $pluginApiService,
        BaseInfoRepository $baseInfoRepository,
        CacheUtil $cacheUtil
    ) {
        $this->pluginRepository = $pluginRepository;
        $this->pluginService = $pluginService;
        $this->systemService = $systemService;
        $this->pluginApiService = $pluginApiService;
        $this->BaseInfo = $baseInfoRepository->get();
        $this->cacheUtil = $cacheUtil;

        // TODO: Check the flow of the composer service below
        $memoryLimit = $this->systemService->getMemoryLimit();
        if ($memoryLimit == -1 or $memoryLimit >= $this->eccubeConfig['eccube_composer_memory_limit']) {
            $this->composerService = $composerService;
        } else {
            $this->composerService = $composerProcessService;
        }
    }

    /**
     * Owner's Store Plugin Installation Screen - Search function
     *
     * @Route("/search", name="admin_store_plugin_owners_search")
     * @Route("/search/page/{page_no}", name="admin_store_plugin_owners_search_page", requirements={"page_no" = "\d+"})
     * @Template("@admin/Store/plugin_search.twig")
     *
     * @param Request     $request
     * @param int $page_no
     * @param Paginator $paginator
     *
     * @return array
     */
    public function search(Request $request, $page_no = null, Paginator $paginator)
    {
        if (empty($this->BaseInfo->getAuthenticationKey())) {
            $this->addWarning('認証キーを設定してください。', 'admin');

            return $this->redirectToRoute('admin_store_authentication_setting');
        }

        // Acquire downloadable plug-in information from owners store
        $category = [];

        $json = $this->pluginApiService->getCategory();
        if (!empty($json)) {
            $data = json_decode($json, true);
            $category = array_column($data, 'name', 'id');
        }

        // build form with master data
        $builder = $this->formFactory
            ->createBuilder(SearchPluginApiType::class, null, ['category' => $category]);
        $searchForm = $builder->getForm();

        $searchForm->handleRequest($request);
        $searchData = $searchForm->getData();
        if ($searchForm->isSubmitted()) {
            if ($searchForm->isValid()) {
                $page_no = 1;
                $searchData = $searchForm->getData();
                $this->session->set('eccube.admin.plugin_api.search', FormUtil::getViewData($searchForm));
                $this->session->set('eccube.admin.plugin_api.search.page_no', $page_no);
            }
        } else {
            // quick search
            if (is_numeric($categoryId = $request->get('category_id')) && array_key_exists($categoryId, $category)) {
                $searchForm['category_id']->setData($categoryId);
            }
            // reset page count
            $this->session->set('eccube.admin.plugin_api.search.page_count', $this->eccubeConfig->get('eccube_default_page_count'));
            if (null !== $page_no || $request->get('resume')) {
                if ($page_no) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                    $this->session->set('eccube.admin.plugin_api.search.page_no', (int) $page_no);
                } else {
                    $page_no = $this->session->get('eccube.admin.plugin_api.search.page_no', 1);
                }
                $viewData = $this->session->get('eccube.admin.plugin_api.search', []);
                $searchData = FormUtil::submitAndGetData($searchForm, $viewData);
            } else {
                $page_no = 1;
                // submit default value
                $viewData = FormUtil::getViewData($searchForm);
                $searchData = FormUtil::submitAndGetData($searchForm, $viewData);
                $this->session->set('eccube.admin.plugin_api.search', $searchData);
                $this->session->set('eccube.admin.plugin_api.search.page_no', $page_no);
            }
        }

        // set page count
        $pageCount = $this->session->get('eccube.admin.plugin_api.search.page_count', $this->eccubeConfig->get('eccube_default_page_count'));
        if (($PageMax = $searchForm['page_count']->getData()) instanceof PageMax) {
            $pageCount = $PageMax->getId();
            $this->session->set('eccube.admin.plugin_api.search.page_count', $pageCount);
        }

        // Owner's store communication
        $searchData['page_no'] = $page_no;
        $searchData['page_count'] = $pageCount;

        $total = 0;
        $items = [];

        try {
            $data = $this->pluginApiService->getPlugins($searchData);
            $total = $data['total'];
            $items = $data['plugins'];
        } catch (PluginApiException $e) {
            $this->addError($e->getMessage(), 'admin');
        }

        // The usage is set because `$items` are already paged.
        // virtual paging
        $pagination = $paginator->paginate($items, 1, $pageCount);
        $pagination->setTotalItemCount($total);
        $pagination->setCurrentPageNumber($page_no);
        $pagination->setItemNumberPerPage($pageCount);

        return [
            'pagination' => $pagination,
            'total' => $total,
            'searchForm' => $searchForm->createView(),
            'page_no' => $page_no,
            'Categories' => $category,
        ];
    }

    /**
     * Do confirm page
     *
     * @Route("/install/{id}/confirm", requirements={"id" = "\d+"}, name="admin_store_plugin_install_confirm")
     * @Template("@admin/Store/plugin_confirm.twig")
     *
     * @param Request $request
     *
     * @return array
     *
     * @throws \Eccube\Exception\PluginException
     */
    public function doConfirm(Request $request, $id)

    {
        try {
            $item = $this->pluginApiService->getPlugin($id);
            // Todo: need define item's dependency mechanism
            $requires = $this->pluginService->getPluginRequired($item);

            return [
                'item' => $item,
                'requires' => $requires,
                'is_update' => false,
            ];
        } catch (PluginApiException $e) {
            $this->addError($e->getMessage(), 'admin');

            return $this->redirectToRoute('admin_store_authentication_setting');
        }
    }

    /**
     * Api Install plugin by composer connect with package repo
     *
     * @Route("/install", name="admin_store_plugin_api_install", methods={"POST"})
     *
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function apiInstall(Request $request, EventDispatcherInterface $dispatcher)
    {
        $this->isTokenValid();

        // .maintenanceファイルを設置
        $this->systemService->switchMaintenance(true);

        // TERMINATE時のイベントを設定
        $dispatcher->addListener(KernelEvents::TERMINATE, function () {
            // .maintenanceファイルを削除
            $this->systemService->switchMaintenance();
        });

        $this->cacheUtil->clearCache();

        $pluginCode = $request->get('pluginCode');

        $log = null;
        try {
            $log = $this->composerService->execRequire('ec-cube/'.$pluginCode);

            return $this->json(['success' => true, 'log' => $log]);
        } catch (\Exception $e) {
            $log = $e->getMessage();
            log_error($e);
        }

        return $this->json(['success' => false, 'log' => $log], 500);
    }

    /**
     * New ways to remove plugin: using composer command
     *
     * @Route("/delete/{id}/uninstall", requirements={"id" = "\d+"}, name="admin_store_plugin_api_uninstall", methods={"DELETE"})
     *
     * @param Plugin $Plugin
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function apiUninstall(Plugin $Plugin, EventDispatcherInterface $dispatcher)
    {
        $this->isTokenValid();

        // .maintenanceファイルを設置
        $this->systemService->switchMaintenance(true);

        // TERMINATE時のイベントを設定
        $dispatcher->addListener(KernelEvents::TERMINATE, function () {
            // .maintenanceファイルを削除
            $this->systemService->switchMaintenance();
        });

        $this->cacheUtil->clearCache();

        if ($Plugin->isEnabled()) {
            return $this->json(['success' => false, 'message' => trans('admin.plugin.uninstall.error.not_disable')], 400);
        }

        $pluginCode = $Plugin->getCode();
        $otherDepend = $this->pluginService->findDependentPlugin($pluginCode);

        if (!empty($otherDepend)) {
            $DependPlugin = $this->pluginRepository->findOneBy(['code' => $otherDepend[0]]);
            $dependName = $otherDepend[0];
            if ($DependPlugin) {
                $dependName = $DependPlugin->getName();
            }
            $message = trans('admin.plugin.uninstall.depend', ['%name%' => $Plugin->getName(), '%depend_name%' => $dependName]);

            return $this->json(['success' => false, 'message' => $message], 400);
        }

        $pluginCode = $Plugin->getCode();
        $packageName = self::$vendorName.'/'.$pluginCode;

        try {
            $log = $this->composerService->execRemove($packageName);

            return $this->json(['success' => false, 'log' => $log]);
        } catch (\Exception $e) {
            log_error($e);

            return $this->json(['success' => false, 'log' => $e->getMessage()], 500);
        }
    }

    /**
     * オーナーズブラグインインストール、アップデート
     *
     * @Route("/upgrade", name="admin_store_plugin_api_upgrade", methods={"POST"})
     *
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function apiUpgrade(Request $request, EventDispatcherInterface $dispatcher)
    {
        $this->isTokenValid();

        // .maintenanceファイルを設置
        $this->systemService->switchMaintenance(true);

        // TERMINATE時のイベントを設定
        $dispatcher->addListener(KernelEvents::TERMINATE, function () {
            // .maintenanceファイルを削除
            $this->systemService->switchMaintenance();
        });
        
        $this->cacheUtil->clearCache();

        $pluginCode = $request->get('pluginCode');
        $version = $request->get('version');

        $log = null;
        try {
            $log = $this->composerService->execRequire('ec-cube/'.$pluginCode.':'.$version);
            return $this->json(['success' => true, 'log' => $log]);
        } catch (\Exception $e) {
            $log = $e->getMessage();
            log_error($e);
        }

        return $this->json(['success' => false, 'log' => $log], 500);
    }

    /**
     * オーナーズブラグインインストール、スキーマ更新
     *
     * @Route("/schema_update", name="admin_store_plugin_api_schema_update", methods={"POST"})
     *
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function apiSchemaUpdate(Request $request)
    {
        $this->isTokenValid();

        $this->cacheUtil->clearCache();

        $pluginCode = $request->get('pluginCode');

        try {
            $Plugin = $this->pluginRepository->findByCode($pluginCode);

            if (!$Plugin) {
                throw new NotFoundHttpException();
            }

            $config = $this->pluginService->readConfig($this->pluginService->calcPluginDir($Plugin->getCode()));

            ob_start();
            $this->pluginService->generateProxyAndUpdateSchema($Plugin, $config);

            // 初期化されていなければインストール処理を実行する
            if (!$Plugin->isInitialized()) {
                $this->pluginService->callPluginManagerMethod($config, 'install');
                $Plugin->setInitialized(true);
                $this->entityManager->persist($Plugin);
                $this->entityManager->flush();
            }

            $log = ob_get_clean();
            while (ob_get_level() > 0) {
                ob_end_flush();
            }

            return $this->json(['success' => true, 'log' => $log]);
        } catch (\Exception $e) {
            $log = $e->getMessage();
            log_error($e);

            return $this->json(['success' => false, 'log' => $log], 500);
        }
    }

    /**
     * オーナーズブラグインインストール、更新処理
     *
     * @Route("/update", name="admin_store_plugin_api_update", methods={"POST"})
     *
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\JsonResponse
     */
    public function apiUpdate(Request $request)
    {
        $this->isTokenValid();

        $this->cacheUtil->clearCache();

        $pluginCode = $request->get('pluginCode');

        $log = null;
        try {
            $Plugin = $this->pluginRepository->findByCode($pluginCode);
            if (!$Plugin) {
                throw new NotFoundHttpException();
            }

            $config = $this->pluginService->readConfig($this->pluginService->calcPluginDir($Plugin->getCode()));
            ob_start();
            $this->pluginService->updatePlugin($Plugin, $config);
            $log = ob_get_clean();
            while (ob_get_level() > 0) {
                ob_end_flush();
            }

            return $this->json(['success' => true, 'log' => $log]);
        } catch (\Exception $e) {
            $log = $e->getMessage();
            log_error($e);
        }

        return $this->json(['success' => false, 'log' => $log], 500);
    }

    /**
     * Do confirm update page
     *
     * @Route("/upgrade/{id}/confirm", requirements={"id" = "\d+"}, name="admin_store_plugin_update_confirm")
     * @Template("@admin/Store/plugin_confirm.twig")
     *
     * @param Plugin $Plugin
     *
     * @return array
     */
    public function doUpdateConfirm(Plugin $Plugin)
    {
        try {
            $item = $this->pluginApiService->getPlugin($Plugin->getSource());

            return [
                'item' => $item,
                'requires' => [],
                'is_update' => true,
                'Plugin' => $Plugin,
            ];
        } catch (PluginApiException $e) {
            $this->addError($e->getMessage(), 'admin');

            return $this->redirectToRoute('admin_store_authentication_setting');
        }
    }
}


1		<?php
2
3		/*
4		* This file is part of EC-CUBE
5		*
6		* Copyright(c) LOCKON CO.,LTD. All Rights Reserved.
7		*
8		* http://www.lockon.co.jp/
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Eccube\Controller\Admin\Store;
15
16		use Eccube\Controller\AbstractController;
17		use Eccube\Entity\BaseInfo;
18		use Eccube\Entity\Master\PageMax;
19		use Eccube\Entity\Plugin;
20		use Eccube\Exception\PluginApiException;
21		use Eccube\Form\Type\Admin\SearchPluginApiType;
22		use Eccube\Repository\BaseInfoRepository;
23		use Eccube\Repository\PluginRepository;
24		use Eccube\Service\Composer\ComposerProcessService;
25		use Eccube\Service\Composer\ComposerServiceInterface;
26		use Eccube\Service\PluginApiService;
27		use Eccube\Service\PluginService;
28		use Eccube\Service\SystemService;
29		use Eccube\Util\CacheUtil;
30		use Eccube\Util\FormUtil;
31		use Knp\Component\Pager\Paginator;
32		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
33		use Symfony\Component\HttpFoundation\Request;
34		use Symfony\Component\HttpKernel\KernelEvents;
35		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
36		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
37		use Symfony\Component\Routing\Annotation\Route;
38
39		/**
40		* @Route("/%eccube_admin_route%/store/plugin/api")
41		*/
42		class OwnerStoreController extends AbstractController
43		{
44		/**
45		* @var PluginRepository
46		*/
47		protected $pluginRepository;
48
49		/**
50		* @var PluginService
51		*/
52		protected $pluginService;
53
54		/**
55		* @var ComposerServiceInterface
56		*/
57		protected $composerService;
58
59		/**
60		* @var SystemService
61		*/
62		protected $systemService;
63
64		/**
65		* @var PluginApiService
66		*/
67		protected $pluginApiService;
68
69		private static $vendorName = 'ec-cube';
70
71		/** @var BaseInfo */
72		private $BaseInfo;
73
74		/** @var CacheUtil */
75		private $cacheUtil;
76
77		/**
78		* OwnerStoreController constructor.
79		*
80		* @param PluginRepository $pluginRepository
81		* @param PluginService $pluginService
82		* @param ComposerProcessService $composerProcessService
83		* @param ComposerServiceInterface $composerService
84		* @param SystemService $systemService
85		* @param PluginApiService $pluginApiService
86		* @param BaseInfoRepository $baseInfoRepository
87		* @param CacheUtil $cacheUtil
88		*
89		* @throws \Doctrine\ORM\NoResultException
90		* @throws \Doctrine\ORM\NonUniqueResultException
91		*/
92		public function __construct(
93		PluginRepository $pluginRepository,
94		PluginService $pluginService,
95		ComposerProcessService $composerProcessService,
96		ComposerServiceInterface $composerService,
97		SystemService $systemService,
98		PluginApiService $pluginApiService,
99		BaseInfoRepository $baseInfoRepository,
100		CacheUtil $cacheUtil
101		) {
102		$this->pluginRepository = $pluginRepository;
103		$this->pluginService = $pluginService;
104		$this->systemService = $systemService;
105		$this->pluginApiService = $pluginApiService;
106		$this->BaseInfo = $baseInfoRepository->get();
107		$this->cacheUtil = $cacheUtil;
108
109		// TODO: Check the flow of the composer service below
110		$memoryLimit = $this->systemService->getMemoryLimit();
111		if ($memoryLimit == -1 or $memoryLimit >= $this->eccubeConfig['eccube_composer_memory_limit']) {
112		$this->composerService = $composerService;
113		} else {
114		$this->composerService = $composerProcessService;
115		}
116		}
117
118		/**
119		* Owner's Store Plugin Installation Screen - Search function
120		*
121		* @Route("/search", name="admin_store_plugin_owners_search")
122		* @Route("/search/page/{page_no}", name="admin_store_plugin_owners_search_page", requirements={"page_no" = "\d+"})
123		* @Template("@admin/Store/plugin_search.twig")
124		*
125		* @param Request $request
126		* @param int $page_no
127		* @param Paginator $paginator
128		*
129		* @return array
130		*/
131		public function search(Request $request, $page_no = null, Paginator $paginator)
132		{
133		if (empty($this->BaseInfo->getAuthenticationKey())) {
134		$this->addWarning('認証キーを設定してください。', 'admin');
135
136		return $this->redirectToRoute('admin_store_authentication_setting');
137		}
138
139		// Acquire downloadable plug-in information from owners store
140		$category = [];
141
142		$json = $this->pluginApiService->getCategory();
143		if (!empty($json)) {
144		$data = json_decode($json, true);
145		$category = array_column($data, 'name', 'id');
146		}
147
148		// build form with master data
149		$builder = $this->formFactory
150		->createBuilder(SearchPluginApiType::class, null, ['category' => $category]);
151		$searchForm = $builder->getForm();
152
153		$searchForm->handleRequest($request);
154		$searchData = $searchForm->getData();
155		if ($searchForm->isSubmitted()) {
156		if ($searchForm->isValid()) {
157		$page_no = 1;
158		$searchData = $searchForm->getData();
159		$this->session->set('eccube.admin.plugin_api.search', FormUtil::getViewData($searchForm));
160		$this->session->set('eccube.admin.plugin_api.search.page_no', $page_no);
161		}
162		} else {
163		// quick search
164		if (is_numeric($categoryId = $request->get('category_id')) && array_key_exists($categoryId, $category)) {
165		$searchForm['category_id']->setData($categoryId);
166		}
167		// reset page count
168		$this->session->set('eccube.admin.plugin_api.search.page_count', $this->eccubeConfig->get('eccube_default_page_count'));
169	View Code Duplication	if (null !== $page_no \|\| $request->get('resume')) {
170		if ($page_no) {
		0 ignored issues – show Bug Best Practice introduced 2018-08-13 10:47 UTC by Report Bug Copy Issue Report The expression `$page_no` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
171		$this->session->set('eccube.admin.plugin_api.search.page_no', (int) $page_no);
172		} else {
173		$page_no = $this->session->get('eccube.admin.plugin_api.search.page_no', 1);
174		}
175		$viewData = $this->session->get('eccube.admin.plugin_api.search', []);
176		$searchData = FormUtil::submitAndGetData($searchForm, $viewData);
177		} else {
178		$page_no = 1;
179		// submit default value
180		$viewData = FormUtil::getViewData($searchForm);
181		$searchData = FormUtil::submitAndGetData($searchForm, $viewData);
182		$this->session->set('eccube.admin.plugin_api.search', $searchData);
183		$this->session->set('eccube.admin.plugin_api.search.page_no', $page_no);
184		}
185		}
186
187		// set page count
188		$pageCount = $this->session->get('eccube.admin.plugin_api.search.page_count', $this->eccubeConfig->get('eccube_default_page_count'));
189		if (($PageMax = $searchForm['page_count']->getData()) instanceof PageMax) {
190		$pageCount = $PageMax->getId();
191		$this->session->set('eccube.admin.plugin_api.search.page_count', $pageCount);
192		}
193
194		// Owner's store communication
195		$searchData['page_no'] = $page_no;
196		$searchData['page_count'] = $pageCount;
197
198		$total = 0;
199		$items = [];
200
201		try {
202		$data = $this->pluginApiService->getPlugins($searchData);
203		$total = $data['total'];
204		$items = $data['plugins'];
205		} catch (PluginApiException $e) {
206		$this->addError($e->getMessage(), 'admin');
207		}
208
209		// The usage is set because `$items` are already paged.
210		// virtual paging
211		$pagination = $paginator->paginate($items, 1, $pageCount);
212		$pagination->setTotalItemCount($total);
213		$pagination->setCurrentPageNumber($page_no);
214		$pagination->setItemNumberPerPage($pageCount);
215
216		return [
217		'pagination' => $pagination,
218		'total' => $total,
219		'searchForm' => $searchForm->createView(),
220		'page_no' => $page_no,
221		'Categories' => $category,
222		];
223		}
224
225		/**
226		* Do confirm page
227		*
228		* @Route("/install/{id}/confirm", requirements={"id" = "\d+"}, name="admin_store_plugin_install_confirm")
229		* @Template("@admin/Store/plugin_confirm.twig")
230		*
231		* @param Request $request
232		*
233		* @return array
234		*
235		* @throws \Eccube\Exception\PluginException
236		*/
237		public function doConfirm(Request $request, $id)
		0 ignored issues – show Unused Code introduced 2018-09-14 09:23 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
238		{
239		try {
240		$item = $this->pluginApiService->getPlugin($id);
241		// Todo: need define item's dependency mechanism
242		$requires = $this->pluginService->getPluginRequired($item);
243
244		return [
245		'item' => $item,
246		'requires' => $requires,
247		'is_update' => false,
248		];
249		} catch (PluginApiException $e) {
250		$this->addError($e->getMessage(), 'admin');
251
252		return $this->redirectToRoute('admin_store_authentication_setting');
253		}
254		}
255
256		/**
257		* Api Install plugin by composer connect with package repo
258		*
259		* @Route("/install", name="admin_store_plugin_api_install", methods={"POST"})
260		*
261		* @param Request $request
262		*
263		* @return \Symfony\Component\HttpFoundation\JsonResponse
264		*/
265		public function apiInstall(Request $request, EventDispatcherInterface $dispatcher)
266		{
267		$this->isTokenValid();
268
269		// .maintenanceファイルを設置
270		$this->systemService->switchMaintenance(true);
271
272		// TERMINATE時のイベントを設定
273		$dispatcher->addListener(KernelEvents::TERMINATE, function () {
274		// .maintenanceファイルを削除
275		$this->systemService->switchMaintenance();
276		});
277
278		$this->cacheUtil->clearCache();
279
280		$pluginCode = $request->get('pluginCode');
281
282		$log = null;
283		try {
284		$log = $this->composerService->execRequire('ec-cube/'.$pluginCode);
285
286		return $this->json(['success' => true, 'log' => $log]);
287		} catch (\Exception $e) {
288		$log = $e->getMessage();
289		log_error($e);
290		}
291
292		return $this->json(['success' => false, 'log' => $log], 500);
293		}
294
295		/**
296		* New ways to remove plugin: using composer command
297		*
298		* @Route("/delete/{id}/uninstall", requirements={"id" = "\d+"}, name="admin_store_plugin_api_uninstall", methods={"DELETE"})
299		*
300		* @param Plugin $Plugin
301		*
302		* @return \Symfony\Component\HttpFoundation\JsonResponse
303		*/
304		public function apiUninstall(Plugin $Plugin, EventDispatcherInterface $dispatcher)
305		{
306		$this->isTokenValid();
307
308		// .maintenanceファイルを設置
309		$this->systemService->switchMaintenance(true);
310
311		// TERMINATE時のイベントを設定
312		$dispatcher->addListener(KernelEvents::TERMINATE, function () {
313		// .maintenanceファイルを削除
314		$this->systemService->switchMaintenance();
315		});
316
317		$this->cacheUtil->clearCache();
318
319		if ($Plugin->isEnabled()) {
320		return $this->json(['success' => false, 'message' => trans('admin.plugin.uninstall.error.not_disable')], 400);
321		}
322
323		$pluginCode = $Plugin->getCode();
324		$otherDepend = $this->pluginService->findDependentPlugin($pluginCode);
325
326		if (!empty($otherDepend)) {
327		$DependPlugin = $this->pluginRepository->findOneBy(['code' => $otherDepend[0]]);
328		$dependName = $otherDepend[0];
329		if ($DependPlugin) {
330		$dependName = $DependPlugin->getName();
331		}
332		$message = trans('admin.plugin.uninstall.depend', ['%name%' => $Plugin->getName(), '%depend_name%' => $dependName]);
333
334		return $this->json(['success' => false, 'message' => $message], 400);
335		}
336
337		$pluginCode = $Plugin->getCode();
338		$packageName = self::$vendorName.'/'.$pluginCode;
339
340		try {
341		$log = $this->composerService->execRemove($packageName);
342
343		return $this->json(['success' => false, 'log' => $log]);
344		} catch (\Exception $e) {
345		log_error($e);
346
347		return $this->json(['success' => false, 'log' => $e->getMessage()], 500);
348		}
349		}
350
351		/**
352		* オーナーズブラグインインストール、アップデート
353		*
354		* @Route("/upgrade", name="admin_store_plugin_api_upgrade", methods={"POST"})
355		*
356		* @param Request $request
357		*
358		* @return \Symfony\Component\HttpFoundation\JsonResponse
359		*/
360		public function apiUpgrade(Request $request, EventDispatcherInterface $dispatcher)
361		{
362		$this->isTokenValid();
363
364		// .maintenanceファイルを設置
365		$this->systemService->switchMaintenance(true);
366
367		// TERMINATE時のイベントを設定
368		$dispatcher->addListener(KernelEvents::TERMINATE, function () {
369		// .maintenanceファイルを削除
370		$this->systemService->switchMaintenance();
371		});
372
373		$this->cacheUtil->clearCache();
374
375		$pluginCode = $request->get('pluginCode');
376		$version = $request->get('version');
377
378		$log = null;
379		try {
380		$log = $this->composerService->execRequire('ec-cube/'.$pluginCode.':'.$version);
381		return $this->json(['success' => true, 'log' => $log]);
382		} catch (\Exception $e) {
383		$log = $e->getMessage();
384		log_error($e);
385		}
386
387		return $this->json(['success' => false, 'log' => $log], 500);
388		}
389
390		/**
391		* オーナーズブラグインインストール、スキーマ更新
392		*
393		* @Route("/schema_update", name="admin_store_plugin_api_schema_update", methods={"POST"})
394		*
395		* @param Request $request
396		*
397		* @return \Symfony\Component\HttpFoundation\JsonResponse
398		*/
399		public function apiSchemaUpdate(Request $request)
400		{
401		$this->isTokenValid();
402
403		$this->cacheUtil->clearCache();
404
405		$pluginCode = $request->get('pluginCode');
406
407		try {
408		$Plugin = $this->pluginRepository->findByCode($pluginCode);
409
410		if (!$Plugin) {
411		throw new NotFoundHttpException();
412		}
413
414		$config = $this->pluginService->readConfig($this->pluginService->calcPluginDir($Plugin->getCode()));
415
416		ob_start();
417		$this->pluginService->generateProxyAndUpdateSchema($Plugin, $config);
418
419		// 初期化されていなければインストール処理を実行する
420		if (!$Plugin->isInitialized()) {
421		$this->pluginService->callPluginManagerMethod($config, 'install');
422		$Plugin->setInitialized(true);
423		$this->entityManager->persist($Plugin);
424		$this->entityManager->flush();
425		}
426
427		$log = ob_get_clean();
428		while (ob_get_level() > 0) {
429		ob_end_flush();
430		}
431
432		return $this->json(['success' => true, 'log' => $log]);
433		} catch (\Exception $e) {
434		$log = $e->getMessage();
435		log_error($e);
436
437		return $this->json(['success' => false, 'log' => $log], 500);
438		}
439		}
440
441		/**
442		* オーナーズブラグインインストール、更新処理
443		*
444		* @Route("/update", name="admin_store_plugin_api_update", methods={"POST"})
445		*
446		* @param Request $request
447		*
448		* @return \Symfony\Component\HttpFoundation\JsonResponse
449		*/
450		public function apiUpdate(Request $request)
451		{
452		$this->isTokenValid();
453
454		$this->cacheUtil->clearCache();
455
456		$pluginCode = $request->get('pluginCode');
457
458		$log = null;
459		try {
460		$Plugin = $this->pluginRepository->findByCode($pluginCode);
461		if (!$Plugin) {
462		throw new NotFoundHttpException();
463		}
464
465		$config = $this->pluginService->readConfig($this->pluginService->calcPluginDir($Plugin->getCode()));
466		ob_start();
467		$this->pluginService->updatePlugin($Plugin, $config);
468		$log = ob_get_clean();
469		while (ob_get_level() > 0) {
470		ob_end_flush();
471		}
472
473		return $this->json(['success' => true, 'log' => $log]);
474		} catch (\Exception $e) {
475		$log = $e->getMessage();
476		log_error($e);
477		}
478
479		return $this->json(['success' => false, 'log' => $log], 500);
480		}
481
482		/**
483		* Do confirm update page
484		*
485		* @Route("/upgrade/{id}/confirm", requirements={"id" = "\d+"}, name="admin_store_plugin_update_confirm")
486		* @Template("@admin/Store/plugin_confirm.twig")
487		*
488		* @param Plugin $Plugin
489		*
490		* @return array
491		*/
492		public function doUpdateConfirm(Plugin $Plugin)
493		{
494		try {
495		$item = $this->pluginApiService->getPlugin($Plugin->getSource());
496
497		return [
498		'item' => $item,
499		'requires' => [],
500		'is_update' => true,
501		'Plugin' => $Plugin,
502		];
503		} catch (PluginApiException $e) {
504		$this->addError($e->getMessage(), 'admin');
505
506		return $this->redirectToRoute('admin_store_authentication_setting');
507		}
508		}
509		}
510

EC-CUBE / ec-cube

Pull Request — 4.0 (#4000)

OwnerStoreController::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like