Completed
Pull Request — experimental/3.1 (#2669)
by
unknown
34:00 queued 06:13
created
eccube_install.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -400,15 +400,15 @@
 block discarded – undo
400 400
     foreach ($finder as $content) {
401 401
         $permission = $content->getPerms();
402 402
         // see also http://www.php.net/fileperms
403
-        if (!($permission & 0x0010) || !($permission & 0x0002)) {
403
+        if (!($permission&0x0010) || !($permission&0x0002)) {
404 404
             $realPath = $content->getRealPath();
405 405
             if ($verbose) {
406 406
                 out(sprintf('%s %s to ', $realPath, substr(sprintf('%o', $permission), -4)), 'info', false);
407 407
             }
408
-            $permission = !($permission & 0x0020) ? $permission += 040 : $permission; // g+r
409
-            $permission = !($permission & 0x0010) ? $permission += 020 : $permission; // g+w
410
-            $permission = !($permission & 0x0004) ? $permission += 04 : $permission;  // o+r
411
-            $permission = !($permission & 0x0002) ? $permission += 02 : $permission;  // o+w
408
+            $permission = !($permission&0x0020) ? $permission += 040 : $permission; // g+r
409
+            $permission = !($permission&0x0010) ? $permission += 020 : $permission; // g+w
410
+            $permission = !($permission&0x0004) ? $permission += 04 : $permission; // o+r
411
+            $permission = !($permission&0x0002) ? $permission += 02 : $permission; // o+w
412 412
             $result = chmod($realPath, $permission);
413 413
             if ($verbose) {
414 414
                 if ($result) {
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/SecurityType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -92,19 +92,19 @@
 block discarded – undo
92 92
                 'label' => 'SSLを強制',
93 93
                 'required' => false,
94 94
             ))
95
-            ->addEventListener(FormEvents::POST_SUBMIT, function ($event) use($app) {
95
+            ->addEventListener(FormEvents::POST_SUBMIT, function($event) use($app) {
96 96
                 $form = $event->getForm();
97 97
                 $data = $form->getData();
98 98
 
99 99
                 $ips = preg_split("/\R/", $data['admin_allow_hosts'], null, PREG_SPLIT_NO_EMPTY);
100 100
 
101
-                foreach($ips as $ip) {
101
+                foreach ($ips as $ip) {
102 102
                     $errors = $this->recursiveValidator->validate($ip, array(
103 103
                             new Assert\Ip(),
104 104
                         )
105 105
                     );
106 106
                     if ($errors->count() != 0) {
107
-                        $form['admin_allow_hosts']->addError(new FormError($ip . 'はIPv4アドレスではありません。'));
107
+                        $form['admin_allow_hosts']->addError(new FormError($ip.'はIPv4アドレスではありません。'));
108 108
                     }
109 109
                 }
110 110
             })
Please login to merge, or discard this patch.
install.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     apc_clear_cache();
27 27
 }
28 28
 
29
-require __DIR__ . '/autoload.php';
29
+require __DIR__.'/autoload.php';
30 30
 
31 31
 set_time_limit(0);
32 32
 ini_set('memory_limit', -1);
Please login to merge, or discard this patch.
index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
 $loader = require __DIR__.'/autoload.php';
26 26
 
27 27
 ini_set('display_errors', 'Off');
28
-error_reporting(E_ALL & ~E_DEPRECATED & ~E_STRICT);
28
+error_reporting(E_ALL&~E_DEPRECATED&~E_STRICT);
29 29
 
30 30
 // see http://silex.sensiolabs.org/doc/web_servers.html#php-5-4
31 31
 $filename = __DIR__.preg_replace('#(\?.*)$#', '', $_SERVER['REQUEST_URI']);
Please login to merge, or discard this patch.
src/Eccube/Form/Type/Admin/ShippingType.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
                 'allow_delete' => true,
208 208
                 'prototype' => true,
209 209
             ))
210
-            ->addEventListener(FormEvents::POST_SET_DATA, function (FormEvent $event) {
210
+            ->addEventListener(FormEvents::POST_SET_DATA, function(FormEvent $event) {
211 211
                 /** @var \Eccube\Entity\Shipping $data */
212 212
                 $data = $event->getData();
213 213
                 /** @var \Symfony\Component\Form\Form $form */
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
                     'placeholder' => '指定なし',
229 229
                     'required' => false,
230 230
                     'data' => $DeliveryTime,
231
-                    'query_builder' => function (EntityRepository $er) use ($Delivery) {
231
+                    'query_builder' => function(EntityRepository $er) use ($Delivery) {
232 232
                         $qb = $er->createQueryBuilder('dt');
233 233
                         if ($Delivery) {
234 234
                             $qb
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
                     'mapped' => false,
241 241
                 ));
242 242
             })
243
-            ->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
243
+            ->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) {
244 244
                 $data = $event->getData();
245 245
                 $form = $event->getForm();
246 246
 
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
                     'choice_label' => 'delivery_time',
262 262
                     'placeholder' => '指定なし',
263 263
                     'required' => false,
264
-                    'query_builder' => function (EntityRepository $er) use ($Delivery) {
264
+                    'query_builder' => function(EntityRepository $er) use ($Delivery) {
265 265
                         $qb = $er->createQueryBuilder('dt');
266 266
                         if ($Delivery) {
267 267
                             $qb
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
                     'mapped' => false,
274 274
                 ));
275 275
             })
276
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) {
276
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) {
277 277
                 $form = $event->getForm();
278 278
                 $OrderItems = $form['OrderItems']->getData();
279 279
 
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
                     $form['shipping_delivery_date']->addError(new FormError('商品が追加されていません。'));
283 283
                 }
284 284
             })
285
-            ->addEventListener(FormEvents::POST_SUBMIT, function (FormEvent $event) {
285
+            ->addEventListener(FormEvents::POST_SUBMIT, function(FormEvent $event) {
286 286
                 $form = $event->getForm();
287 287
                 $Shipping = $event->getData();
288 288
                 $Delivery = $Shipping->getDelivery();
Please login to merge, or discard this patch.
src/Eccube/ServiceProvider/EccubePluginServiceProvider.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
     public function register(Container $app)
27 27
     {
28 28
         // EventDispatcher
29
-        $app['eccube.event.dispatcher'] = function () use ($app) {
29
+        $app['eccube.event.dispatcher'] = function() use ($app) {
30 30
             return $app['dispatcher'];
31 31
         };
32 32
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
         $enabledPlugins = $app['orm.em']->getRepository('Eccube\Entity\Plugin')->findAllEnabled();
37 37
 
38
-        $app['eccube.routers.plugin'] = function ($app) use ($enabledPlugins) {
38
+        $app['eccube.routers.plugin'] = function($app) use ($enabledPlugins) {
39 39
             $pluginDirs = array_map(function($plugin) use ($app) {
40 40
                 return $app['config']['root_dir'].'/app/Plugin/'.$plugin->getCode();
41 41
             }, $enabledPlugins);
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             $config = $pluginConfig['config'];
63 63
 
64 64
             if (isset($config['const'])) {
65
-                $app->extend('config', function ($eccubeConfig) use ($config) {
65
+                $app->extend('config', function($eccubeConfig) use ($config) {
66 66
                     $eccubeConfig[$config['code']] = array(
67 67
                         'const' => $config['const'],
68 68
                     );
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     public function initPluginEventDispatcher(Application $app)
85 85
     {
86 86
         // hook point
87
-        $app->on(KernelEvents::REQUEST, function (GetResponseEvent $event) use ($app) {
87
+        $app->on(KernelEvents::REQUEST, function(GetResponseEvent $event) use ($app) {
88 88
             if (!$event->isMasterRequest()) {
89 89
                 return;
90 90
             }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
93 93
         }, Application::EARLY_EVENT);
94 94
 
95
-        $app->on(KernelEvents::REQUEST, function (GetResponseEvent $event) use ($app) {
95
+        $app->on(KernelEvents::REQUEST, function(GetResponseEvent $event) use ($app) {
96 96
             if (!$event->isMasterRequest()) {
97 97
                 return;
98 98
             }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
102 102
         });
103 103
 
104
-        $app->on(KernelEvents::RESPONSE, function (FilterResponseEvent $event) use ($app) {
104
+        $app->on(KernelEvents::RESPONSE, function(FilterResponseEvent $event) use ($app) {
105 105
             if (!$event->isMasterRequest()) {
106 106
                 return;
107 107
             }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
111 111
         });
112 112
 
113
-        $app->on(KernelEvents::RESPONSE, function (FilterResponseEvent $event) use ($app) {
113
+        $app->on(KernelEvents::RESPONSE, function(FilterResponseEvent $event) use ($app) {
114 114
             if (!$event->isMasterRequest()) {
115 115
                 return;
116 116
             }
@@ -118,13 +118,13 @@  discard block
 block discarded – undo
118 118
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
119 119
         }, Application::LATE_EVENT);
120 120
 
121
-        $app->on(KernelEvents::TERMINATE, function (PostResponseEvent $event) use ($app) {
121
+        $app->on(KernelEvents::TERMINATE, function(PostResponseEvent $event) use ($app) {
122 122
             $route = $event->getRequest()->attributes->get('_route');
123 123
             $hookpoint = "eccube.event.controller.$route.finish";
124 124
             $app['eccube.event.dispatcher']->dispatch($hookpoint, $event);
125 125
         });
126 126
 
127
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function (\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
127
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function(\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
128 128
             if (!$event->isMasterRequest()) {
129 129
                 return;
130 130
             }
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         });
134 134
 
135 135
         // Request Event
136
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::REQUEST, function (\Symfony\Component\HttpKernel\Event\GetResponseEvent $event) use ($app) {
136
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::REQUEST, function(\Symfony\Component\HttpKernel\Event\GetResponseEvent $event) use ($app) {
137 137
 
138 138
             if (!$event->isMasterRequest()) {
139 139
                 return;
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         }, 30); // Routing(32)が解決し, 認証判定(8)が実行される前のタイミング.
165 165
 
166 166
         // Controller Event
167
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function (\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) use ($app) {
167
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::CONTROLLER, function(\Symfony\Component\HttpKernel\Event\FilterControllerEvent $event) use ($app) {
168 168
 
169 169
             if (!$event->isMasterRequest()) {
170 170
                 return;
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
         });
194 194
 
195 195
         // Response Event
196
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function (\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
196
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::RESPONSE, function(\Symfony\Component\HttpKernel\Event\FilterResponseEvent $event) use ($app) {
197 197
             if (!$event->isMasterRequest()) {
198 198
                 return;
199 199
             }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
         });
223 223
 
224 224
         // Exception Event
225
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::EXCEPTION, function (\Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) use ($app) {
225
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::EXCEPTION, function(\Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) use ($app) {
226 226
 
227 227
             if (!$event->isMasterRequest()) {
228 228
                 return;
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
         });
253 253
 
254 254
         // Terminate Event
255
-        $app->on(\Symfony\Component\HttpKernel\KernelEvents::TERMINATE, function (\Symfony\Component\HttpKernel\Event\PostResponseEvent $event) use ($app) {
255
+        $app->on(\Symfony\Component\HttpKernel\KernelEvents::TERMINATE, function(\Symfony\Component\HttpKernel\Event\PostResponseEvent $event) use ($app) {
256 256
 
257 257
             $route = $event->getRequest()->attributes->get('_route');
258 258
 
Please login to merge, or discard this patch.
src/Eccube/Resource/config/path.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,8 +1,8 @@
 block discarded – undo
1 1
 <?php return [
2 2
   'root_dir' => '%ROOT_DIR%',
3 3
   'root_urlpath' => env('ECCUBE_ROOT_URLPATH', null),
4
-  'template_code' => env('ECCUBE_TEMPLATE_CODE','default'),
5
-  'admin_route' => env('ECCUBE_ADMIN_ROUTE','admin'),
4
+  'template_code' => env('ECCUBE_TEMPLATE_CODE', 'default'),
5
+  'admin_route' => env('ECCUBE_ADMIN_ROUTE', 'admin'),
6 6
   'user_data_route' => env('ECCUBE_USER_DATA_ROUTE', 'user_data'),
7 7
   'public_path' => env('ECCUBE_ROOT_URLPATH', null).'/html',
8 8
   'public_path_realdir' => '%ROOT_DIR%/html',
Please login to merge, or discard this patch.
src/Eccube/Doctrine/Common/CsvDataFixtures/CsvFixture.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
         }
35 35
 
36 36
         // CSV Reader に設定
37
-        $this->file->setFlags(\SplFileObject::READ_CSV | \SplFileObject::READ_AHEAD | \SplFileObject::SKIP_EMPTY |\SplFileObject::DROP_NEW_LINE);
37
+        $this->file->setFlags(\SplFileObject::READ_CSV|\SplFileObject::READ_AHEAD|\SplFileObject::SKIP_EMPTY|\SplFileObject::DROP_NEW_LINE);
38 38
 
39 39
         // ヘッダ行を取得
40 40
         $headers = $this->file->current();
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductController.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
                     }
319 319
 
320 320
                     $extension = $image->getClientOriginalExtension();
321
-                    $filename = date('mdHis') . uniqid('_') . '.' . $extension;
321
+                    $filename = date('mdHis').uniqid('_').'.'.$extension;
322 322
                     $image->move($this->appConfig['image_temp_realdir'], $filename);
323 323
                     $files[] = $filename;
324 324
                 }
@@ -479,8 +479,8 @@  discard block
 block discarded – undo
479 479
                 $Categories = $form->get('Category')->getData();
480 480
                 $categoriesIdList = array();
481 481
                 foreach ($Categories as $Category) {
482
-                    foreach($Category->getPath() as $ParentCategory){
483
-                        if (!isset($categoriesIdList[$ParentCategory->getId()])){
482
+                    foreach ($Category->getPath() as $ParentCategory) {
483
+                        if (!isset($categoriesIdList[$ParentCategory->getId()])) {
484 484
                             $ProductCategory = $this->createProductCategory($Product, $ParentCategory, $count);
485 485
                             $this->entityManager->persist($ProductCategory);
486 486
                             $count++;
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
                             $categoriesIdList[$ParentCategory->getId()] = true;
490 490
                         }
491 491
                     }
492
-                    if (!isset($categoriesIdList[$Category->getId()])){
492
+                    if (!isset($categoriesIdList[$Category->getId()])) {
493 493
                         $ProductCategory = $this->createProductCategory($Product, $Category, $count);
494 494
                         $this->entityManager->persist($ProductCategory);
495 495
                         $count++;
@@ -511,7 +511,7 @@  discard block
 block discarded – undo
511 511
                     $this->entityManager->persist($ProductImage);
512 512
 
513 513
                     // 移動
514
-                    $file = new File($this->appConfig['image_temp_realdir'] . '/' . $add_image);
514
+                    $file = new File($this->appConfig['image_temp_realdir'].'/'.$add_image);
515 515
                     $file->move($this->appConfig['image_save_realdir']);
516 516
                 }
517 517
 
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
 
532 532
                     // 削除
533 533
                     $fs = new Filesystem();
534
-                    $fs->remove($this->appConfig['image_save_realdir'] . '/' . $delete_image);
534
+                    $fs->remove($this->appConfig['image_save_realdir'].'/'.$delete_image);
535 535
                 }
536 536
                 $this->entityManager->persist($Product);
537 537
                 $this->entityManager->flush();
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
                     foreach ($deleteImages as $deleteImage) {
667 667
                         try {
668 668
                             $fs = new Filesystem();
669
-                            $fs->remove($this->appConfig['image_save_realdir'] . '/' . $deleteImage);
669
+                            $fs->remove($this->appConfig['image_save_realdir'].'/'.$deleteImage);
670 670
                         } catch (\Exception $e) {
671 671
                             // エラーが発生しても無視する
672 672
                         }
@@ -741,10 +741,10 @@  discard block
 block discarded – undo
741 741
 
742 742
                     // 画像ファイルを新規作成
743 743
                     $extension = pathinfo($Image->getFileName(), PATHINFO_EXTENSION);
744
-                    $filename = date('mdHis') . uniqid('_') . '.' . $extension;
744
+                    $filename = date('mdHis').uniqid('_').'.'.$extension;
745 745
                     try {
746 746
                         $fs = new Filesystem();
747
-                        $fs->copy($this->appConfig['image_save_realdir'] . '/' . $Image->getFileName(), $this->appConfig['image_save_realdir'] . '/' . $filename);
747
+                        $fs->copy($this->appConfig['image_save_realdir'].'/'.$Image->getFileName(), $this->appConfig['image_save_realdir'].'/'.$filename);
748 748
                     } catch (\Exception $e) {
749 749
                         // エラーが発生しても無視する
750 750
                     }
@@ -824,7 +824,7 @@  discard block
 block discarded – undo
824 824
         $em->getConfiguration()->setSQLLogger(null);
825 825
 
826 826
         $response = new StreamedResponse();
827
-        $response->setCallback(function () use ($app, $request) {
827
+        $response->setCallback(function() use ($app, $request) {
828 828
 
829 829
             // CSV種別を元に初期化.
830 830
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_PRODUCT);
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
             // データ行の出力.
865 865
             $this->csvExportService->setExportQueryBuilder($qb);
866 866
 
867
-            $this->csvExportService->exportData(function ($entity, CsvExportService $csvService) use ($app, $request) {
867
+            $this->csvExportService->exportData(function($entity, CsvExportService $csvService) use ($app, $request) {
868 868
                 $Csvs = $csvService->getCsvs();
869 869
 
870 870
                 /** @var $Product \Eccube\Entity\Product */
@@ -907,9 +907,9 @@  discard block
 block discarded – undo
907 907
         });
908 908
 
909 909
         $now = new \DateTime();
910
-        $filename = 'product_' . $now->format('YmdHis') . '.csv';
910
+        $filename = 'product_'.$now->format('YmdHis').'.csv';
911 911
         $response->headers->set('Content-Type', 'application/octet-stream');
912
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
912
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
913 913
         $response->send();
914 914
 
915 915
         log_info('商品CSV出力ファイル名', array($filename));
Please login to merge, or discard this patch.