Completed
Pull Request — experimental/3.1 (#2643)
by
unknown
21:16
created
src/Eccube/ServiceProvider/QueriesServiceProvider.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,6 @@
 block discarded – undo
16 16
      * This method should only be used to configure services and parameters.
17 17
      * It should not get services.
18 18
      *
19
-     * @param Container $pimple A container instance
20 19
      */
21 20
     public function register(Container $app)
22 21
     {
Please login to merge, or discard this patch.
src/Eccube/DI/AutoWiring/RepositoryDefinition.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,9 +32,9 @@
 block discarded – undo
32 32
 
33 33
     /**
34 34
      * RepositoryDefinition constructor.
35
-     * @param $id
36
-     * @param $refClass
37
-     * @param $entityClass
35
+     * @param string $id
36
+     * @param \ReflectionClass $refClass
37
+     * @param string $entityClass
38 38
      */
39 39
     public function __construct($id, $refClass, $entityClass)
40 40
     {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/OutputParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 
128 128
     /**
129 129
      * @param $rowArray
130
-     * @param $key
130
+     * @param string $key
131 131
      * @return array
132 132
      */
133 133
     private static function parseArrayInfoOutput($rowArray, $key)
Please login to merge, or discard this patch.
src/Eccube/Repository/DeliveryRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 
43 43
     /**
44 44
      * @deprecated 呼び出し元で制御する
45
-     * @param $id
45
+     * @param integer $id
46 46
      * @return Delivery|null|object
47 47
      */
48 48
     public function findOrCreate($id)
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ProductClassController.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -600,6 +600,9 @@  discard block
 block discarded – undo
600 600
     /**
601 601
      * 登録、更新時のエラー画面表示
602 602
      *
603
+     * @param Application $app
604
+     * @param boolean $not_product_class
605
+     * @param \Symfony\Component\Form\FormInterface $classForm
603 606
      */
604 607
     protected function render($app, $Product, $ProductClass, $not_product_class, $classForm, $error = null)
605 608
     {
@@ -651,6 +654,7 @@  discard block
 block discarded – undo
651 654
 
652 655
     /**
653 656
      * 規格1と規格2を組み合わせた商品規格を作成
657
+     * @param Application $app
654 658
      */
655 659
     private function createProductClasses($app, Product $Product, ClassName $ClassName1 = null, ClassName $ClassName2 = null)
656 660
     {
@@ -738,6 +742,7 @@  discard block
 block discarded – undo
738 742
      *
739 743
      * @param $productClassDest ProductClass コピー先となる商品規格
740 744
      * @param $productClassOrig ProductClass コピー元となる商品規格
745
+     * @param Application $app
741 746
      */
742 747
     private function setDefaultProductClass($app, $productClassDest, $productClassOrig) {
743 748
         $productClassDest->setDeliveryDuration($productClassOrig->getDeliveryDuration());
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/CsvImportController.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -661,6 +661,8 @@  discard block
 block discarded – undo
661 661
     /**
662 662
      * 登録、更新時のエラー画面表示
663 663
      *
664
+     * @param Application $app
665
+     * @param \Symfony\Component\Form\FormInterface $form
664 666
      */
665 667
     protected function render($app, $form, $headers)
666 668
     {
@@ -692,6 +694,7 @@  discard block
 block discarded – undo
692 694
      * アップロードされたCSVファイルの行ごとの処理
693 695
      *
694 696
      * @param $formFile
697
+     * @param Application $app
695 698
      * @return CsvImportService
696 699
      */
697 700
     protected function getImportData($app, $formFile)
@@ -769,6 +772,8 @@  discard block
 block discarded – undo
769 772
 
770 773
     /**
771 774
      * 商品カテゴリの削除、登録
775
+     * @param Application $app
776
+     * @param CsvImportService $data
772 777
      */
773 778
     protected function createProductCategory($row, Product $Product, $app, $data)
774 779
     {
@@ -868,6 +873,8 @@  discard block
 block discarded – undo
868 873
 
869 874
     /**
870 875
      * 商品規格分類1、商品規格分類2がnullとなる商品規格情報を作成
876
+     * @param Application $app
877
+     * @param CsvImportService $data
871 878
      */
872 879
     protected function createProductClass($row, Product $Product, $app, $data, $ClassCategory1 = null, $ClassCategory2 = null)
873 880
     {
@@ -1000,6 +1007,8 @@  discard block
 block discarded – undo
1000 1007
 
1001 1008
     /**
1002 1009
      * 商品規格情報を更新
1010
+     * @param Application $app
1011
+     * @param CsvImportService $data
1003 1012
      */
1004 1013
     protected function updateProductClass($row, Product $Product, ProductClass $ProductClass, $app, $data)
1005 1014
     {
@@ -1136,6 +1145,7 @@  discard block
 block discarded – undo
1136 1145
     /**
1137 1146
      * 登録、更新時のエラー画面表示
1138 1147
      *
1148
+     * @param string $message
1139 1149
      */
1140 1150
     protected function addErrors($message)
1141 1151
     {
@@ -1209,6 +1219,7 @@  discard block
 block discarded – undo
1209 1219
      * ProductCategory作成
1210 1220
      * @param \Eccube\Entity\Product $Product
1211 1221
      * @param \Eccube\Entity\Category $Category
1222
+     * @param integer $sortNo
1212 1223
      * @return ProductCategory
1213 1224
      */
1214 1225
     private function makeProductCategory($Product, $Category, $sortNo)
Please login to merge, or discard this patch.
src/Eccube/Service/PluginService.php 1 patch
Doc Comments   +22 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      *
115 115
      * @param string $path   path to tar.gz/zip plugin file
116 116
      * @param int    $source
117
-     * @return mixed
117
+     * @return boolean
118 118
      * @throws PluginException
119 119
      * @throws \Exception
120 120
      */
@@ -177,6 +177,10 @@  discard block
 block discarded – undo
177 177
     }
178 178
 
179 179
     // インストール事後処理
180
+
181
+    /**
182
+     * @param integer $source
183
+     */
180 184
     public function postInstall($config, $event, $source)
181 185
     {
182 186
         // Proxyのクラスをロードせずにスキーマを更新するために、
@@ -223,6 +227,10 @@  discard block
 block discarded – undo
223 227
         }
224 228
     }
225 229
 
230
+    /**
231
+     * @param string $archive
232
+     * @param string $dir
233
+     */
226 234
     public function unpackPluginArchive($archive, $dir)
227 235
     {
228 236
         $extension = pathinfo($archive, PATHINFO_EXTENSION);
@@ -282,6 +290,9 @@  discard block
 block discarded – undo
282 290
         }
283 291
     }
284 292
 
293
+    /**
294
+     * @param string $yml
295
+     */
285 296
     public function readYml($yml)
286 297
     {
287 298
         if (file_exists($yml)) {
@@ -299,6 +310,9 @@  discard block
 block discarded – undo
299 310
         // ディレクトリ名などに使われれるので厳しめ
300 311
     }
301 312
 
313
+    /**
314
+     * @param string $path
315
+     */
302 316
     public function deleteFile($path)
303 317
     {
304 318
         $f = new Filesystem();
@@ -318,6 +332,9 @@  discard block
 block discarded – undo
318 332
         return $this->appConfig['plugin_realdir'].'/'.$name;
319 333
     }
320 334
 
335
+    /**
336
+     * @param string $d
337
+     */
321 338
     public function createPluginDir($d)
322 339
     {
323 340
         $b = @mkdir($d);
@@ -375,6 +392,9 @@  discard block
 block discarded – undo
375 392
         return $p;
376 393
     }
377 394
 
395
+    /**
396
+     * @param string $method
397
+     */
378 398
     public function callPluginManagerMethod($meta, $method)
379 399
     {
380 400
         $class = '\\Plugin'.'\\'.$meta['code'].'\\'.'PluginManager';
@@ -867,7 +887,7 @@  discard block
 block discarded – undo
867 887
     /**
868 888
      * @param string $pluginVersion
869 889
      * @param string $remoteVersion
870
-     * @return mixed
890
+     * @return boolean
871 891
      */
872 892
     public function isUpdate($pluginVersion, $remoteVersion)
873 893
     {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerApiService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@
 block discarded – undo
234 234
 
235 235
     /**
236 236
      * Get mode
237
-     * @return mixed|string
237
+     * @return string
238 238
      */
239 239
     public function getMode()
240 240
     {
Please login to merge, or discard this patch.
src/Eccube/Service/Composer/ComposerProcessService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@
 block discarded – undo
234 234
 
235 235
     /**
236 236
      * Get mode
237
-     * @return mixed|string
237
+     * @return string
238 238
      */
239 239
     public function getMode()
240 240
     {
Please login to merge, or discard this patch.