| Conditions | 16 |
| Paths | 145 |
| Total Lines | 210 |
| Code Lines | 120 |
| Lines | 19 |
| Ratio | 9.05 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 42 | public function edit(Application $app, Request $request, $id = null) |
||
| 43 | { |
||
| 44 | /* @var $softDeleteFilter \Eccube\Doctrine\Filter\SoftDeleteFilter */ |
||
| 45 | $softDeleteFilter = $app['orm.em']->getFilters()->getFilter('soft_delete'); |
||
| 46 | $softDeleteFilter->setExcludes(array( |
||
| 47 | 'Eccube\Entity\ProductClass', |
||
| 48 | 'Eccube\Entity\Product', |
||
| 49 | )); |
||
| 50 | |||
| 51 | $TargetOrder = null; |
||
| 52 | $OriginOrder = null; |
||
| 53 | |||
| 54 | if (is_null($id)) { |
||
| 55 | // 空のエンティティを作成. |
||
| 56 | $TargetOrder = new Shipping(); |
||
| 57 | } else { |
||
| 58 | $TargetOrder = $app['eccube.repository.shipping']->find($id); |
||
| 59 | if (is_null($TargetOrder)) { |
||
| 60 | throw new NotFoundHttpException(); |
||
| 61 | } |
||
| 62 | } |
||
| 63 | |||
| 64 | // 編集前の受注情報を保持 |
||
| 65 | $OriginOrder = clone $TargetOrder; |
||
| 66 | $OriginalOrderDetails = new ArrayCollection(); |
||
| 67 | // 編集前のお届け先情報を保持 |
||
| 68 | $OriginalShippings = new ArrayCollection(); |
||
| 69 | // 編集前のお届け先のアイテム情報を保持 |
||
| 70 | $OriginalShipmentItems = new ArrayCollection(); |
||
| 71 | |||
| 72 | foreach ($TargetOrder->getShipmentItems() as $OrderDetail) { |
||
| 73 | $OriginalOrderDetails->add($OrderDetail); |
||
| 74 | } |
||
| 75 | |||
| 76 | // // 編集前の情報を保持 |
||
| 77 | // foreach ($TargetOrder->getShippings() as $tmpOriginalShippings) { |
||
| 78 | // foreach ($tmpOriginalShippings->getShipmentItems() as $tmpOriginalShipmentItem) { |
||
| 79 | // // アイテム情報 |
||
| 80 | // $OriginalShipmentItems->add($tmpOriginalShipmentItem); |
||
| 81 | // } |
||
| 82 | // // お届け先情報 |
||
| 83 | // $OriginalShippings->add($tmpOriginalShippings); |
||
| 84 | // } |
||
| 85 | |||
| 86 | $builder = $app['form.factory'] |
||
| 87 | ->createBuilder(ShippingType::class, $TargetOrder); |
||
| 88 | |||
| 89 | $event = new EventArgs( |
||
| 90 | array( |
||
| 91 | 'builder' => $builder, |
||
| 92 | 'OriginOrder' => $OriginOrder, |
||
| 93 | 'TargetOrder' => $TargetOrder, |
||
| 94 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 95 | ), |
||
| 96 | $request |
||
| 97 | ); |
||
| 98 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_INDEX_INITIALIZE, $event); |
||
| 99 | |||
| 100 | $form = $builder->getForm(); |
||
| 101 | $form->handleRequest($request); |
||
| 102 | |||
| 103 | if ($form->isSubmitted()) { |
||
| 104 | $event = new EventArgs( |
||
| 105 | array( |
||
| 106 | 'builder' => $builder, |
||
| 107 | 'OriginOrder' => $OriginOrder, |
||
| 108 | 'TargetOrder' => $TargetOrder, |
||
| 109 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 110 | ), |
||
| 111 | $request |
||
| 112 | ); |
||
| 113 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_INDEX_PROGRESS, $event); |
||
| 114 | |||
| 115 | // FIXME 税額計算は CalculateService で処理する. ここはテストを通すための暫定処理 |
||
| 116 | // see EditControllerTest::testOrderProcessingWithTax |
||
| 117 | $OrderDetails = $TargetOrder->getShipmentItems(); |
||
| 118 | $taxtotal = 0; |
||
| 119 | foreach ($OrderDetails as $OrderDetail) { |
||
| 120 | $tax = $app['eccube.service.tax_rule'] |
||
| 121 | ->calcTax($OrderDetail->getPrice(), $OrderDetail->getTaxRate(), $OrderDetail->getTaxRule()); |
||
| 122 | $OrderDetail->setPriceIncTax($OrderDetail->getPrice() + $tax); |
||
| 123 | |||
| 124 | $taxtotal += $tax * $OrderDetail->getQuantity(); |
||
| 125 | } |
||
| 126 | |||
| 127 | // 登録ボタン押下 |
||
| 128 | switch ($request->get('mode')) { |
||
| 129 | case 'register_and_commit': |
||
| 130 | if ($form->isValid()) { |
||
| 131 | $TargetOrder->setCommitDate(new \DateTime()); |
||
| 132 | } |
||
| 133 | // no break |
||
| 134 | case 'register': |
||
| 135 | |||
| 136 | log_info('出荷登録開始', array($TargetOrder->getId())); |
||
| 137 | // TODO 在庫の有無や販売制限数のチェックなども行う必要があるため、完了処理もcaluclatorのように抽象化できないか検討する. |
||
| 138 | if ($form->isValid()) { |
||
| 139 | |||
| 140 | $BaseInfo = $app['eccube.repository.base_info']->get(); |
||
| 141 | |||
| 142 | // TODO 後続にある会員情報の更新のように、完了処理もcaluclatorのように抽象化できないか検討する. |
||
| 143 | |||
| 144 | // 画面上で削除された明細をremove |
||
| 145 | foreach ($OriginalOrderDetails as $OrderDetail) { |
||
| 146 | if (false === $TargetOrder->getShipmentItems()->contains($OrderDetail)) { |
||
| 147 | $OrderDetail->setShipping(null); |
||
| 148 | } |
||
| 149 | } |
||
| 150 | |||
| 151 | foreach ($TargetOrder->getShipmentItems() as $ShipmentItem) { |
||
| 152 | $ShipmentItem->setShipping($TargetOrder); |
||
| 153 | } |
||
| 154 | $app['orm.em']->persist($TargetOrder); |
||
| 155 | $app['orm.em']->flush(); |
||
| 156 | |||
| 157 | $event = new EventArgs( |
||
| 158 | array( |
||
| 159 | 'form' => $form, |
||
| 160 | 'OriginOrder' => $OriginOrder, |
||
| 161 | 'TargetOrder' => $TargetOrder, |
||
| 162 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 163 | //'Customer' => $Customer, |
||
| 164 | ), |
||
| 165 | $request |
||
| 166 | ); |
||
| 167 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_INDEX_COMPLETE, $event); |
||
| 168 | |||
| 169 | $app->addSuccess('admin.order.save.complete', 'admin'); |
||
| 170 | |||
| 171 | log_info('受注登録完了', array($TargetOrder->getId())); |
||
| 172 | |||
| 173 | return $app->redirect($app->url('admin/shipping/edit', array('id' => $TargetOrder->getId()))); |
||
| 174 | } |
||
| 175 | |||
| 176 | break; |
||
| 177 | |||
| 178 | View Code Duplication | case 'add_delivery': |
|
| 179 | // お届け先情報の新規追加 |
||
| 180 | |||
| 181 | $form = $builder->getForm(); |
||
| 182 | |||
| 183 | $Shipping = new \Eccube\Entity\Shipping(); |
||
| 184 | $TargetOrder->addShipping($Shipping); |
||
| 185 | |||
| 186 | $Shipping->setOrder($TargetOrder); |
||
| 187 | |||
| 188 | $form->setData($TargetOrder); |
||
| 189 | |||
| 190 | break; |
||
| 191 | |||
| 192 | default: |
||
| 193 | break; |
||
| 194 | } |
||
| 195 | } |
||
| 196 | |||
| 197 | // 会員検索フォーム |
||
| 198 | $builder = $app['form.factory'] |
||
| 199 | ->createBuilder(SearchCustomerType::class); |
||
| 200 | |||
| 201 | $event = new EventArgs( |
||
| 202 | array( |
||
| 203 | 'builder' => $builder, |
||
| 204 | 'OriginOrder' => $OriginOrder, |
||
| 205 | 'TargetOrder' => $TargetOrder, |
||
| 206 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 207 | ), |
||
| 208 | $request |
||
| 209 | ); |
||
| 210 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_SEARCH_CUSTOMER_INITIALIZE, $event); |
||
| 211 | |||
| 212 | $searchCustomerModalForm = $builder->getForm(); |
||
| 213 | |||
| 214 | // 商品検索フォーム |
||
| 215 | $builder = $app['form.factory'] |
||
| 216 | ->createBuilder(SearchProductType::class); |
||
| 217 | |||
| 218 | $event = new EventArgs( |
||
| 219 | array( |
||
| 220 | 'builder' => $builder, |
||
| 221 | 'OriginOrder' => $OriginOrder, |
||
| 222 | 'TargetOrder' => $TargetOrder, |
||
| 223 | 'OriginOrderDetails' => $OriginalOrderDetails, |
||
| 224 | ), |
||
| 225 | $request |
||
| 226 | ); |
||
| 227 | $app['eccube.event.dispatcher']->dispatch(EccubeEvents::ADMIN_ORDER_EDIT_SEARCH_PRODUCT_INITIALIZE, $event); |
||
| 228 | |||
| 229 | $searchProductModalForm = $builder->getForm(); |
||
| 230 | |||
| 231 | // 配送業者のお届け時間 |
||
| 232 | $times = array(); |
||
| 233 | $deliveries = $app['eccube.repository.delivery']->findAll(); |
||
| 234 | View Code Duplication | foreach ($deliveries as $Delivery) { |
|
| 235 | $deliveryTiems = $Delivery->getDeliveryTimes(); |
||
| 236 | foreach ($deliveryTiems as $DeliveryTime) { |
||
| 237 | $times[$Delivery->getId()][$DeliveryTime->getId()] = $DeliveryTime->getDeliveryTime(); |
||
| 238 | } |
||
| 239 | } |
||
| 240 | |||
| 241 | return [ |
||
| 242 | 'form' => $form->createView(), |
||
| 243 | 'shippingForm' => $form->createView(), |
||
| 244 | 'searchCustomerModalForm' => $searchCustomerModalForm->createView(), |
||
| 245 | 'searchProductModalForm' => $searchProductModalForm->createView(), |
||
| 246 | 'Order' => $TargetOrder, // Deprecated |
||
| 247 | 'Shipping' => $TargetOrder, |
||
| 248 | 'id' => $id, |
||
| 249 | 'shippingDeliveryTimes' => $app['serializer']->serialize($times, 'json'), |
||
| 250 | ]; |
||
| 251 | } |
||
| 252 | |||
| 345 |