Completed
Pull Request — 3.0.9-dev (#1486)
by chihiro
205:27 queued 169:12
created
html/install.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,11 +26,11 @@
 block discarded – undo
26 26
     apc_clear_cache();
27 27
 }
28 28
 
29
-require __DIR__ . '/../autoload.php';
29
+require __DIR__.'/../autoload.php';
30 30
 
31 31
 $app = new Eccube\InstallApplication();
32 32
 $app['debug'] = true;
33
-$app->before(function (\Symfony\Component\HttpFoundation\Request $request, \Silex\Application $app) {
33
+$app->before(function(\Symfony\Component\HttpFoundation\Request $request, \Silex\Application $app) {
34 34
     if (!$request->getSession()->isStarted()) {
35 35
         $request->getSession()->start();
36 36
     }
Please login to merge, or discard this patch.
src/Eccube/Controller/AbstractController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     protected function getBoundForm(Application $app, $type)
39 39
     {
40 40
         $form = $app['form.factory']
41
-            ->createBuilder($app['eccube.form.type.' . $type], $app['eccube.entity.' . $type])
41
+            ->createBuilder($app['eccube.form.type.'.$type], $app['eccube.entity.'.$type])
42 42
             ->getForm();
43 43
         $form->handleRequest($app['request']);
44 44
 
Please login to merge, or discard this patch.
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -52,11 +52,17 @@
 block discarded – undo
52 52
         return $form;
53 53
     }
54 54
 
55
+    /**
56
+     * @param Application $app
57
+     */
55 58
     protected function getSecurity($app)
56 59
     {
57 60
         return $app['security.token_storage'];
58 61
     }
59 62
 
63
+    /**
64
+     * @param Application $app
65
+     */
60 66
     protected function isTokenValid($app)
61 67
     {
62 68
         $csrf = $app['form.csrf_provider'];
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/AdminController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     {
56 56
         // install.phpのチェック.
57 57
         if (isset($app['config']['eccube_install']) && $app['config']['eccube_install'] == 1) {
58
-            $file = $app['config']['root_dir'] . '/html/install.php';
58
+            $file = $app['config']['root_dir'].'/html/install.php';
59 59
             if (file_exists($file)) {
60 60
                 $app->addWarning('admin.install.warning', 'admin');
61 61
             }
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
                     t1.status
185 185
                 ORDER BY
186 186
                     t1.status';
187
-        $rsm = new ResultSetMapping();;
187
+        $rsm = new ResultSetMapping(); ;
188 188
         $rsm->addScalarResult('status', 'status');
189 189
         $rsm->addScalarResult('count', 'count');
190 190
         $query = $em->createNativeQuery($sql, $rsm);
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/LayoutController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -89,20 +89,20 @@  discard block
 block discarded – undo
89 89
                 $max = count($Blocks);
90 90
                 for ($i = 0; $i < $max; $i++) {
91 91
                     // block_id が取得できない場合は INSERT しない
92
-                    if (!isset($data['id_' . $i])) {
92
+                    if (!isset($data['id_'.$i])) {
93 93
                         continue;
94 94
                     }
95 95
                     // 未使用は INSERT しない
96
-                    if ($data['target_id_' . $i] == \Eccube\Entity\PageLayout::TARGET_ID_UNUSED) {
96
+                    if ($data['target_id_'.$i] == \Eccube\Entity\PageLayout::TARGET_ID_UNUSED) {
97 97
                         continue;
98 98
                     }
99 99
                     // 他のページに anywhere が存在する場合は INSERT しない
100
-                    $anywhere = (isset($data['anywhere_' . $i]) && $data['anywhere_' . $i] == 1) ? 1 : 0;
101
-                    if (isset($data['anywhere_' . $i]) && $data['anywhere_' . $i] == 1) {
100
+                    $anywhere = (isset($data['anywhere_'.$i]) && $data['anywhere_'.$i] == 1) ? 1 : 0;
101
+                    if (isset($data['anywhere_'.$i]) && $data['anywhere_'.$i] == 1) {
102 102
                         $Other = $app['orm.em']->getRepository('Eccube\Entity\BlockPosition')
103 103
                             ->findBy(array(
104 104
                                 'anywhere' => 1,
105
-                                'block_id' => $data['id_' . $i],
105
+                                'block_id' => $data['id_'.$i],
106 106
                             ));
107 107
                         if (count($Other) > 0) {
108 108
                             continue;
@@ -112,14 +112,14 @@  discard block
 block discarded – undo
112 112
                     $BlockPosition = new \Eccube\Entity\BlockPosition();
113 113
                     $Block = $app['orm.em']->getRepository('Eccube\Entity\Block')
114 114
                         ->findOneBy(array(
115
-                            'id' => $data['id_' . $i],
115
+                            'id' => $data['id_'.$i],
116 116
                             'DeviceType' => $DeviceType,
117 117
                         ));
118 118
                     $BlockPosition
119 119
                         ->setPageId($id)
120
-                        ->setBlockId($data['id_' . $i])
121
-                        ->setBlockRow($data['top_' . $i])
122
-                        ->setTargetId($data['target_id_' . $i])
120
+                        ->setBlockId($data['id_'.$i])
121
+                        ->setBlockRow($data['top_'.$i])
122
+                        ->setTargetId($data['target_id_'.$i])
123 123
                         ->setBlock($Block)
124 124
                         ->setPageLayout($TargetPageLayout)
125 125
                         ->setAnywhere($anywhere);
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Content/PageController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
                 // ファイル生成・更新
91 91
                 $templatePath = $app['eccube.repository.page_layout']->getWriteTemplatePath($editable);
92
-                $filePath = $templatePath . '/' . $PageLayout->getFileName() . '.twig';
92
+                $filePath = $templatePath.'/'.$PageLayout->getFileName().'.twig';
93 93
 
94 94
                 $fs = new Filesystem();
95 95
                 $fs->dumpFile($filePath, $form->get('tpl_data')->getData());
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
                 $app->addSuccess('admin.register.complete', 'admin');
98 98
 
99 99
                 // twig キャッシュの削除.
100
-                $finder = Finder::create()->in($app['config']['root_dir'] . '/app/cache/twig');
100
+                $finder = Finder::create()->in($app['config']['root_dir'].'/app/cache/twig');
101 101
                 $fs->remove($finder);
102 102
 
103 103
                 return $app->redirect($app->url('admin_content_page_edit', array('id' => $PageLayout->getId())));
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
         if ($PageLayout->getEditFlg() == PageLayout::EDIT_FLG_USER) {
137 137
             $templatePath = $app['eccube.repository.page_layout']
138 138
                 ->getWriteTemplatePath($DeviceType, true);
139
-            $file = $templatePath . '/' . $PageLayout->getFileName() . '.twig';
139
+            $file = $templatePath.'/'.$PageLayout->getFileName().'.twig';
140 140
             $fs = new Filesystem();
141 141
             if ($fs->exists($file)) {
142 142
                 $fs->remove($file);
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Customer/CustomerController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         $em->getConfiguration()->setSQLLogger(null);
172 172
 
173 173
         $response = new StreamedResponse();
174
-        $response->setCallback(function () use ($app, $request) {
174
+        $response->setCallback(function() use ($app, $request) {
175 175
 
176 176
             // CSV種別を元に初期化.
177 177
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_CUSTOMER);
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
             // データ行の出力.
187 187
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
188
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
188
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
189 189
 
190 190
                 $Csvs = $csvService->getCsvs();
191 191
 
@@ -207,9 +207,9 @@  discard block
 block discarded – undo
207 207
         });
208 208
 
209 209
         $now = new \DateTime();
210
-        $filename = 'customer_' . $now->format('YmdHis') . '.csv';
210
+        $filename = 'customer_'.$now->format('YmdHis').'.csv';
211 211
         $response->headers->set('Content-Type', 'application/octet-stream');
212
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
212
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
213 213
         $response->send();
214 214
 
215 215
         return $response;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Order/OrderController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
         $em->getConfiguration()->setSQLLogger(null);
185 185
 
186 186
         $response = new StreamedResponse();
187
-        $response->setCallback(function () use ($app, $request) {
187
+        $response->setCallback(function() use ($app, $request) {
188 188
 
189 189
             // CSV種別を元に初期化.
190 190
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_ORDER);
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
             // データ行の出力.
200 200
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
201
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
201
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
202 202
 
203 203
                 $Csvs = $csvService->getCsvs();
204 204
 
@@ -228,9 +228,9 @@  discard block
 block discarded – undo
228 228
         });
229 229
 
230 230
         $now = new \DateTime();
231
-        $filename = 'order_' . $now->format('YmdHis') . '.csv';
231
+        $filename = 'order_'.$now->format('YmdHis').'.csv';
232 232
         $response->headers->set('Content-Type', 'application/octet-stream');
233
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
233
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
234 234
         $response->send();
235 235
 
236 236
         return $response;
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
         $em->getConfiguration()->setSQLLogger(null);
254 254
 
255 255
         $response = new StreamedResponse();
256
-        $response->setCallback(function () use ($app, $request) {
256
+        $response->setCallback(function() use ($app, $request) {
257 257
 
258 258
             // CSV種別を元に初期化.
259 259
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_SHIPPING);
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
 
268 268
             // データ行の出力.
269 269
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
270
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
270
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
271 271
 
272 272
                 $Csvs = $csvService->getCsvs();
273 273
 
@@ -305,9 +305,9 @@  discard block
 block discarded – undo
305 305
         });
306 306
 
307 307
         $now = new \DateTime();
308
-        $filename = 'shipping_' . $now->format('YmdHis') . '.csv';
308
+        $filename = 'shipping_'.$now->format('YmdHis').'.csv';
309 309
         $response->headers->set('Content-Type', 'application/octet-stream');
310
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
310
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
311 311
         $response->send();
312 312
 
313 313
         return $response;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/CategoryController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         $em->getConfiguration()->setSQLLogger(null);
165 165
 
166 166
         $response = new StreamedResponse();
167
-        $response->setCallback(function () use ($app, $request) {
167
+        $response->setCallback(function() use ($app, $request) {
168 168
 
169 169
             // CSV種別を元に初期化.
170 170
             $app['eccube.service.csv.export']->initCsvType(CsvType::CSV_TYPE_CATEGORY);
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 
179 179
             // データ行の出力.
180 180
             $app['eccube.service.csv.export']->setExportQueryBuilder($qb);
181
-            $app['eccube.service.csv.export']->exportData(function ($entity, $csvService) {
181
+            $app['eccube.service.csv.export']->exportData(function($entity, $csvService) {
182 182
 
183 183
                 $Csvs = $csvService->getCsvs();
184 184
 
@@ -198,9 +198,9 @@  discard block
 block discarded – undo
198 198
         });
199 199
 
200 200
         $now = new \DateTime();
201
-        $filename = 'category_' . $now->format('YmdHis') . '.csv';
201
+        $filename = 'category_'.$now->format('YmdHis').'.csv';
202 202
         $response->headers->set('Content-Type', 'application/octet-stream');
203
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
203
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
204 204
         $response->send();
205 205
 
206 206
         return $response;
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Product/ClassCategoryController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
         $num = $app['eccube.repository.product_class']->createQueryBuilder('pc')
96 96
             ->select('count(pc.id)')
97 97
             ->where('pc.ClassCategory1 = :id OR pc.ClassCategory2 = :id')
98
-            ->setParameter('id',$id)
98
+            ->setParameter('id', $id)
99 99
             ->getQuery()
100 100
             ->getSingleScalarResult();
101 101
         if ($num > 0) {
Please login to merge, or discard this patch.