Completed
Pull Request — experimental/sf (#3412)
by Kentaro
14:51 queued 07:29
created
src/Eccube/Command/PluginGenerateCommand.php 1 patch
Doc Comments   +21 added lines patch added patch discarded remove patch
@@ -147,6 +147,9 @@  discard block
 block discarded – undo
147 147
         return $version;
148 148
     }
149 149
 
150
+    /**
151
+     * @param string $pluginDir
152
+     */
150 153
     protected function createDirectories($pluginDir)
151 154
     {
152 155
         $dirs = [
@@ -165,6 +168,9 @@  discard block
 block discarded – undo
165 168
         }
166 169
     }
167 170
 
171
+    /**
172
+     * @param string $pluginDir
173
+     */
168 174
     protected function createConfig($pluginDir, $name, $code, $version)
169 175
     {
170 176
         $source = <<<EOL
@@ -176,12 +182,18 @@  discard block
 block discarded – undo
176 182
         $this->fs->dumpFile($pluginDir.'/config.yml', $source);
177 183
     }
178 184
 
185
+    /**
186
+     * @param string $pluginDir
187
+     */
179 188
     protected function createMessages($pluginDir)
180 189
     {
181 190
         $this->fs->dumpFile($pluginDir.'/Resource/locale/messages.ja.yaml', '');
182 191
         $this->fs->dumpFile($pluginDir.'/Resource/locale/validators.ja.yaml', '');
183 192
     }
184 193
 
194
+    /**
195
+     * @param string $pluginDir
196
+     */
185 197
     protected function createTwigBlock($pluginDir, $code)
186 198
     {
187 199
         $source = <<<EOL
@@ -206,6 +218,9 @@  discard block
 block discarded – undo
206 218
         $this->fs->dumpFile($pluginDir.'/TwigBlock.php', $source);
207 219
     }
208 220
 
221
+    /**
222
+     * @param string $pluginDir
223
+     */
209 224
     protected function createNav($pluginDir, $code)
210 225
     {
211 226
         $source = <<<EOL
@@ -230,6 +245,9 @@  discard block
 block discarded – undo
230 245
         $this->fs->dumpFile($pluginDir.'/Nav.php', $source);
231 246
     }
232 247
 
248
+    /**
249
+     * @param string $pluginDir
250
+     */
233 251
     protected function createEvent($pluginDir, $code)
234 252
     {
235 253
         $source = <<<EOL
@@ -254,6 +272,9 @@  discard block
 block discarded – undo
254 272
         $this->fs->dumpFile($pluginDir.'/Event.php', $source);
255 273
     }
256 274
 
275
+    /**
276
+     * @param string $pluginDir
277
+     */
257 278
     protected function createConfigController($pluginDir, $code)
258 279
     {
259 280
         $snakecased = Container::underscore($code);
Please login to merge, or discard this patch.
src/Eccube/DependencyInjection/EccubeExtension.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@  discard block
 block discarded – undo
96 96
         $this->configureTranslations($container, $enabled, $pluginDir);
97 97
     }
98 98
 
99
+    /**
100
+     * @param string $pluginDir
101
+     */
99 102
     protected function configureTwigPaths(ContainerBuilder $container, $enabled, $pluginDir)
100 103
     {
101 104
         $paths = [];
@@ -114,6 +117,9 @@  discard block
 block discarded – undo
114 117
         }
115 118
     }
116 119
 
120
+    /**
121
+     * @param string $pluginDir
122
+     */
117 123
     protected function configureTranslations(ContainerBuilder $container, $enabled, $pluginDir)
118 124
     {
119 125
         $paths = [];
@@ -155,6 +161,9 @@  discard block
 block discarded – undo
155 161
         return empty($tables) ? false : true;
156 162
     }
157 163
 
164
+    /**
165
+     * @param string $pluginDir
166
+     */
158 167
     protected function getPluginDirectories($pluginDir)
159 168
     {
160 169
         $finder = (new Finder())
Please login to merge, or discard this patch.
src/Eccube/Service/PurchaseFlow/Processor/PointProcessor.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@
 block discarded – undo
179 179
      * 明細追加処理.
180 180
      *
181 181
      * @param ItemHolderInterface $itemHolder
182
-     * @param $discount
182
+     * @param integer $discount
183 183
      */
184 184
     private function addPointDiscountItem(ItemHolderInterface $itemHolder, $discount)
185 185
     {
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/ShippingCsvUploadPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -33,6 +33,9 @@
 block discarded – undo
33 33
         parent::__construct($I);
34 34
     }
35 35
 
36
+    /**
37
+     * @param \AcceptanceTester $I
38
+     */
36 39
     public static function go($I)
37 40
     {
38 41
         $page = new ProductCsvUploadPage($I);
Please login to merge, or discard this patch.
codeception/acceptance/EF02ProductCest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 use Codeception\Util\Fixtures;
4
-use Page\Front\CartPage;
5 4
 use Page\Front\ProductDetailPage;
6 5
 use Page\Front\ProductListPage;
7 6
 use Page\Front\TopPage;
Please login to merge, or discard this patch.
src/Eccube/Controller/CartController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      * @param ProductClassRepository $productClassRepository
57 57
      * @param CartService $cartService
58 58
      * @param PurchaseFlow $cartPurchaseFlow
59
-     * @param BaseInfo $BaseInfo
59
+     * @param BaseInfo $baseInfo
60 60
      */
61 61
     public function __construct(
62 62
         ProductClassRepository $productClassRepository,
Please login to merge, or discard this patch.
src/Eccube/Controller/Admin/Order/OrderController.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -355,7 +355,7 @@  discard block
 block discarded – undo
355 355
     /**
356 356
      * @param Request $request
357 357
      * @param $csvTypeId
358
-     * @param $fileName
358
+     * @param string $fileName
359 359
      *
360 360
      * @return StreamedResponse
361 361
      */
@@ -439,9 +439,9 @@  discard block
 block discarded – undo
439 439
      * @Route("/%eccube_admin_route%/shipping/{id}/order_status", requirements={"id" = "\d+"}, name="admin_shipping_update_order_status")
440 440
      *
441 441
      * @param Request $request
442
-     * @param Shipping $shipping
442
+     * @param Shipping $Shipping
443 443
      *
444
-     * @return RedirectResponse
444
+     * @return \Symfony\Component\HttpFoundation\JsonResponse
445 445
      */
446 446
     public function updateOrderStatus(Request $request, Shipping $Shipping)
447 447
     {
Please login to merge, or discard this patch.
codeception/_support/Page/Admin/ShippingEditPage.php 1 patch
Doc Comments   +27 added lines patch added patch discarded remove patch
@@ -26,6 +26,9 @@  discard block
 block discarded – undo
26 26
         return $page;
27 27
     }
28 28
 
29
+    /**
30
+     * @param \AcceptanceTester $I
31
+     */
29 32
     public static function at($I)
30 33
     {
31 34
         $page = new self($I);
@@ -46,30 +49,45 @@  discard block
 block discarded – undo
46 49
         return $this;
47 50
     }
48 51
 
52
+    /**
53
+     * @param string $value
54
+     */
49 55
     public function 入力_姓($value, $num = 0)
50 56
     {
51 57
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_name_name01'], $value);
52 58
         return $this;
53 59
     }
54 60
 
61
+    /**
62
+     * @param string $value
63
+     */
55 64
     public function 入力_名($value, $num = 0)
56 65
     {
57 66
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_name_name02'], $value);
58 67
         return $this;
59 68
     }
60 69
 
70
+    /**
71
+     * @param string $value
72
+     */
61 73
     public function 入力_セイ($value, $num = 0)
62 74
     {
63 75
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_kana_kana01'], $value);
64 76
         return $this;
65 77
     }
66 78
 
79
+    /**
80
+     * @param string $value
81
+     */
67 82
     public function 入力_メイ($value, $num = 0)
68 83
     {
69 84
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_kana_kana02'], $value);
70 85
         return $this;
71 86
     }
72 87
 
88
+    /**
89
+     * @param string $value
90
+     */
73 91
     public function 入力_郵便番号($value, $num = 0)
74 92
     {
75 93
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_postal_code'], $value);
@@ -83,18 +101,27 @@  discard block
 block discarded – undo
83 101
         return $this;
84 102
     }
85 103
 
104
+    /**
105
+     * @param string $value
106
+     */
86 107
     public function 入力_市区町村名($value, $num = 0)
87 108
     {
88 109
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_address_addr01'], $value);
89 110
         return $this;
90 111
     }
91 112
 
113
+    /**
114
+     * @param string $value
115
+     */
92 116
     public function 入力_番地_ビル名($value, $num = 0)
93 117
     {
94 118
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_address_addr02'], $value);
95 119
         return $this;
96 120
     }
97 121
 
122
+    /**
123
+     * @param string $value
124
+     */
98 125
     public function 入力_電話番号($value, $num = 0)
99 126
     {
100 127
         $this->tester->fillField(['id' => 'form_shippings_'.$num.'_phone_number'], $value);
Please login to merge, or discard this patch.
src/Eccube/Twig/Extension/EccubeExtension.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     /**
37 37
      * Returns a list of functions to add to the existing list.
38 38
      *
39
-     * @return array An array of functions
39
+     * @return TwigFunction[] An array of functions
40 40
      */
41 41
     public function getFunctions()
42 42
     {
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     /**
59 59
      * Returns a list of filters.
60 60
      *
61
-     * @return array
61
+     * @return TwigFilter[]
62 62
      */
63 63
     public function getFilters()
64 64
     {
Please login to merge, or discard this patch.