EC-CUBE / ec-cube

src/Eccube/Controller/Admin/Setting/Shop/DeliveryController.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 use Eccube\Annotation\Component;
 use Eccube\Annotation\Inject;
 use Eccube\Application;
-use Eccube\Common\Constant;
 use Eccube\Controller\AbstractController;
 use Eccube\Entity\Delivery;
 use Eccube\Event\EccubeEvents;

src/Eccube/Controller/Mypage/WithdrawController.php

Unused Use Statements -2 removed lines

@@ -28,14 +28,12 @@
 use Eccube\Annotation\Component;
 use Eccube\Annotation\Inject;
 use Eccube\Application;
-use Eccube\Common\Constant;
 use Eccube\Controller\AbstractController;
 use Eccube\Entity\Master\CustomerStatus;
 use Eccube\Event\EccubeEvents;
 use Eccube\Event\EventArgs;
 use Eccube\Repository\Master\CustomerStatusRepository;
 use Eccube\Service\MailService;
-use Eccube\Util\Str;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
 use Symfony\Component\EventDispatcher\EventDispatcher;

src/Eccube/Service/OrderHelper.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Doctrine\ORM\EntityManager;
 use Eccube\Annotation\Inject;
 use Eccube\Annotation\Service;
-use Eccube\Common\Constant;
 use Eccube\Entity\CartItem;
 use Eccube\Entity\Customer;
 use Eccube\Entity\CustomerAddress;

src/Eccube/Controller/Admin/Order/OrderController.php

Spacing +9 added lines, -9 removed lines

@@ -303,7 +303,7 @@ 
         log_info('受注削除開始', array($Order->getId()));
 
         // 出荷に紐付いている明細がある場合は削除できない.
-        $hasShipping = $Order->getItems()->exists(function ($k, $v) {
+        $hasShipping = $Order->getItems()->exists(function($k, $v) {
             return false === is_null($v->getShipping());
         });
         if ($hasShipping) {
@@ -361,7 +361,7 @@ 
         $em->getConfiguration()->setSQLLogger(null);
 
         $response = new StreamedResponse();
-        $response->setCallback(function () use ($app, $request) {
+        $response->setCallback(function() use ($app, $request) {
 
             // CSV種別を元に初期化.
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_ORDER);
@@ -375,7 +375,7 @@ 
 
             // データ行の出力.
             $this->csvExportService->setExportQueryBuilder($qb);
-            $this->csvExportService->exportData(function ($entity, $csvService) use ($app, $request) {
+            $this->csvExportService->exportData(function($entity, $csvService) use ($app, $request) {
 
                 $Csvs = $csvService->getCsvs();
 
@@ -416,9 +416,9 @@ 
         });
 
         $now = new \DateTime();
-        $filename = 'order_' . $now->format('YmdHis') . '.csv';
+        $filename = 'order_'.$now->format('YmdHis').'.csv';
         $response->headers->set('Content-Type', 'application/octet-stream');
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
         $response->send();
 
         log_info('受注CSV出力ファイル名', array($filename));
@@ -445,7 +445,7 @@ 
         $em->getConfiguration()->setSQLLogger(null);
 
         $response = new StreamedResponse();
-        $response->setCallback(function () use ($app, $request) {
+        $response->setCallback(function() use ($app, $request) {
 
             // CSV種別を元に初期化.
             $this->csvExportService->initCsvType(CsvType::CSV_TYPE_SHIPPING);
@@ -459,7 +459,7 @@ 
 
             // データ行の出力.
             $this->csvExportService->setExportQueryBuilder($qb);
-            $this->csvExportService->exportData(function ($entity, $csvService) use ($app, $request) {
+            $this->csvExportService->exportData(function($entity, $csvService) use ($app, $request) {
 
                 $Csvs = $csvService->getCsvs();
 
@@ -509,9 +509,9 @@ 
         });
 
         $now = new \DateTime();
-        $filename = 'shipping_' . $now->format('YmdHis') . '.csv';
+        $filename = 'shipping_'.$now->format('YmdHis').'.csv';
         $response->headers->set('Content-Type', 'application/octet-stream');
-        $response->headers->set('Content-Disposition', 'attachment; filename=' . $filename);
+        $response->headers->set('Content-Disposition', 'attachment; filename='.$filename);
         $response->send();
 
         log_info('配送CSV出力ファイル名', array($filename));

src/Eccube/Controller/Admin/Setting/Shop/PaymentController.php

Spacing +1 added lines, -1 removed lines

@@ -242,7 +242,7 @@
             $this->eventDispatcher->dispatch(EccubeEvents::ADMIN_SETTING_SHOP_PAYMENT_DELETE_COMPLETE, $event);
 
             $app->addSuccess('admin.delete.complete', 'admin');
-        } catch(ForeignKeyConstraintViolationException $e) {
+        } catch (ForeignKeyConstraintViolationException $e) {
             $this->entityManager->rollback();
             $app->addError('admin.payment.delete.error', 'admin');
         }

src/Eccube/Di/Scanner/FormExtensionScanner.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
 {
     /**
      * FormExtensionAutoWiring constructor.
-     * @param array|string[] $scanDirs
+     * @param string[] $scanDirs
      */
     public function __construct($scanDirs)
     {

src/Eccube/Di/Scanner/RepositoryDefinition.php

Doc Comments +2 added lines, -2 removed lines

@@ -30,8 +30,8 @@
 {
     /**
      * RepositoryDefinition constructor.
-     * @param $id
-     * @param $refClass
+     * @param string $id
+     * @param \ReflectionClass $refClass
      */
     public function __construct($id, $refClass)
     {

src/Eccube/Di/Scanner/RepositoryScanner.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
 {
     /**
      * RepositoryAutoWiring constructor.
-     * @param array|string[] $scanDirs
+     * @param string[] $scanDirs
      */
     public function __construct($scanDirs)
     {

src/Eccube/Di/Di.php

Braces +3 added lines, -1 removed lines

@@ -161,7 +161,9 @@
             }
 
             if (!empty($components)) {
-                if ($snippets) $snippets .= PHP_EOL;
+                if ($snippets) {
+                    $snippets .= PHP_EOL;
+                }
                 $snippets .= $wiring->generate($twig, $components);
                 $snippets .= $wiring->generateExtend($twig, $components);
             }