EC-CUBE / ec-cube

app/Plugin/ExamplePlugin/Controller/ExampleController.php

Doc Comments +1 added lines, -1 removed lines

@@ -93,7 +93,7 @@
      *
      * @param Application $app
      * @param Request $request
-     * @return array
+     * @return Response
      */
     public function examplePayment(Application $app, Request $request)
     {

Unused Use Statements -8 removed lines

@@ -3,21 +3,13 @@
 
 use Eccube\Application;
 use Eccube\Entity\Payment;
-use Eccube\Event\EccubeEvents;
-use Eccube\Event\EventArgs;
 use Eccube\Form\Type\Shopping\OrderType;
-use Plugin\ExamplePlugin\Service\Calculator\Strategy\ExamplePaymentStrategy;
 use Plugin\ExamplePlugin\Entity\ExamplePayment;
-use Symfony\Component\Form\Extension\Core\Type\TextareaType;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\ParameterBag;
-use Symfony\Component\Validator\Constraints\Length;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 
 /**
  * @Route("/shopping")

app/Plugin/ExamplePlugin/PluginManager.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Eccube\Common\Constant;
 use Eccube\Plugin\AbstractPluginManager;
-use Symfony\Component\Filesystem\Filesystem;
 use Plugin\ExamplePlugin\Entity\ExamplePayment;
 
 class PluginManager extends AbstractPluginManager

src/Eccube/Controller/Admin/Store/PluginController.php

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use Eccube\Exception\PluginException;
 use Eccube\Form\Type\Admin\PluginLocalInstallType;
 use Eccube\Util\Str;
-use Monolog\Logger;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Form\Extension\Core\Type\TextType;

src/Eccube/Form/Type/Master/ProductListMaxType.php

Spacing +2 added lines, -2 removed lines

@@ -38,14 +38,14 @@
      */
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
             $options = $event->getForm()->getConfig()->getOptions();
             if (!$event->getData()) {
                 $data = current(array_keys($options['choice_loader']->loadChoiceList()->getValues()));
                 $event->setData($data);
             }
         });
-        $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
+        $builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) {
             $options = $event->getForm()->getConfig()->getOptions();
             $values = $options['choice_loader']->loadChoiceList()->getValues();
             if (!in_array($event->getData(), $values)) {

src/Eccube/Form/Type/Master/ProductListOrderByType.php

Indentation +15 added lines, -15 removed lines

@@ -38,21 +38,21 @@
      */
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-         $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
-             $options = $event->getForm()->getConfig()->getOptions();
-             if (!$event->getData()) {
-                 $data = current(array_keys($options['choice_loader']->loadChoiceList()->getValues()));
-                 $event->setData($data);
-             }
-         });
-         $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
-             $options = $event->getForm()->getConfig()->getOptions();
-             $values = $options['choice_loader']->loadChoiceList()->getValues();
-             if (!in_array($event->getData(), $values)) {
-                 $data = current($values);
-                 $event->setData($data);
-             }
-         });
+            $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+                $options = $event->getForm()->getConfig()->getOptions();
+                if (!$event->getData()) {
+                    $data = current(array_keys($options['choice_loader']->loadChoiceList()->getValues()));
+                    $event->setData($data);
+                }
+            });
+            $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
+                $options = $event->getForm()->getConfig()->getOptions();
+                $values = $options['choice_loader']->loadChoiceList()->getValues();
+                if (!in_array($event->getData(), $values)) {
+                    $data = current($values);
+                    $event->setData($data);
+                }
+            });
     }
 
     /**

Spacing +2 added lines, -2 removed lines

@@ -38,14 +38,14 @@
      */
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-         $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+         $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
              $options = $event->getForm()->getConfig()->getOptions();
              if (!$event->getData()) {
                  $data = current(array_keys($options['choice_loader']->loadChoiceList()->getValues()));
                  $event->setData($data);
              }
          });
-         $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
+         $builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) {
              $options = $event->getForm()->getConfig()->getOptions();
              $values = $options['choice_loader']->loadChoiceList()->getValues();
              if (!in_array($event->getData(), $values)) {

src/Eccube/Form/Type/MasterType.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
             'expanded' => false,
             'required' => false,
             'placeholder' => false,
-            'query_builder' => function (EntityRepository $er) {
+            'query_builder' => function(EntityRepository $er) {
                 return $er->createQueryBuilder('m')
                     ->orderBy('m.rank', 'ASC');
             },

src/Eccube/Form/Type/Master/PageMaxType.php

Spacing +2 added lines, -2 removed lines

@@ -38,14 +38,14 @@
      */
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
             $options = $event->getForm()->getConfig()->getOptions();
             if (!$event->getData()) {
                 $data = current(array_keys($options['choice_loader']->loadChoiceList()->getValues()));
                 $event->setData($data);
             }
         });
-        $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $event) {
+        $builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) {
             $options = $event->getForm()->getConfig()->getOptions();
             $values = $options['choice_loader']->loadChoiceList()->getValues();
             if (!in_array($event->getData(), $values)) {

app/Plugin/ExamplePlugin/Resource/doctrine/migrations/Version20170222080706.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     {
         $Table = $schema->getTable('dtb_payment');
         if (!$Table->hasColumn('use_paypal')) {
-            $Table->addColumn('use_paypal','smallint', [
+            $Table->addColumn('use_paypal', 'smallint', [
                 'notnull' => false,
                 'default' => 0
             ]);

app/Eccube/Controller/RoutingTestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
      * @Security("has_role('ROLE_ADMIN')")
      *
      * @param Application $app
-     * @return \Symfony\Component\HttpFoundation\Response
+     * @return string
      */
     public function testAdmin(Application $app)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Eccube2\Controller;
 
 use Eccube\Application;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Cache;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;